Commit graph

57 commits

Author SHA1 Message Date
Bill Meier
794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier
67ee5049d4 Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors:
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
  the encoding parameter for proto_tree_add_item() calls which directly reference
  an item in hf[] which has a type of:
     FT_BOOLEAN
     FT_IPv4
     FT_EUI64
     FT_GUID
     FT_UINT_STRING

Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260)

svn path=/trunk/; revision=39328
2011-10-10 00:39:31 +00:00
Bill Meier
4e57694d4a Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors:
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
 the encoding parameter for proto_tree_add_item() calls which directly reference
 an item in hf[] which has a type of:
    FT_UINT8
    FT_UINT16
    FT_UINT24
    FT_UINT32
    FT_UINT64
    FT_INT8
    FT_INT16
    FT_INT24
    FT_INT32
    FT_INT64
    FT_FLOAT
    FT_DOUBLE


svn path=/trunk/; revision=39288
2011-10-06 03:35:44 +00:00
Bill Meier
94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00
Jeff Morriss
339136d1d0 Based on patch from Denis Ovsienko via
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6244 :

Fix typo: s/unkown/unknown/

svn path=/trunk/; revision=38561
2011-08-16 13:16:33 +00:00
Bill Meier
b708c2892b Dissectors don't need to #include <gmodule.h>
Also: #include <stdlib.h> not req'd in some cases.

svn path=/trunk/; revision=38409
2011-08-08 15:41:09 +00:00
Gerald Combs
16938e6470 Remove some unused variable assignments. Fixes Coverity CID 1202.
svn path=/trunk/; revision=37065
2011-05-11 20:35:57 +00:00
Jaap Keuter
8428b08b1a From Jens Osterkamp:
The following patch adds some code to decode the EVB TLV being standardized in
the upcoming IEEE 802.1Qbg draft 0.

svn path=/trunk/; revision=37014
2011-05-07 14:50:36 +00:00
Jeff Morriss
ad99181031 There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Use tvb_ether_to_str().

svn path=/trunk/; revision=36128
2011-03-03 03:09:21 +00:00
Jaap Keuter
efba76d248 From Johan Kristell:
In the standard 802.3at-2009 the PoE+ TLVs are 12 bytes long, but in the
earlier version 802.3bc-2009, they are 7 bytes long (the power type/
source/priority, and the requested and allocated fields are lacking).
Not respecting the length of the TLV leads to wireshark displaying garbage 
data and could lead to reading outside of buffer.

svn path=/trunk/; revision=35737
2011-01-31 22:31:05 +00:00
Jaap Keuter
8356fdd6ac From Vaibhav Katkade:
Add support for newly defined LLDP Four-wire Power-via-MDI and 
CDP Spare Pair PoE TLVs

svn path=/trunk/; revision=35559
2011-01-16 21:32:39 +00:00
Jeff Morriss
61876001c3 Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the
return string is NULL terminated.

There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

svn path=/trunk/; revision=35548
2011-01-16 03:57:12 +00:00
Guy Harris
a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Bill Meier
93b94a23ca Define some fcns & vars as static; Some #includes not req'd; packet-mikey.h not req'd.
svn path=/trunk/; revision=34464
2010-10-10 23:28:40 +00:00
Bill Meier
69df32fb11 #include <string.h> not needed.
svn path=/trunk/; revision=32411
2010-04-06 22:09:47 +00:00
Bill Meier
09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Jaap Keuter
802dc7f334 From Greg Schwendimann:
The 802.3at Power Via MDI TLV dissector is incomplete as it does not decode the
last three bytes.  I have attached a patch that decodes the type/source/priority, 
PD requested power value, and PSE allocated power value fields.

svn path=/trunk/; revision=30662
2009-10-22 07:10:05 +00:00
Stig Bjørlykke
2315117682 Initialize ip_addr to avoid an uninitialized warning.
svn path=/trunk/; revision=30335
2009-10-05 16:52:59 +00:00
Kovarththanan Rajaratnam
ac463d2697 Don't guard col_clear with col_check
svn path=/trunk/; revision=29346
2009-08-09 08:14:59 +00:00
Kovarththanan Rajaratnam
4b6090e576 Don't guard col_set_str (COL_INFO) with col_check
svn path=/trunk/; revision=29342
2009-08-09 07:01:26 +00:00
Kovarththanan Rajaratnam
e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Stig Bjørlykke
b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Jeff Morriss
c53823afbf Remove non-ASCII character
svn path=/trunk/; revision=28737
2009-06-15 14:59:08 +00:00
Jörg Mayer
701cedf791 Add decoding of auto-neg capabilites in inverse (wrong) order as
proposed in:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1455#c32

svn path=/trunk/; revision=28680
2009-06-09 22:09:23 +00:00
Jörg Mayer
0db429e50c Powervalue is in units of 100mW, print effective value and unit
svn path=/trunk/; revision=28674
2009-06-09 16:51:04 +00:00
Ulf Lamping
3f533b4038 add some display details
svn path=/trunk/; revision=27404
2009-02-09 19:39:43 +00:00
Bill Meier
33c99f44fd Fix typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27028
2008-12-17 00:08:38 +00:00
Bill Meier
77b81b391b #include <prefs.h> not req'd
svn path=/trunk/; revision=26089
2008-08-25 22:06:20 +00:00
Guy Harris
5a43799a17 Use G_GINT64_MODIFIER, rather than the PRI[douxX]64 macros, for GLib
routines and routines using those routines.  GLib might use different
modifiers for 64-bit quantities than the platform's C library does.

svn path=/trunk/; revision=21990
2007-05-29 18:52:42 +00:00
Ulf Lamping
499624d0ee use the official PROFINET names (only comments changed)
svn path=/trunk/; revision=20962
2007-03-03 09:30:15 +00:00
Gerald Combs
7f88f16077 Bugs 1095 and 1096 in the Ethereal bug database both pointed out that we
were looking at the wrong bits when displaying the port and protocol VLAN
flags.

svn path=/trunk/; revision=20960
2007-03-02 23:44:54 +00:00
Ulf Lamping
36e0b70a68 append period values to the PROFINET PTCP status
svn path=/trunk/; revision=20384
2007-01-10 21:46:50 +00:00
Ulf Lamping
f611704fd2 fix output of PROFINET specific MAC addresses - it simply displayed garbage
svn path=/trunk/; revision=20044
2006-12-05 08:07:00 +00:00
Ulf Lamping
72d82b186c add dissection for PROFINET "PTCP Status"
svn path=/trunk/; revision=19922
2006-11-17 22:38:34 +00:00
Ulf Lamping
aca8366250 add dissection of PROFINET "MRP Port Status"
svn path=/trunk/; revision=19876
2006-11-11 01:29:43 +00:00
Ulf Lamping
efb558955d add another PROFINET specific subtype (5:CHASSIS_MAC)
svn path=/trunk/; revision=18549
2006-06-22 19:19:41 +00:00
Ulf Lamping
53a3dd33e7 update PROFINET port2/3 status text
svn path=/trunk/; revision=18529
2006-06-21 07:30:11 +00:00
Ronnie Sahlberg
feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Anders Broman
8d61e9b902 Mark the value_strings static.
svn path=/trunk/; revision=17718
2006-03-24 07:10:22 +00:00
Ulf Lamping
e43c4e50c9 add another comment what's currently missing in the PROFINET specific parts
svn path=/trunk/; revision=17713
2006-03-24 02:20:37 +00:00
Guy Harris
b0a28a8080 Squelch a compiler warning.
svn path=/trunk/; revision=17115
2006-01-28 23:27:17 +00:00
Guy Harris
54ac396346 Expand the set of #defines in afn.h (and give a URL for the *current*
list of address families) and the list of strings in afn.c, and use them
in packet-lldp.c instead of having it define its own.

svn path=/trunk/; revision=17114
2006-01-28 23:18:19 +00:00
Anders Broman
d31de2bdb4 Bugfix: network address not dissected correctly
svn path=/trunk/; revision=17084
2006-01-23 22:13:08 +00:00
Anders Broman
6f23144e46 From Jaap Keuter:
- Editcap 
Mikko Tiihonen filed bug 379 including a patch for editcap. This wasn't picked up so far. I've ported the patch to svn 16820 and included a documentation patch.

-packet-ieee80211.c
Radek Vokal of RedHat filed a bug found by Vladimir Kondratiev of Intel in the 802.11 dissector. Radek provided a sample capture and Vladimir a oneliner patch. I've ported the patch to svn 16820 and tested it against the provided capture. Works well.


-From Kan Sasaki
A patch for packet-ospf.c is attached:
 - Fix the handling of the DN-bit of options field.
 - Add a new function dissect_ospf_bitfield() to dissect a bitfield
   such as options, flags. The following functions are merged by
   using this function.
     - dissect_ospf_lls_extended_options()
     - dissect_ospf_dbd()


     - dissect_ospf_options()
     - dissect_ospf_v3_prefix_options()
 - dissect the flags and prefix-options bitfield.

- lldp Bugfix Bug 596  LLDP TIA Network Policy Decode is not correct 

- Camel make it possible to dissect based on OID.

svn path=/trunk/; revision=16822
2005-12-16 16:37:03 +00:00
Ulf Lamping
a78d2fbc63 (on behalf of the PROFIBUS Nutzerorganisation e.V. Deutschland):
add some PROFINET specific LLDP extensions

svn path=/trunk/; revision=16488
2005-11-12 10:09:02 +00:00
Gerald Combs
7ce6f2c971 IPv6 addresses are 16 bytes.
svn path=/trunk/; revision=16243
2005-10-16 03:57:49 +00:00
Ronnie Sahlberg
26828b0876 remove some compiler warnings
svn path=/trunk/; revision=15975
2005-09-23 10:39:58 +00:00
Guy Harris
0a93fcdcd3 Give it an RCS ID.
svn path=/trunk/; revision=15909
2005-09-20 22:49:54 +00:00
Ulf Lamping
dce67e2bbe fix: packet-lldp.c(2071) : warning C4761: integral size mismatch in argument; conversion supplied
svn path=/trunk/; revision=15893
2005-09-20 09:02:38 +00:00
Jörg Mayer
7f48c561d2 Jim Young: LLDP improvements
svn path=/trunk/; revision=15879
2005-09-19 21:24:07 +00:00