Commit Graph

168 Commits

Author SHA1 Message Date
Martin Mathieson 4b5c69c0d9 Add bandwidth figures per UE.
svn path=/trunk/; revision=34061
2010-09-03 16:45:05 +00:00
Martin Mathieson c642bae035 From Pascal Quantin:
The decoder expects to do not have any extra byte after the RAR bodies.

But according to 3GPP 36.321 8.8.0 chapter 6.1.5, the eNodeB is allowed to put padding at the end of the RAR PDU:

" A MAC PDU consists of a MAC header and zero or more MAC Random Access Responses (MAC RAR) and optionally padding as described in figure 6.1.5-4.
[...]

Padding may occur after the last MAC RAR. Presence and length of padding is implicit based on TB size, size of MAC header and number of RARs."

svn path=/trunk/; revision=33783
2010-08-12 09:03:05 +00:00
Jörg Mayer 8c03a4472a Updading opensuse 11.2 -> 11.3 updated gcc to 4.5.0, which created
a few warnings that needed fixing when compiling with -Werror.

svn path=/trunk/; revision=33587
2010-07-20 08:27:34 +00:00
Martin Mathieson 703635b979 Give up dissecting a MAC PDU if we see control LCIDs after data ones.
This saves us getting into a mess trying to keep track of PDU sizes in an array...

svn path=/trunk/; revision=33582
2010-07-19 14:14:47 +00:00
Martin Mathieson db478debbd Allocate tap structs rather than using one static struct.
svn path=/trunk/; revision=33503
2010-07-13 16:25:34 +00:00
Martin Mathieson b2a872cd9f Show grant-subframe from context info.
svn path=/trunk/; revision=33437
2010-07-05 16:45:36 +00:00
Martin Mathieson b7f136ae41 Check range of supplied subframe number. If out, set back to max (9) and
add expert info error.  Should fix bug 4970.

svn path=/trunk/; revision=33432
2010-07-05 10:50:27 +00:00
Martin Mathieson 735ec2d6d2 For DL HARQ retx, support knowing result or not.
svn path=/trunk/; revision=33431
2010-07-05 10:35:17 +00:00
Martin Mathieson 97df849b98 Add new strings/dissector function for signalling RRC messages that will add
lte_rrc root to the protocol tree. Makes filtering on call signalling easier.

TODO: same for other RRC entry points...

svn path=/trunk/; revision=33251
2010-06-18 07:07:55 +00:00
Martin Mathieson 4fcd48495f Add the direction to so expert info texts.
svn path=/trunk/; revision=33207
2010-06-10 15:28:41 +00:00
Martin Mathieson 98c68fc8ec Check that the PDU isn't bigger than the reported grant size. Thought I was already doing this...
svn path=/trunk/; revision=32934
2010-05-24 16:28:34 +00:00
Martin Mathieson 5ed2e2f914 Trivial: Update AUTHORS entry, remove out-of-date comments, minor formatting
svn path=/trunk/; revision=32611
2010-04-30 17:15:59 +00:00
Martin Mathieson 0d7425872e Set TA control element expert info based on improved understanding of spec.
svn path=/trunk/; revision=32539
2010-04-22 17:46:12 +00:00
Martin Mathieson 5a39a9ef39 - Lower severity on expert items about Timing Advance if <= 31
- Detect original frame for DL HARQ retx also 9 SFs ago (have even seen 10...)
- Getting ready to log 'grant subframe' for UL frames (only interesting for TDD)

svn path=/trunk/; revision=32538
2010-04-22 13:54:30 +00:00
Bill Meier 09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Martin Mathieson cfb6f1531a Improve reporting of Scheduling Request failure.
svn path=/trunk/; revision=32272
2010-03-23 13:24:01 +00:00
Martin Mathieson 90b1fb287d Show oob items outside of context tree.
svn path=/trunk/; revision=32269
2010-03-22 19:20:37 +00:00
Martin Mathieson 64d949c97e Trivial reformatting
svn path=/trunk/; revision=32226
2010-03-17 19:40:34 +00:00
Martin Mathieson b3a29fcb32 Add some extra (optional) physical layer attributes to logged MAC frames.
svn path=/trunk/; revision=32190
2010-03-14 17:56:37 +00:00
Martin Mathieson 5aaf90b753 Put context info in own subtree.
Use common function to append text to info column and tree items

svn path=/trunk/; revision=32151
2010-03-09 01:41:36 +00:00
Stig Bjørlykke 2f8830b4d0 From LEGO via bug 3459:
Add a callback to UAT to be called after the table has being updated,
use it to renew the snmp_ue_cache.

svn path=/trunk/; revision=32112
2010-03-04 12:50:18 +00:00
Martin Mathieson 5baac1de18 Fix crash where was overwriting buffer for large PDUs when tracking retxs.
svn path=/trunk/; revision=32095
2010-03-03 16:04:12 +00:00
Martin Mathieson eba3b41978 Fix a test.
svn path=/trunk/; revision=32092
2010-03-03 15:38:37 +00:00
Martin Mathieson 80d7644409 Its convenient to be able to filter on mac-lte.ulsch or mac-lte.dlsch.
svn path=/trunk/; revision=32088
2010-03-03 11:57:21 +00:00
Martin Mathieson ebd8c30044 When looking at time differences between frames, round to nearest number of ms.
svn path=/trunk/; revision=32086
2010-03-02 18:41:35 +00:00
Martin Mathieson 862dd48d35 Improve RLC AM sequence analysis by taking MAC retx into account.
svn path=/trunk/; revision=32071
2010-03-01 22:52:34 +00:00
Martin Mathieson 360077ae74 Calculate/show time between Msg3 and Msg4
svn path=/trunk/; revision=31970
2010-02-23 22:28:42 +00:00
Martin Mathieson 6a0c3ecaaf Include detected DL retx in stats.
Each row is now a uniqe RNTI/UEId pair.
Added a filter button to filter by selected RNTI + UEId

svn path=/trunk/; revision=31931
2010-02-20 16:58:48 +00:00
Martin Mathieson 7b2a3c26e6 Recognise update string for SR failure, and show ueid in MAC if set.
svn path=/trunk/; revision=31916
2010-02-18 21:24:47 +00:00
Martin Mathieson 2e08a73235 Add preference that allows RLC PDUs embedded inside MAC info to be seen nicely in the info column
svn path=/trunk/; revision=31828
2010-02-08 15:01:08 +00:00
Martin Mathieson 35a4c0b3d6 Add UEId to MAC tap struct and stats window.
svn path=/trunk/; revision=31788
2010-02-04 16:30:43 +00:00
Martin Mathieson 1146a40844 From Pascal Quantin: show decoding of the Power Headroom Level field as specified in 3GPP 36.133 table 9.1.8.4-1.
svn path=/trunk/; revision=31705
2010-01-27 18:42:40 +00:00
Martin Mathieson 61c6c08861 Undo previous change to avoid crashing.
The test for NULL was to see whether struct had ever been allocated,
not for detecting a failed allocation...

svn path=/trunk/; revision=31681
2010-01-26 14:55:26 +00:00
Martin Mathieson f1f528deeb From Pascal Quantin: fid some LTE MAC and PDCP typos
svn path=/trunk/; revision=31661
2010-01-25 16:45:46 +00:00
Stig Bjørlykke c198fc6546 From Didier Gautheron via bug 4419:
se_alloc and ep_alloc never return NULL and se_alloc0 already initialized
data with 0.

svn path=/trunk/; revision=31654
2010-01-25 11:47:39 +00:00
Bill Meier c5614625ee Fix some gcc -Wshadow warnings ....
svn path=/trunk/; revision=31559
2010-01-18 23:16:10 +00:00
Anders Broman 1f6a39eae9 Use g_snprintf()
svn path=/trunk/; revision=31507
2010-01-12 20:08:30 +00:00
Martin Mathieson d5c96e34e7 Use snprintf() to pass checkAPI
svn path=/trunk/; revision=31506
2010-01-12 18:43:18 +00:00
Martin Mathieson 23c5730798 Append to the SDU field only once (instead of for each byte!).
svn path=/trunk/; revision=31503
2010-01-12 16:12:27 +00:00
Martin Mathieson ccaca7c006 Show in stats % of UL traffic that is padding (subheader or payload).
svn path=/trunk/; revision=31390
2009-12-29 22:55:39 +00:00
Martin Mathieson 3b0a092b18 Fix crash bug by allocating correct size of struct (used with SR tracking).
svn path=/trunk/; revision=31307
2009-12-18 12:32:14 +00:00
Martin Mathieson d7f78d0627 Remove stray #if 1
svn path=/trunk/; revision=31292
2009-12-17 13:33:00 +00:00
Martin Mathieson 5574e77571 Adding FT_NONE item with proto_tree_add_item() causes crashes later, so use
proto_tree_add_none_format() instead.

svn path=/trunk/; revision=31291
2009-12-17 13:15:29 +00:00
Martin Mathieson d0260a142b Add a cast to try to keep the win64 compiler happy
svn path=/trunk/; revision=31267
2009-12-14 16:50:42 +00:00
Martin Mathieson 52163da600 Show the time between SR and failure or grant.
svn path=/trunk/; revision=31265
2009-12-14 16:04:14 +00:00
Martin Mathieson 469884ab44 Catch unexpected Scheduling Request state transitions as expert info.
svn path=/trunk/; revision=31261
2009-12-14 11:23:24 +00:00
Martin Mathieson 9a0c5d29c6 Fix length in loop (from Pascal Quantin).
svn path=/trunk/; revision=31178
2009-12-04 22:27:29 +00:00
Martin Mathieson 2267dcdd0e From Pascal Quantin via bug 4296.
- make framing format work when there are no optional parameters present
- when showing raw SDU, show formatted info as well as data itself.  This is done in a horrible way, but I can't find a nice way.

svn path=/trunk/; revision=31174
2009-12-04 17:39:39 +00:00
Martin Mathieson 27169c915c Provide frame links between grant or failure ind back to SR.
svn path=/trunk/; revision=31169
2009-12-04 11:13:20 +00:00
Martin Mathieson b3a836bc23 The beginnings of a state machine to track a UE's SR state and provide links between relevant frames.
svn path=/trunk/; revision=31153
2009-12-02 17:46:27 +00:00
Martin Mathieson 8713027d83 Obselete a couple of preferences that can always be on.
svn path=/trunk/; revision=31123
2009-11-29 22:45:06 +00:00
Martin Mathieson 57d5b991b5 Include ue id in expert info for retx.
svn path=/trunk/; revision=31080
2009-11-25 23:18:28 +00:00
Martin Mathieson bd3a966861 Track UL HARQ retx, look for original tx frame.
svn path=/trunk/; revision=31072
2009-11-25 16:00:58 +00:00
Martin Mathieson 2d2a1ef1cf Tweak expert info level/text.
svn path=/trunk/; revision=31019
2009-11-19 18:11:38 +00:00
Martin Mathieson 479fc76dc9 Expert warning about BSRs over a threshold configured in pref.
svn path=/trunk/; revision=31003
2009-11-18 13:47:08 +00:00
Martin Mathieson 04078dd997 Improve expert and info column strings reporting OOB events.
svn path=/trunk/; revision=30859
2009-11-08 00:39:22 +00:00
Martin Mathieson eab33c1bb9 Change a filter string for consistency.
svn path=/trunk/; revision=30712
2009-10-26 16:39:46 +00:00
Martin Mathieson afffcffff9 Add support for displaying/filtering some LTE MAC out-of-band events.
svn path=/trunk/; revision=30711
2009-10-26 15:39:00 +00:00
Martin Mathieson 4474e0d25b Label a short BSR as "short"
svn path=/trunk/; revision=30699
2009-10-25 23:03:11 +00:00
Martin Mathieson f5b4b6e32f Expert error if (non-padded) PDU is shorter than reported.
svn path=/trunk/; revision=30666
2009-10-22 17:22:27 +00:00
Martin Mathieson 0f8ee9cdf9 More long BSR fixes.
svn path=/trunk/; revision=30664
2009-10-22 11:45:40 +00:00
Martin Mathieson b3f5ccdae0 Fix issues with long BSR format, and attach expert info for non-zero RAR TA to correct item.
svn path=/trunk/; revision=30663
2009-10-22 10:31:13 +00:00
Martin Mathieson 61eda9b14e Improve DL HARQ resend detection by storing multiple frames per UE.
svn path=/trunk/; revision=30557
2009-10-14 10:43:17 +00:00
Martin Mathieson 7e8d401265 Add detection for suspected DL retx (due to HARQ). Needed if logging is done on UE side of link.
svn path=/trunk/; revision=30554
2009-10-13 13:36:58 +00:00
Martin Mathieson d8726d2a01 Try again...
svn path=/trunk/; revision=29985
2009-09-18 22:01:30 +00:00
Martin Mathieson 66e8e24373 Change type to try to fix win64 build breakage.
svn path=/trunk/; revision=29984
2009-09-18 17:10:35 +00:00
Martin Mathieson b6acfd804e Use a UAT table to map from LCIDs 3-10 to RLC drb channel.
Call RLC dissector for mapped LCIDs.

svn path=/trunk/; revision=29983
2009-09-18 16:27:02 +00:00
Martin Mathieson e09d89e145 Add the option to call RLC dissector for LCID 1&2.
These should be srb1 & srb2 (AM).

svn path=/trunk/; revision=29852
2009-09-10 22:53:57 +00:00
Martin Mathieson 019625d876 Re-arrange dissection of UL/DL-SCH so easier to test for ommitted SDUs.
svn path=/trunk/; revision=29845
2009-09-10 18:12:41 +00:00
Martin Mathieson 4c1be31824 Trivial: add direction to expert info string for CRC failures.
svn path=/trunk/; revision=29802
2009-09-08 17:13:55 +00:00
Martin Mathieson efd2ed4b51 Show UEId in info column for UL-SCH / DL-SCH frames.
svn path=/trunk/; revision=29687
2009-09-03 16:42:16 +00:00
Martin Mathieson 2ef4429761 Add Semi-Persistent Scheduling (SPS) RNTI.
svn path=/trunk/; revision=29667
2009-09-02 16:39:39 +00:00
Martin Mathieson 8437debcb6 Make UL grant size a (generated) field of its own (for easier use as a custom column or IO graph filter).
svn path=/trunk/; revision=29562
2009-08-26 09:13:14 +00:00
Martin Mathieson 5560cb61c0 Show CRC errors for RARs.
svn path=/trunk/; revision=29548
2009-08-25 11:01:51 +00:00
Martin Mathieson 92b2bcf28a Show power headroom report inside its own subtree.
svn path=/trunk/; revision=29303
2009-08-05 08:02:12 +00:00
Martin Mathieson ed930bece3 Remember Msg3 bytes and compare with Msg4 Contention Resolution bodies.
svn path=/trunk/; revision=29258
2009-08-01 09:52:12 +00:00
Martin Mathieson 0abc55b7fc Show backoff indicator value in subheader tree root.
svn path=/trunk/; revision=29244
2009-07-30 16:53:33 +00:00
Martin Mathieson 41b86b26b8 Improve/expand checks on reserved bit values.
svn path=/trunk/; revision=29167
2009-07-22 13:21:15 +00:00
Martin Mathieson 065374366a Trivial formatting changes to RAR output.
svn path=/trunk/; revision=29094
2009-07-14 17:43:20 +00:00
Martin Mathieson 2751aca4f7 Add preference to control whether decode of CRC-error'd frames should be attempted.
svn path=/trunk/; revision=29092
2009-07-14 13:08:23 +00:00
Martin Mathieson 29d6ae0ed5 Remove calls to check_col().
svn path=/trunk/; revision=29079
2009-07-13 11:23:40 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Martin Mathieson fae33ea177 Call RRC dissector inside TRY/CATCH block, in order to:
- finish dissecton of other bodies
- make sure stats are updated in the face of RRC exceptions

svn path=/trunk/; revision=28766
2009-06-17 12:13:29 +00:00
Martin Mathieson ec48fc388f Trivial prettifications
svn path=/trunk/; revision=28765
2009-06-17 09:43:56 +00:00
Martin Mathieson 73aa7cc85b Add BSR reports into their own subtrees.
Check frame length from context info against actual length.

svn path=/trunk/; revision=28701
2009-06-11 13:55:49 +00:00
Martin Mathieson 3b4e37916f Fix typos, and make filter strings more consistent.
svn path=/trunk/; revision=28638
2009-06-04 15:08:56 +00:00
Martin Mathieson 3f416f98ee For DL-SCH/UL-SCH, show subframe number in info column.
svn path=/trunk/; revision=28561
2009-06-01 16:50:27 +00:00
Martin Mathieson 932c696498 Add casts from size_t to fix win64 buildbot problems.
svn path=/trunk/; revision=28512
2009-05-28 03:26:40 +00:00
Martin Mathieson 7bef808c6b Add definitions for a UDP framing protocol and heuristic dissector (example client code will be posted on wiki soon)
Add a missed initialisation to stats window struct.

svn path=/trunk/; revision=28511
2009-05-28 02:24:27 +00:00
Martin Mathieson 7ed080da5c Timing advance command is 6 bits.
svn path=/trunk/; revision=28371
2009-05-15 10:02:14 +00:00
Martin Mathieson 4a16f077ce Backoff Indicator must now (March 09) be the first subheader in an RAR PDU.
svn path=/trunk/; revision=28360
2009-05-14 17:12:37 +00:00
Martin Mathieson 4dda12f0be - add direction filter to PDCP
- fix PDCP fields ("pdcp.*" -> "pdcp-lte.*")
- improve PDCP info column output (to be more like RLC)

svn path=/trunk/; revision=28342
2009-05-13 09:36:42 +00:00
Martin Mathieson 5f875c1be5 Hide a couple of generated fields when they have uninteresting values.
svn path=/trunk/; revision=28291
2009-05-06 22:01:33 +00:00
Martin Mathieson 41c14e2117 Add a generated field showing how many bytes were padding at the end of a DL/UL-SCH frame.
svn path=/trunk/; revision=28232
2009-05-01 14:23:47 +00:00
Martin Mathieson 6e4c1ae913 - Don't show raw decode when doing RRC decode of payloads.
- Associate RAPID with RAR body

svn path=/trunk/; revision=28231
2009-05-01 10:30:18 +00:00
Martin Mathieson 96895f2e05 Another check/expert error for RARs.
svn path=/trunk/; revision=28198
2009-04-30 13:18:56 +00:00
Martin Mathieson c620ac8ed6 Allow RAR UL Request field to be broken down (as in 36.213).
Also consider an RAR PDU to be malformed if it contains > 1 BI headers.

svn path=/trunk/; revision=28175
2009-04-27 11:12:01 +00:00
Martin Mathieson 9efe4d12f1 Also show number of RAR bodies/entries in stats.
svn path=/trunk/; revision=28104
2009-04-21 12:35:50 +00:00
Martin Mathieson be42013858 Add a preference for allowing transparent RRC data (BCH, PCH, CCCH) to be decoded as such.
svn path=/trunk/; revision=28092
2009-04-20 16:46:46 +00:00
Martin Mathieson 81d278251a For RAR PDUs, show RA-RNTI and subframe number in info column.
svn path=/trunk/; revision=28072
2009-04-17 11:38:06 +00:00