Commit graph

979 commits

Author SHA1 Message Date
Martin Mathieson
c0faa8f1da Some more dissector spellings. 2021-08-08 22:21:38 +01:00
Martin Mathieson
aaf79b62d7 F1AP stats 2021-08-06 09:31:15 +00:00
João Valverde
7b845e7194 wsutil: rename bytestring_to_str() -> bytes_to_str_punct() 2021-07-29 17:23:05 +00:00
Tomas Kukosa
ab1b496194 ITS: use custom value format for DSRC elements Angle and Heading 2021-07-28 07:08:26 +00:00
Evan Huus
d09fb571fe asn1: convert most dissectors to pinfo->pool
Part 2/2 as the commits were too big for CI.

Largely find/replace, with a few manual tweaks. Then regenerate the asn1
dissector sources and make sure everything still builds. There are a
handful of cases I skipped as too complex, but this covers most of the
asn1 dissectors.
2021-07-26 14:00:09 -04:00
Evan Huus
e69446aa55 asn1: convert most dissectors to pinfo->pool
Part 1/2 as the commits were too big for CI.

Largely find/replace, with a few manual tweaks. Then regenerate the asn1
dissector sources and make sure everything still builds. There are a
handful of cases I skipped as too complex, but this covers most of the
asn1 dissectors.
2021-07-26 15:30:11 +00:00
João Valverde
133b0c583f Move epan/wmem/wmem_scopes.h to epan/
This header was installed incorrectly to epan/wmem_scopes.h.

Instead of creating additional installation rules for a single
header in a subfolder (kept for backward compatibility) just
rename the standard "epan/wmem/wmem.h" include to
"epan/wmem_scopes.h" and fix the documentation.

Now the header is installed *correctly* to epan/wmem_scopes.h.
2021-07-26 14:56:11 +00:00
Dylan Ulis
e9843baf6c CMS: Correct RFC 4108 Attributes
There was an extra '9' in each of the OIDs. The OIDs were already
correct in CMSFirmwareWrapper.asn (in the same directory)
2021-07-23 08:30:58 +00:00
Stefan Metzmacher
94ac641efa packet-kerberos: implement PAC Ticket checksum verification
We use some private functions from MIT kerberos:
- krb5_free_enc_tkt_part()
- decode_krb5_enc_tkt_part()
- encode_krb5_enc_tkt_part()
but we already do that for krb5int_c_mandatory_cksumtype(),
which is newer than the above functions.

We use all of them only under HAVE_KRB5_PAC_VERIFY,
so we don't seem to need additional configure tests.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2021-07-15 04:52:30 +00:00
Stefan Metzmacher
8cd877fc4d packet-kerberos: always get the true length from decrypt_krb5_data_asn1()
Otherwise the child_tvb blobs may contain to much data.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2021-07-15 04:52:30 +00:00
Alexis La Goutte
0ea7692ec4 sv: fix typo ConfRef => ConfRev
Reported by Robert Sandholzer (#17486)
2021-07-14 17:46:39 +00:00
Pascal Quantin
20f38c06ea LPP: upgrade dissector to v16.5.0 2021-07-07 18:09:24 +00:00
Pascal Quantin
204642089a NR RRC: upgrade dissector to v16.5.0 2021-07-07 17:37:07 +00:00
Pascal Quantin
ce9b01f059 LTE RRC: upgrade dissector to v16.5.0 2021-07-07 17:34:28 +02:00
Pascal Quantin
1c3739c360 NGAP: fix dissection of gNB/ng-eNB transparent container 2021-07-07 14:27:58 +00:00
Pascal Quantin
aa5df68171 NR RRC: fix dissection of MeasTriggerQuantityOffset element 2021-07-04 12:03:45 +02:00
Pascal Quantin
8f69254638 E1AP: upgrade dissector to v16.6.0 2021-07-02 10:57:29 +00:00
Isaac Boukris
5f8a932338 kerberos: fix compilation without kerberos
regressed_by: 38810b76

Reported-By: @crondaemon <Dario Lombardo>.
2021-07-02 10:32:18 +00:00
Pascal Quantin
498f5bf7d1 F1AP: upgrade dissector to v16.6.0 2021-07-02 10:10:23 +00:00
Pascal Quantin
95bc8cf328 XnAP: upgrade dissector to v16.6.0 2021-07-02 09:35:09 +00:00
Pascal Quantin
e1b31629d7 NGAP: upgrade dissector to v16.6.0 2021-07-02 09:19:34 +00:00
Pascal Quantin
6dcb6568ff S1AP: upgrade dissector to v16.6.0 2021-07-02 09:02:58 +00:00
Pascal Quantin
b403255234 X2AP: upgrade dissector to v16.6.0 2021-07-02 08:46:29 +00:00
Isaac Boukris
80c57b3d0b Kerberos: add basic dissection of PAC_TICKET_CHECKSUM
per recent MS-PAC update.
2021-07-02 08:18:57 +00:00
Isaac Boukris
d833f5c061 krb5: use all_keys to verify PAC server signature to allow U2U
As a U2U ticket can't always be distinguished from a normal ticket,
e.g. in TGS-REP. Revert the old fix which didn't work for that case.
2021-07-01 14:25:02 +00:00
David Fort
3874621667 spnego: also interpret the mechList field
In NegTokenTarg the mechListMIC field can be dissected using the gss_wrap dissector.
2021-07-01 07:18:16 +00:00
Isaac Boukris
38810b763b credssp: fully dissect TSRemoteGuardCreds struct 2021-07-01 06:46:55 +00:00
Clément Notin
5b248ac4d0 ldap: Add Active Directory OIDs
From [MS-ADTS] specification
https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-adts/3c5e87db-4728-4f29-b164-01dd7d7391ea
2021-06-30 05:15:41 +00:00
Anders Broman
58ada8b529 NGAP: Catch dissection of containers that may be test data.
In test environments the octet stering may be filled with junk data.
2021-06-28 16:04:19 +00:00
Pascal Quantin
3ea51dba87 NGAP: fix dissection of multiple NGAP messages in the same HTTP2 packet
Also add dissection for more containers
2021-06-21 13:33:55 +00:00
Isaac Boukris
d2c3489d79 Revert "test"
This reverts commit af3a9d72d9.
2021-06-17 10:14:55 +03:00
Isaac Boukris
af3a9d72d9 test 2021-06-17 05:05:59 +00:00
Isaac Boukris
dd39d9b46a credssp: add basic dissection of TSRemoteGuardCreds
as per MS-CSSP 2.2.1.2.3
2021-06-17 05:05:59 +00:00
João Valverde
dcc02b1003 dissectors: Replace g_log() with ws_log() 2021-06-16 12:50:28 +00:00
Tomas Kukosa
4c4bb915c8 ITS: fix displaying of curvature unavailable value 2021-06-16 12:34:06 +00:00
Joakim Karlsson
72193d037f NGAP: add more N2SmInfoType 2021-06-16 09:38:36 +00:00
Martin Gallo
85df6d0273 Kerberos: Add support for MS-KILE Key List Request messages
This adds the MS-KILE pre-authentication data types KERB-KEY-LIST-REQ [161] and KERB-KEY-LIST-REP [162] as per the latest Microsoft' Open Specifications.
Keys obtained from KERB-KEY-LIST-REP are learnt and saved for further use in other packets.

References:
- [MS-KILE] 2.2.11 KERB-KEY-LIST-REQ https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-kile/a8198db9-b537-4256-b903-80a716540398
- [MS-KILE] 2.2.12 KERB-KEY-LIST-REP https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-kile/38a494fc-2885-47eb-b008-3a1b574f3614
- [MS-KILE] 3.3.5.7.8 Key List Request https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-kile/732211ae-4891-40d3-b2b6-85ebd6f5ffff
2021-06-15 14:51:07 +00:00
David Fort
e43d26b39e rdp: many improvements and fixes
This big patch addresses the following items:

* implement the "message" virtual channel so that multi-transport and bandwidth
PDUs are dissected;
* prepare the identification of static channels to be able to dissect them later;
* fix the compression field in channelPDUHeader.channelFlags;
* implement the drdynvc channel dissector, so now we decode the traffic on this
channel and we're able to track data on dynamic channels and transition to UDP
transport
2021-06-15 08:42:47 +00:00
Pascal Quantin
c0f8812c31 Kerberos: fix compilation without HAVE_KERBEROS flag
Closes #17439
2021-06-11 09:38:02 +02:00
yuanjungong
e0d420ac48 Fix a resource leak by closing skf before return 2021-06-09 17:26:24 +00:00
Isaac Boukris
07bc6e4399 krb5: fix PAC server signature verification in U2U 2021-06-08 17:36:44 +00:00
Isaac Boukris
f94f22b7f8 krb5: add TGT-REQ/TGT-REP dissection per the U2U RFC draft
https://datatracker.ietf.org/doc/html/draft-swift-win2k-krb-user2user-03
2021-06-08 17:36:44 +00:00
Isaac Boukris
33a61d14b5 credssp: also decrypt TSRequest/pubKeyAuth blobs 2021-06-08 17:36:44 +00:00
Isaac Boukris
81bed686da credssp: decrypt TSRequest/authInfo using the gssapi_wrap handler
and fix TSCredentials/TSPasswordCreds dissection.
2021-06-08 17:36:44 +00:00
Isaac Boukris
fa1204c02c credssp: add support for gss-api and krb5 dissection
Since the gssapi handler can cope fine with ntlm blobs, remove the
heuristic in ntlmssp and call the gssapi dissector directly. In turn
we get kerberos support, including decpryption with keytab etc.
2021-06-08 17:36:44 +00:00
Isaac Boukris
6f528e6cd7 credssp: update TSRequest asn1 struct with new optional fields
and limit errorCode and clientNonce to respective versions as per MS-CSSP.
2021-06-08 17:36:44 +00:00
Isaac Boukris
2764f53e20 credssp: fix dissect_credssp_heur() with modern clients (using version 6) 2021-06-08 17:36:44 +00:00
Isaac Boukris
9147201351 credssp: fix dissection in RDP stream
When there are more packets on the stream after credssp, like tpkt-rpd
data, the credssp heuristics fails when invoked by tls and then even the
packets for which the credssp heuristics succeeded do not get dissected
as credssp but as tpkt-continuation data.
To work around that, call the credssp heuristic dissector directly from
the rdp dissector before trying fastpath.
Leave the credssp heursitics in TLS for other protocols such as HTTP
where it may work.
2021-06-08 17:36:44 +00:00
Martin Mathieson
3248e2a759 Add E2AP ORAN 1.00 dissector 2021-05-25 13:29:47 +01:00
John Thacker
c00b062cb0 RANAP: Don't attempt to re-register heuristic dissectors
Move the RANAP heuristic dissector registration under the initialization
guard that they're only registered once. Prevents console warnings about
the dissectors already being registered to the sccp and sua tables if
a RANAP preference is changed.
2021-05-25 04:19:28 +00:00