Gerald Combs
8cbaec8e99
Add a comment about dfilter_compile freezing the UI, and how we might work
...
around the problem.
svn path=/trunk/; revision=31066
2009-11-24 19:24:09 +00:00
Stig Bjørlykke
0dbfde8b6d
Removed some unused variables and unused assignments.
...
svn path=/trunk/; revision=30918
2009-11-10 12:05:25 +00:00
Gerald Combs
5e34f21076
Add the ability to push temporary (and highlighted) messages onto the
...
statusbar. This lets us notify the user about something significant
without having to pop up an annoying window. Replace a few dialogs with
statusbar messages.
svn path=/trunk/; revision=30810
2009-11-04 00:02:52 +00:00
Stig Bjørlykke
77c49f4d4b
Made colorize_filter_te_as_deprecated() static.
...
svn path=/trunk/; revision=30200
2009-09-29 19:20:48 +00:00
Kovarththanan Rajaratnam
17f010119a
From Jakub Zawadzki via. Bug 3330:
...
* Fix memleak (df->deprecated in dfilter_free())
* Free protocol hash tables on cleanup.
* Free protocols list on cleanup.
* Free memory allocated by fgetline() in parse_services_file()
From me:
* proto.c: set gmc_hfinfo to NULL after free
* proto.c: switch order of g_free() and g_list_remove() in proto_cleanup()
svn path=/trunk/; revision=29656
2009-09-01 18:16:55 +00:00
Stig Bjørlykke
49ff735599
From yami (bug 3497):
...
Improved the "Invalid filter" message in the status bar.
svn path=/trunk/; revision=28515
2009-05-28 20:25:26 +00:00
Bill Meier
3cae24b6fe
Use consistent indentation
...
svn path=/trunk/; revision=28233
2009-05-01 16:36:04 +00:00
Stig Bjørlykke
62f60df6b4
From Jakub Zawadzki (bug 3331):
...
g_free() is NULL safe, so we don't need check against it.
svn path=/trunk/; revision=27718
2009-03-13 22:06:48 +00:00
Balint Reczey
4995d58135
show the type of the filter (Display/Capture Filter) on filter dialog
...
This fixes bug 1703.
svn path=/trunk/; revision=26622
2008-10-30 13:19:07 +00:00
Stig Bjørlykke
63309c74b8
Do not autocomplete when editing capture filter.
...
svn path=/trunk/; revision=26563
2008-10-26 21:53:24 +00:00
Stig Bjørlykke
3cd4e0ad4d
Only use the statusbar for filter messages from the main window.
...
Updating the statusbar from popup windows is confusing.
svn path=/trunk/; revision=26523
2008-10-23 14:30:35 +00:00
Stig Bjørlykke
2046b2731d
Rewrote to use gtk_widget_modify_text() and gtk_widget_modify_base()
...
to change the background color for filter text edit boxes, because
gtk_widget_set_style() interacts badly with themes.
Go back to default values when filter is empty (instead of white).
Also rewrote the same in the "Edit Color Filter" dialog.
svn path=/trunk/; revision=26421
2008-10-12 13:41:04 +00:00
Stig Bjørlykke
426f90cbe9
Forgot this for the Display Filter dialog:
...
Ensure we initialize the colorized filter text entries before we show the
widget, so we don't get wrong foreground color when using a dark theme.
svn path=/trunk/; revision=26418
2008-10-11 15:50:29 +00:00
Stig Bjørlykke
6012a91ebb
Added an option to syntax check only a single field name.
...
svn path=/trunk/; revision=26405
2008-10-10 17:00:38 +00:00
Martin Mathieson
75890548d7
Filter autocompletion from Bahaa Naamneh (bug 2581).
...
There are still display filter controls where this isn't being used
yet, but I'm committing it now so hopefully people can report any
problems.
Some commenting and formatting was done by myself.
svn path=/trunk/; revision=25788
2008-07-22 15:19:10 +00:00
Bill Meier
56206e0002
Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API
...
gtk_container_border_width() ==> gtk_container_set_border_width()
gtk_container_children() ==> gtk_container_get_children()
gtk_entry_new_with_max_length() ==> gtk_entry_new(); gtk_entry_set_max_length()
gtk_menu_append() ==> gtk_menu_shell_append()
gtk_menu_prepend() ==> gtk_menu_shell_prepend()
gtk_notebook_set_page() ==> gtk_notebook_set_current_page()
gtk_paned_gutter_size() ==> gtk_paned_set_gutter_size()
gtk_radio_button_group() ==> gtk_radio_button_get_group()
gtk_signal_connect() ==> g_signal_connect()
gtk_signal_disconnect() ==> g_signal_handler_disconnect()
gtk_signal_emit_by_name() ==> g_signal_emit_by_name()
gtk_signal_handler_block_by_data() ==> g_signal_handlers_block_matched()
gtk_signal_handler_block_by_func() ==> g_signal_handlers_block_by_func()
gtk_signal_handler_unblock_by_data() ==> g_signal-handlers_unblock_matched()
gtk_signal_handler_unblock_by_func() ==> g_signal-handlers_unblock_by_func()
gtk_spin_button_get_value_as_float() ==> gtk_spin_button_get_value()
gtk_toggle_button_set_state() ==> gtk_toggle_button_set_active()
svn path=/trunk/; revision=25634
2008-06-29 15:51:43 +00:00
Sake Blok
a287b0f3f5
From Jim Young (bug 2212):
...
Add the profile name to the title of all the configuration windows.
(this is a rewrite of Jim's patch)
svn path=/trunk/; revision=25016
2008-04-14 15:01:34 +00:00
Ulf Lamping
8e3e8b588f
sort #includes by directories
...
svn path=/trunk/; revision=24968
2008-04-13 01:54:20 +00:00
Ulf Lamping
72faa680b8
move statusbar related code from main.c into it's own main_statusbar.c
...
svn path=/trunk/; revision=24937
2008-04-12 15:55:27 +00:00
Ulf Lamping
55c2be83db
move stock icon code from toolbar.c into specific stock_icons file(s)
...
svn path=/trunk/; revision=24921
2008-04-12 00:49:20 +00:00
Ulf Lamping
736cada149
third round to replace SIGNAL_CONNECT with g_signal_connect
...
svn path=/trunk/; revision=24914
2008-04-11 22:10:36 +00:00
Ulf Lamping
ae5f841083
replace all appearances of BUTTON_NEW_FROM_STOCK with GTK2's gtk_button_new_from_stock
...
svn path=/trunk/; revision=24904
2008-04-11 18:58:19 +00:00
Bill Meier
42acebd42c
OBECT_..._DATA --> g_object_..._data
...
svn path=/trunk/; revision=24893
2008-04-11 16:04:54 +00:00
Stephen Fisher
16e54385b3
Replace SIGNAL_EMIT_BY_NAME(), SIGNAL_EMIT_OBJECT() and
...
SIGNAL_EMIT_STOP_BY_NAME() macros with their actual function names.
svn path=/trunk/; revision=24890
2008-04-11 05:03:33 +00:00
Ulf Lamping
63307ccc99
remove GTK1 code
...
svn path=/trunk/; revision=24818
2008-04-06 23:36:29 +00:00
Gerald Combs
269b0d0474
Add a priority level to each context in the info status bar. Use it to make
...
sure we don't overwrite filter status messages during live captures.
When "!=" is used in a display filter, point the user to the User's Guide.
svn path=/trunk/; revision=24315
2008-02-13 01:18:40 +00:00
Stig Bjørlykke
fe98fab03c
Added tooltip description for yellow filter background.
...
svn path=/trunk/; revision=24241
2008-02-01 10:02:19 +00:00
Stig Bjørlykke
18fd58de40
Added missing space in front of new statusbar messages.
...
svn path=/trunk/; revision=24233
2008-01-31 20:00:45 +00:00
Gerald Combs
9703c2bb75
If "!=" or "ne" are used in a display filter, warn the user that the results
...
may be unexpected.
svn path=/trunk/; revision=24232
2008-01-31 19:50:38 +00:00
Bill Meier
7b02205d27
Prevent Gtk-Critical msg when invoking "+Expression" from Filter Toolbar in main window;
...
Fixes bug reported by Toralf Förster
svn path=/trunk/; revision=22795
2007-09-05 14:59:37 +00:00
Bill Meier
24c891ab1f
default window_cancel_butoon_cb is not appropriate since a specific cancel cb is specified.
...
svn path=/trunk/; revision=22774
2007-09-03 00:17:47 +00:00
Ronnie Sahlberg
946af07b3a
gtk1 does not have gtk_window_get_modal
...
svn path=/trunk/; revision=22120
2007-06-17 19:57:47 +00:00
Stephen Fisher
c4ba5ad2b0
Fix bug #1334 and a problem where a user couldn't interact with the
...
filter dialog's add expression dialog when going to it through file->open
or file->merge (because dialogs in between are set to modal).
svn path=/trunk/; revision=22115
2007-06-17 00:54:58 +00:00
Ulf Lamping
407d0aeab0
fix all warnings in gtk dir & set the "treat all warnings as errors" MSVC flag
...
svn path=/trunk/; revision=21080
2007-03-21 03:26:26 +00:00
Stephen Fisher
19883c003a
Assign the cancel button (so you can hit the escape key) on the capture/display
...
filter dialog box
svn path=/trunk/; revision=20681
2007-02-02 01:09:41 +00:00
Gerald Combs
94cf826452
Fix Coverity CIDs 217 and 218, and fix filter dialog autoselection in
...
the process. This change assumes that you can make a copy of a
GtkTreeIter and use it later (which may not be valid), and hasn't been
tested using GTK 1.
svn path=/trunk/; revision=20550
2007-01-25 02:54:14 +00:00
Ulf Lamping
57be028caf
As Stephen Fisher noted, the Apply button should also save the changed settings (if the Save button is disabled)
...
svn path=/trunk/; revision=19418
2006-10-03 21:03:08 +00:00
Ulf Lamping
cdb57f37a2
now: Don't have a Save button in the following settings dialogs:
...
- Edit/Preferences
- View/Coloring Rules
- Capture/Capture Filters
- Analyze/Display Filters
- Analyze/Enabled Protocols
The settings will be automatically saved when pressing the Ok button.
If someone really wants the explicit Save buttons as before - you can get them back at the Edit/Preferences/User Interface page.
svn path=/trunk/; revision=19415
2006-10-03 19:53:10 +00:00
Ulf Lamping
765835ac7a
instead of reverting the whole changes by the *first* cancelled dialog box, revert them by clicking "Cancel" on the *last* dialog - this behaviour just makes more sense.
...
svn path=/trunk/; revision=19397
2006-10-02 20:59:38 +00:00
Ulf Lamping
2cf4d327f2
If the Cancel button was clicked and another filter dialog is still open - yes that's possible - reverse the changes on it as well to reflect the current internal list.
...
svn path=/trunk/; revision=19391
2006-10-01 19:34:03 +00:00
Ulf Lamping
889a082501
Change the filter dialog (capture and display filters), so it has a real Cancel button now - the former Close button didn't reverted the changes done.
...
svn path=/trunk/; revision=19390
2006-10-01 17:59:30 +00:00
Anders Broman
05448fcc3d
Ethereal->Wireshark
...
svn path=/trunk/; revision=18232
2006-05-28 17:19:08 +00:00
Guy Harris
92552c2d76
Get rid of a bunch of "Ethereal"s and "ethereal"s in comments, GUI
...
strings, and function names.
svn path=/trunk/; revision=18205
2006-05-22 07:29:40 +00:00
Ronnie Sahlberg
89f022b12b
name change
...
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00
Ulf Lamping
b4471e0195
fix #152
...
set the read filter dialog modal and transient to the parent window if requested. This way, it will receive input signals (solving problems with GTK2's gtk_file_chooser).
To do this, add another construct_args flag, so it will be modal only if really needed ...
svn path=/trunk/; revision=16926
2005-12-31 17:09:27 +00:00
Ulf Lamping
eafbbbcabb
renamed ui_util.c/.h to gui_utils.c/.h to prevent confusion with identical named ui_util.h in / dir
...
svn path=/trunk/; revision=15465
2005-08-20 12:09:48 +00:00
Jörg Mayer
4e1f4b18ab
More char -> const char warning fixes.
...
Removed (very few) casts that only change the warning message
but don't remove it (with gcc-4).
svn path=/trunk/; revision=15227
2005-08-05 20:59:08 +00:00
Guy Harris
b598c79446
GtkStyles are reference-counted, and a style returned by
...
"gtk_style_copy()" has a reference count of 1; release the reference
when we're finished setting other widgets' styles to it.
svn path=/trunk/; revision=13890
2005-03-24 03:58:38 +00:00
Ulf Lamping
66ce7f3623
add some more online help functionality and help buttons at various dialog boxes, if a help page *is* available. However, the new help system needs a lot more work before completed.
...
svn path=/trunk/; revision=13152
2005-01-20 23:17:23 +00:00
Ulf Lamping
6cd11f14ef
first steps towards using the User's Guide as Ethereal's help system
...
svn path=/trunk/; revision=12021
2004-09-16 22:07:03 +00:00