Commit Graph

13598 Commits

Author SHA1 Message Date
Jeff Morriss 3edbdc151d Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34229
2010-09-24 01:34:45 +00:00
Jeff Morriss 72516cc39e Replace another blurb that matches the name (case insensitive) with NULL.
svn path=/trunk/; revision=34228
2010-09-24 01:32:27 +00:00
Jeff Morriss 0ff5638f37 Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34227
2010-09-23 21:46:31 +00:00
Jörg Mayer 72c3e35672 - trunkated -> truncated
- Print "Type II" and "Type III" as versionstrings.
- Make sure that version = 1 or 2

svn path=/trunk/; revision=34222
2010-09-23 20:44:11 +00:00
Jörg Mayer 320de7eb14 Jason Masker:
- Add decoding of direction bit for version 2 (type III) erspan.

Me:
- Decode the original direction bit as unknown in case of version 2.
- The original unknown3 value seems to indicate whether the packet
  was too long to fit into a single mtu (trunkated).
- "Timestamp(s)" -> "Timestamp"


svn path=/trunk/; revision=34221
2010-09-23 19:42:20 +00:00
Stig Bjørlykke f5ab6c1930 Store "Show Resolved" setting for custom columns.
svn path=/trunk/; revision=34220
2010-09-23 19:41:55 +00:00
Bill Meier 123347da00 (Trivial) Whitespace cleanup.
svn path=/trunk/; revision=34217
2010-09-23 18:16:26 +00:00
Bill Meier b98e9422f9 Make value_string ipproto_val static; It should only be referenced using ipproto_val_ext
svn path=/trunk/; revision=34215
2010-09-23 18:00:06 +00:00
Bill Meier 3b48b69866 Use extended ipproto value_string (ipproto_val_ext).
svn path=/trunk/; revision=34214
2010-09-23 17:55:11 +00:00
Bill Meier a41e679b78 Whitespace cleanup: convert "4 space tabs" to spaces.
svn path=/trunk/; revision=34213
2010-09-23 17:52:29 +00:00
Bill Meier f66669274f Whitespace cleanup: Convert "4 space tabs" to spaces.
svn path=/trunk/; revision=34212
2010-09-23 17:49:43 +00:00
Anders Broman 1252ff8350 From Pascal Quantin:
NAS EPS] Wrong dissection of Non-current native NAS key set identifier

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5253

svn path=/trunk/; revision=34210
2010-09-23 14:07:32 +00:00
Jörg Mayer 527f5d5653 Jason Masker <jason at masker.net>:
Updates for the Cisco ERSPAN type III (version 2) protocol.

svn path=/trunk/; revision=34209
2010-09-23 13:31:28 +00:00
Jeff Morriss dfcc9ec3f7 Add some more casts.
svn path=/trunk/; revision=34208
2010-09-23 13:26:41 +00:00
Stig Bjørlykke 6087210f45 Updates from Lukasz Kotasa.
svn path=/trunk/; revision=34207
2010-09-23 09:22:12 +00:00
Stig Bjørlykke 907cfc535a Corrected check for attribute flag bits.
svn path=/trunk/; revision=34203
2010-09-23 07:42:20 +00:00
Stig Bjørlykke c403378c36 Show Abort source in info column.
svn path=/trunk/; revision=34202
2010-09-23 07:39:38 +00:00
Jörg Mayer de68ad3066 H. Sivank <hsivank@gmail.com>
I try to configure Wireshark with cmake on macosx 10.6.
It fails with : set_target_properties called with incorrect number of arguments.
Attached a patch to fix this issue.


svn path=/trunk/; revision=34201
2010-09-23 07:02:33 +00:00
Jaap Keuter 57a7873857 Fix for bug 5252:
Use real IPv6 destination address when RH0 has 0 segments left.

svn path=/trunk/; revision=34199
2010-09-23 06:58:55 +00:00
Jeff Morriss f12ef203b3 Revert 34191 and add some casts instead
svn path=/trunk/; revision=34193
2010-09-23 06:00:22 +00:00
Jeff Morriss 7cdf98c245 Use gsize (size_t) in a couple of places to make the Win64 build happy.
svn path=/trunk/; revision=34191
2010-09-23 01:14:44 +00:00
Sake Blok 558d6a761e Make buildbot happy again...
svn path=/trunk/; revision=34189
2010-09-22 22:46:36 +00:00
Sake Blok 7364bef1b3 When using a custom column, make it possible to select which occurrence to show if the field has multiple occurrences.
svn path=/trunk/; revision=34186
2010-09-22 20:56:14 +00:00
Bill Meier 8e278e7f90 - reassembly code shouldn't be under 'if (tree)'
- ECDH Parameter - Content:  Packet Bytes highlighting was off-by-one.

svn path=/trunk/; revision=34185
2010-09-22 18:32:15 +00:00
Bill Meier 4a1b968738 Code cleanup:
- Fix incorrect uses of val_to_str which could cause inv mem refs;
- Use tvb_reported_length instead of tvb_length;
- (Trivial) Remove some unneeded '= NULL' initializations;
- (A few other trivial changes).

svn path=/trunk/; revision=34183
2010-09-22 15:52:53 +00:00
Stig Bjørlykke 70e4898377 Code cleanup: Changed proto_tree_add_boolean() and proto_tree_add_bytes()
to proto_tree_add_item().

svn path=/trunk/; revision=34182
2010-09-22 13:31:49 +00:00
Stig Bjørlykke 630893d158 From Lukasz Kotasa and Lukasz Suchy via bug 5248:
Added dissector for WAI authentication protocol.

From me:
Some cleanup.

svn path=/trunk/; revision=34181
2010-09-22 13:18:23 +00:00
Stig Bjørlykke df7f6aa8ff From Lukasz Kotasa via bug 5248:
Added ETHERTYPE_WAI.

svn path=/trunk/; revision=34180
2010-09-22 13:14:46 +00:00
Anders Broman b596b69f66 From Pascal Quantin:
[NAS EPS] Use Request Type IE defined in 3GPP 24.008

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5246

svn path=/trunk/; revision=34179
2010-09-22 10:38:45 +00:00
Anders Broman f80f4ae05f From Pascal Quantin:
[NAS EPS] Traffic Flow Template IE dissection bugs.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5243

svn path=/trunk/; revision=34177
2010-09-22 07:06:15 +00:00
Anders Broman 6dc449e99c The CLDAP attribute value on a CLDAP reply is no longer being decoded
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5239

It got broken in Revision 33390 I think, if attr_type is unset at this point it should be set in the calling function.
http://anonsvn.wireshark.org/viewvc/trunk/asn1/ldap/ldap.cnf?r1=33388&r2=33390

svn path=/trunk/; revision=34176
2010-09-21 14:56:55 +00:00
Jeff Morriss 381664535b As suggested by Kovarththanan Rajaratnam in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3548 :
Clean up hf fields some more: mostly removing leading and trailing spaces from names and blurbs.

svn path=/trunk/; revision=34165
2010-09-21 03:14:49 +00:00
Jeff Morriss 46ef82837f Add a cast
svn path=/trunk/; revision=34164
2010-09-21 03:06:54 +00:00
Jeff Morriss 79e39c7ecb Use size_t to keep the Windows compiler happy
svn path=/trunk/; revision=34163
2010-09-21 02:41:29 +00:00
Jeff Morriss f2d070f19e From Jakub Zawadzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3336 :
We parse host & request page from headers, so we easily can construct full http
uri.

I was thinking about making it as field, so we could filter, print in column
info, or do other fancy stuff, but for now this is imho enough.


From me: add it as a (filterable) item.  Clean up spacing and indentation in a
few places.

svn path=/trunk/; revision=34162
2010-09-21 02:12:21 +00:00
Martin Mathieson 5d84e780d9 Fix sequence numbers reported when duplicate SN detected.
svn path=/trunk/; revision=34161
2010-09-20 17:01:22 +00:00
Stig Bjørlykke e6dac92931 Put Abort reason in info column.
svn path=/trunk/; revision=34159
2010-09-20 12:49:52 +00:00
Gerald Combs b08297d7ef [Automatic manuf and enterprise-numbers update for 2010-09-19]
svn path=/trunk/; revision=34155
2010-09-19 15:03:36 +00:00
Jaap Keuter 12b574e628 Fix for bug 5220:
- Don't list codecs which are deleted by using port 0.
- Use real concatenation i.s.o. reprint, which seems to fail in some circumstances.

svn path=/trunk/; revision=34154
2010-09-18 13:12:03 +00:00
Jeff Morriss 9ac49c557d Copy the rev 34143 changes to packet-snmp.c over to the asn1 source.
hf_snmp_engineid_enterprise is now a BASE_EXT_STRING, not BASE_RANGE_STRING.  This fixes
the fuzz failure in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5233 

svn path=/trunk/; revision=34151
2010-09-17 14:03:05 +00:00
Bill Meier 7219ee2a49 Use val_to_str_ext() & friends to access sminmpec_values[];
Also: packet-nhrp.c: #include sminmpec.h not req'd;

svn path=/trunk/; revision=34143
2010-09-17 04:51:21 +00:00
Jeff Morriss d643e0366a Remove check_col(). Clean up some spacing/indentation too.
svn path=/trunk/; revision=34142
2010-09-17 02:22:37 +00:00
Jeff Morriss f2cfa4e453 From Cal Turney via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5197 :
The NFS dissector (all versions) show access types that have not been requested
to be checked as "not allowed" in the call and reply.  This is incorrect and
misleading.  At present one must manually compare what was requested in order
to assess if access was actually denied for that type.  When there are hundreds
or thousands of these ACCESS requests in a capture, it is not possible or
practical to manually check each one.  

The submitted patch does the following:

* Passes the access mask in the call to the reply for comparison
* Adds filterable fields for each supported (v4) and access type
* Adds a pseudo field, nfs.access_denied
* Lists the access types to be checked in the summary and tree
* Separately lists the supported, denied, and allowed access types in the 
  summary and tree

The changes are applied to all NFS versions.


From me: a couple of small changes to make it compile without warnings.

svn path=/trunk/; revision=34141
2010-09-17 02:03:09 +00:00
Bill Meier 252df40cc2 Extensive V9/V10 code clean up, bug fixing & dissection display improvements:
Bugs fixed:
 - Invalid time display for various time fields;
     Millisecs for types 152, 153 are actually stored as 64 bit integers;
     Microsecs, nanosecs are actually stored  in "NTP format";
     Times for fields 158, 159 are relative to "export time";
     SystemInitTime displayed incorrectly;
     ...
 - Options template not cached when only scope fields in template.
 - Templates not processed on first pass thru capture file:
    (In some cases data flows might not be handled until options template later displayed).
 - V9: number of options template entries limited to about 8 instead of intended 42;
 - Multiple options temlate flows in an Options Template flowset not handled;
 - "NotSentOctets" dislayed as "NotSentPackets";
   ...

Cleanups:
 - Options and data template processing code more or less rewritten;
 - options template displayed with format similar to that used for data templates;
 - Handling and display of PEN field (including use to indicate REVERSE) improved;
 - Don't use same filter name for two similar fields which only differ in size;
 - Handling & dislay of "variable length" fields improved;
 - sminmec lookup (PEN) done only during template processing & cached for later use;
   ...
 - Whitespace/Formatting

svn path=/trunk/; revision=34140
2010-09-17 01:45:29 +00:00
Stephen Fisher 034f2739d2 Add "(BE)" to the big endian representations of the ICMP identifier and
sequence number fields to match the "(LE)" ones.


svn path=/trunk/; revision=34136
2010-09-16 18:22:45 +00:00
Stig Bjørlykke 2d93bc5e9a Make "4 NOP in a row" work again after changing the NOP name for TCP and IP
in revisions 34095 and 34097.

svn path=/trunk/; revision=34134
2010-09-16 12:29:22 +00:00
Sake Blok 84c08f1472 From Juha Siltanen :
When sorting a capture by protocol, some RTP packets are shown only as FLIP,
even though the dissection windows shows the RTP tree.

(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5215)


svn path=/trunk/; revision=34128
2010-09-15 21:17:35 +00:00
Stephen Fisher c3beba4fd1 Bug #5127 from Guenter Strubreiter:
for avoiding doubled definition of a table needed also by a tcap subdissector
plugin a definition in libwirshark.def is needed:

isup_calling_partys_category_value

Me: Change extern to WS_VAR_IMPORT in header file


svn path=/trunk/; revision=34126
2010-09-15 20:29:31 +00:00
Martin Mathieson dcf1ce54da Missed this one (check_col() removal)
svn path=/trunk/; revision=34125
2010-09-15 16:17:16 +00:00
Martin Mathieson a5532739d6 Remove a few more calls to check_col()
svn path=/trunk/; revision=34124
2010-09-15 16:16:23 +00:00