Commit Graph

110 Commits

Author SHA1 Message Date
Anders Broman 46e202503a se_allocate and store per packet data.
svn path=/trunk/; revision=42657
2012-05-16 14:56:34 +00:00
Anders Broman 3e2ea7b812 Handle DCH information in RadioLinkReconfigurationPrepareFDD
svn path=/trunk/; revision=42655
2012-05-16 13:05:27 +00:00
Anders Broman dc8224653e Only do HS-DSCH Control frames for now as something is broken.
svn path=/trunk/; revision=42653
2012-05-16 08:35:53 +00:00
Anders Broman ce6e224b5b Bug fixes and add HSDSCH
svn path=/trunk/; revision=42649
2012-05-16 05:57:41 +00:00
Anders Broman e134cca032 Use converstaion info to dissect FP DCH flows. Revert unfinished code.
svn path=/trunk/; revision=42628
2012-05-15 15:00:52 +00:00
Martin Mathieson eaf2e8a0bc Formatting of { } wasn't consistent, so settle on having { at the end of
the line rather than on a  line on its own.

svn path=/trunk/; revision=42548
2012-05-10 14:34:21 +00:00
Martin Mathieson 9cd2bdf381 Remove an accidental ; following a test.
svn path=/trunk/; revision=42519
2012-05-09 12:07:14 +00:00
Anders Broman 41ae73c57d Collect and use more information in converstion data to be able to dissect FP flows.
svn path=/trunk/; revision=42518
2012-05-09 12:01:16 +00:00
Guy Harris aee419527f Revert previous change - packet-umts_fp.h wasn't changed.
svn path=/trunk/; revision=42474
2012-05-07 17:41:29 +00:00
Martin Mathieson c9a82fcdb1 Include <epan/conversation.h> from packet-umts_fp.h.
svn path=/trunk/; revision=42469
2012-05-07 17:10:12 +00:00
Anders Broman 1e6a26dfe9 Use converstaion info in umts_fp.
svn path=/trunk/; revision=42466
2012-05-07 16:09:49 +00:00
Anders Broman babb1e59f6 Fix a typo.
svn path=/trunk/; revision=42400
2012-05-03 15:31:01 +00:00
Martin Mathieson ca382b40b4 Remove an unnecessary assignment from clang output. I can't see the
problem with the other 2 warnings for this file.
--This linen , and those below, will be ignored--

M    packet-umts_fp.c

svn path=/trunk/; revision=42312
2012-04-28 16:11:54 +00:00
Jakub Zawadzki 8a1dc57c03 Remove doubled semicolons and semicolons outside function.
svn path=/trunk/; revision=42053
2012-04-13 20:22:31 +00:00
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier 94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00
Martin Mathieson 85fdc1e62d Use val_to_str_const().
svn path=/trunk/; revision=39110
2011-09-23 17:10:08 +00:00
Anders Broman 215d3611ed Remove check_col and use ENC_BIG_ENDIAN.
svn path=/trunk/; revision=39070
2011-09-21 08:33:38 +00:00
Jeff Morriss 947e2c78c8 Use tvb_bytes_to_str() instead of a homegrown version.
svn path=/trunk/; revision=37321
2011-05-20 03:17:01 +00:00
Martin Mathieson 6c57efee2a Add missing trailing 0 to an hf mask value.
svn path=/trunk/; revision=37160
2011-05-15 16:52:05 +00:00
Martin Mathieson 46857df13e Fix mask when extracting FACH Indicator.
Coverity CID 349.

svn path=/trunk/; revision=36257
2011-03-22 18:24:38 +00:00
Martin Mathieson f69a54705c Respond to most of the clang warnings for this dissector.
svn path=/trunk/; revision=36208
2011-03-17 16:00:13 +00:00
Martin Mathieson 46f9b98003 2 VS Code Analyzer warnings were bogus. Avoid one and add a comment about the second one.
svn path=/trunk/; revision=36201
2011-03-16 22:51:45 +00:00
Martin Mathieson 4d3d029e09 Remove some instances of _U_ where the parameter is now used.
svn path=/trunk/; revision=36148
2011-03-06 23:10:28 +00:00
Martin Mathieson aa9102b72f Was reading F in mac-is descriptors the wrong way around...
svn path=/trunk/; revision=36106
2011-03-01 10:53:58 +00:00
Martin Mathieson e305c20212 Refactor EDCH-T2 function to also support the very similar EDCH-Common format.
N.B. EDCH-Common support itself not yet tested.

svn path=/trunk/; revision=35212
2010-12-17 17:40:42 +00:00
Martin Mathieson 3daaaf8a53 Use value_string for MAC-is descriptor lchid.
svn path=/trunk/; revision=35191
2010-12-15 12:07:41 +00:00
Martin Mathieson dea41913d5 Prettify the dissection of EDCH T2 data.
svn path=/trunk/; revision=35189
2010-12-15 10:53:35 +00:00
Martin Mathieson dc24655c06 Add support for FP E-DCH T2 frames.
svn path=/trunk/; revision=35188
2010-12-15 01:45:43 +00:00
Martin Mathieson 91436c78f6 Show DDI config info.
svn path=/trunk/; revision=35181
2010-12-13 11:00:05 +00:00
Martin Mathieson e1689f4ad4 Check the DDI while dissecting the header.
svn path=/trunk/; revision=35013
2010-11-23 11:01:48 +00:00
Martin Mathieson c018054581 Add another (unsupported) channel type identifier.
svn path=/trunk/; revision=35001
2010-11-22 13:37:13 +00:00
Martin Mathieson fe225663ee Reserve not-yet-supported channel type IDs.
svn path=/trunk/; revision=34967
2010-11-19 11:42:05 +00:00
Martin Mathieson f6ee7d8d4f From Tobias Witek (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5283)
epan/dissectors/packet-umts_fp.c
* Added mac subdissector (MAC) call to HSDSCH TYPE2 frames

epan/dissectors/packet-umts_mac.c
* Added support for HSDSCH TYPE2 frames by means of
        not nibble-shifting (4 bits) the SDU if MAC-ehs is used

epan/dissectors/packet-rlc.c
* Added support for "Use special value of the HE field" (3gpp 25.332-7a0 
9.2.2.7) commonly used for Release 7 HSDPA.
        REMARK: although the specification mandates that the
        special value is only allowed when activated by higher
        layers (RRC), it is interpreted unconditionally. We assume
        this is OK, because a different use in future specifications
        is very unlikely.

epan/dissectors/packet-fp_hint.c
* Added decoding of MAC-ehs indicator for HSDSCH frames
* Bumped fpi->release from 6 to 7 to enable proper
        HSDSCH TYPE2 frame decoding in the UTMS MAC parser.
        In general, this appears not to affect decoding
        of (conformant) FP frames of pevious releases.

svn path=/trunk/; revision=34433
2010-10-08 11:03:08 +00:00
Martin Mathieson 9f65e2a9c7 From Tobias Witek (bug 5282):
In some cases, the UMTS FP dissector currently calls upper-layer dissectors
(e.g. UMTS MAC) only when a proto-tree is present. Effectively, this causes the
RLC reassembly to fail in certain cases.

The attached patch solves the problem by slightly moving the calls to
'call_dissector()'.

svn path=/trunk/; revision=34399
2010-10-07 10:17:18 +00:00
Martin Mathieson fbf198ae9b Add expert info for timing adjustment control message, and tweak a label.
svn path=/trunk/; revision=34123
2010-09-15 15:52:30 +00:00
Martin Mathieson 31099a13aa Allow 3GPP release info to be displayed.
svn path=/trunk/; revision=33950
2010-08-27 13:54:05 +00:00
Martin Mathieson 3852415572 Show (again?) MAC-d PDUs inside MAC-es PDUs.
svn path=/trunk/; revision=33918
2010-08-25 13:01:00 +00:00
Martin Mathieson d8be0764d3 Set length of 'PDU Block Header' subtrees.
svn path=/trunk/; revision=33812
2010-08-16 15:14:01 +00:00
Martin Mathieson bbc98aa015 Fix a duplicate/copy-pasted filter field name.
svn path=/trunk/; revision=33782
2010-08-12 08:53:08 +00:00
Martin Mathieson b91b0515cc Update bit_offset whether calling MAC dissector or not.
svn path=/trunk/; revision=33711
2010-08-04 14:42:09 +00:00
Martin Mathieson 7b5d7d2e33 Add a preference to call MAC for TBs (on by default).
Improve info column display for HS-DSCH Capacity Request messages.
Removed calls to check_col().
Removed a few tabs.

svn path=/trunk/; revision=33698
2010-08-03 14:26:35 +00:00
Bill Meier 73eb16d678 Fix some gcc -Wshadow warnings
svn path=/trunk/; revision=31623
2010-01-22 17:41:47 +00:00
Anders Broman 4888a8de8a From Tobias Witek:
Add support for UMTS FP over UDP.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4218

svn path=/trunk/; revision=31113
2009-11-29 12:05:23 +00:00
Anders Broman 54aa776069 From Tobias Witek:
w protocols: UMTS RLC (ETSI TS 125 322), UMTS MAC (ETSI TS 125 321)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3495

svn path=/trunk/; revision=30838
2009-11-05 21:54:06 +00:00
Kovarththanan Rajaratnam 65c53fedb6 Don't guard col_append_str with check_col
svn path=/trunk/; revision=30125
2009-09-24 20:00:21 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Stig Bjørlykke 0437f102c3 From Kovarththanan Rajaratnam:
More FT_XXX cleanup.

svn path=/trunk/; revision=28971
2009-07-07 09:02:59 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Bill Meier c0e92cbc04 Fix various typos and spelling errors (mostly in text strings)
svn path=/trunk/; revision=27065
2008-12-20 00:09:02 +00:00