Commit Graph

3392 Commits

Author SHA1 Message Date
Bill Meier b56def1506 Fix compile errors if 'configure ... --without-pcap'
svn path=/trunk/; revision=24416
2008-02-22 04:56:26 +00:00
Stephen Fisher 470000e6c1 Use default numeric/text sort for custom columns also.
svn path=/trunk/; revision=24414
2008-02-22 01:26:26 +00:00
Bill Meier 4f82d2a007 Fix two compilation errors
svn path=/trunk/; revision=24405
2008-02-21 02:10:05 +00:00
Stig Bjørlykke 9f522c8eaf Added logarithmic y axis scale option.
svn path=/trunk/; revision=24402
2008-02-20 17:53:31 +00:00
Stephen Fisher ed3a633dd5 Fix some formatting
svn path=/trunk/; revision=24399
2008-02-20 05:47:39 +00:00
Gerald Combs 3df577499f Switch to the "oooh shiny" splash image.
svn path=/trunk/; revision=24393
2008-02-19 18:06:57 +00:00
Bill Meier 5b8da491d7 Add $Id$
svn path=/trunk/; revision=24382
2008-02-18 22:39:03 +00:00
Stig Bjørlykke fd9486cea6 Added help button in expert info and expert info composite dialogs.
svn path=/trunk/; revision=24374
2008-02-17 21:22:00 +00:00
Stig Bjørlykke 1c3c9d7828 When resize the IO Graphs window expand the filter field and advanced
calc field instead of the space between "Style:" and the style boxes, and
the X/Y Axis labels and corresponding boxes.

svn path=/trunk/; revision=24373
2008-02-17 18:37:56 +00:00
Bill Meier 16032ced67 Remove redundant (repeated) "PortAudio" from "About Wireshark" screen.
svn path=/trunk/; revision=24372
2008-02-17 16:26:06 +00:00
Stig Bjørlykke c9f7367658 Simplified printing of x-axis values so we get a consistent view even if
resizing the window.  Also draw a 8 pixel x-axis line between the x-axis
labels to make it easier to determine midway.

svn path=/trunk/; revision=24370
2008-02-17 14:27:52 +00:00
Stig Bjørlykke 43272f9435 Added an option to Conversations and Endpoints to limit the list to match
the current display filter.

Some Hosts -> Endpoints cleanup.

svn path=/trunk/; revision=24368
2008-02-17 00:35:55 +00:00
Stig Bjørlykke f8a07f7eff Added check for idx in get_frame_num().
svn path=/trunk/; revision=24364
2008-02-16 19:57:37 +00:00
Stig Bjørlykke 7af630f136 Corrected previous cast.
svn path=/trunk/; revision=24361
2008-02-16 17:19:09 +00:00
Stig Bjørlykke c1f721e423 Cast a double to guint32.
svn path=/trunk/; revision=24359
2008-02-16 17:00:08 +00:00
Stig Bjørlykke 11de0a827d Click in the IO Graph to select the first package in the selected interval.
Click button 3 to select the last package.

svn path=/trunk/; revision=24358
2008-02-16 16:40:36 +00:00
Stig Bjørlykke ba11df88da Added option to turn off name resolution.
Added help button (documentation TBD).

svn path=/trunk/; revision=24329
2008-02-14 09:33:57 +00:00
Gerald Combs 269b0d0474 Add a priority level to each context in the info status bar. Use it to make
sure we don't overwrite filter status messages during live captures.

When "!=" is used in a display filter, point the user to the User's Guide.

svn path=/trunk/; revision=24315
2008-02-13 01:18:40 +00:00
Stig Bjørlykke 5df0b2fe77 Do not update window title when destroying the dialog.
svn path=/trunk/; revision=24314
2008-02-13 00:31:54 +00:00
Stig Bjørlykke f410d0b781 Fixed an incorrect free loop.
svn path=/trunk/; revision=24311
2008-02-12 15:18:01 +00:00
Stig Bjørlykke a356f552b4 Added WLAN Traffic Statistics dialog.
svn path=/trunk/; revision=24310
2008-02-12 14:17:18 +00:00
Gerald Combs 556d14a8bf Wireshark occasionally starts up behind other applications. Bring it to the
front.

svn path=/trunk/; revision=24304
2008-02-11 19:20:10 +00:00
Stig Bjørlykke 56b0985653 Fixed setting filter in SCTP Chunk Counter statistics.
Fixed setting filter in NCP Endpoints.
Corrected $Id$ in hostlist_ncp.c

svn path=/trunk/; revision=24300
2008-02-11 13:15:48 +00:00
Stig Bjørlykke 89693ff729 Avoid double space in filter when creating from conversations and endpoints.
svn path=/trunk/; revision=24299
2008-02-11 11:06:35 +00:00
Stephen Fisher aa3c4cafbc Fix for bug #2250
svn path=/trunk/; revision=24294
2008-02-09 01:09:05 +00:00
Stig Bjørlykke 59a76191b4 Added SCTP Endpoints table.
Display port number in SCTP Conversations table.
Get correct display filter from SCTP Conversations.
Arrange Conversations and Endpoints tabs alphabetically.

svn path=/trunk/; revision=24291
2008-02-08 12:33:26 +00:00
Stig Bjørlykke 42fe2398b9 Added missing "svn:keywords Id" and "svn:eol-style native" for some
c and h files.

svn path=/trunk/; revision=24290
2008-02-08 09:45:36 +00:00
Stig Bjørlykke ad5e6ad06b Removed some more "statement not reached" warnings.
svn path=/trunk/; revision=24283
2008-02-07 12:52:08 +00:00
Stig Bjørlykke a60079bd1e Improved the profile name check to popup a dialog when trying to apply an
invalid profile name.

svn path=/trunk/; revision=24268
2008-02-04 15:50:17 +00:00
Bill Meier 3d02aa4c1f Clean up (some) indentation ...
svn path=/trunk/; revision=24266
2008-02-04 00:21:20 +00:00
Bill Meier ccabb036ec Fix benign typo
svn path=/trunk/; revision=24265
2008-02-04 00:11:59 +00:00
Sake Blok c8276a5c91 From Balint Reczey (bug 2233):
The attached patch makes the Statistics -> RTP -> Show All Streams feature of
wireshark accessible via tshark.

I found it helpful in dealing with tons of RTP captures.


svn path=/trunk/; revision=24252
2008-02-03 10:31:55 +00:00
Stig Bjørlykke de3c7e9a0b Disallow ending space was not such a good idea, chop it of before save instead.
Also disallow '/' in profilename for !win32. 

svn path=/trunk/; revision=24243
2008-02-01 18:42:59 +00:00
Stig Bjørlykke 4c2f3b0644 Fixed a problem with renaming a profile after hitting apply.
Profile name cannot start or end with space, and on win32 it cannot contain
any of this characters: \ / : * ? " < > |
Added a tooltip to the profile name text box.

svn path=/trunk/; revision=24242
2008-02-01 16:49:34 +00:00
Stig Bjørlykke fe98fab03c Added tooltip description for yellow filter background.
svn path=/trunk/; revision=24241
2008-02-01 10:02:19 +00:00
Stig Bjørlykke 10a8f59e03 Rewrote some prohibited APIs in gtk/ (sprintf, strcpy, strcat).
If we get some truncated strings we probably overwrote some buffers...

svn path=/trunk/; revision=24239
2008-02-01 01:07:58 +00:00
Stig Bjørlykke 18fd58de40 Added missing space in front of new statusbar messages.
svn path=/trunk/; revision=24233
2008-01-31 20:00:45 +00:00
Gerald Combs 9703c2bb75 If "!=" or "ne" are used in a display filter, warn the user that the results
may be unexpected.

svn path=/trunk/; revision=24232
2008-01-31 19:50:38 +00:00
Stig Bjørlykke f3747bf637 Hide hidden devices in "Capture Interfaces" dialog.
Added a function to check for hidden devices, which also work correctly
for plumbed devices on solaris.

svn path=/trunk/; revision=24231
2008-01-31 16:47:05 +00:00
Bill Meier 161eb8b6d7 Add missing g_object_unref for treeview models;
Remove not needed set_tree_model (stats_tree_stat.c)

svn path=/trunk/; revision=24230
2008-01-31 16:37:56 +00:00
Stig Bjørlykke 1efb7e3627 Add Luis' uat_get_table_by_name() to fetch SMI uat tables.
svn path=/trunk/; revision=24229
2008-01-30 22:50:55 +00:00
Stig Bjørlykke 869213d9ef Added missing space in front of some statusbar messages.
svn path=/trunk/; revision=24226
2008-01-30 15:16:21 +00:00
Stig Bjørlykke 7ec0e26318 When having more than one matching item in a frame the MAX and MIN calculation
could return an invalid value.  Also fixed AVG calculation.

svn path=/trunk/; revision=24220
2008-01-29 14:27:02 +00:00
Stig Bjørlykke 3278775634 When having more than one matching item in a frame the AVG calculation
did not return a correct value.

svn path=/trunk/; revision=24210
2008-01-27 18:19:40 +00:00
Stig Bjørlykke 8369bda495 Expand the Protocol column instead of the last column on window resize.
svn path=/trunk/; revision=24209
2008-01-27 15:54:15 +00:00
Stig Bjørlykke 45572b611c Do not change profile if directory creation failed, and change to default
profile if existing profile was deleted.

svn path=/trunk/; revision=24208
2008-01-27 14:45:31 +00:00
Stig Bjørlykke 57ab05545c Also destroy the window when failure to export/import color filters.
svn path=/trunk/; revision=24204
2008-01-26 17:04:49 +00:00
Stig Bjørlykke dce0761a4a Destroy the open window after open failure to avoid having an unusable
open dialog when using GTK >= 2.4.

This fixes bug 1986.

svn path=/trunk/; revision=24203
2008-01-26 16:50:08 +00:00
Stig Bjørlykke 9c8078686e Destroy the save window after canceling a save to an existing file, so
the user is able to save again without having a hidden save window which 
will not open.

Older GTK versions will show the hidden window after failure.

This fixes bug 1896.

svn path=/trunk/; revision=24202
2008-01-26 16:45:29 +00:00
Bill Meier e923010814 Fix various small memory leaks & 1 invalid g_free (airpcap_gui_utils.c)
svn path=/trunk/; revision=24185
2008-01-24 22:26:05 +00:00
Bill Meier 644a5bb6d2 Change "Found no match" to "No match found"
svn path=/trunk/; revision=24183
2008-01-24 22:12:10 +00:00
Jeff Morriss 75849c12f1 s/%ll/%" G_GINT64_MODIFIER "/g
svn path=/trunk/; revision=24181
2008-01-24 21:57:13 +00:00
Stig Bjørlykke 6a31f43f8b Always return a valid profile name from get_profile_name().
svn path=/trunk/; revision=24175
2008-01-24 17:06:22 +00:00
Bill Meier dc0b8a0727 One of fixes in SVN #24173 incomplete; Undo it for now
svn path=/trunk/; revision=24174
2008-01-24 05:39:48 +00:00
Bill Meier b01c07bcdd Fix two very minor memory leaks
svn path=/trunk/; revision=24173
2008-01-24 04:20:07 +00:00
Gerald Combs 690f8f51f8 Arrange things so that if '-o "capture.auto_scroll: FALSE"' is passed to
Wireshark on the command line, auto-scroll is actually disabled.

svn path=/trunk/; revision=24172
2008-01-24 01:23:19 +00:00
Bill Meier a054ed6040 Fix a minor memory leak; Remove some unused variables
svn path=/trunk/; revision=24168
2008-01-23 14:07:40 +00:00
Bill Meier 6bb8b5f9b9 Fix minor memory leak
svn path=/trunk/; revision=24167
2008-01-23 14:05:22 +00:00
Jaap Keuter 56222aed0e Fix for bug 1920:
Avoid double free, causing crash, and stop memory leak via normal code path.

svn path=/trunk/; revision=24152
2008-01-21 07:35:16 +00:00
Stig Bjørlykke edf727387f Fixed crash when save IO Graphs (bug 2126).
The problem was that configure_event() is called each time the window size
changes, and each time the pixmap buffer is recreated and a new signal added
to the save button.

svn path=/trunk/; revision=24145
2008-01-20 16:53:53 +00:00
Stig Bjørlykke 27db1b2798 Added "copy as CSV" button to IO Graphs.
svn path=/trunk/; revision=24143
2008-01-20 12:24:14 +00:00
Jaap Keuter d3e52cc1fe Cleanup the whitespace.
svn path=/trunk/; revision=24137
2008-01-19 07:46:52 +00:00
Stig Bjørlykke 1621224a86 Free allocated data in prefs_reset, removed need for uat_reload_all and
made some cleanups in profile_dlg.

svn path=/trunk/; revision=24136
2008-01-19 01:18:35 +00:00
Stig Bjørlykke cd259ecb55 I can't find any reason to unselect the current package only when an entry
in the packet details view is selected.  I suppose unselecting the field is
more correct.  The previous behaviour lead to some strange errors:

 Select a packet and an entry in the packet details.  Add a new column
 and change a protocol preference.  Observe the selected package is
 unselected and packet 1 is selected, which I think is wrong.

 Do the same as above with one of the following exceptions:
  - without selecting an entry in the packet details.
  - without adding a new column.
  - without changing a protocol preference.
 Observe the selected package is still selected, which is correct.

The correct behaviour here happens because of the cf_goto_frame call in
redraw_hex_dump_all, which causes the field to be unselected before
packet_list_set_sel_browse is called, and then the cf_unselect_package
is never called.  

Maybe someone with a deeper knowledge should have a look at this...

svn path=/trunk/; revision=24135
2008-01-18 22:51:37 +00:00
Jaap Keuter 44ea74a5da Move libsmi settings from virtual mibs protocol page to name resolution page.
svn path=/trunk/; revision=24131
2008-01-18 07:18:32 +00:00
Jaap Keuter 32e4818641 Whitespace cleanup of AIRPCAP code.
svn path=/trunk/; revision=24127
2008-01-17 22:28:31 +00:00
Jaap Keuter 2e0f8088c3 From Jim Young:
This patch provides a new RTP Player preferences dialog.  It allows one to
select the maximum number of visable channels in the RTP Player window.  The
default is four (4) channels which is the maximum number of usable channels 
that the RTP Player can display and still have access to the bottom row buttons 
on a 1024*768 resolution display.  Specifying a value less than 1 or greater than 
10 will be result in the RTP Player displaying the default 4 channels.

svn path=/trunk/; revision=24112
2008-01-16 07:36:34 +00:00
Stig Bjørlykke ac7dfec61d Changed to use GTK stock icon for preferences in the toolbar.
svn path=/trunk/; revision=24094
2008-01-15 00:24:59 +00:00
Stig Bjørlykke c6ab78409f Save the changes also when selecting a profile from the list.
svn path=/trunk/; revision=24092
2008-01-14 21:58:45 +00:00
Stig Bjørlykke ba3f5057b1 Several profile enhancements:
- Give initial focus to the profiles list
- Enter in the profiles list selects the profile
- Give focus to the profile name when creating a new profile

svn path=/trunk/; revision=24091
2008-01-14 21:43:10 +00:00
Stig Bjørlykke a6c7284e3b Added cast of argument to isspace.
svn path=/trunk/; revision=24090
2008-01-14 19:19:47 +00:00
Stig Bjørlykke a2d1e9005d This patch adds support for configuration profiles, which can be used to
configure and use more than one set of preferences and configuration files.

This can be found in the "Configuration Profiles..." menu item from the Edit
menu, or by pressing Shift-Ctrl-A.  It's also possible to start wireshark
and tshark with a named profile by using the "-C ProfileName" option.
A new status pane in the main window will show the current profile.

The configuration files currently stored in the Profiles are:
- Preferences
- Capture Filters
- Display Filters
- Coloring Rules
- Disabled Protocols
- User Accessible Tables

The recent data are by design not added to the profile.

Planned future enhancements:
- make a more convenient function to switch between profiles
- add a "clone profile" button to copy an existing profile
- make the profiles list active and accept return as OK
- save users "Decode as" in the profile
- make new, clone and deletion of profiles more secure
- make some of the recent values available in the profile

This patch also fixes:
- setting default status pane sizes
- a bug setting status pane for packets when not having main lower pane.

svn path=/trunk/; revision=24089
2008-01-14 16:40:23 +00:00
Stig Bjørlykke 8b4e80384a Fixed a few "statement not reached" warnings and a "assignment type mismatch" warning.
svn path=/trunk/; revision=24085
2008-01-14 09:39:55 +00:00
Stephen Fisher 9463667692 Fix for bug #2017: VoIP trace crashes Wireshark when specific RTP Player
buttons are clicked


svn path=/trunk/; revision=24073
2008-01-13 04:24:24 +00:00
Bill Meier addba66749 Use glib equivalent of ntohs
svn path=/trunk/; revision=24056
2008-01-10 14:42:55 +00:00
Stephen Fisher 430866e511 To ease troubleshooting of bug #2017 and for code clarity in the future, use
two different variables for types voip_rtp_stream_info_t (strinfo) and
voip_calls_info_t (callsinfo) instead of using strinfo for both.


svn path=/trunk/; revision=24038
2008-01-09 08:34:58 +00:00
Stig Bjørlykke eef80786a8 Fixed some small typos.
svn path=/trunk/; revision=24035
2008-01-08 23:14:13 +00:00
Stig Bjørlykke 6d4a2e7ebf Changed email address for Gerald from zing.org to wireshark.org
in a lot of files, which I suppose is correct.

svn path=/trunk/; revision=24034
2008-01-08 22:54:51 +00:00
Jaap Keuter 670e46f78b Make RTP player G.729 Annex B compatible.
svn path=/trunk/; revision=24032
2008-01-08 13:04:50 +00:00
Stig Bjørlykke 56bf2afc04 Never print x axis values outside the graph (we now have "view as time of day").
Fixed calculating first_interval (the scrollbar issue in bug 1763).

svn path=/trunk/; revision=23989
2008-01-03 01:17:47 +00:00
Stig Bjørlykke ddac83a322 Initialize io->view_as_time.
svn path=/trunk/; revision=23988
2008-01-02 20:09:20 +00:00
Stig Bjørlykke cb1448416f Fix a cut'n'paste error for GTK_VERSION < 2 in last commit.
Fixed some indentation.

svn path=/trunk/; revision=23975
2007-12-29 23:20:14 +00:00
Stig Bjørlykke 1776029a7c Add an option to view the X axis as time of day instead of seconds since
start of capture.

svn path=/trunk/; revision=23974
2007-12-29 20:57:15 +00:00
Stig Bjørlykke 69be72052c Add a warning in the IO Graph if too many elements.
svn path=/trunk/; revision=23973
2007-12-29 20:53:10 +00:00
Tomas Kukosa 487792b348 save RTP in 16-bit linear PCM instead of 8-bit G.711 u-Law
(preparation for more codecs support via codec plugins)

svn path=/trunk/; revision=23961
2007-12-28 13:01:55 +00:00
Jaap Keuter 789d4770d5 Fix menu sensitivity even for text only nodes.
svn path=/trunk/; revision=23936
2007-12-21 22:22:19 +00:00
Guy Harris 0cadc40746 Temporarily #if 0 out code that was causing crashes.
svn path=/trunk/; revision=23893
2007-12-16 22:33:03 +00:00
Sake Blok 9a2d18d386 Changes the name of the menu item "View/Reset Coloring" to
"View/Reset Coloring 1-10" and adds sensitivity to it so that
it will be greyed out when none of the temporary color filters
are used.

(as per discussion on wireshark-dev some time ago)


svn path=/trunk/; revision=23879
2007-12-15 23:38:29 +00:00
Jaap Keuter a629334be6 With increasing number of dissectors, heuristics cause sometimes false hits on packets. It's a pain to go through the menu / enabled protocols dialog to temporarily disable such dissector. This change adds an option to the packet detail menu to do a point-and-click style temporary disable of such protocol.
svn path=/trunk/; revision=23873
2007-12-15 13:26:09 +00:00
Jaap Keuter 14141c3275 Source code cleanup.
svn path=/trunk/; revision=23860
2007-12-14 07:06:22 +00:00
Stig Bjørlykke 74c6f15a03 Do not use calc_field unless in advanced y axis (bug 1763).
Register new tap listener (new filter) when going from advanced y axis.
Add parantheses to the filters to ensure they are correct when concatenated.

svn path=/trunk/; revision=23844
2007-12-12 09:31:02 +00:00
Ronnie Sahlberg 757e72e177 If not building for gtk 2.4.0, if out a function that is only used when
building for 2.4.0


svn path=/trunk/; revision=23830
2007-12-10 20:40:31 +00:00
Bill Meier 2b73cb3e19 Fix conversions so compiles for both 32-bit and 64-bit
svn path=/trunk/; revision=23826
2007-12-10 18:09:52 +00:00
Bill Meier df4f2f604e Fix Bug #2055: "File Save not working properly";
Change SVN #23487 patch to not use signal_connect each time the
the function of the save button is changed since that
results in multiple callbacks attached to the save button.
Intead: associate data with the save button which species its
current function.
(It sure would be nice if the original problem causing the 
 blank spot on the toolbar could be resolved; the work-around 
is starting to get messy).

svn path=/trunk/; revision=23821
2007-12-10 03:27:40 +00:00
Guy Harris d4672d13f5 Add macros for various filter actions and types, and to combine them
into a callback argument and split a callback argument up.

svn path=/trunk/; revision=23816
2007-12-09 09:04:58 +00:00
Guy Harris 7c03d14d60 Add macros for various filter actions, types, and directions, and to
combine them into a callback argument and split a callback argument up.

svn path=/trunk/; revision=23815
2007-12-09 09:04:39 +00:00
Guy Harris 88adb489c3 Add extra parenthesization, tweak name of argument to some macros to
more accurately reflect what it is.

svn path=/trunk/; revision=23814
2007-12-09 09:02:14 +00:00
Ronnie Sahlberg b57ce9e48f some updates to make it compile with gtk/glib < 2
svn path=/trunk/; revision=23810
2007-12-08 22:45:30 +00:00
Bill Meier 01ec87aee5 Revert SVN #23728 since change (to fix a Windows issue) is in code not used on Windows
and thus does not actually fix anything.
See Bug #2055 for further info.

svn path=/trunk/; revision=23809
2007-12-08 20:59:15 +00:00
Stig Bjørlykke 4783f12c08 Added "Apply as filter"/"Prepare a filter"/"Find frame"/"Colorize Protocol"
menu.  Simplified getting the Display filter.

svn path=/trunk/; revision=23786
2007-12-06 18:10:35 +00:00
Gerald Combs e66660cd84 Make sure the "auto scroll in live capture" toolbar button and menu item
correctly reflect the auto scroll state. Re-enable the ability to use
the auto scroll toolbar button and menu item during a live capture.

svn path=/trunk/; revision=23777
2007-12-05 23:50:28 +00:00
Stig Bjørlykke 11c616f11e Do not redraw graph and goto frame 1 if selecting an "item" outside the list
in Graph Analysis list.

svn path=/trunk/; revision=23770
2007-12-05 13:32:09 +00:00
Guy Harris d31730a21b Use G_GINT64_MODIFIER for gint64 and guint64 values.
svn path=/trunk/; revision=23763
2007-12-05 10:17:58 +00:00
Stig Bjørlykke d3c4d1b221 Do not create an illegal filter when having an empty display filter and
selecting Apply/Prepare "and/or (not) Selected" in Conversations, Endpoints
and Service Response Time.

svn path=/trunk/; revision=23756
2007-12-04 23:47:30 +00:00
Gerald Combs 0fa29bb1ea Add an oid_get_default_mib_path() function, and use it to display the MIB
path in About->Folders.

svn path=/trunk/; revision=23753
2007-12-04 18:43:40 +00:00
Tomas Kukosa 08bbd29c71 Support for RPCAP features in GUI (from Boris Misenov, see Bug 1366)
- retrieving the list of remote PCAP interfaces
  - password authentication support
  - UDP data fransfer
  - packet sampling (available in WinPcap 4.x)
  etc.

fix problem if non-default rpcap port is used

svn path=/trunk/; revision=23750
2007-12-04 11:19:29 +00:00
Tomas Kukosa 236e14d9f6 add missing emem.h include (prefs-int.h uses emem structures now)
svn path=/trunk/; revision=23748
2007-12-04 08:33:20 +00:00
Guy Harris 15f3b2c750 Add macros for various filter actions and types, and to combine them
into a callback argument and split a callback argument up.

svn path=/trunk/; revision=23747
2007-12-04 08:27:48 +00:00
Guy Harris a8ce49d758 More whitespace cleanup.
svn path=/trunk/; revision=23746
2007-12-04 07:53:23 +00:00
Guy Harris 353d921d66 Clean up indentation.
svn path=/trunk/; revision=23745
2007-12-04 07:50:44 +00:00
Guy Harris d226610d55 Add a break statement - not necessary in this case, but cleaner, and
matches similar code in other files.

svn path=/trunk/; revision=23744
2007-12-04 07:50:18 +00:00
Guy Harris 9f720bb78f Note in a comment the sad truth that CFURLCreateWithString() fails
either because of a bad URL string or a failure to allocate memory, and
that we can't easily determine which of those happened.

svn path=/trunk/; revision=23740
2007-12-04 04:33:44 +00:00
Stig Bjørlykke 1b7aed33ca - Added three more y axis scale values to be able to draw time values
up to 2000 seconds (maximum when using guint32).
- Combined some common code to draw the y axis values.

svn path=/trunk/; revision=23732
2007-12-04 01:28:38 +00:00
Stig Bjørlykke b20e64d4f9 Simplified y-positions for FBAR and DOT to ensure out-of-graph values are
drawn as they should be.  I hope this is the last fix this time...

svn path=/trunk/; revision=23729
2007-12-04 00:36:39 +00:00
Gerald Combs ed0bb11925 If we're using the native Windows file dialog, don't bother to see if the
file exists before we try to save it. The Windows file dialog code does that
for us.

svn path=/trunk/; revision=23728
2007-12-04 00:23:56 +00:00
Stig Bjørlykke 96586ead65 Use same notation for all y axis time labels, so we don't end up having one
in seconds, one in milliseconds and one in microseconds.

svn path=/trunk/; revision=23722
2007-12-03 22:11:06 +00:00
Guy Harris b370727bf3 Fix indentation.
svn path=/trunk/; revision=23720
2007-12-03 21:57:57 +00:00
Guy Harris 3066148a2b Clean up indentation.
svn path=/trunk/; revision=23719
2007-12-03 21:55:44 +00:00
Guy Harris 835bcbd5e5 If CoreFoundation create calls fail, fail, don't drive on.
svn path=/trunk/; revision=23716
2007-12-03 21:41:06 +00:00
Guy Harris ae459b483f Parenthesize the operand of the cast, to make it clearer that we're
casting the result of the entire computation.

svn path=/trunk/; revision=23714
2007-12-03 21:35:54 +00:00
Anders Broman ea19a489e1 Add another cast.
svn path=/trunk/; revision=23712
2007-12-03 20:53:26 +00:00
Stig Bjørlykke e9090e24bc Add some casts to get the windows compiler happy.
svn path=/trunk/; revision=23711
2007-12-03 20:43:30 +00:00
Stig Bjørlykke 96e82fb78f Added two more y axis scale values to be able to draw time values up to
200 seconds.

svn path=/trunk/; revision=23710
2007-12-03 20:17:31 +00:00
Stig Bjørlykke 4efc9ba371 Ensure we don't wrap the values when calculating advanced time values.
With default window size the limit for this wrap is ~27 seconds when having
0-50 seconds on the y axis, and decreases greatly on higher window size.  

svn path=/trunk/; revision=23708
2007-12-03 19:44:27 +00:00
Stig Bjørlykke 79b3da4b00 Changed from Ok button to Close button.
svn path=/trunk/; revision=23697
2007-12-02 14:43:41 +00:00
Ulf Lamping e4d7a5c236 fix bug #1594: compositions must be differentiated by both protocol and summary, not only the summary - otherwise this results in a single entry if two protocols share the same summary, e.g. TCP/UDP "Bad Checksum"
svn path=/trunk/; revision=23696
2007-12-02 10:13:57 +00:00
Sake Blok e8ca13de9e After taking a closer look at SVN 23089, I believe it was intended only to add the
file-name to the window title and not change the rest of the name.
(the graph window is both used from "Flow Graph" and from "VoIP calls")


svn path=/trunk/; revision=23695
2007-12-01 02:10:03 +00:00
Ulf Lamping a912ab234c move "Display Filter Macros" from View to Analyze menu, just below "Display Filter" - I guess it fit's much better there
svn path=/trunk/; revision=23693
2007-11-30 23:28:06 +00:00
Sake Blok e825cba61b Give the flow graph window the correct title.
svn path=/trunk/; revision=23689
2007-11-30 18:55:34 +00:00
Stig Bjørlykke 44145c21ed Show the Display filter in Protocol Hierarchy Statistics.
svn path=/trunk/; revision=23686
2007-11-30 15:37:21 +00:00
Stig Bjørlykke facb4b5d50 Move the "copy" button down to the button bar, to match the layout in
the conversations window.

svn path=/trunk/; revision=23685
2007-11-30 14:36:18 +00:00
Stig Bjørlykke 0abea9b7d9 More summary enhancements:
- Don't hide columns in the GUI
- Show Packets count first
- Always show values in Packets count
- Don't show Avg. packet size if 1 packet
- Don't show time between packets if 1 packet

svn path=/trunk/; revision=23684
2007-11-30 13:28:12 +00:00
Tomas Kukosa a5ca7ec384 hide implementation of module list
(it makes easier change from GList to GTree as we have many modules now and GList implementation is slow for searching)

svn path=/trunk/; revision=23669
2007-11-29 07:52:52 +00:00
Sake Blok e2598d0c92 Remove "Reset coloring" from context menu's to keep the GUI consistent
svn path=/trunk/; revision=23657
2007-11-28 22:36:53 +00:00
Sake Blok 069ddc1335 Add sensitivity to some temporary coloring menu items.
svn path=/trunk/; revision=23654
2007-11-28 22:07:44 +00:00
Stig Bjørlykke 311ec68206 Put double click on a frame link back.
svn path=/trunk/; revision=23644
2007-11-28 12:30:18 +00:00
Stephen Fisher 9d83eb39fc Fix bug #954 for LDAP SRT stats along with the same problem in all the other
SRT code.


svn path=/trunk/; revision=23640
2007-11-28 03:04:09 +00:00
Stephen Fisher c232d0b385 Fix a problem whereby the smb2 service resposne time statistics filter was
getting a comma added to be beginning of the filter that the user entered.


svn path=/trunk/; revision=23639
2007-11-28 02:54:23 +00:00
Ronnie Sahlberg e6ed260aca some more path fixes for g_ascii_strcasecmp.h
svn path=/trunk/; revision=23638
2007-11-28 01:31:23 +00:00
Ronnie Sahlberg abb4bc4fae no need to include those xpm's unless we are building for gtk2
svn path=/trunk/; revision=23637
2007-11-28 01:27:07 +00:00
Ronnie Sahlberg 2830cf2045 fix the path to include g_ascii_strcasecmp.h
svn path=/trunk/; revision=23636
2007-11-28 01:23:09 +00:00
Stig Bjørlykke 6e39bc94d1 Summary enhancements:
- Added traffic statistics for marked packages.
- Do not show Displayed column unless using it.
- Removed Marked packets line, as this info is in the marked packets column.

Will add documentation changes if keeping this feature.

svn path=/trunk/; revision=23633
2007-11-28 01:09:02 +00:00
Guy Harris 9c89cdaaa3 strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delenda
est.  Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our
own versions if they're missing from GLib (as is the case with GLib
1.x).

In the code to build the list of named fields for Diameter, don't use
g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping
in the hash function and use g_ascii_strcasecmp() in the compare
function.

We do this because there is no guarantee that toupper(), tolower(), and
functions that use them will, for example, map between "I" and "i" in
all locales; in Turkish locales, for example, there are, in both
upper case and lower case, versions of "i" with and without a dot, and
the upper-case version of "i" is "I"-with-a-dot and the lower-case
version of "I" is "i"-without-a-dot.  This causes strings that should
match not to match.

This finishes fixing bug 2010 - an earlier checkin prevented the crash
(as there are other ways to produce the same crash, e.g. a bogus
dictionary.xml file), but didn't fix the case-insensitive string matching.

svn path=/trunk/; revision=23623
2007-11-27 18:52:51 +00:00
Jaap Keuter 3f8ffe514f Fix for bug 2000. Make sure that both datalink layer and application layer agree that information is missing before refusing to write a payload.
svn path=/trunk/; revision=23618
2007-11-27 06:49:48 +00:00
Gerald Combs 85d12e73b3 Disable splash message logging, since it seems to ignore the log level mask.
svn path=/trunk/; revision=23611
2007-11-26 21:54:00 +00:00
Gerald Combs 9e16f1313c If the user has G_LOG_LEVEL_INFO enabled, provide startup progress messages.
svn path=/trunk/; revision=23606
2007-11-26 18:38:03 +00:00
Jeff Morriss dd0a4750b0 s/stat/eth_stat/ and s/unlink/eth_unlink/ to avoid non-ASCII filename problems on Windows.
svn path=/trunk/; revision=23605
2007-11-26 18:35:37 +00:00
Jeff Morriss be611615f8 From Florent Drouin via http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2015 : fix crash when editing UAT tables
svn path=/trunk/; revision=23604
2007-11-26 18:00:21 +00:00
Stig Bjørlykke 4b395e9e56 Check current_frame instead of finfo_selected before trying to build a
display filter based on the "selected" package.

svn path=/trunk/; revision=23597
2007-11-26 11:16:04 +00:00
Sake Blok 24c8b3a4b7 Check if a packet is selected before trying to build a display filter based
on the "selected" packet. Fixes bug 2020.


svn path=/trunk/; revision=23596
2007-11-26 09:10:37 +00:00
Sake Blok 61e7574a5c Reset the temporary coloring filters to defaults instead of doing it
implicitly by calling "color_filters_init()". This should probably
fix the crashes experienced when pressing ctrl-space a couple of times


svn path=/trunk/; revision=23583
2007-11-25 14:17:56 +00:00
Sake Blok db2f6ce546 Fixes crashing when opening color filters and pressing OK
(introduced in SVN 23560)


svn path=/trunk/; revision=23582
2007-11-25 12:36:33 +00:00
Stig Bjørlykke 6f1ab30f2f From Joe Eykholt:
Show content even if the trailer is missing.

From me:
Add proto_tree_set_appendix for the checksum and EOF.

svn path=/trunk/; revision=23581
2007-11-25 12:15:02 +00:00
Stig Bjørlykke e021e1441f Add a cast to make it compile again.
svn path=/trunk/; revision=23569
2007-11-24 20:55:03 +00:00
Sake Blok 9b6f806089 This patch adds (ten) temporary coloring rules which will only live until Wireshark is
quit. Temporary coloring filters can be set by:

- pressing <ctrl>-<digit> will create a conversation coloring filter based on the
  addresses of the currently selected packet (order TCP/UDP/IP/Ethernet)
  This can also be achieved from the "View|Colorize Conversation" menu.

- Rightclicking on a packet in the packet-list will give the option to
  "Colorize Conversation" just as "Conversation Filter" does.

- Rightclicking on an item in the packet-detail-list will give the option to
  "Colorize with filter" which works similar to "Apply as filter"

Temporary filters can be cleared from the same menus or by pressing <ctrl>-<space>.

This patch also adds an item to the above mentioned menu's to add a permanent color filter
in the same way.


The colors for the temporary coloring rules are now hardcoded as I do not know
how to change the color of menu-items and therefore I chose to use icons to
show the actual color of each of the ten temporary coloring rules. Is it at all
possible to have different menu items in different colors?

One other way of solving this is to recreate the icons on the fly after changing
the colors. I will have a look into that once it is clear whether I can use 
different colors within the menu structure.


svn path=/trunk/; revision=23560
2007-11-24 11:38:16 +00:00
Stig Bjørlykke f174dede0a Avoid redraw hex dump windows if redissecting.
svn path=/trunk/; revision=23532
2007-11-21 18:56:05 +00:00
Tomas Kukosa cfce233c75 fix crash caused with memory overwrite (flush buffer into window when we do not have space for next line)
svn path=/trunk/; revision=23527
2007-11-21 13:11:13 +00:00
Stephen Fisher d0b752c441 Fix bug #1841: Crash after adding&deleting a column (while packet capture
is in progress).


svn path=/trunk/; revision=23523
2007-11-20 23:21:33 +00:00
Gerald Combs dfb104544f Add relative start time, duration, and average data rate (bps) columns
to the conversation lists. Move the "copy" button down to the button bar
in order to free up some real estate. Add an nstime_cmp() function. Clean
up code in a few places.

svn path=/trunk/; revision=23516
2007-11-20 18:35:41 +00:00
Stephen Fisher 94af1b4929 Rest of fix for SVN revision 23487. This change also changes the callback
function for the Save/Save As button as necessary.


svn path=/trunk/; revision=23506
2007-11-20 00:34:16 +00:00
Stephen Fisher 64fe05e583 Fix my last commit (23487) to work with GTK 2.4 - 2.11+. I had accidently
used a GTK 2.12+ function in the last commit.


svn path=/trunk/; revision=23488
2007-11-19 04:37:45 +00:00
Stephen Fisher 854790d061 Fix a problem introduced with the GTK 2.4+ Toolbar API whereby the save/
save as button would disappear (leaving a blank spot on the toolbar) after
starting & stopping a capture session more than once.

This fix gets rid of the second save_as_button when using GTK 2.4+ in favor
of converting the stock id / tooltip text of the save_button to that of
the save as button when necessary and reverting it back to just save when
necessary.


svn path=/trunk/; revision=23487
2007-11-19 04:24:00 +00:00
Stephen Fisher 8a154bcfdd Fix bug #1164 again - this time for GTK1.
svn path=/trunk/; revision=23482
2007-11-18 04:20:14 +00:00
Anders Broman f6d282b6cd Apply yet another set of the optimization patches:
- Don't call tree_view_select on first button click event, it's already done by the tree widget.
- Factorize slow gtk_text_buffer_insert_with_tags_by_name() calls

svn path=/trunk/; revision=23477
2007-11-17 08:57:20 +00:00
Stig Bjørlykke ff0346154a Added some parentheses to clarify the gint64 cast.
svn path=/trunk/; revision=23447
2007-11-14 10:15:20 +00:00
Stig Bjørlykke b4980a48bd From Shiang-Ming Huang:
Removed unnecessary parentheses that make the average packets size 
calculated as an integer instead of a float.

svn path=/trunk/; revision=23446
2007-11-14 09:37:44 +00:00
Stephen Fisher dc7a454b71 From didier:
Fix for bug #1876: Resizing columns changes the currently-selected packet


svn path=/trunk/; revision=23445
2007-11-14 06:39:58 +00:00
Sake Blok de5a407bbb Open the coloring rule edit dialog when the coloring rule is
double-clicked.


svn path=/trunk/; revision=23427
2007-11-11 00:59:19 +00:00
Sake Blok adefd3367c Make the enable/disable buttons on the coloring rule list follow
the selection. There is a little difference between the behaviour
in GTK1 and GTK2 (As long as either one row or a block of rows with 
the same status is selected, GTK1 and GTK2 behave the same way):

GTK1:
- if the last selected row is disabled, grey out the disable button
- if the last selected row is enabled, grey out the enable button

GTK2:
- grey out both buttons when no rule is selected
- grey out the enable button when *all* selected rules are enabled
- grey out the disable button when *all* selected rules are disabled
- leave both buttons active if there is a mix of disabled and enabled
  rules



svn path=/trunk/; revision=23426
2007-11-10 23:05:35 +00:00
Stig Bjørlykke 6e3a2bdbf1 Ensure we pop any previous loaded filename from the statusbar
when loading a new file with a file already loaded.

svn path=/trunk/; revision=23425
2007-11-10 21:59:20 +00:00
Anders Broman 4093b817c6 Apply yet another set of the optimization patches:
there's two structures with the same name conversation_t, change one to conv_t

svn path=/trunk/; revision=23423
2007-11-10 16:09:10 +00:00
Sake Blok 508e268063 This patch makes it possible to disable individual coloring rules
without having to delete them. The patch has been tested on
Fedora-7 with GTK+ 1.2.10 and GTK+ 2.10.11.

Since I don't know how to use "strikethrough" in clists in GTK1
there is a little difference in how the disabled coloring rules
are displayed. In GTK2 they are striked through and in GTK1
they are shown in lightgrey on a white background.

Any info on how to use strikthrough in clists within GTK1 is more
than welcome :-)


svn path=/trunk/; revision=23421
2007-11-10 15:18:49 +00:00
Stephen Fisher eae32f15eb Back out part of revision 23395 - leave the toolbar arrow, but remove the
preference to turn it on / off per discussion on -dev list.


svn path=/trunk/; revision=23407
2007-11-09 02:08:00 +00:00
Stephen Fisher d7c1ba361f Add an arrow with drop-down menu including any toolbar buttons that do not
fit on the top of the screen.  This only works in GTK 2.4+ and there is
a layout preference setting to disable it.


svn path=/trunk/; revision=23395
2007-11-07 21:50:48 +00:00
Stephen Fisher bb71da97df Fix distcheck after my prior 2 commits
svn path=/trunk/; revision=23348
2007-11-03 06:23:02 +00:00
Stephen Fisher 367b809aec The rest of the Follow UDP Stream check-in
svn path=/trunk/; revision=23347
2007-11-03 04:46:22 +00:00
Stephen Fisher 700d8194b8 - Future improve/clean up the now generic follow stream code
- Add "Follow UDP Stream" feature


svn path=/trunk/; revision=23346
2007-11-03 04:45:35 +00:00
Tomas Kukosa 9b3c5f9f03 display SRTP isntead of RTP if stream is established like a SRTP
svn path=/trunk/; revision=23337
2007-11-02 07:43:49 +00:00
Mike Duigou 7dcafc5e82 Avoid casting directly from int to pointers. (It doesn't work on 64-bit linux)
svn path=/trunk/; revision=23322
2007-10-31 15:16:33 +00:00
Stephen Fisher 487abcdf5b Remove empty #if / #endif block
svn path=/trunk/; revision=23283
2007-10-27 05:11:50 +00:00
Tomas Kukosa d3a00ff8bf do not update call_state if new call_state == VOIP_NO_STATE
svn path=/trunk/; revision=23271
2007-10-25 12:24:01 +00:00
Tomas Kukosa 136de3920c new codec table for registering codecs by name
new codec plugin type
search registered codecs in rtp player
fix memory leak in rtp player

svn path=/trunk/; revision=23270
2007-10-25 09:38:15 +00:00
Martin Mathieson 977dbfc490 Add missing case.
svn path=/trunk/; revision=23264
2007-10-24 09:21:13 +00:00
Tomas Kukosa 97dde57b7e fix voip_calls.c:126: warning: missing initializer
svn path=/trunk/; revision=23263
2007-10-24 09:10:43 +00:00
Tomas Kukosa 28cb460c25 add common VoIP TAP listener "voip" which can be used in arbitrary experimental/proprietary protocol (implemented e.g. in plugin) and allows it to make graphs and replay streams
svn path=/trunk/; revision=23262
2007-10-24 08:30:46 +00:00
Bill Meier 09e7be9068 From Jim Young: Simple one line patch resolves compiler warning.: Bug #1929
svn path=/trunk/; revision=23240
2007-10-22 15:13:41 +00:00
Guy Harris 0ea7d1372f Silently ignore bogus geometry subkeys, just as we silently ignore other
bogus entries in the recent file.  This fixes bug 1925.

svn path=/trunk/; revision=23233
2007-10-20 02:34:41 +00:00
Tomas Kukosa 44800d2c5a H.460 new dissector implemented (H.460.2-H.460.22)
H.225
 - change RysMessage_vals to h225_Rasmessage_vals
 - use #.PDU directive for H323-UserInformation and RasMessage instead of implementing it by hands
 - register RasMessage_PDU as "h225.ras" dissector for calling it from H.460
asn2wrs make PDUs exportable

svn path=/trunk/; revision=23226
2007-10-18 13:35:57 +00:00
Sake Blok 6bec9d3d9e From tmiller@hcjbtech.org : Spelling error on GDS DB protocol dissector: "Buffer lenght:"
(recursively grepped through the source and corrected all occurences, even 
the ones just in comments)



svn path=/trunk/; revision=23211
2007-10-16 23:42:33 +00:00
Anders Broman 01fd1df04e Change mgcp include.
svn path=/trunk/; revision=23199
2007-10-16 05:45:03 +00:00
Anders Broman fcbc9389d6 Change mgcp include.
svn path=/trunk/; revision=23197
2007-10-15 22:20:53 +00:00
Alejandro Vaquero 4bf238547f VoIP Calls changes: Add the file name to the title window in VoIP calls, Voip graph and RTP player windows. Make the calls selection using standard multiple selection using the GTK buildin functions. Add a 'Select All' buttom to the VoIP calls window.
svn path=/trunk/; revision=23089
2007-10-08 00:31:26 +00:00
Tomas Kukosa e461d0d0e8 export more types from H.225.0 and H.245 which will be necessary for H.460.x, H.323 (Annex M,R), H.501
svn path=/trunk/; revision=23069
2007-10-05 07:44:03 +00:00
Stig Bjørlykke 8745da6ed0 - Added Tick interval 1 min and 10 min.
- Draw an empty graph if no items in given tick interval.
- Initialize interval_delta so we don't get overlaping x-scale labels.
- Some whitespace cleanup.

svn path=/trunk/; revision=22992
2007-09-26 22:50:53 +00:00
Jörg Mayer 6bb9369681 "fix" some warnings about "might be used uninitialized" variables
svn path=/trunk/; revision=22983
2007-09-26 07:09:51 +00:00
Gerald Combs f7c4b26cb4 In newer versions of GTK+ 2.x, if you have the mouse positioned above a
button that goes from insensitive to sensitive, the button won't respond
to mouse clicks.

This caused the Coloring Rules dialog behavior reported in bug 699.  Work 
around it by not making the up/down buttons insensitive while we're moving
a rule.

Fixup whitespace.

svn path=/trunk/; revision=22946
2007-09-25 05:12:44 +00:00
Bill Meier 29c4953c11 Fix bug #1457: Undersized array causing "smashed stack".
svn path=/trunk/; revision=22942
2007-09-24 21:34:58 +00:00
Jörg Mayer 094e2a9a5f Get rid of the remains of NET-SNMP in the build process.
svn path=/trunk/; revision=22934
2007-09-24 06:59:40 +00:00
Jaap Keuter b7d63247ad Get rid of the last warning.
svn path=/trunk/; revision=22930
2007-09-24 06:42:59 +00:00
Jaap Keuter f2c1b7e8f0 From Chad Singer:
I fixed a bug in packet_unistim.c which was causing a 'malformed packet' to
appear when an open stream command is read with no endpoint ip (as is sometimes
done) I added a simple msg_len check to avoid this. 
I also added UFTP to the unistim dissector and adjusted the unistim call-detection 
in voip-info.c to start on an open stream as well as keypresses..

svn path=/trunk/; revision=22929
2007-09-24 06:19:56 +00:00