Commit Graph

128 Commits

Author SHA1 Message Date
Ulf Lamping 644a474c95 sort #includes by directories
svn path=/trunk/; revision=24969
2008-04-13 03:32:24 +00:00
Ulf Lamping d4ccf577a8 where it's not necessary, remove #include "compat_macros.h"
svn path=/trunk/; revision=24922
2008-04-12 01:02:59 +00:00
Ulf Lamping 8e58ec7085 last round to replace SIGNAL_CONNECT with g_signal_connect
svn path=/trunk/; revision=24918
2008-04-11 23:16:06 +00:00
Ulf Lamping c6d13dc2c8 replace WIDGET_SET_SIZE with gtk_widget_set_size_request
svn path=/trunk/; revision=24910
2008-04-11 20:31:05 +00:00
Ulf Lamping ae5f841083 replace all appearances of BUTTON_NEW_FROM_STOCK with GTK2's gtk_button_new_from_stock
svn path=/trunk/; revision=24904
2008-04-11 18:58:19 +00:00
Bill Meier 42acebd42c OBECT_..._DATA --> g_object_..._data
svn path=/trunk/; revision=24893
2008-04-11 16:04:54 +00:00
Anders Broman c973aa3830 Remove:
#ifdef NEED_G_ASCII_STRCASECMP_H
#include "g_ascii_strcasecmp.h"
#endif

svn path=/trunk/; revision=24868
2008-04-09 19:39:58 +00:00
Ulf Lamping 3b7fe5fc6c remove GTK1 code
svn path=/trunk/; revision=24823
2008-04-07 00:42:04 +00:00
Michael Tüxen 4306c7037d Include epan/strutil.h for gtk-1.2 builds.
svn path=/trunk/; revision=24513
2008-03-01 10:23:57 +00:00
Stig Bjørlykke 7deec480ff Next attempt to cleanup some string functions, including:
strncpy -> g_strlcpy, strncat -> g_strlcat

svn path=/trunk/; revision=24504
2008-02-29 13:33:37 +00:00
Sake Blok c8276a5c91 From Balint Reczey (bug 2233):
The attached patch makes the Statistics -> RTP -> Show All Streams feature of
wireshark accessible via tshark.

I found it helpful in dealing with tons of RTP captures.


svn path=/trunk/; revision=24252
2008-02-03 10:31:55 +00:00
Stig Bjørlykke 10a8f59e03 Rewrote some prohibited APIs in gtk/ (sprintf, strcpy, strcat).
If we get some truncated strings we probably overwrote some buffers...

svn path=/trunk/; revision=24239
2008-02-01 01:07:58 +00:00
Tomas Kukosa 487792b348 save RTP in 16-bit linear PCM instead of 8-bit G.711 u-Law
(preparation for more codecs support via codec plugins)

svn path=/trunk/; revision=23961
2007-12-28 13:01:55 +00:00
Ronnie Sahlberg e6ed260aca some more path fixes for g_ascii_strcasecmp.h
svn path=/trunk/; revision=23638
2007-11-28 01:31:23 +00:00
Guy Harris 9c89cdaaa3 strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delenda
est.  Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our
own versions if they're missing from GLib (as is the case with GLib
1.x).

In the code to build the list of named fields for Diameter, don't use
g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping
in the hash function and use g_ascii_strcasecmp() in the compare
function.

We do this because there is no guarantee that toupper(), tolower(), and
functions that use them will, for example, map between "I" and "i" in
all locales; in Turkish locales, for example, there are, in both
upper case and lower case, versions of "i" with and without a dot, and
the upper-case version of "i" is "I"-with-a-dot and the lower-case
version of "I" is "i"-without-a-dot.  This causes strings that should
match not to match.

This finishes fixing bug 2010 - an earlier checkin prevented the crash
(as there are other ways to produce the same crash, e.g. a bogus
dictionary.xml file), but didn't fix the case-insensitive string matching.

svn path=/trunk/; revision=23623
2007-11-27 18:52:51 +00:00
Jaap Keuter 3f8ffe514f Fix for bug 2000. Make sure that both datalink layer and application layer agree that information is missing before refusing to write a payload.
svn path=/trunk/; revision=23618
2007-11-27 06:49:48 +00:00
Anders Broman 8f1d357618 From Stas Maximov:
RTP analysis' jitter values are thrown off by RTP events
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1076
a) Ephemeral string (packet duration) was inserted into long-term hash of
dynamic payloads
b) There was no clock_rate mapping for MIME type "telephone-event".

svn path=/trunk/; revision=22780
2007-09-04 05:22:43 +00:00
Stephen Fisher 2745f06d96 From Lars Ruoff:
find attached several trivial diffs for viewing RTP SSRC values in Hex
rather than Dec at various places in the UI.
Also includes change from BASE_DEC to BASE_HEX_DEC for corresponding RTP
and RTCP dissector header fields.


svn path=/trunk/; revision=22017
2007-05-31 18:41:25 +00:00
Sebastien Tandel 76729e5d0f From David Howells :
Fix compilation failures when building wireshark-0.99.6-SVN-21916 on an
x86_64-unknown-linux-gnu target with gcc version 4.1.2 20070403 (Red Hat
4.1.2-8).

The failures fall into two categories:
  (1) Casts between pointers and 32-bit integers without an intermediary cast
via 'long' or 'unsigned long'.  This results in a compiler warning complaining
about casts between a pointer and an integer of a different size.
  (2) Passing values to "%lld" or similar printf-style format options that the
compiler thinks are a different size.  Such values need to be cast to 'long
long' or 'unsigned long long'.

svn path=/trunk/; revision=21975
2007-05-29 02:43:18 +00:00
Gerald Combs 17271f0879 When saving an RTP stream, don't insert silence if our packet has a
wrong timestamp.  Place a cap on the amount of silence that we do
insert.  This should fix bug 1580.

Update the release notes.

svn path=/trunk/; revision=21818
2007-05-17 18:41:07 +00:00
Ronnie Sahlberg 8d27a59817 some more : try to make read/write not break the build if the return value is not used
svn path=/trunk/; revision=21641
2007-05-02 12:17:01 +00:00
Ronnie Sahlberg 6c3ca6fb55 do something with the return value from eth_write (which is a define for fwrite)so that -Werror does not cause the build to fail
-This line, and those below, will be ignored--

M    gtk/rtp_analysis.c

svn path=/trunk/; revision=21639
2007-05-02 12:07:46 +00:00
Ronnie Sahlberg 2fadd01c25 fix some more warnings that the result from fread/fwrite is discarded by assigning the return value to a variable
svn path=/trunk/; revision=21638
2007-05-02 11:50:54 +00:00
Ronnie Sahlberg a1131be153 move include of a few headers down a few lines so the compile works on
gtk1

svn path=/trunk/; revision=21504
2007-04-22 16:40:34 +00:00
Stephen Fisher 1909b97d4d Remove all warnings under Unix for the gtk/ directory.
svn path=/trunk/; revision=21160
2007-03-24 00:45:11 +00:00
Martin Mathieson 997e5415f9 Add separate union entries to fvalue.value for signed and unsigned
32-bit numbers.  Separate signed and unsigned accessors have been
added and used where appropriate.

Definitely not for 0.99.5.

svn path=/trunk/; revision=20472
2007-01-18 11:02:26 +00:00
Jörg Mayer c3814a25de nikai@nikai.net:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1225

Attempting a simple cleanup of duplicated includes, will attach patch.


svn path=/trunk/; revision=19894
2006-11-14 20:08:44 +00:00
Ulf Lamping a1b7a22a8e from Stephen Fisher:
Here is a patch for spelling typos in comments and strings in the gtk/ 
directories.

svn path=/trunk/; revision=19568
2006-10-17 01:29:55 +00:00
Jörg Mayer 5c8bb9bca8 Alex Shnitman <AlexS@mangodsp.com>
Below is a patch for a bug in rtp_analysis.c. The variable
	statinfo->delta_timestamp was not initialized in all the
	necessary cases. The function rtp_packet_save_payload uses this
	variable and the for loop on line 935 could use an old value
	and run an incorrect amount of times, e.g. a couple billion,
	which gets ethereal stuck. I can supply an example capture
	which causes it. The patch solves the problem.

svn path=/trunk/; revision=18798
2006-07-27 14:19:10 +00:00
Guy Harris 92552c2d76 Get rid of a bunch of "Ethereal"s and "ethereal"s in comments, GUI
strings, and function names.

svn path=/trunk/; revision=18205
2006-05-22 07:29:40 +00:00
Ronnie Sahlberg 89f022b12b name change
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00
Guy Harris 84aef00bad Move the file selection dialog routines to file_dlg.c, and give it a
header file.

#if 0 out some includes; if none of the builds have a problem with
that, I'll remove them.

svn path=/trunk/; revision=18036
2006-04-30 01:47:58 +00:00
Ronnie Sahlberg 41f5478753 coverity #62
potential null dereference


svn path=/trunk/; revision=17549
2006-03-09 12:16:53 +00:00
Jaap Keuter d986b91df6 Solving various uninitialized variable warnings.
coverity reports 132, 133 and 134

svn path=/trunk/; revision=17501
2006-03-07 16:39:54 +00:00
Ulf Lamping d350736e0b add missing #include "tempfile.h"
svn path=/trunk/; revision=17294
2006-02-13 23:52:11 +00:00
Luis Ontanon fcf7b3789c add an userdata argument to register_stat_cmd_arg() and its callback to use the callback for multiple registrations.
svn path=/trunk/; revision=17252
2006-02-11 13:05:24 +00:00
Guy Harris 0dbf17b690 Allow a progress dialog to have "Stop" or "Cancel" as the "terminate
button"; "Stop" should be used for operations that can only be stopped
(meaning that what it's already done isn't undone), not cancelled
(meaning that whatever it's already done *is* undone), for which
"Cancel" is used.

Allow the merging process to be cancelled.

Clean up indentation.

Update some comments.

svn path=/trunk/; revision=16489
2005-11-12 11:05:02 +00:00
Ulf Lamping c3187174bf replace *a lot* of file related calls by their GLib counterparts. This is necessary for the switch to GTK 2.6 (at least on WIN32).
to do this, I've added file_util.h to wiretap (would file_compat.h be a better name?), and provide compat_macros like eth_open() instead of open(). While at it, move other file related things there, like #include <io.h>, definition of O_BINARY and alike, so it's all in one place.

deleted related things from config.h.win32

As of these massive changes, I'm almost certain that this will break the Unix build. I'll keep an eye on the buildbot so hopefully everything is working again soon.

svn path=/trunk/; revision=16403
2005-11-06 22:43:25 +00:00
Anders Broman 2916d12d76 Packet-amr Register as "AMR" not "amr".
Add Dynamic PT:s mimestring  to rtp_info if avalable.
Use Dynamic PT:s mime string to find clock rate.

svn path=/trunk/; revision=16397
2005-11-05 21:38:22 +00:00
Anders Broman bd8e72aa0a From Jaap Keuter
Improvments to PCMA and PCMU handling-

svn path=/trunk/; revision=16356
2005-10-29 15:34:16 +00:00
Guy Harris b7b80d94be Move a pile of protocol-related headers from the top-level source
directory to the epan directory.  Some of them should perhaps ultimately
be moved to epan/dissectors, if they pertain only to stuff exported by a
particular dissector.

Fix Gerald's e-mail address in files we're moving.

svn path=/trunk/; revision=15844
2005-09-17 00:02:31 +00:00
Guy Harris f34e1a97c6 Have cf_retap_packets() take an argument that indicates whether to
generate columns; use cf_retap_packets instead of cf_redissect_packets()
when running taps (the general flow graph stat uses the Info column).

svn path=/trunk/; revision=15793
2005-09-14 08:59:41 +00:00
Anders Broman 42637ec84b From Tomer Shani:
Patch which will enable saving payload in raw (binary) format in addition to the existing au format.

We have found it very useful to be able to extract the RTP data for use with other tools (especially when dealing with proprietary/uncommon coders).

Changes:

rtp_packet_save_payload: no longer transforms packet to linear coding, payload is saved in raw format 
copy_file: will perform the needed transcoding and save to needed format (au or raw)

svn path=/trunk/; revision=15648
2005-09-01 05:41:59 +00:00
Ulf Lamping 6f43fbb2f0 EVERYTHING IN THE BUILDBOT IS GOING TO BE RED!!! Sorry!
I've done more than a day to change the timestamp resolution from microseconds to nanoseconds. As I really don't want to loose those changes, I'm going to check in the changes I've done so far. Hopefully someone else will give me a helping hand with the things left ...

What's done: I've changed the timestamp resolution from usec to nsec in almost any place in the sources. I've changed parts of the implementation in nstime.s/.h and a lot of places elsewhere.

As I don't understand the editcap source (well, I'm maybe just too tired right now), hopefully someone else might be able to fix this soon.

Doing all those changes, we get native nanosecond timestamp resolution in Ethereal. After fixing all the remaining issues, I'll take a look how to display this in a convenient way...

As I've also changed the wiretap timestamp resolution from usec to nsec we might want to change the wiretap version number...

svn path=/trunk/; revision=15520
2005-08-24 21:31:56 +00:00
Guy Harris 13e0b409cf As per a suggestion by Ulf Lamping, rename gtk_*.[ch] to gui_*.[ch], so
that it doesn't appear to be part of GTK+.

svn path=/trunk/; revision=15501
2005-08-21 19:24:11 +00:00
Guy Harris a0e68da918 Add a "register_dfilter_stat()", to register stats that take a display
filter as an argument on the command line and have a dialog box to enter
the display filter through the GUI.  Use it for all stats using
"gtk_tap_dfilter_dlg_cb()".

Add a top-level "stat_menu.h" file to declare "REGISTER_STAT_GROUP_E"
for the benefit of the declaration of "register_dfilter_stat()" in the
top-level "tap_dfilter_dlg.h".  Rename the "stat_menu.h" in the gtk
directory to "gtk_stat_menu.h", so as not to have two headers with the
same name.

Get rid of headers not declaring any functions not being used in the
module.

svn path=/trunk/; revision=15493
2005-08-21 09:48:27 +00:00
Guy Harris 50d77b113c Rename epan/stat.[ch] to epan/stat_cmd_args.[ch] - it only deals with
implementing the "-z" command-line arguments, it doesn't deal with *all*
issues for stats.

svn path=/trunk/; revision=15483
2005-08-20 20:06:05 +00:00
Jörg Mayer 0edcc8920e - Declare some functions static
- Add plugins_dlg.h
- Include .h files in their respective .c files
- Include .h and remove extern declarations in .c files
- set eol-style and keywords on gui_utils.[hc]

svn path=/trunk/; revision=15471
2005-08-20 14:02:00 +00:00
Ulf Lamping eafbbbcabb renamed ui_util.c/.h to gui_utils.c/.h to prevent confusion with identical named ui_util.h in / dir
svn path=/trunk/; revision=15465
2005-08-20 12:09:48 +00:00
Guy Harris 4ddd504bb4 Move the stats.[ch] stuff into epan, so plugins can use it.
svn path=/trunk/; revision=15429
2005-08-19 10:00:14 +00:00