* If stopped there is no time to show
* Default shall be multiple of 1 min
Change-Id: Id9c489688abc30f28a6fb4efbde263409ae92873
Reviewed-on: https://code.wireshark.org/review/26022
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
in accordance with 3GPP 29.244 v15.0.0
Change-Id: I27d65d591976edfef13a713cf3a0768915e29256
Reviewed-on: https://code.wireshark.org/review/25803
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
* TEIDIR should use the UINT8 type (its only 3 bit really)
* Network Instance length needs to take the already decoded
bytes into account
3GPP TS 29.244 Section 8.2.82
Change-Id: I6772ca726f5e5d65c68a6d3dae8eff43e72196e0
Reviewed-on: https://code.wireshark.org/review/24940
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
The Enterprise ID is included in the length. Don't skip it twice.
3GPP TS 29.244 Section 8.1.1.
Change-Id: If601309c0008775268e399bbedf7ab956ae0ec6b
Reviewed-on: https://code.wireshark.org/review/24939
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
PDN Connection Set Identifier is two bytes.
3GPP TS 29.244 Section 8.2.43
Change-Id: I6ac1dab341e4ae54cbbdcbcbe8583a6a49293269
Reviewed-on: https://code.wireshark.org/review/24938
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Node ID is encoded as DNS label according to RFC 1035. That RFC
states that a label can have maximum length of 63 characters.
3GPP TS 29.244 Section 8.2.38 and RFC 1035 Section 2.3.4.
Change-Id: I54ba4a204e2bf010b5b61b4be7f6ca483d7210b9
Reviewed-on: https://code.wireshark.org/review/24937
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Adjusted bitmask in both IEs to correct order of bytes
3GPP TS 29.244 Sections 8.2.19 and 8.2.41
Change-Id: Ia9409c0d33b8821d459faf1d502f833883416b40
Reviewed-on: https://code.wireshark.org/review/24929
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Matej Tkac <matej.tkac.mt@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
HF is related only to single -5th- octet
3GPP TS 29.244 Section 8.2.58
Change-Id: Id0d4dd644cc4f94dec2a7ab73cea7b02bff1fc9f
Reviewed-on: https://code.wireshark.org/review/24926
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
In accordance with 3GPP TS 29.244 Section 8.2.62
Change-Id: Id3663817f64cab60713e02ca9e9a26349fe1a29a
Reviewed-on: https://code.wireshark.org/review/24925
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Port number should only be included with UDP/IP header
Change-Id: Ie2655d2b6f1b755bff47e74723f36b1ee87170f9
Reviewed-on: https://code.wireshark.org/review/24361
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
For readability, DEC<->HEX and "IE length"
Change-Id: I753d8f6cba43a6b34fd06b49b1ffa96f13790c67
Reviewed-on: https://code.wireshark.org/review/24360
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Added PDN Type dissection (3GPP 29.244 Section 8.2.79)
Fixed bit order in dissect_ue_ip_address
Added "Encoding error" message if MBR or GBR has different format than specified in doc.
Change-Id: I3b8b096fa490a2b4a16b3e6e9a640f92e389be1f
Reviewed-on: https://code.wireshark.org/review/24334
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Fixed FQDN Field in Dissect Node ID according to 3GPP 29.244 Section 8.2.38
Added "Encoding error" message if the value in field is in dotted form contrary to the doc.
Minor fix: Decreased F-TEID Flags spare bits (fix of dc269fcd6f)
Change-Id: I7e9ba53a7deed7af1305f5c445bf4b2a9212e115
Reviewed-on: https://code.wireshark.org/review/24321
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Added Bit 4 - CHID as described in 3GPP 29.244 Section 8.2.3.
Added "Encoding error" msg if documentation conditions aren't met.
Change-Id: Ia5e6d8bb2bf635fa695a2bfcba3877c2ecf52d87
Reviewed-on: https://code.wireshark.org/review/24318
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
In accordance with 3GPP 29.244 8.2.26 Apply Action.
Change-Id: Icef9bc9807efc255ece8fbde5e4c244d5f1fc525
Reviewed-on: https://code.wireshark.org/review/24301
Reviewed-by: Michael Mann <mmann78@netscape.net>
Octet 5 (Spare Node/ID Type) is included in the IE length
and FQDN uses just remainding length
Change-Id: I9c6e1de850bda0af315cbf801e757af6b25ed33e
Reviewed-on: https://code.wireshark.org/review/24101
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
** (process:8955): WARNING **: Field 'Uplink Time Unit' (pfcp.ul_time_unit) has a conflicting entry in its value_string: 3 is at indices 3 (Day) and 4 (Week))
** (process:8955): WARNING **: Field 'Downlink Time Unit' (pfcp.dl_time_unit) has a conflicting entry in its value_string: 3 is at indices 3 (Day) and 4 (Week))
Change-Id: I870af4a53721e0ffe0f9f778c8287e090f2b2929
Reviewed-on: https://code.wireshark.org/review/23985
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Joakim Karlsson