Commit graph

129 commits

Author SHA1 Message Date
Anders Broman
a9bbcb4a05 Remove extra space at end of IMSI.
svn path=/trunk/; revision=37519
2011-06-02 11:06:26 +00:00
Chris Maynard
3848ace06e Use [hi|lo]_nibble macros, leave room in str[] for invalid BCD digits to be
displayed as blanks.  Since imsi_to_str() and ip_to_str() do the same thing,
just have imsi_to_str() call ip_to_str() rather than having two different
implementations of the same thing.  Use a BCD2CHAR macro instead of doing a
table lookup.

svn path=/trunk/; revision=36740
2011-04-20 20:12:40 +00:00
Chris Maynard
80889668bc From Vladimir Kazansky via bug 5849: Fix msisdn_to_str() so it converts all BCD
digits and not just 1.

svn path=/trunk/; revision=36727
2011-04-20 02:24:16 +00:00
Alexis La Goutte
eff30da7a4 Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=36703
2011-04-18 17:48:23 +00:00
Bill Meier
fc600d4bf9 Fix a few cases of proto_item_add_subtree() using the wrong tree: Coverity 916-918;
Also: Fix some indentation: e.g., "4 space tabs".

svn path=/trunk/; revision=36585
2011-04-12 15:39:19 +00:00
Anders Broman
8d6ca293dc Change the signature of elem_fcn():ns to include pinfo.
svn path=/trunk/; revision=36443
2011-04-04 14:37:25 +00:00
Anders Broman
5b60867fc6 ../../../epan/dissectors/packet-gtp.c:5607: error: unused variable ‘length’
svn path=/trunk/; revision=36182
2011-03-13 09:33:45 +00:00
Anders Broman
285513860c Add sub dissection of AVP MBMS Service Area.
svn path=/trunk/; revision=36181
2011-03-12 23:26:55 +00:00
Anders Broman
b4941ca580 Prepare to remove old bssgp code by changing exports.
svn path=/trunk/; revision=36142
2011-03-06 09:42:41 +00:00
Jeff Morriss
ab2b947088 Make the _to_str() functions in here take a pointer to a TVB and an offset
rather than (generally) a pointer into the TVB.

Replace some tabs with spaces (for consistency).

Remove a couple unnecessary includes.

svn path=/trunk/; revision=36123
2011-03-03 02:18:57 +00:00
Anders Broman
e761ed7206 Add private extensions under the right tree.
svn path=/trunk/; revision=36089
2011-02-28 11:34:59 +00:00
Anders Broman
2ea4267951 - Add a dissector table for Private Extensions.
- Use ENC_BIG_ENDIAN.

svn path=/trunk/; revision=36075
2011-02-26 09:37:43 +00:00
Anders Broman
ed66081a4d From Alexis La Goutte:
Cleanup packet-ipv6.h and dependency.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5713

svn path=/trunk/; revision=36031
2011-02-23 13:51:49 +00:00
Jeff Morriss
1d396a69e0 Register ett_gtp_bcm.
Replace some tabs with spaces.


svn path=/trunk/; revision=35890
2011-02-09 18:45:32 +00:00
Anders Broman
94d8b44aec Use gprscdr to dissect CDRs.
svn path=/trunk/; revision=35763
2011-02-02 17:51:00 +00:00
Bill Meier
410284fe15 A bit more indentation cleanup
svn path=/trunk/; revision=35749
2011-02-02 02:44:14 +00:00
Guy Harris
fa5efc04e3 Get rid of unused variable warnings.
Clean up indentation.

svn path=/trunk/; revision=35746
2011-02-02 00:04:18 +00:00
Anders Broman
3fa9788f21 Dissect a bit more of data records.
svn path=/trunk/; revision=35744
2011-02-01 22:47:12 +00:00
Bill Meier
ce2a2e50e6 Use {'0', ...} type initializer for fixed length character arrays.
svn path=/trunk/; revision=35741
2011-02-01 14:30:24 +00:00
Jeff Morriss
d8468eb53a Replace some blurbs with NULL
svn path=/trunk/; revision=35728
2011-01-31 21:09:28 +00:00
Anders Broman
0855affbec Add dissection of Evolved Allocation/Retention Priority I IE.
svn path=/trunk/; revision=35723
2011-01-31 16:25:26 +00:00
Anders Broman
830f6f9891 From Grzegorz Szczytowski:
Add Bearer Control Mode selection support in gtpv1 dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5634
Sligtly reworked by me:
- prefix names with gtp
- Use proto_tree_add_item()
- remove ref to specific protocol version, as it's probably a mix.
- Changed the update to the AUTHORS file.

svn path=/trunk/; revision=35699
2011-01-30 11:32:42 +00:00
Stephen Fisher
fc7b0c019b Fix the dead initialization warnings found by clang's static analysis
("Value stored to 'xxx' during its initialization is never read")


svn path=/trunk/; revision=35598
2011-01-20 18:56:11 +00:00
Anders Broman
9c04eb9b2c Fix typos
svn path=/trunk/; revision=35597
2011-01-20 14:03:13 +00:00
Anders Broman
fbde1c7130 Update a comment.
svn path=/trunk/; revision=35596
2011-01-20 13:19:26 +00:00
Anders Broman
3112035ad2 In MM context the container contains IE:s not a complete
DTAP message.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5598

svn path=/trunk/; revision=35595
2011-01-20 13:05:17 +00:00
Anders Broman
2c7b85a624 Add dissection of Radio Priority LCS.
svn path=/trunk/; revision=35276
2010-12-27 20:23:26 +00:00
Guy Harris
a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Bill Meier
62e44e3f66 Minor cleanup:
- Initialize a few static global variables;
- Remove two unnecessary calls to g_hash_table_foreach_remove;
- Do whitespace cleanup and use consistent indentation;
- Fix a few typos and fix up several comments.

svn path=/trunk/; revision=35183
2010-12-14 01:50:31 +00:00
Anders Broman
7870de6f95 Fill value_strings.
svn path=/trunk/; revision=34875
2010-11-15 16:46:07 +00:00
Bill Meier
c256942255 Use value_string_ext fcns to access various value_string arrays.
Also: use value_string_const() instead of value_string() where apropriate;
      minor reformatting & whitespace cleanup.

svn path=/trunk/; revision=34745
2010-11-01 18:26:34 +00:00
Jeff Morriss
cca3ba3ce2 (Refining the regexp...) Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34230
2010-09-24 02:51:40 +00:00
Jeff Morriss
0ff5638f37 Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34227
2010-09-23 21:46:31 +00:00
Bill Meier
7219ee2a49 Use val_to_str_ext() & friends to access sminmpec_values[];
Also: packet-nhrp.c: #include sminmpec.h not req'd;

svn path=/trunk/; revision=34143
2010-09-17 04:51:21 +00:00
Stig Bjørlykke
85b4d16277 Update the header length after dissecting the header.
This fixes bug 5162.

svn path=/trunk/; revision=34031
2010-08-31 10:24:08 +00:00
Anders Broman
9092ed1aa2 Try to fix the GTP' header dissection a bit.
svn path=/trunk/; revision=33689
2010-08-01 20:55:29 +00:00
Anders Broman
d4182159b6 Split dissection of GTP and GTP' in ordet to try to fix bug
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5055

svn path=/trunk/; revision=33648
2010-07-28 16:13:56 +00:00
Gerald Combs
83c5be18c7 Add End Marker back in.
svn path=/trunk/; revision=33380
2010-06-29 23:50:51 +00:00
Gerald Combs
bce5424063 Completely revert r33367 so that we don't duplicate content in
packet-gtp.h.

svn path=/trunk/; revision=33379
2010-06-29 23:48:24 +00:00
Anders Broman
3123ecf3e4 Add "End Marker" get rid of the .h file as no one imports anything.
(Leave the .h file for a while).

svn path=/trunk/; revision=33367
2010-06-29 08:06:13 +00:00
Jeff Morriss
729de1a635 As suggested in http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html
(as referenced in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2907 ) and
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3411 :

Write a new convenience routine for finding a conversation and, if it is not
found, create it.  The frame number and addresses are taken from pinfo (as is
the common case).

Use this function in a bunch of dissectors.

svn path=/trunk/; revision=32790
2010-05-13 18:28:34 +00:00
Bill Meier
10ffd14b8f Indentation & whitespace cleanup (including: "4 space tabs" ==> spaces)
svn path=/trunk/; revision=32735
2010-05-10 15:54:57 +00:00
Anders Broman
a0f2f56ec8 Dissect 3GPP AVP 5 3GPP-GPRS Negotiated QoS profile.
svn path=/trunk/; revision=32622
2010-05-01 14:58:03 +00:00
Anders Broman
99054f9413 From Tamas Regos:
Another bug in packet-gtp.c (mask of Signalling Indication)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4694

svn path=/trunk/; revision=32510
2010-04-19 06:02:56 +00:00
Anders Broman
64a8ae8676 From Tamas Regos:
Harmless typo and whitespace bugs in packet-gtp.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4677
(didn't apply cleanly so partly applied by hand).

svn path=/trunk/; revision=32474
2010-04-15 17:58:54 +00:00
Bill Meier
69df32fb11 #include <string.h> not needed.
svn path=/trunk/; revision=32411
2010-04-06 22:09:47 +00:00
Bill Meier
09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Guy Harris
b395a98305 Squelch a bunch of compiler warnings.
svn path=/trunk/; revision=31961
2010-02-23 04:35:23 +00:00
Anders Broman
0c5dfd7698 Target Identification shall be coded as TLV IE where value is
coded as TargetRNC-ID.
Proposed fix to
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3974
(The enclosed trace dioes not decode properly but may be wrongly encoded).

svn path=/trunk/; revision=29816
2009-09-09 07:29:41 +00:00
Kovarththanan Rajaratnam
8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining()
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00