Commit graph

18433 commits

Author SHA1 Message Date
Chris Maynard
365139b5cf Do not use BASE_NONE for FT_UINT8 types.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7333 (I think).

svn path=/trunk/; revision=43176
2012-06-09 17:08:46 +00:00
Chris Maynard
8fe8287a39 Add sip.to.tag and sip.from.tag filters.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5226

svn path=/trunk/; revision=43175
2012-06-09 15:54:15 +00:00
Chris Maynard
bf35ccfbce Allow syslog to work with "Decode As" for TCP.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5241

svn path=/trunk/; revision=43174
2012-06-09 15:43:08 +00:00
Chris Maynard
e40c7ab1dc Be sure to specify FORMAT_MESSAGE_IGNORE_INSERTS in the dwFlags arg to all FormatMessage() calls where FORMAT_MESSAGE_FROM_SYSTEM is also specified. (Ref: http://blogs.msdn.com/b/oldnewthing/archive/2007/11/28/6564257.aspx)
svn path=/trunk/; revision=43172
2012-06-09 03:41:23 +00:00
Gerald Combs
1a7470c6be Forward-port r43165 and r43168 from trunk-1.6.
------------------------------------------------------------------------
  r43165 | gerald | 2012-06-08 14:23:25 -0700 (Fri, 08 Jun 2012) | 4 lines
  Changed paths:
     M /trunk-1.6/epan/Makefile.am
     M /trunk-1.6/wiretap/Makefile.am
     M /trunk-1.6/wsutil/Makefile.am
  
  Use separate commands in the dumpabi recipes instead a big huge long
  chain. If abi-compliance-checker fails print the contents of its
  log file.
  ------------------------------------------------------------------------
  r43168 | gerald | 2012-06-08 15:43:50 -0700 (Fri, 08 Jun 2012) | 2 lines
  Changed paths:
     M /trunk-1.6/epan/Makefile.am
     M /trunk-1.6/wiretap/Makefile.am
     M /trunk-1.6/wsutil/Makefile.am
  
  Make sure ln happens in the right directory.
  ------------------------------------------------------------------------

We don't currently have a usable tag for "git describe --tags
--abbrev=0" to latch onto so just use the first 1.9 commit.

svn path=/trunk/; revision=43170
2012-06-08 23:54:22 +00:00
Jeff Morriss
be965bff75 Don't register 3 (IPAddress) hf's with the same abbreviation but with 3
different types; instead use different abbreviations (filters).

This is in order to prevent running into

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2402

and seg-faulting when someone applies a filter of, for example,
diameter.Framed-IP-Address .

svn path=/trunk/; revision=43166
2012-06-08 22:23:11 +00:00
Bill Meier
836ed4ccfc Fix bug I introduced in SVN #43129.
Fixes fuzz crash reported in Bug #7346.


svn path=/trunk/; revision=43164
2012-06-08 21:17:42 +00:00
Jeff Morriss
b4f3ea200c Thinking about it more, how we're storing the application ID isn't a problem.
svn path=/trunk/; revision=43163
2012-06-08 20:08:43 +00:00
Jeff Morriss
c75657ad14 Don't call val_to_str() only to then compare the result with "Uknown": use
match_strval() instead.

Also, don't retrieve the application ID 3 more times; we've already got it
in a variable...

Point out a bug regarding how we're storing the application ID for use by
subdissectors (from r34570).

svn path=/trunk/; revision=43162
2012-06-08 19:59:33 +00:00
Gerald Combs
39dbd45c9f Fix some dead assignments.
svn path=/trunk/; revision=43157
2012-06-08 17:20:44 +00:00
Anders Broman
ae43364681 Only dissect as SDp if it's IPBCP (text encoded).
svn path=/trunk/; revision=43152
2012-06-08 11:50:52 +00:00
Anders Broman
98b74816ae From Stefan Hoffmeister:
ActiveSync WBXML CodeSpace updated to match official documentation.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7345

svn path=/trunk/; revision=43151
2012-06-08 06:26:55 +00:00
Bill Meier
d01cb597c9 Don't crash in 'proto_registrar_dump_values' if BASE_EXT_STRING and no extended string.
Note: this shows up when doing 'tshark -G values'.

BASE_EXT_STRING with a missing extended string does *not* cause issues
with the normal display code:

ToDo (eventually): Add some code to enforce requirement that hf[] entries with BASE_EXT_STRING
(or BASE_RANGE_STRING) set must also have a 'strings' value.



svn path=/trunk/; revision=43150
2012-06-07 21:10:02 +00:00
Bill Meier
fabd558ffe Fix invalid hf[] entry 'display' field value.
result: incorect display of value (and, incidentally,
        a crash in 'tshark -G values'

svn path=/trunk/; revision=43147
2012-06-07 17:39:11 +00:00
Anders Broman
059d407e19 From Niels de Vos: GlusterFS: Display SETATTR attribute valid as a list of flags https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7341
svn path=/trunk/; revision=43144
2012-06-06 20:44:21 +00:00
Anders Broman
7881fe8493 From Stephen Donnelly: Correct ERF name, add WTAP_ENCAP string display https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7313
svn path=/trunk/; revision=43141
2012-06-06 20:35:37 +00:00
Pascal Quantin
2f035a3c0f From Frank Lahm via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7334 :
FPSpotlightRPC dates structure can contain multiple dates

svn path=/trunk/; revision=43133
2012-06-06 16:55:48 +00:00
Bill Meier
027b57b472 Fix compiler error (I hope)
svn path=/trunk/; revision=43131
2012-06-06 05:58:42 +00:00
Bill Meier
e18d46784f Fix compiler error
svn path=/trunk/; revision=43130
2012-06-06 05:36:43 +00:00
Bill Meier
57c6467b81 Fix some bugs & do extensive cleanup;
Bugs fixed:
 - Calling col_...() fcns or dissectors under 'if (tree)'
 - Potential buffer overflows (if bad data)
 - Misc incorrect data display issues
Cleanup including;
 - Remove unneeded #includes
 - Fix excessive use of value_strings
 - Use extended value_strings & val_to_str_(ext_)const as appropriate
 - Optimize repeated fetches of the same data from a tvb
 - Do general code simplification
 - Remove or #if 0 unused code;
 - Add XXX comments for code which may be incorrect
 - Remove unneeded prefs callback to proto_reg_handoff...()
 - Remove unneeded use of check_col()
 - Define several functions as static
 - Move proto_reg_handoff...() to the end of the file
 - Fix whitespace (including "4 space tabs")
 - ...

svn path=/trunk/; revision=43129
2012-06-06 04:54:47 +00:00
Jörg Mayer
f554994823 Just fix some clang analysis warnings
svn path=/trunk/; revision=43126
2012-06-05 23:03:13 +00:00
Jakub Zawadzki
cf25f08af0 yami: dissect header messages, add parameter names to parent tree item.
svn path=/trunk/; revision=43117
2012-06-05 15:52:08 +00:00
Jeff Morriss
e9a30385c7 Fix Coverity 702396: tvbr is ep_ allocated so it can't be NULL.
svn path=/trunk/; revision=43116
2012-06-05 15:29:25 +00:00
Jeff Morriss
fe5f076b5c Fix Coverity 702397: reference tvbr *after* checking that it is not NULL.
svn path=/trunk/; revision=43115
2012-06-05 15:26:09 +00:00
Jeff Morriss
49c359bf2d Fix Coverity 703495: reference fpinf *after* checking that it is not NULL.
Also replace some 4 space tabs with spaces.

svn path=/trunk/; revision=43113
2012-06-05 15:05:17 +00:00
Jakub Zawadzki
97d51ce67f packet-yami: cleanup, remove non-ASCII character.
svn path=/trunk/; revision=43112
2012-06-05 15:02:49 +00:00
Jakub Zawadzki
7d075658b1 packet-wreth: cleanup
- make function and arrays static
- comment out unused hf-entry.
- comment out unused variable.

svn path=/trunk/; revision=43111
2012-06-05 14:50:37 +00:00
Jakub Zawadzki
6dc698ca27 Dissector for YAMI protocol.
svn path=/trunk/; revision=43110
2012-06-05 14:17:50 +00:00
Anders Broman
28098ed4ab From Roland Knall:
openSAFETY - Names for certain SOD objects, automatic SCM UDID detecion.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7335

svn path=/trunk/; revision=43109
2012-06-05 13:12:28 +00:00
Anders Broman
aa4e655696 Set SVN properties.
svn path=/trunk/; revision=43108
2012-06-05 11:19:33 +00:00
Anders Broman
189ea54f0b from Alex Lindberg:
Update to packet-h248.c and associated h248 dissecorts.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7332

svn path=/trunk/; revision=43107
2012-06-05 10:54:21 +00:00
Anders Broman
5bd0c263f2 From Andrew Kampjes:
SDH support for wireshark.

- Added GPL license.
- Removed not needed includes.
- Skipped th .h file as it wasn't used.

svn path=/trunk/; revision=43106
2012-06-05 10:42:38 +00:00
Anders Broman
1d27ce5d99 From Adam Langley: Add support for decrypting ECDHE-RSA-RC4-SHA. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7331
svn path=/trunk/; revision=43100
2012-06-05 05:27:06 +00:00
Anders Broman
75319f09a9 From Adam Langley: Add support for CLIENT_RANDOM lines in SSL keylog. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7330
svn path=/trunk/; revision=43099
2012-06-05 05:22:41 +00:00
Anders Broman
cec562ddd2 From Alex Lindberg: Add preference to packet-ber.c to toggle BER warning on leading zero bits. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7328
svn path=/trunk/; revision=43098
2012-06-05 05:16:06 +00:00
Anders Broman
6c85e092cf From Adam Langley: Clean up code for handling keylog files. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7329
svn path=/trunk/; revision=43097
2012-06-05 05:10:18 +00:00
Gerald Combs
7186d034f0 Fix compilation.
svn path=/trunk/; revision=43094
2012-06-04 23:47:11 +00:00
Alexis La Goutte
167b8c6cba From Clement Marrast via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7260
New dissector for WSE Remote Ethernet protocol

 From me :
 * Fix Compilation under linux
 * Use proto_tree_add_item*
 * Make build-in dissector
 * Include Status.* and Codef.* in dissector
 * Reorder function (to respect Wireshark Codelines)
 * Add Modelines Info and fix indent (use 4 spaces)
 * Fix check* tools
 * Add Clement to AUTHORS

With the dissector....

svn path=/trunk/; revision=43092
2012-06-04 22:34:27 +00:00
Alexis La Goutte
42451447b1 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=43091
2012-06-04 22:26:40 +00:00
Alexis La Goutte
e2cec4bb63 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
(Manual Fix, not found how to fix the generator...)

svn path=/trunk/; revision=43090
2012-06-04 22:26:18 +00:00
Alexis La Goutte
c7e8a39966 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=43089
2012-06-04 22:25:27 +00:00
Alexis La Goutte
cb2000b9f3 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=43087
2012-06-04 22:24:46 +00:00
Alexis La Goutte
7ec2d11b9b From Clement Marrast via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7260
New dissector for WSE Remote Ethernet protocol

From me :
* Fix Compilation under linux
* Use proto_tree_add_item*
* Make build-in dissector
* Include Status.* and Codef.* in dissector
* Reorder function (to respect Wireshark Codelines)
* Add Modelines Info and fix indent (use 4 spaces)
* Fix check* tools
* Add Clement to AUTHORS

svn path=/trunk/; revision=43086
2012-06-04 22:22:32 +00:00
Gerald Combs
a0c9661fa5 There doesn't appear to be a way to convey the message "This library is
under development. Maybe you should use a stable version." via the
version number. Use the next best thing and set each number to zero.

svn path=/trunk/; revision=43073
2012-06-04 18:33:21 +00:00
Jakub Zawadzki
6fff7c61f0 display filter: restore comparision of fields.
like:
  udp.srcport == udp.dstport
  frame.cap_len != frame.len
(probably you can use it for better ones)

part of bug #7263


svn path=/trunk/; revision=43069
2012-06-04 14:45:50 +00:00
Jakub Zawadzki
11e584f4cf packet-gadu-gadu: set COL_INFO in undissected/unknown packet types.
svn path=/trunk/; revision=43068
2012-06-04 14:37:24 +00:00
Anders Broman
a90e1a353a Try to make the buildbot happy.
svn path=/trunk/; revision=43067
2012-06-04 14:31:53 +00:00
Anders Broman
b69547925f Get rid of a couple of warnings.
svn path=/trunk/; revision=43066
2012-06-04 13:52:46 +00:00
Anders Broman
2a30b1eff9 Get rid of a couple of warnings.
svn path=/trunk/; revision=43065
2012-06-04 13:21:44 +00:00
Anders Broman
a0910557c7 Get rid of a couple of warnings.
svn path=/trunk/; revision=43064
2012-06-04 12:20:37 +00:00