019e64f58d
Upgrade RRC dissector to v11.7.0
...
svn path=/trunk/; revision=52202
2013-09-24 17:56:17 +00:00
d74564d6cf
Ensure to release an existing DRX configuration when receiving a RRC Connection Setup message
...
svn path=/trunk/; revision=52193
2013-09-23 21:21:58 +00:00
15ba18d1df
Upgrade LPPa dissector to v11.3.0
...
svn path=/trunk/; revision=52192
2013-09-23 20:20:36 +00:00
102c452bcb
More emem -> wmem conversion:
...
- tvb_get_g_stringz()/tvb_get_ephemeral_stringz()/tvb_get_seasonal_stringz() -> tvb_get_stringz()
- tvb_get_g_stringz_enc()/tvb_get_ephemeral_stringz_enc() -> tvb_get_stringz_enc()
- tvb_get_ephemeral_unicode_stringz() -> tvb_get_unicode_stringz()
- tvb_bcd_dig_to_ep_str() -> tvb_bcd_dig_to_wmem_packet_str()
- update docs accordingly
svn path=/trunk/; revision=52180
2013-09-22 20:04:35 +00:00
a0c53ffaa1
emem -> wmem conversion:
...
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits()
- tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup()
- tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode()
- tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string()
- tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string()
- tvb_get_ephemeral_string_enc() -> tvb_get_string_enc()
- update docs accordingly
svn path=/trunk/; revision=52172
2013-09-22 15:50:55 +00:00
6df83e8078
Add _g_ to the names of functions that allocate glib memory. This is a bit more
...
explicit, and frees up the "generic" names (like tvb_memdup) for new signatures
that take the appropriate wmem pool.
Majority of the conversion done with sed.
svn path=/trunk/; revision=52164
2013-09-21 17:04:41 +00:00
95c5f81c83
DCH-ID can be 255
...
svn path=/trunk/; revision=52154
2013-09-20 14:19:31 +00:00
ab7d8cc87d
Fix a couple of EXPORT_DEPENDS
...
svn path=/trunk/; revision=52135
2013-09-18 03:58:07 +00:00
6883f691c7
Add the dependeny handling for windows builds as well
...
svn path=/trunk/; revision=52134
2013-09-18 03:31:03 +00:00
ae8824d555
Missed 1 character replacement as part of r52132.
...
svn path=/trunk/; revision=52133
2013-09-18 02:58:14 +00:00
b9ee9fa694
Remove all non-ASCII characters from all .asn files. I didn't see the harm in replacing them all as opposed to only those not copied verbatim from other sources.
...
svn path=/trunk/; revision=52132
2013-09-18 02:48:29 +00:00
af15a51a6b
Fix remaining dependencides for -exp.cnf files.
...
svn path=/trunk/; revision=52129
2013-09-17 20:45:00 +00:00
de20bbf0ac
More dependeny updates for asn1 -exp.cnf files.
...
Only three remaining: p7, p22, x509ce - thanks to Chris Maynard for the list.
svn path=/trunk/; revision=52127
2013-09-17 19:43:37 +00:00
72f8ca4895
One of the wmem patches only updated the generated packet-snmp.c
...
but not the source. Fix that.
svn path=/trunk/; revision=52123
2013-09-17 18:54:18 +00:00
fb834104e5
When building packet-dap.c on an empty build tree, packet-dap.c would
...
be incorrect on the first pass and only be correct when remade.
The reason was that disp-exp.cnf was created incorrectly on first pass.
disp-exp.cnf required dop-exp.cnf to build correctly, so add a mechanism
to add dependencies for export files.
Note: Only the cmake change has been tested, the autofoo stuff requires
testing.
svn path=/trunk/; revision=52120
2013-09-17 18:02:25 +00:00
a2e86de160
Fix dependency problems (continuation of r52110 and r52112).
...
svn path=/trunk/; revision=52118
2013-09-17 14:45:52 +00:00
af96c7bb45
Fix a difference to Makefile.common
...
svn path=/trunk/; revision=52117
2013-09-17 05:53:02 +00:00
686dd9b061
Copy over rev 52110 to cmake
...
svn path=/trunk/; revision=52112
2013-09-16 21:45:46 +00:00
e14b587293
Fix dependency problem reported by Joerg Mayer on wireshark-dev.
...
Ref: http://www.wireshark.org/lists/wireshark-dev/201309/msg00151.html
svn path=/trunk/; revision=52110
2013-09-16 21:35:27 +00:00
886332e74f
Whitespace changes
...
svn path=/trunk/; revision=52109
2013-09-16 21:35:19 +00:00
7d6899b96b
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9155 :
...
Ensure that codec_str string is always initialized
svn path=/trunk/; revision=52107
2013-09-16 21:26:03 +00:00
c5ffff76d8
Fix checkapi warnings (missing id)
...
Replace Makefile.{am,nmake,common} that did not conform by
their asn1/c133/ version.
svn path=/trunk/; revision=52062
2013-09-15 15:00:03 +00:00
65ff43fada
Finish asn1 emem -> wmem conversion.
...
Left are snmp and those functions that don't have wmem equivalents.
svn path=/trunk/; revision=52060
2013-09-15 14:37:46 +00:00
c65459c729
emem -> wmem (don't forget about .cnf)
...
svn path=/trunk/; revision=52058
2013-09-15 14:33:38 +00:00
888650324b
emem -> wmem
...
svn path=/trunk/; revision=52054
2013-09-15 13:24:14 +00:00
868b345eea
Convert a few more dissectors to wmem API
...
svn path=/trunk/; revision=52053
2013-09-15 10:29:49 +00:00
fd50ee16e8
dissect OCSP nonce extension
...
some minor reformatting of the ASN.1 imports
svn path=/trunk/; revision=51987
2013-09-12 21:29:50 +00:00
efe18f199c
Convert a few dissectors from emem to wmem API
...
svn path=/trunk/; revision=51983
2013-09-12 20:37:30 +00:00
0c11b6f8da
Give various files RCS IDs.
...
svn path=/trunk/; revision=51963
2013-09-12 03:41:22 +00:00
0c41507bad
Change some internal dissector table UI names so it's clear which protocol they pertain to and it's easier to find in the list.
...
svn path=/trunk/; revision=51904
2013-09-09 21:55:57 +00:00
9e3f9b449f
expert_add_info_format_text -> expert_add_info_format
...
svn path=/trunk/; revision=51852
2013-09-09 00:44:09 +00:00
00dd0adc0d
expert_add_info_format_text -> expert_add_info_format
...
svn path=/trunk/; revision=51851
2013-09-09 00:28:48 +00:00
f54441c125
Add a chunk forgotten in r51846
...
svn path=/trunk/; revision=51847
2013-09-08 21:22:11 +00:00
a6ae13dee9
Slightly different fix for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9117 :
...
Check that tvb returned by dissect_per_bit_string is not null before trying to use it
svn path=/trunk/; revision=51846
2013-09-08 21:10:36 +00:00
57c28aeffd
Fix the FSF address in the license header for the new ASN.1 dissectors.
...
svn path=/trunk/; revision=51830
2013-09-07 22:12:24 +00:00
52c9e57474
Deduplicate some type and field names.
...
svn path=/trunk/; revision=51800
2013-09-06 17:39:03 +00:00
96d29a5d50
Get rid of a duplicated filter name.
...
svn path=/trunk/; revision=51792
2013-09-05 20:55:59 +00:00
8552f0df64
The length field is retrieved from the packet in bytes, not bits, so stop
...
adjusting it by 8 everywhere.
Seems to fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9087 though
someone more familiar with the protocol will have to verify it's actually
correct now.
svn path=/trunk/; revision=51784
2013-09-05 13:15:04 +00:00
3b6f55c579
Convert atn-* dissectors to wmem. No emem in new code please!
...
svn path=/trunk/; revision=51780
2013-09-05 12:13:00 +00:00
39bff3218a
Missed 50% of the updates in last commit
...
svn path=/trunk/; revision=51773
2013-09-05 07:33:05 +00:00
d4f2865595
CMakeLists was no longer in sync with Makefile.common
...
svn path=/trunk/; revision=51772
2013-09-05 07:28:47 +00:00
022706764b
Add missing CMakeLists.txt files
...
svn path=/trunk/; revision=51771
2013-09-05 06:05:15 +00:00
02a61b07e4
Fix cmake syntax - so now it "only" warns about missing
...
CMakeLists.txt in the subdirectories.
svn path=/trunk/; revision=51770
2013-09-05 05:48:22 +00:00
80cd0dca1d
From Mathias Guettler:
...
New dissector for Air/Ground Datalink ICAO doc 9705 Ed2: ULCS, CM, CPDLC.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8903
svn path=/trunk/; revision=51766
2013-09-05 05:26:04 +00:00
7dbc052d78
More dissectors to wmem. There are no more dissectors using se_tree now, just a
...
few other places.
svn path=/trunk/; revision=51622
2013-09-01 01:00:11 +00:00
a09ee6af03
The first step towards tracking and showing DRX info in MAC:
...
- send release from RRC
- show current DRX config from each frame, including a link back to the
RRC config frame
- show simple DRX state for each frame (currently only offset into long
cycle and whether within long cycle 'on' period)
TODO:
- simulate timers in response to new UL/DL transmissions or DL CRC
errors
- maintain whether in long or short cycle
- show state of all timers
svn path=/trunk/; revision=51585
2013-08-30 04:08:57 +00:00
7e3922cf43
Use dissector_delete_uint_range/dissector_add_uint_range
...
svn path=/trunk/; revision=51540
2013-08-27 19:21:20 +00:00
b5900e53d9
Make sure our ldap_call_response_t struct is always completely initialized,
...
fixing a "Conditional jump or move depends on uninitialised value" error found
by valgrind fuzzing.
svn path=/trunk/; revision=51516
2013-08-25 17:31:15 +00:00
0675ed7494
Clang, clang, clang went the warning....
...
Fix a memset (drb_mapping is a pointer, so its size is the size of a
pointer; we want the size of what it points to).
svn path=/trunk/; revision=51500
2013-08-23 23:51:52 +00:00
ae4f556630
Simplify logic a bit now that we do not use anymore GUINT_TO_POINTER macro
...
svn path=/trunk/; revision=51490
2013-08-23 12:51:07 +00:00
483ee317f7
From Martin Mathieson:
...
Follow-up of r51429 that
- uses accessors to lazily allocate a private_data struct and returns the different parts based upon their use
- includes the v1130 DRX Config
svn path=/trunk/; revision=51489
2013-08-23 10:42:11 +00:00
75f4fa5b4b
Remove tree check when dissecting PCCH message so as to avoid filtering expert info on first pass
...
svn path=/trunk/; revision=51477
2013-08-22 19:55:25 +00:00
b3dc1eed1c
Fix Coverity CID's 1063706-1063710: Out-of-bounds read (OVERRUN_STATIC)
...
svn path=/trunk/; revision=51450
2013-08-21 14:08:42 +00:00
641032ea44
Gather together dedicated DRX configuration, and make sure that it
...
is internally consistent.
TODO: include r11 sequence that can overwrite some of these values.
TODO: actx->private_data gets reused for several purposes, need to
separate these uses out and avoid possible conflicts...
svn path=/trunk/; revision=51429
2013-08-19 17:06:42 +00:00
b46f9bebe2
Change some dissectors to use pinfo memory pool instead of malloc if it can trigger an exception between between buffer allocation and tvb_set_free_cb call
...
svn path=/trunk/; revision=51427
2013-08-19 14:55:41 +00:00
02cae558f9
Do not use ephemeral memory when adding a new data source
...
svn path=/trunk/; revision=51424
2013-08-19 11:11:11 +00:00
64f079430b
Fix $Id$.
...
svn path=/trunk/; revision=51373
2013-08-15 03:55:09 +00:00
3b5aaefce3
- Extract variables from Makefile.common.
...
- Apply this to asn1/c1222/
svn path=/trunk/; revision=51324
2013-08-12 22:17:06 +00:00
24e7b8aefd
Fix copy paste error and reinitialize actx->private_data to NULL once used
...
svn path=/trunk/; revision=51311
2013-08-12 09:26:24 +00:00
467ece42b3
Fix (-W)documentation error found by Clang
...
../../asn1/c1222/packet-c1222-template.c:348:15: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param pinfo
~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:349:14: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param tree
~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:350:16: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param length
~~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:351:16: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param offset
~~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:758:11: error: parameter 'keybuf' not
found in the function declaration [-Werror,-Wdocumentation]
* \param keybuf is updated with a copy of the key data if successful lookup.
^~~~~~
../../asn1/c1222/packet-c1222-template.c:758:11: note: did you mean 'keybuff'?
* \param keybuf is updated with a copy of the key data if successful lookup.
^~~~~~
keybuff
../../asn1/c1222/packet-c1222-template.c:879:13: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param tvb
~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:880:16: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param offset
~~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:881:13: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param len
~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:882:15: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param pinfo
~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:883:14: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param tree
~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1023:13: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param tvb
~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1024:15: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param pinfo
~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1025:14: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param tree
~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1047:15: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param pinfo
~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1048:13: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param tvb
~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1049:16: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param offset
~~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1068:13: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param tvb
~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1069:15: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param pinfo
~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1070:14: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param tree
~~~~~~~~~~^
svn path=/trunk/; revision=51272
2013-08-10 21:30:38 +00:00
237182ba42
Use proper macros to cast between uint and pointer
...
svn path=/trunk/; revision=51246
2013-08-10 17:09:12 +00:00
11304a30ee
Try again...
...
svn path=/trunk/; revision=51245
2013-08-10 16:53:05 +00:00
8cddb7a24e
Try using guint.
...
svn path=/trunk/; revision=51244
2013-08-10 16:34:19 +00:00
0fb73abcc9
Add a malformed check to show if GroupA has more RAPIDs than A & B
...
combined.
svn path=/trunk/; revision=51243
2013-08-10 16:17:33 +00:00
cf6288e21f
Added default ignore targets for new asn1 dissectors.
...
Removed cnf data from atn-cpdlc.asn to make it generate.
svn path=/trunk/; revision=51215
2013-08-08 11:15:45 +00:00
77f4bef154
From Mathias Guettler:
...
New dissector for Air/Ground Datalink ICAO doc 9705 Ed2: ULCS, CM, CPDLC.
Add the files to the distribution.
svn path=/trunk/; revision=51212
2013-08-08 05:34:22 +00:00
a4d1560fd1
From Mathias Guettler:
...
New dissector for Air/Ground Datalink ICAO doc 9705 Ed2: ULCS, CM, CPDLC.
Just adding the files to SVN for now.
svn path=/trunk/; revision=51210
2013-08-08 05:09:13 +00:00
08d223eb71
When dissecting IMSI handle the zero length tvb case, fixes "Malformed Packet: CAMEL (empty IMSI tag)"
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9015
svn path=/trunk/; revision=51208
2013-08-08 04:36:54 +00:00
2f072ac53c
add a range check for dch_id
...
this should fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9005
svn path=/trunk/; revision=51195
2013-08-07 20:18:11 +00:00
9cfac1227d
Replace hfinfo pointer to same_name_prev, with same_name_prev_id.
...
svn path=/trunk/; revision=51175
2013-08-06 20:53:47 +00:00
518ac53e2c
Make some global variables static
...
svn path=/trunk/; revision=51163
2013-08-05 20:15:06 +00:00
af134c29ca
Convert proto_item_set_expert_flags into filterable items.
...
svn path=/trunk/; revision=51140
2013-08-04 19:59:01 +00:00
3eafc74e2b
Convert proto_item_set_expert_flags to "filterable" items in alcap dissector. Unfortunately it had a few tentacles, so they needed to be brought along for the ride.
...
svn path=/trunk/; revision=51136
2013-08-04 13:46:25 +00:00
f7843da692
md5.h is in wsutil now.
...
svn path=/trunk/; revision=51102
2013-08-01 23:53:35 +00:00
2df54da6e2
Move a bunch of the crypt modules and pint.h into wsutil.
...
This means wsutil now links against libcrypt.
Protect a bunch of the crypt header files from multiple inclusion.
svn path=/trunk/; revision=51100
2013-08-01 23:34:47 +00:00
82569132d9
Add the forgotten makefile updates.
...
svn path=/trunk/; revision=51017
2013-07-29 18:19:59 +00:00
266e577aee
Update to handle version 9.
...
svn path=/trunk/; revision=50981
2013-07-28 19:25:14 +00:00
8441fff193
Use the pinfo pool for adding data sources in the h245 dissector. The packet
...
pool is freed before the packet is displayed or otherwise processed, so adding
data sources from it leads to use-after-free errors.
Not sure why this wasn't showing up in the fuzz-bot valgrind step, there
are lots of h245 captures in the menagerie...
svn path=/trunk/; revision=50897
2013-07-25 23:58:49 +00:00
802e7bed77
Try to differentiate a non filled private_data (pointer set to NULL) from an enum with value = 0
...
svn path=/trunk/; revision=50837
2013-07-23 14:34:46 +00:00
c702e92121
Replace relative timestamp with reference frame number. Saves 16B per frame.
...
svn path=/trunk/; revision=50772
2013-07-21 23:07:33 +00:00
a18172147f
Remove fragment_data, add fragment_head, fragment_item - for now alias it to the same structure.
...
This is begin of work to split fragment head and fragments items.
svn path=/trunk/; revision=50708
2013-07-17 21:12:24 +00:00
f5f20fa8e3
Fix warning: ISO C does not allow extra ';' outside of a function.
...
svn path=/trunk/; revision=50638
2013-07-15 20:42:57 +00:00
54bb2e7a5c
Move report_err.{h,c} from epan into wsutil: there's nothing epan-specific there and moving it avoids having to recompile the file for use in editcap and capinfos (which don't link against libwireshark).
...
svn path=/trunk/; revision=50598
2013-07-15 02:48:26 +00:00
0e40234217
Make pointers to raw packet data pointers to guint8, not pointers to
...
char; they're chunks of raw octets, not characters.
svn path=/trunk/; revision=50586
2013-07-14 17:39:36 +00:00
543ba2746b
fix: ../../asn1/t38/packet-t38-template.c:346: warning: request for implicit conversion from 'gpointer' to 'char *' not permitted in C++
...
svn path=/trunk/; revision=50582
2013-07-14 15:51:15 +00:00
c766e78cfa
Rewrite reassemble API to use TVBs instead of raw data.
...
(it seems to be working for TCP ^^)
svn path=/trunk/; revision=50580
2013-07-14 14:42:05 +00:00
8c9ab802ce
Upgrade LTE RRC dissector to v11.4.0
...
svn path=/trunk/; revision=50473
2013-07-09 20:39:09 +00:00
b2475c1c29
Squelch some warnings that show up with, for example, the GCC 4.2.1 that
...
comes with Xcode 3.2.6 (it's not a real problem, but that requires more
flow analysis than that version of the compiler does, apparently).
svn path=/trunk/; revision=50419
2013-07-06 19:34:21 +00:00
74e1b830a9
Use epan-scoped memory for h248 packages. Fixes another ~24KB of leaks.
...
svn path=/trunk/; revision=50414
2013-07-06 18:14:04 +00:00
225698ef0b
Fix display filter errors caught by checkfiltername.pl
...
svn path=/trunk/; revision=50399
2013-07-06 02:53:45 +00:00
eec311ef39
Fix duplicate diplay filter names found by checkfiltername.pl
...
svn path=/trunk/; revision=50396
2013-07-06 01:20:38 +00:00
7878e93cad
expert_add_info_format_text + proto_tree_add_text = proto_tree_add_expert_format, where applicable.
...
svn path=/trunk/; revision=50377
2013-07-03 23:43:26 +00:00
b00abd1c43
Check actx->private_data validity before using it
...
svn path=/trunk/; revision=50339
2013-07-03 12:01:12 +00:00
b91b990a77
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8880 :
...
Check actx->private_data validity before using it
svn path=/trunk/; revision=50338
2013-07-03 08:53:47 +00:00
98492c5619
expert_add_info + proto_tree_add_text = proto_tree_add_expert, where applicable
...
svn path=/trunk/; revision=50337
2013-07-03 02:59:31 +00:00
17772df943
Fix Coverity CID 1040373 (Dereference before null check). Minor whitespace changes come along for the ride on this one.
...
svn path=/trunk/; revision=50297
2013-07-01 15:09:56 +00:00
997c6c7d8e
Fix Coverity CID 712348 (Unused pointer value).
...
svn path=/trunk/; revision=50288
2013-07-01 06:15:37 +00:00
95daae2290
Squelch some warnings.
...
svn path=/trunk/; revision=50286
2013-07-01 06:13:21 +00:00
bfcaf93bff
Fix Coverity CID 1040372 (Printf arg count mismatch) by eliminating the double %'s.
...
svn path=/trunk/; revision=50283
2013-07-01 05:47:13 +00:00
c1ddd6046d
replace object_identifier_id with actx->external.direct_reference
...
svn path=/trunk/; revision=50209
2013-06-28 12:52:13 +00:00
Pascal Quantin