Commit Graph

20039 Commits

Author SHA1 Message Date
Anders Broman 5c1bc94608 "Fill" a couple of value_string(ext)
svn path=/trunk/; revision=46518
2012-12-12 12:48:12 +00:00
Bill Meier 93fdffd70d General cleanup:
- Fix instance of offset changed under 'if (tree)' and used after 'if (tree)';
- Create/use some extended value strings;
- #if 0 an unused value_string array;
- Localize some variables & remove some uneeded initializers;
- Fix some whitespace & long lines.

svn path=/trunk/; revision=46516
2012-12-12 03:38:46 +00:00
Jeff Morriss 7033cc7220 Fix some indentation.
svn path=/trunk/; revision=46512
2012-12-12 01:50:44 +00:00
Bill Meier 9bb7c0f6b9 From Adam Butcher: Add SAKKE support to MIKEY dissector
... adds support for ECCSI signature type, SAKKE payload,
MIKEY-TICKET ID Role types (required for MIKEY-SAKKE KMS
role identifiers) to the MIKEY dissector.

The related specifications are:
  http://tools.ietf.org/html/rfc6509    MIKEY-SAKKE
   (http://tools.ietf.org/html/rfc6507  ECCSI)
   (http://tools.ietf.org/html/rfc6508  SAKKE)
  http://tools.ietf.org/html/rfc6043    MIKEY-TICKET (ID Role types only)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8080

svn path=/trunk/; revision=46511
2012-12-12 01:28:21 +00:00
Evan Huus 48c653481a Use the complete fragment length to reassembly SSL frames. The old method
of picking them up one at a time failed on jumbo frames.

Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8075

svn path=/trunk/; revision=46510
2012-12-12 00:02:34 +00:00
Alexis La Goutte 2e8cb1c5cd Enhance BGP ORF (Make field filterable)
svn path=/trunk/; revision=46508
2012-12-11 23:24:02 +00:00
Alexis La Goutte cf6115367b Update IEEE Wireless Documentation links
IEEE Std 802.11(m)-2012 (pdf) is now available for free ! include with 10 amendements

* IEEE Std 802.11k™-2008: Radio Resource Measurement of Wireless LANs (Amendment 1)
* IEEE Std 802.11r™-2008: Fast Basic Service Set (BSS) Transition (Amendment 2)
* IEEE Std 802.11y™-2008: 3650–3700 MHz Operation in USA (Amendment 3)
* IEEE Std 802.11w™-2009: Protected Management Frames (Amendment 4)
* IEEE Std 802.11n™-2009: Enhancements for Higher Throughput (Amendment 5)
* IEEE Std 802.11p™-2010: Wireless Access in Vehicular Environments (Amendment 6)
* IEEE Std 802.11z™-2010: Extensions to Direct-Link Setup (DLS) (Amendment 7)
* IEEE Std 802.11v™-2011: IEEE 802.11 Wireless Network Management (Amendment 8)
* IEEE Std 802.11u™-2011: Interworking with External Networks (Amendment 9)
* IEEE Std 802.11s™-2011: Mesh Networking (Amendment 10)

svn path=/trunk/; revision=46507
2012-12-11 23:23:48 +00:00
Alexis La Goutte 293d44fca1 Enhance (minor) MPLS PW OAM Dissector Replace proto_tree_add_uint => proto_tree_add_item
svn path=/trunk/; revision=46506
2012-12-11 23:23:35 +00:00
Alexis La Goutte baf4a0ed5a From Steve Dickson via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8081
Added the Labled NFS protocol dissector for NFS v4.1

Signed-off-by: Steve Dickson <steved@redhat.com>

svn path=/trunk/; revision=46505
2012-12-11 23:23:20 +00:00
Pascal Quantin 70c283816b Dissect eMBMS MTCH LCIDs
svn path=/trunk/; revision=46504
2012-12-11 23:20:22 +00:00
Anders Broman 1ecfc445b8 From zhang lei:
Cause、RAB Context、PDU Numbers in packet-gtpv2.c are not dissected correctly. fixed in the patch.

The patch did not apply cleanly to trunk, applied by hand.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8079

svn path=/trunk/; revision=46497
2012-12-11 09:39:15 +00:00
Anders Broman c5c24d2277 Only construct bit string if show internal per fields is set. Use tvb_get_bits
svn path=/trunk/; revision=46496
2012-12-11 07:01:43 +00:00
Jeff Morriss 70eecf2392 Move ett and hf arrays into proto_register routine.
Reindent some.

svn path=/trunk/; revision=46495
2012-12-11 02:26:44 +00:00
Bill Meier 4daca92053 Minor cleanup:
- Remove some uneeded initializers;
- Whitespace.

svn path=/trunk/; revision=46493
2012-12-10 23:23:01 +00:00
Bill Meier a98fa4f861 Minor cleanup:
- Localize some variables & remove some uneeded initializers;
- Fix a "set but unused" instance;
- Misc.

svn path=/trunk/; revision=46492
2012-12-10 23:20:05 +00:00
Bill Meier 6104b2f45e For the record: add comments about some duplicate values in a value_string array.
svn path=/trunk/; revision=46491
2012-12-10 20:10:30 +00:00
Bill Meier 3971e95140 Re-generate value_string array for MIBenum mapping char set names from latest IANA document;
Adds new values and fixes an incorrect value in the previous value_string array.

Note: names used as specified (with capitalization) in the document.
      (Previously all the names in the value_string array were lower case).

Also: rename the value_string array to have a less generic name.

svn path=/trunk/; revision=46490
2012-12-10 19:12:05 +00:00
Bill Meier a4128c56b9 General cleanup:
- Use/create extended value strings as appropriate;
- Reformat hf[] entries;
- Do whitespace, & etc changes to use a consistent formatting style;
- Reformat some long lines;
- Localize some variables; remove some unneeded initializers;
- expert...() shouldnt be called under 'if (tree)' (packet-wimaxasncp);
- Move proto_register...() & etc to the end of the file (packet-ieee80211);
- Misc.

svn path=/trunk/; revision=46489
2012-12-10 14:50:32 +00:00
Anders Broman 1567e207a9 Try to speed up decode_bits_in_field().
svn path=/trunk/; revision=46487
2012-12-09 23:12:59 +00:00
Pascal Quantin afc90af6fd Add release number to UMTS and LTE RLC
svn path=/trunk/; revision=46486
2012-12-09 22:02:38 +00:00
Anders Broman 0c348dbb6b Copy paste error - RAC is one byte.
svn path=/trunk/; revision=46485
2012-12-09 18:22:09 +00:00
Anders Broman 799983a565 Fix dissection of Target Identification.
svn path=/trunk/; revision=46484
2012-12-09 18:17:47 +00:00
Gerald Combs 0390157100 [Automatic manuf, services and enterprise-numbers update for 2012-12-09]
svn path=/trunk/; revision=46481
2012-12-09 15:03:25 +00:00
Martin Mathieson 950325b82a Cast result of strlen() from size_t to int.
svn path=/trunk/; revision=46480
2012-12-09 14:35:14 +00:00
Martin Mathieson 394853ec7e Similarly avoiding calling g_snprintf() in dissect_per_constrained_integer().
svn path=/trunk/; revision=46479
2012-12-09 04:49:58 +00:00
Martin Mathieson e5e25f8670 Speed up dissect_per_boolean() by avoiding call to ep_strdup_printf().
Saves 5% on a particular LTE log.

svn path=/trunk/; revision=46478
2012-12-09 04:23:46 +00:00
Evan Huus ea47ca37b1 Put in a cast to silence a stupid MSVC warning.
svn path=/trunk/; revision=46473
2012-12-08 22:00:17 +00:00
Evan Huus ae17fffd38 Convert IPv4 dissector to wmem - much bigger canarie in the coal mine, since
IPv4 is *everywhere*.

svn path=/trunk/; revision=46471
2012-12-08 21:36:14 +00:00
Evan Huus 7b979a26bb Convert the SMTP dissector and the frame_data manager from emem to wmem.
Canaries in the coal mine, since I have a capture handy that I know excercises
both code paths.

svn path=/trunk/; revision=46470
2012-12-08 21:22:46 +00:00
Evan Huus dc530fd2c2 Fix uninitialized value error caught by valgrind.
svn path=/trunk/; revision=46469
2012-12-08 21:15:40 +00:00
Evan Huus af700fa79a Make sure the wmem block allocator returns aligned memory.
svn path=/trunk/; revision=46468
2012-12-08 21:08:29 +00:00
Bill Meier 1f4d7cb6a7 Convert '4 space tabs' to spaces;
svn path=/trunk/; revision=46467
2012-12-08 20:49:51 +00:00
Evan Huus df71a9a669 Fix some compiler warnings under gcc.
svn path=/trunk/; revision=46466
2012-12-08 03:04:55 +00:00
Michael Mann 2ff0d7870a Bugfix FCP lun request/response tracking.
This works towards bug 3209 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3209) by at least satisfying the layer under SCSI.  All of the dissectors that feed into SCSI seem to have similar "lun tracking" issues, so I think a more general solution may be needed to fix the bug "right"

#BACKPORT

svn path=/trunk/; revision=46464
2012-12-08 01:33:04 +00:00
Jeff Morriss 14252042d6 As requested in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7735 :
Make the Source and Destination hf names indicate that they are for the
Source and Destination fields so that, for example, their column names are
descriptive.

svn path=/trunk/; revision=46461
2012-12-07 22:32:34 +00:00
Martin Kaiser 3ccd739fc6 removed a last if (tree) check in dissect_ftpdata()
svn path=/trunk/; revision=46460
2012-12-07 22:00:56 +00:00
Martin Kaiser dbaf194b10 EPRT parameters are mandatory, flag up an error if they're missing
remove if (linelen!=0) check

svn path=/trunk/; revision=46459
2012-12-07 21:54:20 +00:00
Martin Kaiser cf032504d3 remove some more if (tree) checks
svn path=/trunk/; revision=46457
2012-12-07 21:50:22 +00:00
Martin Kaiser 6a6babe5b0 at one place, offset was incremented depending on if (tree)
this created a bug when offset was used later on
remove the if (tree) check

svn path=/trunk/; revision=46456
2012-12-07 21:46:59 +00:00
Martin Kaiser 48f3309e14 dissect_ftp() start at the beginning of the tvb
make this clear by not using a variable offset which is always 0

svn path=/trunk/; revision=46455
2012-12-07 21:42:30 +00:00
Martin Kaiser 8f81b0fafe remove some more unnecessary if (tree) checks
svn path=/trunk/; revision=46454
2012-12-07 21:37:50 +00:00
Martin Kaiser 43f3eb63dc remove some unnecessary if (tree) checks in the ftp dissector
svn path=/trunk/; revision=46452
2012-12-07 21:31:03 +00:00
Gerald Combs c9d4240196 Add a context menu to the packet list and fill in the
apply/match-related actions. Have matchSelectedFilter figure out our
filter strings, which lets us remove duplicate code in the apply/match
action slots. Remove some leftover code from an experiment.

Adjust the temporary message colors in the status bar and label stack.

Add a NULL check to construct_match_selected_string.

svn path=/trunk/; revision=46449
2012-12-07 20:08:00 +00:00
Bill Meier 65384d0091 General cleanup:
- Don't call col...() & expert...() under 'if (tree)';
- Localize some variables; Remove uneeded initializers;
- Remove incorret _U_ from certain function parameters;
- Reformat long-lines; Do whitespace changes;
- Misc.


svn path=/trunk/; revision=46444
2012-12-07 16:25:56 +00:00
Anders Broman 6e0208c98e Correct dissection of RNC ID in two places.
svn path=/trunk/; revision=46443
2012-12-07 14:41:05 +00:00
Anders Broman 2f827154f8 Bug 3974 - wrong decoding of gtp.target identification.
Use the IE description from 3GPP TS 29.060 version 10.4.0 Release 10.
- Fix bugs with RAI and LAC in other parts of the code.

svn path=/trunk/; revision=46439
2012-12-07 12:06:40 +00:00
Stig Bjørlykke 38aeb0e1e3 Added deltaRevocationList.
svn path=/trunk/; revision=46438
2012-12-07 11:40:29 +00:00
Anders Broman 264ac136ef Make it easier to make full extended value string if required.
svn path=/trunk/; revision=46437
2012-12-07 09:34:39 +00:00
Guy Harris 6913fe06ba Revert previous change - maybe we shouldn't enable -Wshadow with crufty
old GCCs that complain about that.

svn path=/trunk/; revision=46432
2012-12-06 23:43:00 +00:00
Guy Harris eed1e3c91b Squelch some -Wshadow warnings (inappropriate warnings - they're just
names in a prototype declaration - but maybe that's what you get with
older compilers).

svn path=/trunk/; revision=46431
2012-12-06 23:19:13 +00:00