Commit Graph

101 Commits

Author SHA1 Message Date
Jakub Zawadzki bf81b42e1e Update Free Software Foundation address.
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Pascal Quantin 4d1abc7bbb From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7306 :
RPC: show the AUTH_GLUSTERFS/lk_owner as hex

svn path=/trunk/; revision=42940
2012-05-31 08:56:19 +00:00
pascal d6381b4123 From Evan Huus via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7271 :
Remove useless null check

svn path=/trunk/; revision=42741
2012-05-21 09:37:58 +00:00
Bill Meier b869cb0bc5 Remove unneeded includes (ctype.h, stdio.h);
In one case, define our own size for a string buffer
 (instead of using a magic constant 'BUFSIZ');
In a few cases: do some whitespace, indentation & reformatting cleanup.

svn path=/trunk/; revision=42634
2012-05-15 20:57:21 +00:00
pascal 079f737508 Remove useless '+0' in proto_tree_add_* function calls
svn path=/trunk/; revision=42574
2012-05-11 09:50:28 +00:00
pascal 0264b67ed7 From Niels de Vos:
Add dissection of AUTH_GLUSTERFS as used in GlusterFS-3.3
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7244

svn path=/trunk/; revision=42573
2012-05-11 09:44:55 +00:00
pascal f982541723 From Niels de Vos:
Add a helper function to dissect AUTH_UNIX groups
Fix hf_rpc_auth_lk_owner entry
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7244

svn path=/trunk/; revision=42572
2012-05-11 09:38:49 +00:00
Guy Harris eab1625599 Get rid of remaining Booleans-as-encoding-arguments in
proto_tree_add_item() calls.

svn path=/trunk/; revision=42537
2012-05-10 02:28:01 +00:00
pascal f0a6f372ac From Niels de Vos:
dissect AUTH_RSA as Gluster AUTH-flavor
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7190

svn path=/trunk/; revision=42244
2012-04-25 21:02:48 +00:00
Jörg Mayer 5b9cc23569 Fix compiler warnings (set but not used).
Remove whitespace at end of line.

svn path=/trunk/; revision=41845
2012-03-30 13:18:13 +00:00
Ronnie Sahlberg 461b2021b2 ONC-RPC: After we have dissected the decrypted PDU, update offset to reflect that we have eaten all these bytes or rpc will think there was un-dissected data remaining and will show it as an extra "data" field.
svn path=/trunk/; revision=41833
2012-03-29 21:13:24 +00:00
Ronnie Sahlberg 378d039009 ONC-RPC: Add decryption of GSSAPI protected NFS and other ONC based protocols
svn path=/trunk/; revision=41822
2012-03-29 07:42:47 +00:00
Ronnie Sahlberg 3d81f3612b ONC-RPC: When a GSS context is destroyed, that NULL procedure call does not carry neither a verifier nor a payload.
Stop decoding the packed immediately after the credentials so that we dont incorrectly flag these packets as malformed.


svn path=/trunk/; revision=41817
2012-03-28 09:42:05 +00:00
Ronnie Sahlberg 5a2b1ea380 remove a header include that was used when debugging and forgotten to be removed from previous commit
svn path=/trunk/; revision=41814
2012-03-28 09:16:09 +00:00
Ronnie Sahlberg fcd7ed4e62 ONC-RPC: add tracking of GSSAPI authentication contexts
Add traking of when GSS authentication contexts are created and when they are destroyed
so that it is easy to "click on created in link" in a SecNFS packet to get to where the kerberos blob for authentication is


Add context created in/destroyed in to the decode so you can quickly jump to where the authantiation happened to check the decrypted krb5 credentials



svn path=/trunk/; revision=41813
2012-03-28 09:10:41 +00:00
Bill Meier 0a1ded8725 Fix proto_tree_add_item() encoding args.
svn path=/trunk/; revision=39618
2011-10-26 20:43:58 +00:00
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier 94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00
Bill Meier 781129806f Fix ex "modeline" so it works;
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5748

svn path=/trunk/; revision=39081
2011-09-21 17:49:11 +00:00
Jeff Morriss cdedb31e94 As suggested by Chris: use val_to_str_const() instead of match_strval() plus a
NULL-return check.

Use val_to_str_const instead of val_to_str() in a couple places where the string
is constant.

Use val_to_str() instead of blindly passing the return value from match_strval()
into a format routine (to ensure a non-NULL string pointer).  A couple of these
were cases where it could not actually return NULL, but I changed it for
consistency.

Store the return value of match_strval() rather than calling it repeatedly.

svn path=/trunk/; revision=37204
2011-05-17 18:58:40 +00:00
Jeff Morriss 3dc36263cc Avoid passing a NULL string pointer to format routines: some libc's (e.g.,
Solaris') will seg-fault on that.

svn path=/trunk/; revision=36827
2011-04-22 18:32:56 +00:00
Stig Bjørlykke 27344a90fe Removed some unneeded assignments.
Found by clang.

svn path=/trunk/; revision=36698
2011-04-18 15:29:25 +00:00
Stig Bjørlykke 84bc28bd6a Introduce "Fragment count" filter element for all protocols doing reassembly.
svn path=/trunk/; revision=35705
2011-01-30 21:01:07 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Jeff Morriss 8187894200 After calling a subdissector, set a fence on COL_INFO so whatever the
subdissector put in the Info column stays there.

svn path=/trunk/; revision=34607
2010-10-21 20:51:06 +00:00
Jeff Morriss fae45ea6a1 Remove check_col()
svn path=/trunk/; revision=34426
2010-10-08 01:50:50 +00:00
Jeff Morriss 96164ee15f Restore pinfo->private_data after an exception was thrown by a subdissector.
This is necessary in case a subdissector had changed it but was unable to
restore it (due to the exception).

svn path=/trunk/; revision=34408
2010-10-07 21:10:51 +00:00
Anders Broman a13bf525a8 From Ian Schorr:
NFSv4 usability enhancements (Info column summaries, filterable fields).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4975

svn path=/trunk/; revision=33442
2010-07-06 04:13:54 +00:00
Bill Meier 09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Stig Bjørlykke 539b558f8c Renamed some reassembled data texts.
Removed some check_col().

svn path=/trunk/; revision=31809
2010-02-06 18:20:21 +00:00
Stig Bjørlykke 88b72356ad Introduce "Reassembled length" filter element for all protocols doing
reassembly.

svn path=/trunk/; revision=31767
2010-02-02 16:01:52 +00:00
Bill Meier 37547c1791 Fix a few gcc _Wshadow warnings ....
svn path=/trunk/; revision=31580
2010-01-19 23:51:27 +00:00
Anders Broman 7afd9b0c3b From Jakub Zawadzki:
Cleanup dissector code - use proper memory functions.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164

svn path=/trunk/; revision=31408
2010-01-02 09:46:16 +00:00
Anders Broman 88bb44a51e From Jakub Zawadzki:
Cleanup dissector code - use proper memory functions.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164

svn path=/trunk/; revision=30691
2009-10-25 11:43:30 +00:00
Kovarththanan Rajaratnam 8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining()
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Kovarththanan Rajaratnam 6110a96f68 Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29345
2009-08-09 07:59:51 +00:00
Kovarththanan Rajaratnam 4b6090e576 Don't guard col_set_str (COL_INFO) with col_check
svn path=/trunk/; revision=29342
2009-08-09 07:01:26 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Stig Bjørlykke 0437f102c3 From Kovarththanan Rajaratnam:
More FT_XXX cleanup.

svn path=/trunk/; revision=28971
2009-07-07 09:02:59 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Anders Broman b4aeb97ed5 tvb_new_real_data -> tvb_new_child_real_data
svn path=/trunk/; revision=28517
2009-05-29 06:16:43 +00:00
Bill Meier 5aa5576a55 The convention is to use TFS(...) when specifying a true_false_string with an FT_BOOLEAN field;
Also: use the global true_false_string tfs_yes_no  in place of a static local string.

svn path=/trunk/; revision=28320
2009-05-08 22:18:14 +00:00
Gerald Combs 180852ed7c From Mark Cave-Ayland: Fix a crash in the PCNFSD dissector.
From me: Apply Mark's fix to the ident string. Add public #defines for
the special strings that dissect_rpc_* might return and use them in
PCNFSD.  Replace a manual buffer allocation with ep_strdup_printf.

svn path=/trunk/; revision=28128
2009-04-22 17:42:47 +00:00
Gerald Combs 4403f89243 More size_t fixes.
svn path=/trunk/; revision=27976
2009-04-06 19:30:48 +00:00
Gerald Combs 6d04f793f0 Back out r27047 and r27053.
svn path=/trunk/; revision=27062
2008-12-19 17:39:52 +00:00
Gerald Combs fc71188963 Update calls to proto_tree_add_bytes_format to reflect r27047.
svn path=/trunk/; revision=27053
2008-12-18 20:19:49 +00:00
Bill Meier 97e7747d42 Small cleanup of proto_reg_handoff & etc
- 'once-only' not req'd in some cases
- use find_dissector as appropriate
- remove unneeded code

svn path=/trunk/; revision=26284
2008-09-27 13:38:59 +00:00
Bill Meier afd857957a Fix a few Emacs "file variables" to have "safe" values.
That is: indent-tabs-mode: tabs --> indent-tabs-mode: t
Also: fix a typo: set-tabs-mode --> indent-tabs-mode

svn path=/trunk/; revision=26113
2008-09-02 11:17:03 +00:00
Bill Meier 38eb4d6ce3 Use const with value_string array definitions
svn path=/trunk/; revision=26028
2008-08-14 23:51:52 +00:00
Jeff Morriss 6946f1878f From https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2723
Tigran Mkrtchyan: decode and display fattr4_fs_layout_types.

Thijs Stuurman: Synchronize names used by wireshark with those used in
latest pnfs draft.

J. Bruce Fields: Use large default max_rpc_tcp_pdu_size setting
The linux server will do up to 1M these days, so the current default is
very likely to discard all reads and writes from such a server.
Thanks to Jim Rees for catching this.

Jeff Morriss: limit the max_rpc_tcp_pdu_size increase to 4M instead of the 16M
proposed.  Memory is cheap but still not unlimited.

svn path=/trunk/; revision=25769
2008-07-19 20:17:42 +00:00