Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
the encoding parameter for proto_tree_add_item() calls which directly reference
an item in hf[] which has a type of:
FT_UINT8
FT_UINT16
FT_UINT24
FT_UINT32
FT_UINT64
FT_INT8
FT_INT16
FT_INT24
FT_INT32
FT_INT64
FT_FLOAT
FT_DOUBLE
svn path=/trunk/; revision=39288
epan/dissectors/packet-ncp2222.inc is a bit hard to fix, so we're not
ready to enable that warning by default yet.
Throw in some casts to handle GLib routines that take arbitrary
non-const pointers (they can later return the pointers, and some
callers might want to modify or free up those pointers in cases where
they're known to be writable or allocated).
Use ep_tvb_memdup() rather than a combination of ep_alloc() and
tvb_memcpy().
Clean up some indentation.
svn path=/trunk/; revision=25601
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster.
Replace
- col_append_fstr() with faster col_append_str()
- col_add_str() with col_set_str()
when it's safe
svn path=/trunk/; revision=23252
there are many reasons why some protocols actually need to be able to access the pinfo structure while determining the pdu size
svn path=/trunk/; revision=19751
while this should improve performance by unmeasurably little it does have the sideeffect that once we finish the rewrite tcp analysis might actually work and work well even for tcp over tcp tunnelling.
this also means that if you include packet-tcp.h you also need to include emem.h .
svn path=/trunk/; revision=17681
hand.
Use "g_strdup()" rather than duplicating its functionality by hand.
Make the magic number an array of "guint8", as "tvb_memeql()" expects a
pointer to "guint8".
svn path=/trunk/; revision=14881
Use "tvb_reported_length_remaining()", not "tvb_length_remaining()", to
find out how much encapsulated data there is, so we properly handle
short frames (reporting how much was really there, not how much was
captured).
svn path=/trunk/; revision=12219
The reason why you need to turn on "Try heuristic sub-dissector first"
is that the traffic might be port 10000 traffic, and the NDMP dissector
gets that but doesn't properly reject it if it doesn't look like NDMP -
that's been fixed.
svn path=/trunk/; revision=12217