osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
47127 commits 26 branches 0 tags 795 MiB
Commit graph

111 commits

Author SHA1 Message Date
Chris Maynard
d3c38473b9 tvb_length_remaining() can return -1 so don't cast its return value to an unsigned type when performing integer comparisons. Instead, cast strlen()'s return value to a signed type and perform the comparison that way. 
#BACKPORT(1.10,1.8)

svn path=/trunk/; revision=49983
 2013-06-17 15:39:56 +00:00
Pascal Quantin
17fa61c36e Use a more compact display for the status bitmap 
svn path=/trunk/; revision=49974
 2013-06-17 04:26:16 +00:00
Martin Mathieson
562a126ddc Improve the way PDCP status PDUs are shown. 
For the bitmap, present and missing SNs are both
interesting, but only until the last received SN 
(i.e. the last byte of the bitmap will be padded
out with zero bits).

It would be possible to use existing sequence analysis
info, where available, to decide if any zeros beyond the last
received SN are interesting...

svn path=/trunk/; revision=49959
 2013-06-16 14:24:47 +00:00
Anders Broman
85a8e304dd Add the posibillity to use a key for per-packet-data. 
svn path=/trunk/; revision=49259
 2013-05-12 18:11:02 +00:00
Martin Mathieson
94d2036ad0 Turn some preferences on by default. Won't affect info column. 
svn path=/trunk/; revision=49005
 2013-04-23 22:33:53 +00:00
Anders Broman
3eb06be97d From beroset: 
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48425
 2013-03-19 19:28:57 +00:00
Bill Meier
1823aa007c it's ==> its & its ==> it's as needed. 
svn path=/trunk/; revision=47891
 2013-02-26 01:06:19 +00:00
Pascal Quantin
959e3e3e2c Various enhancements to ROHC dissector: 
- fix dissection of type 0 packets with large CID
- add dissection of type 1 and 2 packets (extension 3 dissection to be done)
- add dissection of UDP checksum

svn path=/trunk/; revision=47869
 2013-02-24 22:06:53 +00:00
Guy Harris
29715ccc8f How can I get a new tvbuff that starts at an offset within a given 
tvbuff and runs to the end of the tvbuff?  Let me count the ways....

Replace a bunch of different ways of doing that (some incorrect, in that
they're not properly handling tvbuffs where the captured and reported
lengths are different) with tvb_new_subset_remaining().

svn path=/trunk/; revision=47751
 2013-02-19 23:17:07 +00:00
Michael Mann
86d690880f replace "unsigned" datatype with "guint". Some mpeg files needed "unsigned int" instead. 
bugs 7825-7827 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7825)

svn path=/trunk/; revision=46928
 2013-01-04 05:22:43 +00:00
Martin Mathieson
b7e64d6571 Fix some clang warnings. 
svn path=/trunk/; revision=46549
 2012-12-16 00:15:26 +00:00
Jeff Morriss
0266cceef3 Make all enum_val_t's const. 
svn path=/trunk/; revision=46292
 2012-11-29 20:15:37 +00:00
Martin Mathieson
dd3cf21124 Include channel details in PDCP sequence analysis expert info strings. 
svn path=/trunk/; revision=46035
 2012-11-15 21:28:21 +00:00
Martin Mathieson
af71608df6 Use GPOINTER_TO_UINT macro. 
svn path=/trunk/; revision=45368
 2012-10-07 15:59:26 +00:00
Martin Mathieson
96386ec1da Make the channel state key fit into the gpointer to avoid allocations. 
Don't fetch the first byte of the payload length multiple times.

svn path=/trunk/; revision=45367
 2012-10-07 15:14:44 +00:00
Pascal Quantin
7dd916459e Let's be consistent and display lte_rrc root for all LTE RRC messages 
svn path=/trunk/; revision=45080
 2012-09-23 21:01:05 +00:00
Pascal Quantin
006f022fea Upgrade PDCP LTE dissector to v11.0.0 
svn path=/trunk/; revision=45049
 2012-09-21 20:12:32 +00:00
Jeff Morriss
2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 
svn path=/trunk/; revision=45017
 2012-09-20 02:03:38 +00:00
Martin Mathieson
d729f21ad2 Revert r45005. 
svn path=/trunk/; revision=45006
 2012-09-19 16:56:59 +00:00
Martin Mathieson
a232ae9242 Make proto_item_append_string() behave sanely, and use it in a few more 
dissectors.

svn path=/trunk/; revision=45005
 2012-09-19 11:58:32 +00:00
Jakub Zawadzki
9f92dc93c5 Add data parameter to call_dissector_only. 
svn path=/trunk/; revision=44872
 2012-09-11 08:28:07 +00:00
Jakub Zawadzki
5a8783f5b1 Initial commit to support yet another method of passing data between dissectors. 
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL

svn path=/trunk/; revision=44860
 2012-09-10 21:40:21 +00:00
Martin Mathieson
7e88a07e71 proto_item_append_string() doesn't work this case, so stop using it. 
I am tempted though to chage proto_item_append_string() just be like
proto_item_append_text() without the call to g_vsnprintf(), which is the
expensize part I was hoping to avoid.

svn path=/trunk/; revision=44614
 2012-08-22 19:01:01 +00:00
Martin Mathieson
d847bc85a5 Delete the ROHC from here as it is superceded by packet-rohc.c 
svn path=/trunk/; revision=44610
 2012-08-21 21:37:31 +00:00
Martin Mathieson
973be664bb Use proto_item_append_string() rather than proto_item_append_text() with 
%s.

svn path=/trunk/; revision=44606
 2012-08-21 17:12:13 +00:00
Jakub Zawadzki
bf81b42e1e Update Free Software Foundation address. 
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
 2012-06-28 22:56:06 +00:00
Bill Meier
6fbb09d50b General Cleanup including: 
- Remove unneeded #include <stdlib.h>;
- Remove "README.developer" comments;
- Reformat hf[] entries;
- Remove unneeded variable initialization;
- "localize" some variables;
- Whitespace/indentation/long lines/formatting
- (In one case) proto_tree_add_uint returns a proto_item* (not a proto_tree *);

svn path=/trunk/; revision=42678
 2012-05-17 14:35:11 +00:00
Jakub Zawadzki
68ec58d385 Fix some: 'cast discards qualifiers from pointer target type' warnings 
- Add const qualifier
- Remove some strange casts

svn path=/trunk/; revision=42131
 2012-04-18 12:35:36 +00:00
Martin Mathieson
4d256e6628 Getting closer to deleting old ROHC from PDCP dissector. 
Don't register ROHC fields there (so its easier to find real fields with
auto-completion).

svn path=/trunk/; revision=42076
 2012-04-15 01:37:08 +00:00
Martin Mathieson
3f592f10e6 For PDCP status reports, show each lost SN as a bit from the map. 
svn path=/trunk/; revision=42014
 2012-04-10 21:26:55 +00:00
Jakub Zawadzki
23494db817 Add missing const attribute to some char * 
Fix some "assignment discards qualifiers from pointer target type", etc

svn path=/trunk/; revision=41996
 2012-04-09 18:44:10 +00:00
Martin Mathieson
6407baee32 Obsolete a preference 
svn path=/trunk/; revision=41986
 2012-04-09 01:50:26 +00:00
Martin Mathieson
d101fb251b Clear info column before calling ROHC dissector. 
svn path=/trunk/; revision=41880
 2012-04-01 14:52:48 +00:00
Martin Mathieson
5282c1b9c5 When a capture starts with a non-zero SN, don't report 0-(SN-1) as 
missing.

svn path=/trunk/; revision=41837
 2012-03-30 01:18:12 +00:00
Martin Mathieson
60a22a4072 Want to write RRC info column info always. Also save and restore writable 
flag.

svn path=/trunk/; revision=41435
 2012-03-08 16:30:39 +00:00
Martin Mathieson
16c443956d Add a preference to show in the info column RLC, PDCP or traffic 
details.

svn path=/trunk/; revision=41433
 2012-03-08 13:19:41 +00:00
Martin Mathieson
7c0b8e6097 Dissect and check reserved bits at start of signalling format. 
svn path=/trunk/; revision=40823
 2012-02-03 16:44:56 +00:00
Martin Mathieson
26d6d4ce8a Use plane rather than channelType as part of key for looking up channel 
state for sequence analysis.

svn path=/trunk/; revision=40659
 2012-01-23 14:39:38 +00:00
Martin Mathieson
7e5f6d9fc1 PDCP: 
- Pass is_retx flag to PDCP from RLC in struct instead of calling function
RLC:
- use full key to look up sequence analysis results
    - avoids overwriting and attaching result details to wrong PDU
- add links to previous and next 'OK' PDUs in channel
- shorten some long variable and type names.

svn path=/trunk/; revision=40656
 2012-01-23 02:36:46 +00:00
Martin Mathieson
7a17238dab Use detailed key for sequence analysis results to avoid overwriting with 
other PDUs info from same frame.  Also:
- initialise next-frame value to 0
- don't show expected-SN when analysis result is 'ok'

svn path=/trunk/; revision=40655
 2012-01-22 20:31:09 +00:00
Martin Mathieson
c585d8de24 Allow sequence analysis to be done either for PDCP frames found in RLC 
frames, or logged at the PDCP level.  Provide a forward link to the next
SN frame for a channel.

svn path=/trunk/; revision=40649
 2012-01-22 03:02:10 +00:00
Bill Meier
439adbdbcc Remove obsolete comments referring to mem_chunks. 
svn path=/trunk/; revision=40507
 2012-01-14 20:14:43 +00:00
Anders Broman
0214486008 Avoid dupliacte entries in col_proto 
svn path=/trunk/; revision=40255
 2011-12-20 19:34:52 +00:00
Guy Harris
33f6b348d1 #if 0 out a bunch of (currently?) unused routines. 
svn path=/trunk/; revision=40219
 2011-12-15 21:03:21 +00:00
Guy Harris
3d3c612706 Clean up indentation. 
svn path=/trunk/; revision=40218
 2011-12-15 21:00:15 +00:00
Anders Broman
8bbb6d5b2a #if 0 now unused variables. 
svn path=/trunk/; revision=40216
 2011-12-15 20:45:06 +00:00
Anders Broman
a106a9047a Call the rohc dissector directly, the code will be cleaned up 
in the next weeks or so.

svn path=/trunk/; revision=40213
 2011-12-15 20:22:54 +00:00
Anders Broman
b2678b43d1 From Per Liedberg: 
RoHC dissection improvment.

svn path=/trunk/; revision=40210
 2011-12-15 17:28:43 +00:00
Anders Broman
9d0fa5cfcb - Change the tree layout to mimic packet-pdcp-lte.c 
- Add IPv6 static chain dissectoin
- Part of IPv6 dynamic chain dissectoin

svn path=/trunk/; revision=40156
 2011-12-12 06:58:37 +00:00
Anders Broman
58221afc41 Fix a couple of warnings. 
svn path=/trunk/; revision=40149
 2011-12-10 13:18:45 +00:00