Commit Graph

1092 Commits

Author SHA1 Message Date
Jeff Morriss 8ec05eb569 Add a small note saying not to use proto_tree_add_text() in new code unless you have a specific reason (like those given in the next paragraphs).
svn path=/trunk/; revision=23011
2007-09-28 13:39:20 +00:00
Jeff Morriss 7efd1b9a76 Add notes suggesting not to use hidden fields but if you're going to, use PROTO_ITEM_SET_HIDDEN() instead of proto_tree_add_*_hidden(). (I thought that was in here already...) Suggest putting fields-you-want-hidden in subtrees where they can be found by ordinary users.
svn path=/trunk/; revision=23010
2007-09-28 13:33:54 +00:00
Gerald Combs 23af5dbf9a Add the -E (encapsulation) flag.
svn path=/trunk/; revision=22987
2007-09-26 15:48:45 +00:00
Stephen Fisher 5775a1dca8 The dissector packet-dcp.c now fails to compile on MacOS X (gcc 4.0.1/Apple). Change G_INLINE_FUNC back to inline per GLib documentation (also remove recommendation in developer's guide to not use inline):
http://library.gnome.org/devel/glib/unstable/glib-Miscellaneous-Macros.html#id2571572

G_INLINE_FUNC

#define             G_INLINE_FUNC
This macro is used to export function prototypes so they can be linked with an external version when no inlining is performed. The file which implements the functions should define G_IMPLEMENTS_INLINES before including the headers which contain G_INLINE_FUNC declarations. Since inlining is very compiler-dependent using these macros correctly is very difficult. Their use is strongly discouraged.

This macro is often mistaken for a replacement for the inline keyword; inline is already declared in a portable manner in the glib headers and can be used normally.


svn path=/trunk/; revision=22980
2007-09-26 03:05:42 +00:00
Guy Harris cd4d203af2 Don't use
case N ... M:

as that's not supported by all compilers.

Say so in the Portability section of README.developer, in the hopes of
discouraging others from using that GCCism.

svn path=/trunk/; revision=22976
2007-09-26 00:41:00 +00:00
Ulf Lamping 35eb028ca4 clarify tshark -B (file format) option
svn path=/trunk/; revision=22968
2007-09-25 21:38:54 +00:00
Bill Meier c387e3fbc9 When -t option: Use current date or time fields for unspecified fields; Fixes bug #1836.
svn path=/trunk/; revision=22916
2007-09-20 16:12:17 +00:00
Ulf Lamping 1366745e45 start an experiment to provide MS Visual Studio 2005 solution / project files for a lot easier debugging. They still use the underlying Makefile.nmake files for the actual build process.
svn path=/trunk/; revision=22831
2007-09-09 13:59:58 +00:00
Gerald Combs 92802883a6 Change the "--enable-setuid-install" option to install dumpcap and TShark
setuid instead of Wireshark.  Remove the "DANGEROUS" notices, but leave it
disabled by default.  Whine if the user runs Wireshark or TShark as root.
Add a preference to disable the whining.  Add a "setuid-root" script that
can be used to switch dumpcap and TShark's setuid-ness on and off for
development and testing.  Update the release notes and README.packaging.

svn path=/trunk/; revision=22733
2007-08-30 00:24:40 +00:00
Gerald Combs a6d76c62a5 Clear out any remaining references to the h223 plugin. Replace the
references to h223 in README.plugins with agentx since it's small and
no one seems to be in a hurry to move it to epan/dissectors. 

svn path=/trunk/; revision=22641
2007-08-24 16:08:31 +00:00
Guy Harris 2305f9e389 Give the full pathname of the wireshark.nsi file, and add information on
what to do for the U3 win32/makefile.nmake file.

svn path=/trunk/; revision=22566
2007-08-21 18:09:33 +00:00
Guy Harris 8ed8be19f3 Add more information on adding a plugin to the NSIS installer.
svn path=/trunk/; revision=22564
2007-08-21 17:59:08 +00:00
Gerald Combs 89a2966ced Add a "-S" flag to dumpcap, which prints out interface statistics. Use
this in the GUI rather than calling pcap_stats() directly. This gets rid
of the last pcap_open_live() call in the GUI code. Update
README.packaging.

svn path=/trunk/; revision=22443
2007-08-02 21:45:27 +00:00
Gerald Combs c02e0c7b4a Remove the "-I" flag from dumpcap, and add a "-M" flag used to specify
that "-D" and "-L" should produce machine-readable output.  Use this to
move an indirect get_pcap_linktype() call from the GUI to dumpcap.

svn path=/trunk/; revision=22367
2007-07-20 21:43:07 +00:00
Gerald Combs 4285f239f0 Add a note about svnversion.h.
svn path=/trunk/; revision=22325
2007-07-16 18:04:53 +00:00
Jaap Keuter b989e08afd Added remark on anonymous unions.
svn path=/trunk/; revision=22294
2007-07-13 06:28:44 +00:00
Jeff Morriss 25df9f2133 From Guillem Hernandez: fix decoding of EOSP bit. From Jaap Keuter: fix description of 'value' in proto_tree_add_boolean() that caused the former bug.
svn path=/trunk/; revision=22293
2007-07-12 22:36:35 +00:00
Jaap Keuter 29b56573a0 Add a note on how to handle obsolete preferences
svn path=/trunk/; revision=22279
2007-07-09 16:44:30 +00:00
Stephen Fisher 2329adaf2d Add a simple entry for -z voip,calls to wireshark man page/html file
svn path=/trunk/; revision=22139
2007-06-19 18:09:50 +00:00
Gerald Combs e9f1a0b692 One more step in privilege separation.
Add a capture_interface_list(), which works similar to
get_interface_list() except that it forks dumpcap instead of calling
the pcap routines directly.  Use it in the GUI.

Add a "-I" flag to dumpcap, which prints out verbose interface
information.

Tested under Windows and Linux.

svn path=/trunk/; revision=22071
2007-06-11 03:58:58 +00:00
Guy Harris 2c1e75d519 Update to reflect the use of G_GINT64_MODIFIER, rather than PRI[douxX],
with GLib routines and the routines that love them.

svn path=/trunk/; revision=21991
2007-05-29 18:59:50 +00:00
Guy Harris 2a5ff70caa Document "-T fields".
svn path=/trunk/; revision=21977
2007-05-29 06:20:03 +00:00
Gerald Combs f0377b44af Add a note about the recent change in "--disable-wireshark" behavior to
the release notes.

Add a couple of updates to the packaging doc.

svn path=/trunk/; revision=21891
2007-05-22 19:05:27 +00:00
Ulf Lamping 530b2735e9 fix -E path setting doc
svn path=/trunk/; revision=21691
2007-05-05 12:17:19 +00:00
Ulf Lamping c32b8d992a add command line option -E for path settings - implemented already weeks ago
svn path=/trunk/; revision=21690
2007-05-05 11:33:32 +00:00
Jeff Morriss a5f4e7b85a Make RX a new style dissector: return 0 if there isn't at least 28 bytes of message or if it receives an unknown Type. Add a check of tvb length to README.developer's cut-n-paste dissector code.
svn path=/trunk/; revision=21300
2007-04-02 08:25:43 +00:00
Ulf Lamping b05d384d71 add a small section, that code should be warning free
svn path=/trunk/; revision=21291
2007-03-31 15:32:06 +00:00
Sebastien Tandel 0ca67aef30 - new ptvcursor subtrees management functions :
* ptvcursor_push_subtree(), ptvcursor_pop_subtree() for pushing/popping
    subtrees. Multiple levels of subtrees (256 max.), allocation per 8 levels.
  * Two new functions creating an item in the tree and pushing a subtree at the
    same time. These two functions accept an undefined length
    (SUBTREE_UNDEFINED_LENGTH). The length of the item is set at the next pop.
        1) ptvcursor_add_with_subtree
	2) ptvcursor_add_text_with_subtree
- get rid of potential memory leaks with g_new in ptvcursor_new().

- Documentation of the new ptvcursor functions in README.developer


svn path=/trunk/; revision=21276
2007-03-30 00:21:39 +00:00
Stephen Fisher 509883e3e9 From Doug Pratley:
The purpose of the patch is to provide a new output format (so it is
independent of -V): single line record per-packet with the fields chosen by the
user, with configuration options to control separator, quoting and whether a
header line is printed. It also extends some existing options behaviour (-c and
-a:filesize) so that they affect reading a file as well as writing one, so that
only the first <n> packets or bytes are read).


svn path=/trunk/; revision=21211
2007-03-26 20:17:05 +00:00
Stephen Fisher 6d8d2854c8 From Sake Blok:
Fix for bug #491: Unexpected frame.time_delta behavior

This patch ... fixes bug 491. It does this by changing the
behaviour of the frame.time_delta field so it reflects the delta
time between captured packets (tshark already did this).  To keep
the delta time between displayed packets, the field 
frame.time_delta_displayed is created.


svn path=/trunk/; revision=21154
2007-03-23 18:08:17 +00:00
Jeff Morriss 62596bffb3 Fix bug 552:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=552

by enforcing that header fields have names of length > 0.  This should fix
the display of those fields and also make them filterable (which was the
subject of the bug).  Abbreviations are (still) optional: if they are empty
then the field is not filterable.

Update README.developer with this information.

Add header field names in several dissectors where they were missing.

In packet-arp.c give "packet-storm-detected" a name (as above) but also set it
as _GENERATED.

Also remove trailing white space from all the files checked in.

svn path=/trunk/; revision=21018
2007-03-11 06:16:00 +00:00
Ulf Lamping acefba187a from Sake Blok:
I have changed the patch according to your suggestions and also changed
the doc[book] files accordingly. I tested the patch and it does seem to
work fine on my test-system.

ULFL: In addition, I've added the en-/disabling to the other (already existing) Copy menu items - some just did nothing, some crashed if nothing was selected.
I've also sligthly changed the menu seperators and made both context menus look a bit more identical.

svn path=/trunk/; revision=21005
2007-03-08 23:37:55 +00:00
Jaap Keuter 88a508d407 From Richard van der Hoff:
I've had a good look at the code in packet-tcp.c, and whilst it's
somewhat impenetrable, I've come to the conclusion that it just doesn't
support multiple pdus as described.

That's not entirely unreasonable in itself; my objection is solely to
the fact that README.developer is completely misleading. In fact, even
the example dissect_cstr won't work on the tcp dissector, because if you
set desegment_len=1 the tcp dissector believes that you know what you
are doing and doesn't let you change your mind later.

Furthermore, 2.7.2 says that you can set desegment_len=-1; that doesn't
work either, because the tcp dissector expects
DESEGMENT_ONE_MORE_SEGMENT, which is 0x0fffffff, which is nowhere near -1.

In short, I think the relevant section of README.developer needs a
rewrite. I attach a patch - comments welcome.

svn path=/trunk/; revision=20974
2007-03-05 20:25:54 +00:00
Jaap Keuter a6817744ae Further cleanup of the document
svn path=/trunk/; revision=20855
2007-02-19 06:24:29 +00:00
Stephen Fisher 371179340e Fix a couple of spelling mistakes
svn path=/trunk/; revision=20840
2007-02-19 00:23:58 +00:00
Jörg Mayer b3fcfe4fd4 Version 0.10.12 was still Ethereal, not Wireshark
svn path=/trunk/; revision=20811
2007-02-14 13:25:08 +00:00
Stephen Fisher aa897723ff From Sebastien Tandel:
Here is an updated patch for proto_tree_add_item and the
range_string structure. The new macro RVALS() can be used as the macro
VALS() in the declaration of your hf_register_info with another
structure (range_string).  Be aware that you *have to* ORed the value of
the field display with BASE_RANGE_STRING constant and it can 'only' be
used with FT_(U)INT* types in a header_field_info.


svn path=/trunk/; revision=20805
2007-02-14 00:39:48 +00:00
Stephen Fisher 0ebc01dc03 From Sebastien Tandel:
Create two new files (ws_strsplit.[ch]) that use GTK2 code to override
the buggy g_strsplit() function when compiling for GTK1.  Include this
work-around function (ws_strsplit) in libwireshark.def.  Add notes on usage
to README.developer.  Include epan/ws_strsplit.h in all files that use
g_strsplit().


svn path=/trunk/; revision=20804
2007-02-13 20:57:22 +00:00
Stephen Fisher a93d280d7a Minor cleanup - spelling fixes, formatting
svn path=/trunk/; revision=20802
2007-02-13 02:06:04 +00:00
Jeff Morriss e166f9c4e6 Explain what 'base' in 'prefs_register_uint_preference()' is: it's used in 'strtoul()'
svn path=/trunk/; revision=20636
2007-01-31 01:59:12 +00:00
Jaap Keuter e4e739a5ca From Graham Bloice:
In the Developers Guide, Section 9.3, Example 9.17. Decompressing data
packets for dissection

The code calls tvb_set_free_cb() for the newly created next_tvb.  This
is unnecessary as the call to tvb_set_child_real_data() adds next_tvb to
the chained list of tvb, thus ensuring that next_tvb is correctly
deleted.  In fact when I had the call in, Visual Studio kept breaking
deep down in ntdll.dll, probably because of a double free every time the
main tvb was deleted.

In README.developer, para 2..2.7 The example conversation code doesn't
assign the result of conversation_new() back into the conversation variable.

svn path=/trunk/; revision=20569
2007-01-26 17:12:00 +00:00
Jaap Keuter 929af1b95b Improve information on building plugins.
svn path=/trunk/; revision=20476
2007-01-18 12:22:21 +00:00
Jaap Keuter f8422ab7db Extending true_false_string support
- Separate tfs.[ch]
- Add larger sample collection
- Properly export DATA

svn path=/trunk/; revision=20373
2007-01-10 07:47:00 +00:00
Guy Harris 44c0624bd9 Add a WIRESHARK_RUN_FROM_BUILD_DIRECTORY environment variable on UN*X;
if set, and if the program isn't running with additional privileges,
it'll treat the directory in which the program is found as the data
directory.

If, on Windows, the version-number subdirectory of {data
directory}\plugins doesn't exist (which is assumed to mean that the
program is being run from the build directory), or if, on UN*X,
WIRESHARK_RUN_FROM_BUILD_DIRECTORY is set, the plugin directory is the
"plugins" subdirectory of the data directory, and all subdirectories of
that directory are scanned for plugins, as the "plugins" subdirectory of
the build directory contains subdirectories for the plugins; this means
that if we're running from the build directory, we'll find the plugins
we built in the build tree.

When generating the wireshark-filter man page, run tshark with
WIRESHARK_RUN_FROM_BUILD_DIRECTORY set, so it uses the plugins from the
build to generate the list of filters.

svn path=/trunk/; revision=20261
2007-01-02 06:49:40 +00:00
Jaap Keuter c0be7a8d28 Updated to describe the current state of plugin development.
svn path=/trunk/; revision=20180
2006-12-20 16:24:19 +00:00
Stephen Fisher 8b8b648ad6 From Stig Bjorlykke:
* Fixed a typo in README.developer


svn path=/trunk/; revision=20132
2006-12-14 00:05:03 +00:00
Stephen Fisher c980cede98 From Francesco Fondelli:
I defined a range_string struct. It's like value_string
but stores range <-> string pairs.
Moreover I wrote rval_to_str(), match_strrval_idx()
match_strrval() which are behaving exactly as
val_to_str(), match_strval_idx() and match_strval().


svn path=/trunk/; revision=20061
2006-12-07 20:29:40 +00:00
Bill Meier e4a99fc4dd Add a few missing /$(MAKEFLAGS)
svn path=/trunk/; revision=20046
2006-12-05 12:36:06 +00:00
Stephen Fisher 75acf34518 From Douglas Pratley with trivial changes and documentation changes
by myself:

Corrected patch; epan/column.c and epan/column_utils.c were not included. This
one has now been properly tested against a clean checkout of today's code.

- New menu option available under view\time display format
- New sub-option (e) to -t switch for both wireshark and tshark
- Extended recent settings code to handle new value
- Did NOT add new explicit epoch time column


svn path=/trunk/; revision=20040
2006-12-05 03:19:51 +00:00
Jeff Morriss 39c6f8bf89 Add documentation of the col_set_fence() and col_prepend_fence_fstr() calls. I *think* I got the description of col_prepend_fence_fstr() right.
svn path=/trunk/; revision=20015
2006-11-29 13:42:16 +00:00