Commit Graph

12212 Commits

Author SHA1 Message Date
Gerald Combs 2efa26e0e1 Fix a double-free bug which was causing a crash. Our decryption buffer
length doesn't change, so allocate it just once. Add an expert item for
a successful decryption.

svn path=/trunk/; revision=31571
2010-01-19 19:28:30 +00:00
Guy Harris 92a3647ac4 Get rid of a dead link, use IETF links for what appear to be the last
I-Ds for PIMv1 (the next version of the dense-mode draft didn't run on
IGMP).

svn path=/trunk/; revision=31568
2010-01-19 18:53:41 +00:00
Gerald Combs 2799a0216f Remove an unused variable. Fixup whitespace.
svn path=/trunk/; revision=31567
2010-01-19 17:40:52 +00:00
Anders Broman 3e1c4ca38a Remove an include.
svn path=/trunk/; revision=31566
2010-01-19 17:21:19 +00:00
Anders Broman 2dfd8a1e8c If user data is xml display it.
svn path=/trunk/; revision=31565
2010-01-19 17:20:17 +00:00
Stig Bjørlykke 174de72350 Moved expert info for bitstring size constraints below bit values.
Enabled bitstring minimum length size check.

svn path=/trunk/; revision=31564
2010-01-19 08:54:13 +00:00
Stig Bjørlykke 6ff81c8f6a Change group for "Unknown bit(s)" expert info to Undecoded.
svn path=/trunk/; revision=31563
2010-01-19 08:11:23 +00:00
Guy Harris 4579732494 Even better - don't use a global variable in the first place, as its
value isn't used outside dissect_sss_request().

Get rid of some unused value_strings while we're at it; they duplicate
value_strings in packet-ncp-nmas.c, and if they're really needed here,
there should probably be only one instance, in, for example, the NCP
dissector.

Get rid of some unused variables, use -1 for "to the end of the tvbuff",
don't use "subverb" unless we've actually fetched its value.

svn path=/trunk/; revision=31562
2010-01-19 01:16:02 +00:00
Bill Meier 9b568ea691 Fix gcc -Wshadow warnings
svn path=/trunk/; revision=31561
2010-01-19 00:37:39 +00:00
Bill Meier c5614625ee Fix some gcc -Wshadow warnings ....
svn path=/trunk/; revision=31559
2010-01-18 23:16:10 +00:00
Bill Meier de4c6ff515 Fix a number of gcc _Wshadow warnings
svn path=/trunk/; revision=31557
2010-01-18 21:49:47 +00:00
Bill Meier 55669f7127 Fix gcc -Wshadow warnings.
[And therefore fixing a benign bug where memory was allocated for sizeof(*p) rather than sizeof(p)].

svn path=/trunk/; revision=31556
2010-01-18 21:37:34 +00:00
Bill Meier b3685a583a Use true_false_strings from tfs.c when possible;
#include stdio, stdlib & string not req'd;
Fix a gcc -Wshadow warnng

svn path=/trunk/; revision=31555
2010-01-18 20:51:13 +00:00
Stig Bjørlykke 10466c4bbe Add expert info to unknown bitstring bits when having a named_bits table.
svn path=/trunk/; revision=31554
2010-01-18 20:08:56 +00:00
Bill Meier 1c11b9571e Use consistent indentation; Reformat a few hf[] array entries.
svn path=/trunk/; revision=31553
2010-01-18 18:00:23 +00:00
Anders Broman 9a030dda05 Get rid of check_col();
svn path=/trunk/; revision=31552
2010-01-17 18:16:06 +00:00
Gerald Combs fd5ca381c5 [Automatic manuf and enterprise-numbers update for 2010-01-17]
svn path=/trunk/; revision=31549
2010-01-17 16:03:29 +00:00
Stig Bjørlykke 1b9b0af135 Added packet-hp-erm.c.
svn path=/trunk/; revision=31548
2010-01-17 14:20:53 +00:00
Bill Meier 05eae470b9 Dissector for HP encapsulated remote mirroring.
svn path=/trunk/; revision=31547
2010-01-17 14:07:03 +00:00
Anders Broman a255c08b66 Get rid of check_col();
svn path=/trunk/; revision=31546
2010-01-17 12:46:00 +00:00
Anders Broman ba8d7bd919 Get rid of check_col();
svn path=/trunk/; revision=31544
2010-01-17 12:19:02 +00:00
Anders Broman 0d3840e704 Update to version 9.1.0
svn path=/trunk/; revision=31543
2010-01-17 09:43:31 +00:00
Stephen Fisher 5531c24c67 Update URL in comments.
svn path=/trunk/; revision=31542
2010-01-16 03:34:07 +00:00
Guy Harris 268345f515 Use G_GSIZE_MODIFIER rather than casting to "gulong" and printing with
"%lu".

svn path=/trunk/; revision=31541
2010-01-16 02:57:42 +00:00
Guy Harris 969b98fa35 tvb_get_ntohl() doesn't return a long on any platform (it returns a
guint32, and on no platform supported by GLib, and thus on no platform
supported by Wireshark, does a guint32 have to be an unsigned long), so
there's no need to cast it to long and print it with %lld.

svn path=/trunk/; revision=31540
2010-01-16 02:39:25 +00:00
Jeff Morriss 508fd83368 Show spare bits in decimal, not as booleans.
svn path=/trunk/; revision=31537
2010-01-15 19:28:28 +00:00
Stig Bjørlykke 5c4ee8a291 Change col_set_str() call to col_add_str() since the string being passed
can be a ep_alloc from val_to_str().

svn path=/trunk/; revision=31536
2010-01-15 14:05:06 +00:00
Stig Bjørlykke 9d918146ff Changed val_to_str() to val_to_str_const() when used with col_set_str().
svn path=/trunk/; revision=31535
2010-01-15 13:51:47 +00:00
Stig Bjørlykke 8255893114 Change col_set_str() call to col_add_str() since the string being passed
can be a ep_alloc from val_to_str().

svn path=/trunk/; revision=31534
2010-01-15 13:40:14 +00:00
Anders Broman 4a38ad658c Get rid of check_col();
svn path=/trunk/; revision=31533
2010-01-15 07:32:04 +00:00
Anders Broman 90bf722451 From Chris Costa:
tcp.analysis.acks_frame and tcp.analysis.ack_rtt is not reliable.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3311

svn path=/trunk/; revision=31532
2010-01-15 07:20:25 +00:00
Anders Broman a230916b8e From Didier Gautheron:
Don't use packet without data in sequence analysis.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2054

svn path=/trunk/; revision=31531
2010-01-15 07:07:28 +00:00
Gerasimos Dimitriadis a72447c0da Avoid assertion failure when adding a column of type
IEEE 802.11 TX rate.

svn path=/trunk/; revision=31527
2010-01-14 18:30:57 +00:00
Gerasimos Dimitriadis fe1e9d6296 Fix for Bug 3747:
use FT_FLOAT for the radiotap data rate because of .5 Mbps granularity

svn path=/trunk/; revision=31526
2010-01-14 18:21:09 +00:00
Gerald Combs 0e3ba74734 Fix several buffer overflows found by babi babi. Replace a lot of manual
fetching and displaying with proto_tree_add_item().

Use get_dns_name() instead of lwres_get_dns_name(), which fixes a separate
issue.

svn path=/trunk/; revision=31524
2010-01-14 01:22:00 +00:00
Anders Broman 69b7a06578 Remove redundant calls to check_col() in the .cnf files and regenerate.
svn path=/trunk/; revision=31523
2010-01-13 21:41:28 +00:00
Michael Tüxen c273169cbd Display correct chunk type for unknown chunks.
svn path=/trunk/; revision=31522
2010-01-13 21:31:24 +00:00
Anders Broman 04d526a914 check_col.diff
Remove redundant calls to check_col() in the template files and regenerate.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31521
2010-01-13 21:27:44 +00:00
Anders Broman 526891f1b4 From Didier Gautheron:
fix a memory leak by using se_strdup rather for g_strdup for column text.
replace col_clear() follow by col_add_str() with the faster col_set_str()
remove redundant check_col() call

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31520
2010-01-13 21:16:46 +00:00
Anders Broman 440c3f9261 From Didier Gautheron:
check_col.diff
Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31519
2010-01-13 20:32:01 +00:00
Anders Broman 6343ffb68e Try to fix indentation sligtly.
svn path=/trunk/; revision=31518
2010-01-13 20:26:17 +00:00
Anders Broman c4dd31cd87 From Didier Gautheron:
col_clear.diff 
Remove calls to col_clear :
- called twice.
- before functions which also clear the column
- by replacing col_clear + col_append_xxx with col_add_xxx
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31517
2010-01-13 20:25:10 +00:00
Anders Broman 253ce6255d Try to fix a memory leak.
svn path=/trunk/; revision=31514
2010-01-13 16:35:50 +00:00
Anders Broman 0a5a3c1158 From Didier Gautheron:
Fix a memory leak.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3917

svn path=/trunk/; revision=31511
2010-01-13 07:42:42 +00:00
Stig Bjørlykke 86a6a0c2a4 Use a more correct length for hf_bssgp_ie_type and hf_bssgp_bvci,
to try fixing a buildbot run-randpkt failure.

svn path=/trunk/; revision=31509
2010-01-12 21:25:35 +00:00
Anders Broman 8dea26e52c From Gonzalo Casas:
MMS TimeOfDay display.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4387

svn path=/trunk/; revision=31508
2010-01-12 20:15:24 +00:00
Anders Broman 1f6a39eae9 Use g_snprintf()
svn path=/trunk/; revision=31507
2010-01-12 20:08:30 +00:00
Martin Mathieson d5c96e34e7 Use snprintf() to pass checkAPI
svn path=/trunk/; revision=31506
2010-01-12 18:43:18 +00:00
Martin Mathieson 23c5730798 Append to the SDU field only once (instead of for each byte!).
svn path=/trunk/; revision=31503
2010-01-12 16:12:27 +00:00
Stig Bjørlykke 3d32eed0b5 Update to RFC5035.
svn path=/trunk/; revision=31502
2010-01-12 14:31:08 +00:00