Commit graph

5051 commits

Author SHA1 Message Date
Ronnie Sahlberg
be579f8bb2 there wre two fields in smb for filenames with the same display filer string.
rename one of them to a different name so filtering works reliably


svn path=/trunk/; revision=21855
2007-05-21 03:07:25 +00:00
Anders Broman
eef2203f38 Update MAP_DialoguePDU to 3GPP TS 29.002 V8.1.0 (2007-03) update makefiles and
rename the asn file.

TCAP ad Id and update makefiles.

svn path=/trunk/; revision=21845
2007-05-20 21:19:48 +00:00
Jörg Mayer
a066b97ac9 Remove cvs2svn:cvs-rev property
Remove forward declaration of proto_reg_handoff_gdsdb
  (this is just a hack to suppress a warning that needs
  a proper solution for many many more files)

svn path=/trunk/; revision=21844
2007-05-20 20:41:48 +00:00
Jörg Mayer
20796b0120 Môshe van der Sterre:
Replace the Interbase dissector by a Firebird/Interbase
	dissector.

Me:
	Fix warnings about unused parameters
	Fix warnings about unused variables
	Fix warning about unused function
	Fix warning about mixed code and declaration
	Declare all dissection functions static
	Remove function declarations and move the switching
		function down instead.
	Update AUTHORS file
	Add $Id$ and email address to file header
	Fix filename in first comment line

svn path=/trunk/; revision=21843
2007-05-20 20:26:17 +00:00
Guy Harris
55419bedf4 Make the SliMP3 dissector a "new-style" dissector, so it rejects packets
that don't look like SliMP3 packets.  This fixes bug 1259 (at least for
the packet in the bug).

svn path=/trunk/; revision=21839
2007-05-19 22:33:42 +00:00
Guy Harris
e62e5e3b25 There's more than one IE table; instead of fixing up all the IE tables
with default IE names, have bssgp_proto_tree_add_ie() use val_to_str()
if the IE table doesn't have an IE name.

Don't use the IE name as a format; use "%s" as the format, and the IE
name as the argument.  (That more clearly states what's being done.)

svn path=/trunk/; revision=21837
2007-05-19 21:22:05 +00:00
Gerald Combs
55d2b928c2 From Dustin Johnson:
- Update the wireless/AirPcap GUI code to support 802.11n as well as
    some related upcoming code changes.
  - Remove airpcap.h from the repository, since it exists in the AirPcap
    devpack (and will be superseded Real Soon Now).
  - Show the individual channel flag bits in radiotap.
  
Fix the 802.11n MCS set display.

This is a partial checkin, so hopefully nothing is broken.

svn path=/trunk/; revision=21831
2007-05-18 21:06:20 +00:00
Anders Broman
86ba8937c7 Use proto_tree_add_bits_ret_val and proto_tree_add_bits_item().
svn path=/trunk/; revision=21830
2007-05-18 18:14:09 +00:00
Martin Mathieson
ceb34bc72a - show service val in protocol tree label (there can be multiple of them)
- use fences so that multiple summaries can appear together in the info column

svn path=/trunk/; revision=21829
2007-05-18 17:25:26 +00:00
Anders Broman
b688f9154a Split tvb_get_bits64 into tvb_get_bits8 tvb_get_bits16 tvb_get_bits32 and tvb_get_bits64
and use them in proto_tree_add_bits_ret_val().

svn path=/trunk/; revision=21828
2007-05-18 16:46:35 +00:00
Tomas Kukosa
16c1010894 RRLP updated to 3GPP TS 44.031 V7.4.0 (2007-03)
svn path=/trunk/; revision=21825
2007-05-18 12:53:55 +00:00
Ronnie Sahlberg
db3711d720 this error is returned in srvsvc when a SessDel fails because no matching session can be
found


svn path=/trunk/; revision=21823
2007-05-18 05:25:31 +00:00
Ronnie Sahlberg
c6addcd89f add a new dos error code
svn path=/trunk/; revision=21809
2007-05-17 01:19:26 +00:00
Martin Mathieson
ae673b5b38 Allow Via sigcomp-id parameter name to be matched properly.
svn path=/trunk/; revision=21804
2007-05-16 14:24:13 +00:00
Tomas Kukosa
2251e35514 RNSAP updated to V7.4.0 (2007-03)
svn path=/trunk/; revision=21803
2007-05-16 13:41:54 +00:00
Ronnie Sahlberg
2c0a600046 from metze
prettify dissection of multiple chained smb2 pdus in one frame


svn path=/trunk/; revision=21801
2007-05-16 06:50:19 +00:00
Tomas Kukosa
2054f1302a use some by mistake unused types
remove unused variables and types

svn path=/trunk/; revision=21800
2007-05-16 06:30:45 +00:00
Ronnie Sahlberg
f7aba27936 start prettifying SRVSVC
svn path=/trunk/; revision=21799
2007-05-16 01:06:30 +00:00
Ronnie Sahlberg
417b366bcd we must provide a hfinfo field when dissecting a dcerpc integer or else
we might get a dissector bug assert and fail to dissect the blob


svn path=/trunk/; revision=21797
2007-05-15 23:30:03 +00:00
Ronnie Sahlberg
99c98d6c6e when spawning off to the next smb2 pdu in a chain we need to create a
new tvb for it    or else the offset/length calculations for where blobs 
a		next_tvb=tvb_new_subset(tvb, chain_offset, MIN((int)len, 
tvb_length_remaining(tvb, off)), len);
re in the packets are wrong.



svn path=/trunk/; revision=21795
2007-05-15 20:46:45 +00:00
Ronnie Sahlberg
827df92fb1 add dissection of the end_of_chain bit in the header flags
svn path=/trunk/; revision=21794
2007-05-15 20:33:44 +00:00
Ronnie Sahlberg
9498ad3a2d from metze
patch to find and enhancement of extra_info handling


svn path=/trunk/; revision=21793
2007-05-15 20:13:30 +00:00
Ronnie Sahlberg
0977ea7e74 from metze
add support for smb2 chaining

rename sessionsetupandz to sessionsetup


svn path=/trunk/; revision=21792
2007-05-15 20:07:58 +00:00
Martin Mathieson
198f8f8185 Fix problem from previous commit (confused myself with FT_UINT_STRING needing length of 1 when adding to tree...), and show display-name in info column.
svn path=/trunk/; revision=21790
2007-05-15 15:26:13 +00:00
Martin Mathieson
dc9745267b TBCP fixes:
- more careful checking of packet length
- skip padding at end of SDES items block
- formatting

svn path=/trunk/; revision=21789
2007-05-15 14:49:26 +00:00
Tomas Kukosa
783da34c50 get rid of the rest of dummy ASN.1 code and switch()
svn path=/trunk/; revision=21787
2007-05-15 12:53:04 +00:00
Ronnie Sahlberg
a944d1a3e8 since the fid dissector helper now adds a lot of extra info to the tree
we must now pass it a (semi-)valid tvb.


svn path=/trunk/; revision=21783
2007-05-15 09:48:02 +00:00
Tomas Kukosa
a0ee5100c4 ULP regenerated from OMA UserPlane Location Protocol Candidate Version 1.0 – 22 Jan 2007
svn path=/trunk/; revision=21778
2007-05-15 08:26:18 +00:00
Tomas Kukosa
35da9bda8a support for value range and unions in permitted alphabet
svn path=/trunk/; revision=21777
2007-05-15 08:15:34 +00:00
Ronnie Sahlberg
a190cecf66 prettify the server_name component of NetWkstaTransportEnum
svn path=/trunk/; revision=21776
2007-05-15 08:12:10 +00:00
Anders Broman
f08cd1e5e3 actx in the rest of dissect_ber..()l
svn path=/trunk/; revision=21773
2007-05-15 05:49:43 +00:00
Jaap Keuter
792e51d00a Attempt to fix bug 1360.
Remove calls to tvb_free on subsets, since this seems to upset the tvb administration(!?)

svn path=/trunk/; revision=21772
2007-05-14 20:55:11 +00:00
Gerald Combs
b482e10da4 From Dustin Johnson: Fix a couple of spelling errors. Normalize the display
of A-MPDU and A-MSDU trees.

svn path=/trunk/; revision=21771
2007-05-14 18:27:47 +00:00
Tomas Kukosa
6f83c76235 remove packet-rnsap.h which was empty
svn path=/trunk/; revision=21766
2007-05-14 15:00:08 +00:00
Martin Mathieson
750959bb3d - give NACK reason codes in hex rather than decimal
- minor prettifications

svn path=/trunk/; revision=21764
2007-05-14 14:23:52 +00:00
Tomas Kukosa
52b3c8baf4 fix packet-per.c:155: warning: 'val_tvb' may be used uninitialized in this function
svn path=/trunk/; revision=21763
2007-05-14 14:17:42 +00:00
Tomas Kukosa
c388131e82 - RNSAP regenerated from the last specification Release 6 V6.13.0 (2007-03)
(original unchanged ASN.1 source could be used because asn2wrs has been improved)
- IE value switch(){} replaced with dissector table
  (some switch() and dummy CHOICE still remains but will be removed soon)

svn path=/trunk/; revision=21761
2007-05-14 14:11:43 +00:00
Tomas Kukosa
25c299ea4e - support of constraint unions
- support of FN_VARIANT parameter for OpenType
- many small changes

svn path=/trunk/; revision=21758
2007-05-14 13:46:09 +00:00
Tomas Kukosa
61ffcf48a9 - more variants of dissect_per_open_type_*()
- move asn1_get_real() to asn1.c/.h

svn path=/trunk/; revision=21757
2007-05-14 13:39:31 +00:00
Ronnie Sahlberg
fc5ce01ee4 replace an incorrect '{' with ';' in the ber header file
change the signature for dissect_ber_external_type() to only provide the 
parameter actx once


svn path=/trunk/; revision=21756
2007-05-13 22:19:04 +00:00
Anders Broman
0bc558f88d actx in ber_external
svn path=/trunk/; revision=21755
2007-05-13 22:01:17 +00:00
Anders Broman
0a0a913a01 Try to make the buildbot happy.
svn path=/trunk/; revision=21754
2007-05-13 21:54:45 +00:00
Anders Broman
c01f382974 Second step in introducing asn context to BER dissectors just like in PER.
svn path=/trunk/; revision=21753
2007-05-13 20:58:29 +00:00
Jaap Keuter
b80cb43018 From bug 1492: Fortify layer name presentation.
Some code cleanups.

svn path=/trunk/; revision=21752
2007-05-12 19:54:55 +00:00
Gerald Combs
797545d2e5 Fix a bunch of spelling errors.
svn path=/trunk/; revision=21751
2007-05-12 00:01:57 +00:00
Gerald Combs
6c940e0714 implented -> implemented.
svn path=/trunk/; revision=21749
2007-05-11 22:51:48 +00:00
Gerald Combs
790061f5c7 Add separate filters for vendor-specific HT items.
svn path=/trunk/; revision=21748
2007-05-11 15:52:13 +00:00
Jaap Keuter
caa79282d8 Fix for bug 1545.
Add a preference to support BVLC on non standard UDP port.

svn path=/trunk/; revision=21747
2007-05-11 06:31:22 +00:00
Anders Broman
2427e6390d From Andrew Feren:
This patch collapses start and end time for each flow to a single duration item.  The duration item can, of course, be expanded to display the start and end time.

svn path=/trunk/; revision=21746
2007-05-11 06:21:18 +00:00
Ronnie Sahlberg
ff35bf2ca1 make create_options, access_mask and share_access fitlerable
svn path=/trunk/; revision=21745
2007-05-11 03:02:38 +00:00
Ronnie Sahlberg
f43afbaf35 add more tracking of FID properties
track create_flags, access_mask, file_attributes, share_access and 
create options for all FIDs


svn path=/trunk/; revision=21743
2007-05-10 20:53:35 +00:00
Martin Mathieson
6c310715bd - show NACK summary in info column
- calculated and show compression ratio achieved
- show some fields as being generated

svn path=/trunk/; revision=21742
2007-05-10 16:49:00 +00:00
Martin Mathieson
ef3f75d6df Make dhcpv6 findable by name.
svn path=/trunk/; revision=21740
2007-05-10 10:56:36 +00:00
Ronnie Sahlberg
e5e23150ab prettify dissection of FIDs,
put the filename, if known, on the fid expansion line

also place a "generated" fid in failed ntcreateandx so it is easier to 
quickly see which file the ntcreateandx failed for


svn path=/trunk/; revision=21739
2007-05-10 02:34:06 +00:00
Jaap Keuter
4fef1c31c1 Fix for bug 1497.
Set DSCP_VALUE column info without tree to support export operations.

svn path=/trunk/; revision=21738
2007-05-09 22:27:39 +00:00
Graham Bloice
bb61f339ed Cast values to correct sizes for number of bits to squelch Win32 warnings
svn path=/trunk/; revision=21737
2007-05-09 09:33:44 +00:00
Guy Harris
636807c1ce Unless I've missed something, the number of subframes can be as many as
16 (4 bits, 0-origin, so that's 15 + 1 as the maximum).

svn path=/trunk/; revision=21733
2007-05-09 03:50:58 +00:00
Jaap Keuter
bf55e2cf1d Fix for bug 1103:
1. in dissect_routing6() if (rt.ip6r_type == 2) set pinfo->dst to the Home Address.
2. dissect_mipv6_hoa() set the pinfo->src to the Home Address.

svn path=/trunk/; revision=21732
2007-05-08 22:25:03 +00:00
Stephen Fisher
937b925cf5 From Victor Fajardo:
The packet-pana.c dissector I have submitted previously [SVN rev 21447]
had a minor issue. The following are the fixes:
 
Change packet-pana.c, Line 823:

                       { "Ping","pana.flags.e",
 
to:
 
                       { "Error","pana.flags.e",
 

svn path=/trunk/; revision=21731
2007-05-08 19:33:24 +00:00
Stephen Fisher
1d114f469c Fix for bug #1532 -
From Kenneth Golomb:

Fixes two issues:
1) interface_name is allocated iface_len+1 bytes but a buffer length of iface
len is passed in when the string is copied.  This truncates the string to 9
characters if the interface_name is 10 characters long.

2) interface_name added to tree with proto_tree_add_string_format and is
missing the initial value parameter when called.  Even if this is added the
field can not be filtered on.  Adding the field with proto_tree_add_item fixes
both the tree display and the filtering issues.


svn path=/trunk/; revision=21730
2007-05-08 19:11:33 +00:00
Martin Mathieson
ab32895f34 Use new 'unknown' value for dch_crc_present for EDCH channels.
svn path=/trunk/; revision=21728
2007-05-08 17:19:18 +00:00
Martin Mathieson
aac8ca1355 From Kriang Lerdsuwanakij:
This patch adds the handling of Spare Extension bytes
to UMTS Frame Protocol.  It also handles the case when
the presence of CRC in dedicated channels is not known
(i.e. when FP from a K12/K15 log is dissected).

The new functionality is placed in the new function
"dissect_spare_extension_and_crc".  The "dch_crc_present"
field inside "struct fp_info" (file packet-umts_fp.h)
is also extended to handle the case of unknown CRC presence.

Much of other changes is to update "offset" variable and
return it so that the location of Spare Extension and CRC
is available.

The patch also include a small tweak to handle Frame
Protocol information saved from K15.  Some fields appear
8 bytes later compared to K12.  The changes are in the file
packet-k12.c.

svn path=/trunk/; revision=21726
2007-05-08 17:13:14 +00:00
Gerald Combs
965fda1995 Add NULL dereference checks. Fixes Coverity CID 241.
svn path=/trunk/; revision=21724
2007-05-08 16:18:59 +00:00
Ronnie Sahlberg
f133d28663 prettify wkssvc dissection using the conformance file and generate the
dissector again using a new version of pidl


svn path=/trunk/; revision=21723
2007-05-08 03:30:14 +00:00
Ronnie Sahlberg
d71ee1a0e5 update PIDL_dissect_cvstring so that it can be used in a future pidl to
prettify strings


svn path=/trunk/; revision=21722
2007-05-08 00:04:51 +00:00
Gerald Combs
e2733321e9 Bug fixes and cleanup from Dustin Johnson and myself:
- Remove unused hf_block_ack_ssc code.
  - Fix +HTC detection and frame length calculation.
  - Fix Channel Width dissection.
  - Fix Primary Channel dissection.
  - Tweak the TID field width.
  - Display the Block Ack Buffer Size as decimal.
  - Display the SSC fragment and sequence numbers as decimal.
  - Fix the spelling of "recommended".

svn path=/trunk/; revision=21721
2007-05-07 21:57:05 +00:00
Ronnie Sahlberg
b183abad3e update the conformance file for winreg to specify that the string for
OpenKey keynames should be saved/stored in the dcv structure.

this now makes all policy handles generated by the OpenKey function show
OpenKey(/path/keyname)
for all such policyhandles


svn path=/trunk/; revision=21720
2007-05-07 19:23:59 +00:00
Ronnie Sahlberg
50a23f1970 when creating a policy handle, use the string stored in dcv if
available as the name of the handle

This means we can show policy handles like
OpenKey(/a/b/c/d)
instead of 
OpenKey(<...>)




svn path=/trunk/; revision=21719
2007-05-07 19:21:37 +00:00
Ronnie Sahlberg
e19938fb0b using latest version of pidl, which includes the required pragmas and
which also handles TYPE and PARAM_VALUE for strings,   regenerate winreg 
after using hte conformance file to prettify how and where strings are 
to be used to decorate the summary line and the dissection tree


svn path=/trunk/; revision=21717
2007-05-07 18:35:28 +00:00
Tomas Kukosa
a38b44a647 - simple Information Objects support
- all definitions in ASN.1 source are skipped and need not to be commented out
  - #.CLASS directive can define types for Object Class Fields
- do not append 'xxx' postfix to parametrized types (changes H.235 and H.450 in accordance with it)
- change QSIG ASN.1 source to be more identical to original one

svn path=/trunk/; revision=21715
2007-05-07 12:59:31 +00:00
Tomas Kukosa
a8c10b431f changes in external structure of asn1_ctx_t
svn path=/trunk/; revision=21714
2007-05-07 11:25:21 +00:00
Ronnie Sahlberg
0eae1cc0bd add dissection of smb1 ioctl data by tying it into the dissectors for
ioctl data that already exists for smb2


svn path=/trunk/; revision=21713
2007-05-07 09:07:29 +00:00
Ronnie Sahlberg
34afdc5fc3 change the smb2 ioctl function to take a pointer to a uint32 (ioctl
function code) instead of a structure

extend the nt trans structure to contain a ioctl function code for smb1


svn path=/trunk/; revision=21712
2007-05-07 08:11:59 +00:00
Ronnie Sahlberg
bda722d3bf remove the ioctl function and table from the smb dissector and just use
the one in smb2 instead since the smb2 one is more developed.


svn path=/trunk/; revision=21711
2007-05-07 07:41:35 +00:00
Ronnie Sahlberg
731485ecc4 there were missing #defines in the header file that prevented it from
compiling properly

update the headerfile from a freshly generated one from pidl


svn path=/trunk/; revision=21708
2007-05-07 06:26:39 +00:00
Anders Broman
fd108518ed _U_ mark some parameters and a forgotten file.
svn path=/trunk/; revision=21706
2007-05-07 05:35:45 +00:00
Anders Broman
4c692a62b6 Start introducing actx to ber functions.
svn path=/trunk/; revision=21705
2007-05-06 22:34:05 +00:00
Graeme Lunt
01fa6378eb Better column information display for delivery reports.
svn path=/trunk/; revision=21700
2007-05-06 16:38:04 +00:00
Ulf Lamping
302f45549f add CBA_E_INVALIDID
svn path=/trunk/; revision=21699
2007-05-06 12:07:44 +00:00
Graeme Lunt
2e96e3fe55 Separate field for the elements of a constructed OCTET STRING.
svn path=/trunk/; revision=21695
2007-05-06 08:18:44 +00:00
Ulf Lamping
0bea95c152 disable warning 4005 *again*
svn path=/trunk/; revision=21688
2007-05-05 10:11:06 +00:00
Anders Broman
334177b096 Show BER internal fields in external type in ACSE, update a comment in packet-ber.c.
svn path=/trunk/; revision=21685
2007-05-04 20:27:43 +00:00
Guy Harris
2447ba1de6 Once is enough. :-)
That should get rid of warnings in packet-ber.c; add it to the list of
clean dissectors, to try to keep it clean.

svn path=/trunk/; revision=21684
2007-05-04 18:56:59 +00:00
Tomas Kukosa
bbe6caca6b - Q.932: fix warnings
- RNSAP: generate field functions only for necessary types 
- other dissectors regenerated

svn path=/trunk/; revision=21683
2007-05-04 13:33:35 +00:00
Tomas Kukosa
176949badb missing packet-t30.h file
svn path=/trunk/; revision=21679
2007-05-04 09:48:06 +00:00
Tomas Kukosa
180f915bef fix few warnings in Q.932 and QSIG dissectors
svn path=/trunk/; revision=21677
2007-05-04 07:51:19 +00:00
Tomas Kukosa
cfa43d6daa generate T.38 dissector from ASN.1 source
svn path=/trunk/; revision=21676
2007-05-04 07:10:15 +00:00
Anders Broman
141674620e Fix a copy paste error.
svn path=/trunk/; revision=21674
2007-05-04 06:41:55 +00:00
Anders Broman
386af8e774 From Olivier Montanuy:
Patch tested against traces obtained from Cisco IOS 12.4 Flexible Netflow,
IOS-XR 3.3, Huawei VRP 5.30.

Features:
- Decodes Netflow v9 option templates
- Decodes quite a few additional Netflow v9 types
- Packets and octets counters can be 64-bit
- Show unknown Netflow v9 fields as hexa, useful when using tshark -V with
  Netflow v9 implementations that use undocumented proprietary types.
  Enabled by:  "#define SHOW_UNKNOWN_TYPES 1"

svn path=/trunk/; revision=21672
2007-05-04 06:07:30 +00:00
Anders Broman
98cb9db12d Split out asn1 common functions. Start of BER EXTERNAL.
svn path=/trunk/; revision=21670
2007-05-03 21:52:57 +00:00
Ronnie Sahlberg
d21de3799a use the latest version of PIDL to regenerate winreg using the new TYPE
conformance file directive to replace winreg_String with our own code.

PARAM_VALUE does not yet work for this however which needs to looked 
into


svn path=/trunk/; revision=21669
2007-05-03 19:58:04 +00:00
Anders Broman
fdb44d8bb4 Show internal ber fields for tagged type if pref. set.
svn path=/trunk/; revision=21668
2007-05-03 19:56:13 +00:00
Anders Broman
f16eb4e369 Dissect returnedFunction.
svn path=/trunk/; revision=21667
2007-05-03 19:55:22 +00:00
Gerald Combs
c1688f5612 Check for an infinite loop while processing cipher suites. Fixes bug 1582.
Add release notes for the SSL and display filter macro bugs.

svn path=/trunk/; revision=21665
2007-05-03 16:59:13 +00:00
Tomas Kukosa
a70a1b3eb6 EXTERNAL type is handled in asn2wrs now
private implementations were renamed EXTERNAL -> EXTERNALt

svn path=/trunk/; revision=21662
2007-05-03 11:37:47 +00:00
Tomas Kukosa
6e491e8c3b REAL type support
svn path=/trunk/; revision=21658
2007-05-03 09:15:04 +00:00
Gerald Combs
bb76982d2c Add a routine to dissect the MCS Set. Add a tree for the MCS Set
Rx Bitmask.  "Steams" -> "Scheme".

svn path=/trunk/; revision=21654
2007-05-02 23:26:33 +00:00
Luis Ontanon
49e49452dd fix warnings in debug code
svn path=/trunk/; revision=21652
2007-05-02 20:37:25 +00:00
Guy Harris
cbea9dd75b Check for read failures, and report them (and don't parse the key list
if we get one).

svn path=/trunk/; revision=21650
2007-05-02 19:46:05 +00:00
Jaap Keuter
e51904c765 Fix the windows build by changing uint32_t into guint32.
svn path=/trunk/; revision=21648
2007-05-02 18:42:53 +00:00