Commit Graph

90 Commits

Author SHA1 Message Date
Anders Broman 3123ecf3e4 Add "End Marker" get rid of the .h file as no one imports anything.
(Leave the .h file for a while).

svn path=/trunk/; revision=33367
2010-06-29 08:06:13 +00:00
Jeff Morriss 729de1a635 As suggested in http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html
(as referenced in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2907 ) and
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3411 :

Write a new convenience routine for finding a conversation and, if it is not
found, create it.  The frame number and addresses are taken from pinfo (as is
the common case).

Use this function in a bunch of dissectors.

svn path=/trunk/; revision=32790
2010-05-13 18:28:34 +00:00
Bill Meier 10ffd14b8f Indentation & whitespace cleanup (including: "4 space tabs" ==> spaces)
svn path=/trunk/; revision=32735
2010-05-10 15:54:57 +00:00
Anders Broman a0f2f56ec8 Dissect 3GPP AVP 5 3GPP-GPRS Negotiated QoS profile.
svn path=/trunk/; revision=32622
2010-05-01 14:58:03 +00:00
Anders Broman 99054f9413 From Tamas Regos:
Another bug in packet-gtp.c (mask of Signalling Indication)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4694

svn path=/trunk/; revision=32510
2010-04-19 06:02:56 +00:00
Anders Broman 64a8ae8676 From Tamas Regos:
Harmless typo and whitespace bugs in packet-gtp.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4677
(didn't apply cleanly so partly applied by hand).

svn path=/trunk/; revision=32474
2010-04-15 17:58:54 +00:00
Bill Meier 69df32fb11 #include <string.h> not needed.
svn path=/trunk/; revision=32411
2010-04-06 22:09:47 +00:00
Bill Meier 09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Guy Harris b395a98305 Squelch a bunch of compiler warnings.
svn path=/trunk/; revision=31961
2010-02-23 04:35:23 +00:00
Anders Broman 0c5dfd7698 Target Identification shall be coded as TLV IE where value is
coded as TargetRNC-ID.
Proposed fix to
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3974
(The enclosed trace dioes not decode properly but may be wrongly encoded).

svn path=/trunk/; revision=29816
2009-09-09 07:29:41 +00:00
Kovarththanan Rajaratnam 8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining()
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Gerald Combs 1f3776bf8b Add some length checks.
svn path=/trunk/; revision=29388
2009-08-11 23:29:21 +00:00
Kovarththanan Rajaratnam 0a5b014cec Don't guard col_clear with col_check
svn path=/trunk/; revision=29344
2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Anders Broman 7b8cdbe44f Restore hf_gtp_ext_rat_type as it's used in decode_gtp_rat_type().
Fix IMEI(SV) While we're at it.

svn path=/trunk/; revision=29053
2009-07-10 12:26:39 +00:00
Bill Meier 59cc6f3e61 packet-gtp: 3GPP AVP custom VSA dissection no longer required for 3GPP-RAT-Type attribute.
3GPP-RAT-Type values are now defined in the Radius dictionary.3gpp file.

svn path=/trunk/; revision=29039
2009-07-09 16:02:34 +00:00
Stig Bjørlykke 0437f102c3 From Kovarththanan Rajaratnam:
More FT_XXX cleanup.

svn path=/trunk/; revision=28971
2009-07-07 09:02:59 +00:00
Anders Broman 2555dcfb74 Revert(Try to fix indentation a bit.)
svn path=/trunk/; revision=28821
2009-06-23 14:16:28 +00:00
Anders Broman 6738ccefeb Try to fix indentation a bit.
svn path=/trunk/; revision=28820
2009-06-23 13:49:46 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Stig Bjørlykke fc3f1b5283 From Artem Tamazov (bug 3472):
Save/Restore pinfo->private_data when used.

svn path=/trunk/; revision=28412
2009-05-19 17:16:14 +00:00
Anders Broman ca3cca594a Update a comment.
svn path=/trunk/; revision=28309
2009-05-08 18:11:39 +00:00
Anders Broman 0416dd2457 Inital GTPv2 dissector.
svn path=/trunk/; revision=27414
2009-02-10 21:57:56 +00:00
Bill Meier da3959145e Fix some indentation .....
svn path=/trunk/; revision=27307
2009-01-27 00:54:09 +00:00
Bill Meier c544c20956 Fix various typos and spelling errors (mostly in text strings)
svn path=/trunk/; revision=27050
2008-12-18 19:08:49 +00:00
Bill Meier a8f30cbca1 Fix some typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27037
2008-12-17 17:23:37 +00:00
Anders Broman f050d5a949 Add a cople of IE's
svn path=/trunk/; revision=26975
2008-12-12 20:36:57 +00:00
Stig Bjørlykke bd08ae7ee6 Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26647
2008-10-31 15:11:57 +00:00
Jaap Keuter 73cd38c1bd Fix an assignment which is intended as a comparison.
svn path=/trunk/; revision=26529
2008-10-23 19:57:19 +00:00
Anders Broman b3256e6d44 Fix:
cc1: warnings being treated as errors
packet-gtp.c: In function ‘decode_qos_umts’:
packet-gtp.c:3725: error: ‘guar_dl_ext’ may be used uninitialized in this function
packet-gtp.c:3722: error: ‘max_dl_ext’ may be used uninitialized in this function
packet-gtp.c:3725: error: ‘guar_ul_ext’ may be used uninitialized in this function
packet-gtp.c:3722: error: ‘max_ul_ext’ may be used uninitialized in this function
packet-gtp.c:3726: error: ‘sig_ind’ may be used uninitialized in this function
packet-gtp.c:3726: error: ‘src_stat_desc’ may be used uninitialized in this function
make[4]: *** [libdissectors_la-packet-gtp.lo] Error 1

svn path=/trunk/; revision=26528
2008-10-23 19:44:07 +00:00
Anders Broman 2ff51cb037 Update the QoS IE
svn path=/trunk/; revision=26526
2008-10-23 19:22:54 +00:00
Anders Broman cee238507d From Kari Tiirikainen:
Req/resp tracking and service response time stats for GTP-C

svn path=/trunk/; revision=26361
2008-10-06 20:11:44 +00:00
Bill Meier 802f4452b4 Minor cleanup related to proto_reg_handoff ....
svn path=/trunk/; revision=26176
2008-09-11 14:07:02 +00:00
Bill Meier 8d9c5d9b2b Cleanup related to prefs & proto_reg_handoff
svn path=/trunk/; revision=26124
2008-09-02 21:40:46 +00:00
Anders Broman 6c7b56081c Handle extension header.
svn path=/trunk/; revision=26119
2008-09-02 18:27:33 +00:00
Anders Broman 798fe6acca From Andrei Slavoiu:
TS 29.060 v7.8.0 and later specify new flags in the Common Flags IE:
bit 5 - No QoS Negotiation
bit 6 - NRSN
bit 7 - Upgrade QoS Supported

The current Wireshark implementation has bits 5 and 6 reversed. Attached patch
fixes this issue.

svn path=/trunk/; revision=26084
2008-08-25 20:05:26 +00:00
Anders Broman 45b2e37a27 FromVincent Helfre:
A patch for the PS handover XID parameters Information element, which uses the sndcp-xid dissector.

svn path=/trunk/; revision=25934
2008-08-05 18:49:02 +00:00
Anders Broman 96aa45646d First step to split the gsm_a dissector into several smaller ones ( done by Neil Piercy)
rename the "old" one to gsm_a_common.

svn path=/trunk/; revision=25915
2008-08-04 16:11:17 +00:00
Jaap Keuter 816a7f1cc8 Fix for bug 2618:
Add MS Time Zone interpretation.

svn path=/trunk/; revision=25478
2008-06-18 19:59:24 +00:00
Guy Harris 6d61024a55 Don't peek inside the column information and manually wrap "GTP < ... >"
around the protocol field, use the standard routines for prepending to
and appending to a column.  That should fix bug 2311, as the standard
routines use g_strlcat(), and should also keep that code robust in the
face of changes to the way columns are implemented.

svn path=/trunk/; revision=24502
2008-02-29 03:32:58 +00:00
Anders Broman d6aea2d0a1 - Add application Id:s to Diameter
- Further dissect 3GPP Radius AVP:s.

svn path=/trunk/; revision=24293
2008-02-08 16:32:12 +00:00
Stig Bjørlykke 677eb18d20 Rewrote some prohibited APIs in epan/dissectors/ (sprintf, strcpy, strcat).
If we get some truncated strings we probably overwrote some buffers...

svn path=/trunk/; revision=24249
2008-02-02 17:25:40 +00:00
Anders Broman ce40fc22a4 Make it possible to do subdissection of Diameter AVP:s and add dissection
of some 3GPP AVP:s.

svn path=/trunk/; revision=24211
2008-01-27 21:06:33 +00:00
Anders Broman c3fa6a267c Uncomplete code change.
svn path=/trunk/; revision=24207
2008-01-27 14:27:11 +00:00
Anders Broman f0582373ef Decode som more MBMS elements. Diameter XML fixes.
svn path=/trunk/; revision=24192
2008-01-25 17:27:54 +00:00
Anders Broman f67a7818b0 Decode som MBMS elements.
svn path=/trunk/; revision=24184
2008-01-24 22:21:13 +00:00
Anders Broman 95f17aafe0 Fix Missing -z proto,colinfo,ip,gtp.teid_cp and -z proto,colinfo,ip,gtp.teid_data
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2136
Copy paseto..

svn path=/trunk/; revision=24021
2008-01-07 19:15:43 +00:00
Anders Broman 654554a507 Wireshark packet-gtp.c error in decoding IMEI.
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1536

svn path=/trunk/; revision=22779
2007-09-03 16:42:28 +00:00
Anders Broman ab242d50fa From From: Sommars, Steven E:
Minor problem in packet-gtp.c  when decoding the PDP context Information
Element (7.7.29 in 29.060)   The two uplink TEIDs are reversed in
packet-gtp.c, it should be control plane, followed by data.

Reworked the patch.

svn path=/trunk/; revision=22500
2007-08-14 21:50:12 +00:00
Anders Broman d28046f3b5 Updated GSM MAP to use the latest asn1 original files.
MAP-dalouge and gsm_ss is included in this dissector.

svn path=/trunk/; revision=22069
2007-06-10 19:04:12 +00:00