Commit graph

2154 commits

Author SHA1 Message Date
Jeff Morriss
339136d1d0 Based on patch from Denis Ovsienko via
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6244 :

Fix typo: s/unkown/unknown/

svn path=/trunk/; revision=38561
2011-08-16 13:16:33 +00:00
Chris Maynard
352cc7a410 Fix bug 5848, "https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5848", which was apparently introduced with r27287 (http://anonsvn.wireshark.org/viewvc/trunk/epan/dissectors/packet-h225.c?r1=26698&r2=27287). Regenerate the packet-h225.c dissector. Patch from ericn1234@yahoo.com.
Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5848

svn path=/trunk/; revision=38399
2011-08-07 20:50:31 +00:00
Anders Broman
4b0961fb7a Bug 6146 - Malformed RANAP packets when HandOver procedure on iuh
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6146

svn path=/trunk/; revision=38312
2011-08-02 16:47:37 +00:00
Chris Maynard
b25c098e0c From Paul Stath via bug 5731: The check for engineID length should only occur if the engineID has a non-zero length.
Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5731

svn path=/trunk/; revision=38303
2011-08-02 01:54:03 +00:00
Anders Broman
7439bba9dc Try to do a more syntactically correct import.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6150

svn path=/trunk/; revision=38159
2011-07-21 22:46:07 +00:00
Martin Mathieson
7d7f7d870e Register nicer entry points for LTE RRC BCH messages, and use them in RLC, MAC, PDCP.
svn path=/trunk/; revision=38131
2011-07-20 12:19:22 +00:00
Stig Bjørlykke
ba2aae0f8e Use ENC_NA as encoding for FT_PROTOCOL, FT_NONE and FT_BYTES.
svn path=/trunk/; revision=38122
2011-07-19 18:48:31 +00:00
Stig Bjørlykke
f282154ab0 Use correct encoding for proto_tree_add_item().
svn path=/trunk/; revision=38107
2011-07-19 10:51:12 +00:00
Graeme Lunt
9e4afbfd49 Update the algorithms in line with RFC 5912 including support for eliptic curve algorithms.
svn path=/trunk/; revision=38017
2011-07-14 13:47:13 +00:00
Graeme Lunt
f8a7d85e1c Update to correct the definition of the clearance attribute used in certificates.
RFC3281 erroneously defined the Clearance attribute to be different to that defined in X.509. This has been recognised and corrected in RFC5755.
The RFC3281 syntax is retained and registered as the "RFC3281Clearance" syntax, which can be used to override the correct syntax in the BER oidtables if necessary.


svn path=/trunk/; revision=38014
2011-07-14 08:47:05 +00:00
Anders Broman
a5839116d3 Pretyfy APN display and make it filterable as a string.
svn path=/trunk/; revision=37731
2011-06-20 10:29:46 +00:00
Anders Broman
2477298026 From Sean Van Gorder:
When Wireshark attempts to read an SNMP packet with a variable-bindings item
with an OID containing an index string which includes an entry of type
"Unsigned32", Wireshark will stop dissecting the packet at this index entry and
end with the error:

[Dissector bug, protocol SNMP: proto.c:2761: failed assertion
"DISSECTOR_ASSERT_NOT_REACHED"]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5883

svn path=/trunk/; revision=37558
2011-06-05 20:12:44 +00:00
Stig Bjørlykke
51864807b3 Corrected "old-style function definition".
svn path=/trunk/; revision=37433
2011-05-27 11:03:04 +00:00
Stig Bjørlykke
7b5896a179 Corrected "old-style function definition".
svn path=/trunk/; revision=37429
2011-05-27 10:18:17 +00:00
Jeff Morriss
f3f9f2697f Make TVBs opaque for most users.
Convert TVB_RAW_OFFSET() and TVB_GET_DS_TVB() into functions.

svn path=/trunk/; revision=37422
2011-05-27 03:06:50 +00:00
Jeff Morriss
7ad71a2d78 Treat TVBs as opaque: use the accessor functions instead of accessing the fields
directly.

svn path=/trunk/; revision=37420
2011-05-27 01:57:33 +00:00
Gerald Combs
d16058dd8c Remove a backslash.
svn path=/trunk/; revision=37395
2011-05-25 18:09:04 +00:00
Anders Broman
84a22ed17e Make it easier to add custom asn1 dissectors.
svn path=/trunk/; revision=37393
2011-05-25 14:21:42 +00:00
Jeff Morriss
80c1ef3811 Fix a couple (value) mistakes in value_strings. Found by Martin's patch on the -dev list.
svn path=/trunk/; revision=37259
2011-05-18 20:06:17 +00:00
Stig Bjørlykke
a10ffa4ceb Build with S1AP-SonTransfer-IEs.asn
svn path=/trunk/; revision=37117
2011-05-13 07:51:27 +00:00
Stig Bjørlykke
624a041e6f Indicate Signed Receipt in info column.
svn path=/trunk/; revision=37074
2011-05-12 11:06:42 +00:00
Jeff Morriss
a80a391b0e From Ed Day via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5890 :
ASN.1 files in trunk/asn1/qsig contain syntax errors that prevent them from
being compiled by a standard ASN.1 compiler.  A patch of modified files is
attached along with General-Error-List.asn which was missing completely.

From me: add the new asn file to the list of source files.  Add SVN Id tag to
the new file.

svn path=/trunk/; revision=37005
2011-05-06 01:47:16 +00:00
Anders Broman
16c0bcbdee From Pascal Quantin:
Add an expert check for the MS Classmark 2 decoding in UE EUTRA Capability message and a few missing message type display in the column text.

svn path=/trunk/; revision=36984
2011-05-04 17:24:48 +00:00
Anders Broman
e0c80c4138 From Pascal Quantin:
the dissection of the UE capabilities when the RAT
type is set to geran-cs (the value part of Classmark 2 starts at the third byte). 
Moreover it adds a subtree to enhance the display of Mobile Station Classmark 2 and 3 and MS Radio Access Capability IEs.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5867

svn path=/trunk/; revision=36943
2011-04-28 19:59:14 +00:00
Jeff Morriss
9be16e49c4 From Stefan Metzmacher and Gregor Beck via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5850 :
The smallest LDAP PDU is 7 bytes, not 4.

svn path=/trunk/; revision=36777
2011-04-21 19:51:05 +00:00
Alexis La Goutte
ec7709406e Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=36771
2011-04-21 16:00:38 +00:00
Alexis La Goutte
7239db18ec Fix Dead Store (Dead nested assignment) Warning found by Clang
svn path=/trunk/; revision=36760
2011-04-21 13:34:22 +00:00
Stephen Fisher
fcfcfa347c Rollback r36614 and change dissect_SMUX_PDUs_PDU() to use previously
unused smux_tree instead of tree.  Per suggestion from Stig on -dev.


svn path=/trunk/; revision=36624
2011-04-13 15:48:24 +00:00
Stephen Fisher
4b416d92d0 Fix Coverity 524: NEGATIVE_RETURNS
Coverity sees that two calls to tvb_length_remaining() with an offset
of 0 may return -1 (for an "out of bounds" condition), which would lead
to an assignment of -1 to an unsigned variable and then passing it
to functions further down that cannot accept negative values.

Use tvb_ensure_length_remaining() to throw an exception in a case of
out of bounds access (though unlikely with an offset of 0) instead of
tvb_length_remaining(), which would return -1.


svn path=/trunk/; revision=36615
2011-04-12 22:23:03 +00:00
Stephen Fisher
ce2eea5b95 Fix Coverity 1047: UNUSED_VALUE in dissect_smux
svn path=/trunk/; revision=36614
2011-04-12 22:12:05 +00:00
Gerald Combs
ca01b3a876 Add x509if_frame_end() which is passed to register_frame_end_routine()
and which resets our global variables. Remove a boolean which was used
to track a char *; just check if the pointer is NULL instead. Fixes bugs
5754 and 5793, hopefully without breaking anything.

svn path=/trunk/; revision=36608
2011-04-12 20:39:48 +00:00
Stig Bjørlykke
b862371815 Removed some unused variables.
svn path=/trunk/; revision=36602
2011-04-12 19:06:51 +00:00
Stig Bjørlykke
42f41ddf0b Corrected switch-case flow.
Coverity 1184.

svn path=/trunk/; revision=36579
2011-04-12 09:05:43 +00:00
Guy Harris
4fdcc5c180 Rename ws_stat to ws_stat64, and make it take a pointer to a ws_statb64
as an argument, along the lines of ws_fstat64, and, on Windows, make it
use _wstati64, to handle 64-bit file sizes.

svn path=/trunk/; revision=36547
2011-04-10 20:59:10 +00:00
Anders Broman
842d4ff53e From Pascal Quantin:
A patch adding the missing hunks (it looks like extract_asn1_from_spec.pl script is mixing Windows and Linux line endings).

svn path=/trunk/; revision=36524
2011-04-08 19:54:07 +00:00
Anders Broman
da3f7673db From Pascal Quantin:
Upgrade LTE RRC ASN.1 description to V9.6.0

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5815

svn path=/trunk/; revision=36520
2011-04-08 17:36:53 +00:00
Gerald Combs
f989235a87 Use a unique variable name. Fixes Coverity CID 593.
svn path=/trunk/; revision=36512
2011-04-07 23:52:37 +00:00
Anders Broman
c039f9f8a8 Add a comment
svn path=/trunk/; revision=36490
2011-04-06 06:24:19 +00:00
Anders Broman
cb0e7f80da Missing decoding for CalledPartyBCD number in CAMEL
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5788

svn path=/trunk/; revision=36488
2011-04-06 06:20:32 +00:00
Stig Bjørlykke
c13f84b345 Compile fix: camel_obj_id -> obj_id.
svn path=/trunk/; revision=36475
2011-04-05 15:49:56 +00:00
Anders Broman
909a166343 Actually get the oid string ...
svn path=/trunk/; revision=36474
2011-04-05 15:43:15 +00:00
Anders Broman
8d6ca293dc Change the signature of elem_fcn():ns to include pinfo.
svn path=/trunk/; revision=36443
2011-04-04 14:37:25 +00:00
Anders Broman
e645e3c4d0 -Whitespace fix in gsm_map-template(no need to regenerate).
- Fix dissection of extensions in INAP it should now be possible to add
an "OID dissector" for extensions.
Should fix BUG
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5799

svn path=/trunk/; revision=36435
2011-04-02 09:18:18 +00:00
Anders Broman
129f07a949 Added FALLTHRU comment to avoid a "missing break" warning.
svn path=/trunk/; revision=36365
2011-03-27 14:02:42 +00:00
Jeff Morriss
cc6fc23812 From Didier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3055 :
Apply rev 25869 to most of the rest of the TCP-desegmenting dissectors.
(The SSL dissector was already updated in one of two spots with bug 4535/rev
32456.)

A couple of the patches had to be manually applied.

From me: Fix the comments to match the change (including in the TCP and SSL
dissectors.)

svn path=/trunk/; revision=36332
2011-03-25 19:02:18 +00:00
Gerald Combs
670d38ec71 Properly initialize our filter counters.
svn path=/trunk/; revision=36190
2011-03-14 16:00:51 +00:00
Anders Broman
675d79871e Export SONtransferRequestContaine, SONtransferResponseContainerand and Global-ENB-ID
svn path=/trunk/; revision=36130
2011-03-03 07:20:34 +00:00
Tomas Kukosa
16bdcb2fbe QSIG: decoding of PSS1InformationElement
svn path=/trunk/; revision=36108
2011-03-01 13:01:26 +00:00
Gerald Combs
91fe31c9b4 If we encounter an excessively long filter string or one with too many
elements, add an expert item and throw a ReportedBoundsError. We may
want to handle this more cleanly in the future but this avoids
allocating a huge amount of memory.

svn path=/trunk/; revision=36101
2011-03-01 00:50:17 +00:00
Anders Broman
8ec8d3fcc3 Export:
SONtransferRequestContainer
SONtransferResponseContainer
SONtransferCause

svn path=/trunk/; revision=36086
2011-02-27 21:55:35 +00:00