osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
26,148 Commits 26 Branches 0 Tags 795 MiB
Commit Graph

133 Commits

Author SHA1 Message Date
Bill Meier c3ea1560bd Minor cleanup related to proto_register and proto_reg_handoff 
svn path=/trunk/; revision=26281
 2008-09-26 22:07:45 +00:00
Bill Meier b3aa52f573 Fix some of the Errors/warnings detected by checkapi. 
svn path=/trunk/; revision=25307
 2008-05-15 12:54:27 +00:00
Jeff Morriss bb323055b2 match_strval() may return NULL so don't blindly pass its return value into col_add_*() or proto_add_*(); use val_to_str() (returning "Unknown (%d)" if no match is found) instead. 
svn path=/trunk/; revision=24557
 2008-03-04 21:05:21 +00:00
Stig Bjørlykke f95de28c72 Updated scsi_verdesc_val from appendix D in spc-3. 
Dump Inquiry Vendor Specific and Reserved fields as bytes.
(still missing dumping of Clocking/QAS/IUS bits)

svn path=/trunk/; revision=23060
 2007-10-03 16:22:50 +00:00
Stig Bjørlykke 05043ca65d Use correct offset for sccs, bque and reladdr flags. 
svn path=/trunk/; revision=23059
 2007-10-03 15:00:58 +00:00
Guy Harris 5a43799a17 Use G_GINT64_MODIFIER, rather than the PRI[douxX]64 macros, for GLib 
routines and routines using those routines.  GLib might use different
modifiers for 64-bit quantities than the platform's C library does.

svn path=/trunk/; revision=21990
 2007-05-29 18:52:42 +00:00
Sebastien Tandel a7615a1afb another attempt to let windows buildbot becoming green 
fix rev21398 (gcc warning fix)

svn path=/trunk/; revision=21412
 2007-04-13 17:16:24 +00:00
Sebastien Tandel 42791e157b use of volatile for every functions and not only the ones using the Exception 
mechanisms. (fix rev21398)

Windows buildbot sould be green again as formal parameters are the same as the
ones in the declaration now.

svn path=/trunk/; revision=21409
 2007-04-13 15:23:47 +00:00
Stephen Fisher f002ac6db5 Fix various warnings 
Move packet-cops.c out of clean dissectors due to a #define conflict
in the headers of net-snmp with our config.h


svn path=/trunk/; revision=21398
 2007-04-13 00:50:23 +00:00
Jeff Morriss 4d21c49929 Get rid of some more g_assert*()'s in the dissectors. There are a few 
remaining that I'm not sure exactly what to do with at the moment:
the one in packet-frame probably should be there, the others probably
shouldn't but they also should never fail unless there's a compile or build
problem (AFAICS).


svn path=/trunk/; revision=21367
 2007-04-10 14:48:06 +00:00
Ulf Lamping f1a58d41d4 from Peter Johansson: 
compilation warnings fixed

svn path=/trunk/; revision=21230
 2007-03-27 21:20:19 +00:00
Stephen Fisher d565967b58 From Peter Johansson: 
Fix warnings


svn path=/trunk/; revision=21214
 2007-03-26 21:16:21 +00:00
Ulf Lamping 411249419d fix some more warnings (type casts) 
svn path=/trunk/; revision=21141
 2007-03-23 00:51:21 +00:00
Ronnie Sahlberg f6f95ea6a0 remove the revision number from the spc symbols 
change all spc2 and spc3 to spc



svn path=/trunk/; revision=20779
 2007-02-11 00:45:15 +00:00
Ronnie Sahlberg 9535fb5e42 dont encode a specific revision of the standard in the symbol names 
change all symbols from smc2 to smc

svn path=/trunk/; revision=20778
 2007-02-11 00:20:37 +00:00
Ronnie Sahlberg a99fb4ebb7 add the remaining TAPE ALERT log flags from ssc3r01c 
svn path=/trunk/; revision=20719
 2007-02-05 11:31:21 +00:00
Ronnie Sahlberg 059f550b16 add some infrastructure to enable us to dissect the content of LOG SENSE pages and parameters 
dissect the READ WARNING flag in the TAPE-ALERT log page as an example


svn path=/trunk/; revision=20718
 2007-02-05 09:39:36 +00:00
Ronnie Sahlberg c1ccab43aa update the LOG SELECT dissector slightly and harmonize the hf fields so both LOG SELECT and LOG SENSE use the same variables 
svn path=/trunk/; revision=20703
 2007-02-03 22:03:39 +00:00
Ronnie Sahlberg b06f81f4b4 updates to the LOG SELECT CDB decoding 
svn path=/trunk/; revision=20696
 2007-02-03 16:21:21 +00:00
Ronnie Sahlberg 9a0b5c4d4a use the correct offset to access the service action in PERSISTENT RESERVE IN 
svn path=/trunk/; revision=20672
 2007-02-01 20:10:51 +00:00
Stephen Fisher 7317125c33 From Patrick vd Lageweg: 
The PERSISTENT REVERVE OUT dissectors uses the table of the PERSISTENT REVERVE
IN command to decode the Service Action field which is obviously not correct.
This patch fixes the problem.


svn path=/trunk/; revision=20631
 2007-01-30 19:43:29 +00:00
Jaap Keuter f8be165898 From Patrick vd Lageweg: 
This patch fixes three problems with the SCSI persistent reserve in command:
- The Additional length starts at offset 4 and not 0
- The len field contains the length used by the keys and doesn't include the header length. 
  So don't substract the header length from the length.
- The key list is traversed from the beginning to end end and not the other way around.

svn path=/trunk/; revision=20568
 2007-01-26 17:06:17 +00:00
Gerald Combs e7bda1efe4 Attempt to squelch Coverity CID 222. 
svn path=/trunk/; revision=20551
 2007-01-25 06:45:09 +00:00
Jaap Keuter b99ce1a967 From Patrick vd Lageweg: 
The "NUMBER OF BLOCKS" field in the SCSI MODE SENSE return data is 24 bits and not 32 bits. This patch fixes that.

svn path=/trunk/; revision=20462
 2007-01-17 17:11:09 +00:00
Ronnie Sahlberg 34824cb310 change all sbc2 references into sbc 
svn path=/trunk/; revision=20100
 2006-12-10 13:52:30 +00:00
Ronnie Sahlberg 41c258daf3 create a nice helper to dissect bitmasks and implement some test useage of it in the scsi dissector 
svn path=/trunk/; revision=20002
 2006-11-27 14:50:23 +00:00
Ronnie Sahlberg 3dca5cbed9 break the SCSI SBC commandset out into its own dissector 
svn path=/trunk/; revision=20000
 2006-11-27 11:00:06 +00:00
Ronnie Sahlberg bd16443f38 add some missing commandsets to the preference for default commandset and to the scsi srt statistics 
svn path=/trunk/; revision=19973
 2006-11-24 08:22:30 +00:00
Jaap Keuter 14a576d293 From Patrick vd Lageweg: 
This patch fixes a simple typo.

svn path=/trunk/; revision=19972
 2006-11-24 07:28:02 +00:00
Ronnie Sahlberg 303187fad8 break the SCSI SMC commandset out into its own dissector 
svn path=/trunk/; revision=19964
 2006-11-23 09:21:16 +00:00
Ronnie Sahlberg 651ed76925 break the SCSI SSC commandset out into its own dissector 
svn path=/trunk/; revision=19957
 2006-11-22 10:12:59 +00:00
Ronnie Sahlberg b7e08d5059 ssc space6 count is a signed integer 
svn path=/trunk/; revision=19956
 2006-11-22 09:00:36 +00:00
Ronnie Sahlberg 541d2f8baa Patrick vd Lageweg <patrick@bitwizard.nl> 
Hi,

The rease/release commands are also usable on SSC devices. This patch adds them to the valid SSC command.

        Patrick
_______________________________________________


svn path=/trunk/; revision=19947
 2006-11-21 09:18:28 +00:00
Ronnie Sahlberg c0cccf43c2 start splitting the monolitic scsi dissector up into commandset dissectors 
split the MMC commandset out of the main scsi dissector



svn path=/trunk/; revision=19738
 2006-10-30 12:18:29 +00:00
Gerald Combs fb22815c2b Attempt to squelch Coverity CID 221. 
svn path=/trunk/; revision=19678
 2006-10-25 00:49:36 +00:00
Ronnie Sahlberg 26e2395f1d if reassembly did not give us a new tvb, then dont call any scsi payload subdissector 
svn path=/trunk/; revision=19534
 2006-10-14 22:05:57 +00:00
Ronnie Sahlberg 057c7a0555 let SCSI reassembly default to FALSE 
put "reassembled in" in the summary line

put the fragment list at the top of the tree instead of down inside the SCSI expansion



svn path=/trunk/; revision=19523
 2006-10-14 01:44:29 +00:00
Ronnie Sahlberg 91ff6ddaf4 add scsi data reassembly 
svn path=/trunk/; revision=19519
 2006-10-13 22:25:35 +00:00
Ronnie Sahlberg 02ea9c5608 check the estinated data transfer length for the current transfer and start adding checks for scsi data reassembly 
svn path=/trunk/; revision=19518
 2006-10-13 21:26:03 +00:00
Ronnie Sahlberg 9768637878 dont call the scsi data in/out dissectors unless data offset is 0 i.e. the beginning of data in/out 
svn path=/trunk/; revision=19517
 2006-10-13 21:07:07 +00:00
Ronnie Sahlberg 8826c144f7 pass the relative data offset of data in/out pdu's to the scsi data in/out dissector (dissect_scsi_payload) so that we can later add reassembly of data pdu's 
and also (if reassembly is disabled) only dissect the initial (offset==0) data pdu.

dissect_scsi_payload() does not yet use this parameter.


now that we have both data offset and expected data length/bidir expected data length and also the read/write flags availabe we have what we need to reassemble data in/out pdus    (modulo overflow/underflow  but those are so rare we can worry about them later).


ndmp:   ndmp conceptually always has a data in and a data out phase and never fragment the data into smaller pdu's os that dissector always report offset as 0.





svn path=/trunk/; revision=19511
 2006-10-13 09:16:45 +00:00
Ronnie Sahlberg 2f6fb1fe7f From Patrick vd Lageweg 
Hi,

This patch makes several bit fields in the LOG SELECT command being displayed as bits instead of as numbers.



svn path=/trunk/; revision=19497
 2006-10-11 20:05:27 +00:00
Ronnie Sahlberg 10893e51d7 From Patrick vd Lageweg 
Hi,

This patch fixes the page number user for the "write error couner page".






svn path=/trunk/; revision=19496
 2006-10-11 20:03:44 +00:00
Ronnie Sahlberg d8a8ec9b36 From Patrick vd Lageweg 
Hi,

This patch impelments a dissect for the SCSI SSC Medium Partition Page.


Patrick


svn path=/trunk/; revision=19495
 2006-10-11 20:00:43 +00:00
Ronnie Sahlberg 494e873eb0 move the ITL and the ITLQ structure to packet-scsi.h where it belongs 
svn path=/trunk/; revision=19492
 2006-10-11 10:38:59 +00:00
Ronnie Sahlberg e2a851e18d add initial scsi osd dissector but only dissect sdbs that are impoerted from SPC 
various changes to the existing scsi dissector to start allowing different commandsets to be implemented in their own dissector files to prevent the scsi dissector to become as huge as the parlay dissector




svn path=/trunk/; revision=19360
 2006-09-29 10:40:51 +00:00
Ronnie Sahlberg d09cfb2bb8 move the defines for SPC command opcode values to the headerfile 
svn path=/trunk/; revision=19359
 2006-09-29 09:24:51 +00:00
Ronnie Sahlberg c20b7c8eda additional scsi sense codes from patrick@abra2.bitwizard.nl 
svn path=/trunk/; revision=19349
 2006-09-28 15:57:54 +00:00
Ronnie Sahlberg ad305c630b Hi, 
This patch fixes the page code selector for the scsi log sense command.

Patrick




svn path=/trunk/; revision=19348
 2006-09-28 15:55:13 +00:00
Ronnie Sahlberg fe3114d00b check that itl is non-NULL to prevent a NULL pointer dereference that would crash the windows build but funnily enough not linux (since you can read from the null page on linux?) 
svn path=/trunk/; revision=18832
 2006-08-04 00:36:25 +00:00