Commit Graph

608 Commits

Author SHA1 Message Date
Guy Harris 245086eb83 HTTPS In Still More Places, update more URLs.
Microsoft reshuffled their documentation - almost all of it moved from
msdn.microsoft.com to docs.microsoft.com.  Some blogs moved to
devblogs.microsoft.com; the comments *didn't* move, so in one case we go
to the Wayback Machine - the link isn't dead, but it formats horribly,
at least on my browser, but the archived version formats OK.

Use the Wayback Machine for some URLs, and update others.

Update the sections for MS-ADTS.

Point to the HTML versions of some RFCs and I-Ds.

Change-Id: I344b20f880de63f1ae2a4e3f9ff98af78a7fe139
Reviewed-on: https://code.wireshark.org/review/34101
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-27 22:56:35 +00:00
Guy Harris 20800366dd HTTPS (almost) everywhere.
Change all wireshark.org URLs to use https.

Fix some broken links while we're at it.

Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c
Reviewed-on: https://code.wireshark.org/review/34089
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-26 18:44:40 +00:00
Pascal Quantin c5dab4efb5 E1AP: upgrade dissector to v15.4.0
Change-Id: Ic9a19804b5e46ca63f3d1256e13173a92fc39f9b
Reviewed-on: https://code.wireshark.org/review/34065
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-24 07:56:10 +00:00
Pascal Quantin c7884e2170 XnAP: upgrade dissector to v15.4.0
Change-Id: Ia26593e7895709671a7a9d4a51bb6788e4059c94
Reviewed-on: https://code.wireshark.org/review/34015
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-19 12:46:44 +00:00
Pascal Quantin ef61883766 NGAP: upgrade dissector to v15.6.0
Change-Id: Iac53380ba1a6ba105103db7104d44688bbbe383d
Reviewed-on: https://code.wireshark.org/review/34014
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-19 11:35:03 +00:00
Pascal Quantin a754879c7d X2AP: upgrade dissector to v15.6.0
Change-Id: Iffa23a10350ad8ef765401b50373a7d6aaf5d2bf
Reviewed-on: https://code.wireshark.org/review/33971
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-16 22:27:50 +00:00
Pascal Quantin 1b39837cae F1AP: upgrade dissector to v15.6.0
Change-Id: I39f33ffc76856e0bad8cb39f1199fc8a881a293c
Reviewed-on: https://code.wireshark.org/review/33950
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-15 13:50:53 +00:00
Darien Spencer d22db568a0 RRC: Remove duplicate dissection of algorithm cap bitmaps
This commit is effectively reverting  I88ddc2aec6805a77fcb3f3d547efda4d513ec919
The dissection logic is now generated into the dissector
following the changes I2f4258e2f4fd11c26bdc101e1375d0b5708610b7
and Iec2cb22e61e235a749c7d0f976bae8ad52e6c08f

Change-Id: I871c2b00d7a72103da83d6e64091886a8e2b12ed
Reviewed-on: https://code.wireshark.org/review/33923
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-13 13:43:29 +00:00
Pascal Quantin 5e54c7147e XnAP: get rid of duplicate bit string decoding
After gca694eb078, no manual decoding is required

Change-Id: I641ce984b08ec74d7075b9e7cdd0806ccd707a45
Reviewed-on: https://code.wireshark.org/review/33917
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-12 16:22:53 +00:00
Pascal Quantin e36e6c9115 ULP: get rid of duplicate bit string decoding
After gca694eb078, no manual decoding is required

Change-Id: Ic23daf75c317df8b022e2e9911a6ad025dceaae8
Reviewed-on: https://code.wireshark.org/review/33916
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-12 16:22:42 +00:00
Pascal Quantin 4d500e84ed LPP: get rid of duplicate bit string decoding
After gca694eb078, no manual decoding is required

Change-Id: Ibe83becaea2f3587e770f6346ec71e775d25cf75
Reviewed-on: https://code.wireshark.org/review/33915
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-12 16:22:31 +00:00
Pascal Quantin 62abddc26e S1AP: upgrade dissector to v15.6.0
Change-Id: I87b7aba8abb69254f30429cdc1c84efac317b652
Reviewed-on: https://code.wireshark.org/review/33909
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-12 10:22:04 +00:00
Joakim Karlsson d560f76401 gprscdr: Update to 3GPP TS 32.298 V15.7.0
Change-Id: Id67fd508619d63a5c6cbd5857551493b77c41019
Reviewed-on: https://code.wireshark.org/review/33848
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-05 03:53:31 +00:00
Joakim Karlsson 84a3cc1064 s1ap: fix compile error on older GCC
error: variable ‘handle’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]

Change-Id: Id53d02927cbb738acedc80b0f6556afb3322c787
Reviewed-on: https://code.wireshark.org/review/33846
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-04 22:07:43 +00:00
Pascal Quantin 7af35b68bd LTE RRC: dissect requestedCapabilityCommon / appliedCapabilityFilterCommon IEs
Change-Id: I39198df9a048510d040d56a53183669bda176cdc
Reviewed-on: https://code.wireshark.org/review/33804
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-01 16:53:03 +00:00
Pascal Quantin 376d4c3595 NR RRC: upgrade dissector to v15.6.0
Change-Id: I07eb698fa7ec0ce74953844667590e72368f9456
Reviewed-on: https://code.wireshark.org/review/33803
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-01 16:52:56 +00:00
Pascal Quantin 2a80a9b80a LTE RRC: upgrade dissector to v15.6.0
Change-Id: I05417ad4425e301af9d307a1c20fd3c16091c80c
Reviewed-on: https://code.wireshark.org/review/33784
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-06-30 19:23:48 +00:00
Pascal Quantin 892d5914b4 LPP: upgrade dissector to v15.4.0
Change-Id: I667ab9480334dd1b66a36982b972b8f8837dd7a6
Reviewed-on: https://code.wireshark.org/review/33783
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-06-30 18:11:02 +00:00
Anders Broman 41d0cf7320 S1AP: Catch out-of-bounds error when dissecting UERadioCapability.
Change-Id: I14fbf46583a5e17bcd3e7b05d1faee43983f47a5
Reviewed-on: https://code.wireshark.org/review/33763
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-28 12:50:07 +00:00
Dario Lombardo 3ae9831cb1 ldap: remove dead increment (found by clang).
Small indentation fixes while here.

Change-Id: Id1d0a0e9556e5910f5cddfc442549eb2f5fc8a3c
Reviewed-on: https://code.wireshark.org/review/33721
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-24 12:14:58 +00:00
Dario Lombardo df34133584 kerberos: remove dead assignment (found by clang).
Change-Id: Ic171f2ff2c53621f079dc9efa0cd8a19d91d8af9
Reviewed-on: https://code.wireshark.org/review/33720
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-06-24 00:24:52 +00:00
Dario Lombardo f01b2f36d4 ldap: remove dead assignment (found by clang).
Change-Id: Id61b68419b71d07ac66c4436eafd430602917eaa
Reviewed-on: https://code.wireshark.org/review/33719
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-06-24 00:23:36 +00:00
Pascal Quantin d7ef3118b1 LPPa: upgrade dissector to v15.2.1
Change-Id: I48e4a33f66a121ec1fd380540e382101e6f9a0c1
Reviewed-on: https://code.wireshark.org/review/33665
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-06-19 18:19:16 +00:00
Anders Broman c1c0a2911b NRPPa: Add dissector for TS 38.455 V15.2.1
Change-Id: I66da8ced410163c872af1d4161f2c9fc38f72ff8
Reviewed-on: https://code.wireshark.org/review/33590
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-17 13:12:20 +00:00
Pascal Quantin be3d469ddc NGAP: fix dissection of N2 Information Content
Change-Id: I8aaf578c8eb71533313cf2cfd42871eae0c0ff57
Reviewed-on: https://code.wireshark.org/review/33603
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-06-16 11:30:24 +00:00
Anders Broman 7c8b21d329 NGAP: Dissect N2 SM Information
Change-Id: I05c334a7ba69986e9dee63e9b71839c6ae0d994f
Reviewed-on: https://code.wireshark.org/review/33568
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-12 22:55:02 +00:00
Guy Harris 2def295022 Eliminate more calls to get_unicode_or_ascii_string().
Just use proto_tree_add_item() or tvb_get_string_enc(); that way, we
handle full UTF-16, not just the ISO 8859/1 subset thereof.

Change-Id: I8ded392b87522c45902354092d6988965265d3b3
Reviewed-on: https://code.wireshark.org/review/33567
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-06-12 20:16:25 +00:00
Martin Kaiser f155601d66 decode_as: remove the "title" member from decode_as_t
The title of a decode_as_t was used by the GTK UI. It's no
longer required for Qt.

Change-Id: Ibd9d4acbe9cad2c1af520340d04e550326a97ebe
Reviewed-on: https://code.wireshark.org/review/33557
Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-11 18:50:32 +00:00
Guy Harris f72e504817 Dissect LDAP strings as UTF-8.
This requires some special hackery, including a new packet-ber.c
routine, as those strings are just OCTET STRINGs, not UTF8Strings.

Change-Id: I776ed47f7400eba366a630b60b94be3397f7b45f
Reviewed-on: https://code.wireshark.org/review/33403
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-05-28 04:11:35 +00:00
Piotr Tulpan bc5b71c00b RANAP: Handle 7 byte NSAP address in transportLayerAddress
Handle NSAP 7 byte IPv4 address in transportLayerAddress field which aren't padded to 20 bytes.

Change-Id: Ied9a9549612fe8e9ec511419ee0d7e5ae06bcedf
Reviewed-on: https://code.wireshark.org/review/33278
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-27 08:34:21 +00:00
Joakim Karlsson f1946955ca gprscdr: update RatingGroupId as unsigned
Changed type for the RatingGroupId fields, from signed32 to unsigned32.
This fixes the problem of getting "-1" values at G_MAXUINT32.

Change-Id: Ia1113901657bedc8d9c231aa1fe38b63170b2257
Reviewed-on: https://code.wireshark.org/review/33338
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-24 11:00:22 +00:00
Joakim Karlsson c1220ec0c7 gprscdr: Update to 3GPP TS 32.298 V15.6.0
Change-Id: Iec680f2f2ac9b0149ad9933cb2e805dc9aa00d32
Reviewed-on: https://code.wireshark.org/review/33202
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-15 05:34:47 +00:00
Anders Broman 88096e1fc5 GSM MAP: Fix dissection of authenticationSet in SentParameterList
Ber choice called with a non FT_UINT hf variable. Work around by
duplicating ASN1 code.

Change-Id: I71b38e25288f222058793110eb43c122c012dcca
Reviewed-on: https://code.wireshark.org/review/33191
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-14 11:48:56 +00:00
Anders Broman faf191edc1 SBc-AP:Update to 3GPP TS 29.168 V15.1.0 (2018-09).
Change-Id: Ie1418deda58046e48419be252a41c4e1cf9593b8
Reviewed-on: https://code.wireshark.org/review/33144
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-10 11:26:18 +00:00
Martin Mathieson 81e9417b76 MAC-NR: Fix a couple of issues with configuring RLC bearers from RRC.
Need to make sure to read UM/AM direction before reading SN-length.  Also fix a backward test while looking up
stored SNLength.

Change-Id: I4dbb701efe80c78fee5e1af9e405b2cf883f7401
Reviewed-on: https://code.wireshark.org/review/33129
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2019-05-09 13:14:58 +00:00
Anders Broman 348e0de9d3 ieee1609dot2: Add media type dissection.
Change-Id: Iaa6979535c120402957510bc7d89df3e9d83b15a
Reviewed-on: https://code.wireshark.org/review/33130
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-09 12:37:46 +00:00
Martin Mathieson b41d122142 Add preferences to NR RLC to accept PDCP config (SN length) from RRC.
Change-Id: I526c2438d78a767b39adb258e016c784a8c2994a
Reviewed-on: https://code.wireshark.org/review/33034
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2019-05-08 20:27:19 +00:00
Pascal Quantin a8317adbca S1AP: add ErrorIndication message type to info column
Change-Id: I82206169d7a77f9798fc672a87de9789d56fda3d
Reviewed-on: https://code.wireshark.org/review/33088
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-05-05 21:36:00 +00:00
Martin Mathieson dd708676d3 NR: Configure LCID -> RLC Bearer config from RRC
Change-Id: Ida6af4ccd2157f967b9d2340e6f12319e4dbe688
Reviewed-on: https://code.wireshark.org/review/32998
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2019-04-29 23:39:58 +00:00
Anders Broman a44e838158 GSM MAP: Update to V15.4.0 (2018-12)
Change-Id: I2ce50236b963e14e48214e8a72a98bec96cfea71
Reviewed-on: https://code.wireshark.org/review/32958
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-23 13:38:55 +00:00
Anders Broman 344a596a49 ITS: Enhance ETSI ITS support (ETSI TS 103 301 and ETSI TS 103 097)
Bug: 15703
Change-Id: Iba080ba21862be078174db6098200f1ef63ea9d6
Reviewed-on: https://code.wireshark.org/review/32885
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-18 13:05:11 +00:00
Anders Broman 3b0aabc204 IEEE1609dot2: Update to the latest ASN1 files.
Bug: 15703
Bug: 15704
Change-Id: I0574abc5c72835d9e7ca835790c10e55d9e86593
Reviewed-on: https://code.wireshark.org/review/32879
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-17 14:45:29 +00:00
Anders Broman 0f5dd4c778 CRMF: Handle 64 bit serialNumber
Add MIN..MAX in the ASN1 code to have it generate code to handle 64
bits.

Bug: 15154
Change-Id: I87b786a84bdab60641c520322ea8096c5f7a7f81
Reviewed-on: https://code.wireshark.org/review/32860
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-15 13:15:36 +00:00
Pascal Quantin 3e2cad0cb5 F1AP: upgrade dissector to v15.5.0
Change-Id: Id5ebdfc1c7351ab234020dbb51dabbadc65d8fbd
Reviewed-on: https://code.wireshark.org/review/32826
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-04-11 16:56:35 +00:00
Pascal Quantin 1795d6f201 E1AP: upgrade dissector to v15.3.0
Change-Id: Ia3bdc2c76e0ad9d6951598d37771a1137b24a8c7
Reviewed-on: https://code.wireshark.org/review/32824
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-04-11 14:31:33 +00:00
Pascal Quantin 0c53d7dc29 XnAP: upgrade dissector to v15.3.0
Change-Id: Iba03132e146e22f37a8af842e3ec1b44ce4d364b
Reviewed-on: https://code.wireshark.org/review/32823
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-04-11 13:55:46 +00:00
Pascal Quantin d3e7bf79dc NGAP: upgrade dissector to v15.3.0
Change-Id: I9b60b99cd3caa310799508221cec0c26c9a8d597
Reviewed-on: https://code.wireshark.org/review/32817
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-04-11 05:13:48 +00:00
Pascal Quantin a6dac6240f X2AP: use the right tree for EndcSONConfigurationTransfer IE
Change-Id: I44739870524af86c9b590fdc995d7b93490f9296
Reviewed-on: https://code.wireshark.org/review/32816
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-04-10 21:03:31 +00:00
Anders Broman ed51e15cfa LCS-AP: Update to V15.2.0 (2019-03)
Change-Id: I39e9b0871a7d5ce51872bcd44aa3c357ced5d543
Reviewed-on: https://code.wireshark.org/review/32811
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-10 14:52:52 +00:00
Pascal Quantin fe50824bb4 X2AP: upgrade dissector to v15.5.0
Change-Id: I43f96e8ea5acb3cd94b8b3b4e08e0d10a5e8d951
Reviewed-on: https://code.wireshark.org/review/32800
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-04-09 11:31:21 +00:00