Commit Graph

35 Commits

Author SHA1 Message Date
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Stig Bjørlykke 26d30411b6 Adjusted my name to use only ASCII characters.
svn path=/trunk/; revision=27733
2009-03-15 21:13:27 +00:00
Stig Bjørlykke 248ca24f4f Removed mark for unused pinfo, its in use.
svn path=/trunk/; revision=27537
2009-02-25 00:28:19 +00:00
Gerald Combs 6d04f793f0 Back out r27047 and r27053.
svn path=/trunk/; revision=27062
2008-12-19 17:39:52 +00:00
Gerald Combs fc71188963 Update calls to proto_tree_add_bytes_format to reflect r27047.
svn path=/trunk/; revision=27053
2008-12-18 20:19:49 +00:00
Stig Bjørlykke 9168a0a714 Added total time analysis from Address to Ack-Ack PDU.
Renamed previous total time to transmission time.

svn path=/trunk/; revision=26428
2008-10-13 14:59:28 +00:00
Stig Bjørlykke acd4e734c9 From Mattias Nissler (bug 2936):
Fix some gpointer casts.

svn path=/trunk/; revision=26347
2008-10-03 17:01:08 +00:00
Stig Bjørlykke 6882a5cd1a Several improvements:
- Split SEQ/ACK analysis into SEQ analysis (pr msg) and ACK analysis
  (pr dest/ackinfo entry) to correctly handle multicast messages.
- Improved dump of timestamp (in units of 100ms).
- Show Address PDU with 0 dest entries as Ack-Ack PDU.
- Print correct number of missing sequence numbers in Ack.
- Indicate end of list entry in Ack.
- Message ID is unsigned.

svn path=/trunk/; revision=26345
2008-10-03 14:58:53 +00:00
Stig Bjørlykke 2a4ddda66a Added option to decode as BER encoded ASN.1.
Dump as data if no decoding.

svn path=/trunk/; revision=26339
2008-10-02 15:47:06 +00:00
Bill Meier 5ac2ba6354 Minor changes related to proto_reg_handoff & pref ranges
svn path=/trunk/; revision=26254
2008-09-23 15:03:39 +00:00
Bill Meier a3e6eb8071 Minor cleanup mostly related to proto_reg_handoff
svn path=/trunk/; revision=26236
2008-09-19 17:39:44 +00:00
Stig Bjørlykke 7cf79249e0 Only use one IP address for seq/ack analysis.
Use correct length for dest entry and ack info entry.
Print correct id list for acks.

svn path=/trunk/; revision=26059
2008-08-22 15:15:56 +00:00
Stig Bjørlykke 6b1c605ca4 Added handling of missing sequence number range in ack.
Add all message ids in ack to the info column.
Changed data types for sequence number and total number of pdus.
Untabify file.

svn path=/trunk/; revision=26031
2008-08-15 07:59:11 +00:00
Stig Bjørlykke a3e13c0e3a Register dissector by name.
svn path=/trunk/; revision=25180
2008-04-25 19:25:49 +00:00
Stig Bjørlykke c714042d2f Updated to Version 2.0 Draft 6.
Removed unofficial port numbers.

svn path=/trunk/; revision=24582
2008-03-07 12:22:20 +00:00
Stig Bjørlykke 3590fc0713 Changed to checksum_good and checksum_bad to align with other dissectors.
svn path=/trunk/; revision=24115
2008-01-16 19:16:30 +00:00
Stig Bjørlykke 1c68fd7a75 Added total retransmission time analysis field.
svn path=/trunk/; revision=23924
2007-12-19 11:25:47 +00:00
Stig Bjørlykke 6f9241bca7 - Added first version of P_Mul sequence analysis.
- Added expert info for Discard_Message_PDU.

svn path=/trunk/; revision=23922
2007-12-19 10:05:42 +00:00
Stig Bjørlykke 4e9892cbfd Added checksum.good and checksum.bad items.
svn path=/trunk/; revision=23590
2007-11-25 21:30:57 +00:00
Stig Bjørlykke c787b310eb Added port range.
svn path=/trunk/; revision=23491
2007-11-19 07:26:53 +00:00
Anders Broman 1950ffc214 Apply the small performance enhancment patches for:
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster.
Replace 
- col_append_fstr() with faster  col_append_str() 
- col_add_str() with col_set_str()
when it's safe

svn path=/trunk/; revision=23252
2007-10-23 05:50:00 +00:00
Stig Bjørlykke af2d10d5bf - Added option to use relative message id (MSID)
- Added generated entry for total missing sequence numbers
- Added expert info on invalid ack info length
- Added count of ack in info column

svn path=/trunk/; revision=23079
2007-10-06 11:28:09 +00:00
Stig Bjørlykke d2bc64938c Added expert info for length issues.
svn path=/trunk/; revision=22648
2007-08-24 23:27:33 +00:00
Stig Bjørlykke 1ac635cd7d When calculating checksum for p_mul the checksum field itself is set to zero.
Ensure this field is inside the buffer before altering it, so we don't 
write outside the allocated buffer.

svn path=/trunk/; revision=22529
2007-08-16 20:54:43 +00:00
Jeff Morriss 3dec62b85c - s/ntohs/g_ntohs
- s/ntohl/g_ntohl
- s/free/g_free
- Change some tvb_get_string()+g_free()'s into tvb_get_ephemeral_string()
- Change some tvb_fake_unicode()+g_free()'s into tvb_get_ephemeral_faked_unicode()
- Change some tvb_get_string() calls that were clearly memory leaks (like
  atoi(tvb_get_string(...))) into tvb_get_ephemeral_string()

svn path=/trunk/; revision=22515
2007-08-15 22:27:52 +00:00
Stig Bjørlykke 0cab42b465 Use fragment_start_seq_check to start defragmentation when receiving an
Address PDU without adding a empty message fragment.

svn path=/trunk/; revision=22514
2007-08-15 22:26:00 +00:00
Anders Broman c01f382974 Second step in introducing asn context to BER dissectors just like in PER.
svn path=/trunk/; revision=21753
2007-05-13 20:58:29 +00:00
Stephen Fisher d565967b58 From Peter Johansson:
Fix warnings


svn path=/trunk/; revision=21214
2007-03-26 21:16:21 +00:00
Graeme Lunt 835fd8749e This patch adds some expert info in P_Mul when:
- Checksum failure
- Missing sequence numbers

http://www.wireshark.org/lists/wireshark-dev/200702/msg00357.html


svn path=/trunk/; revision=20747
2007-02-08 17:15:45 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Ronnie Sahlberg 7efbafb6e5 from Stig B:
I have made a small change in packet-x411-template.c to make the X.
411 message heading in CDT look like in COTP.




svn path=/trunk/; revision=16657
2005-12-02 22:01:00 +00:00
Anders Broman cf0d307ef6 From Stig Bjørlykke
Added a new dissector for CDT (CompressedDataType) as
 defined in STANAG 4406 Annex E.  This dissector is used in P_Mul to  
 decode encapsulated X.411 content.  I have added a function in the  
 X.411 dissector to decode a MTS APDU without having a ROS

 Changes in this patch:
 * Added CDT dissector
 * Use CDT dissector in P_Mul
 * Added function to decode MTS APDU in the X.411 dissector

svn path=/trunk/; revision=16567
2005-11-23 07:33:03 +00:00
Gerald Combs 66296cdf17 Don't use null values for blurbs in header fields.
svn path=/trunk/; revision=16462
2005-11-11 00:04:37 +00:00
Gerald Combs f9d4caf148 From Stig Bjørlykke:
I just learned how easy it is to reassemble multiple UDP packets, so  I
had to implement this for the P_Mul protocol :)

This patch fixes:
* Reassemble multiple data packets
* Add packet length check
* Fix for PDU type in tree entry

svn path=/trunk/; revision=16448
2005-11-09 16:01:35 +00:00
Anders Broman 8586ce47d2 From Stig Bjørlykke
A new dissector for P_Mul (ACP142) http://www.jcs.mil/j6/cceb/acps/Acp142.pdf

svn path=/trunk/; revision=16417
2005-11-07 19:35:48 +00:00