Commit graph

1162 commits

Author SHA1 Message Date
Stephen Fisher
f76387ba1c From Scott Robinson:
Enhancement patch:
  http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1758

This change gives Wireshark the ability to read ATM captures saved by UpTime
Select traffic capture.


svn path=/trunk/; revision=22612
2007-08-23 22:11:39 +00:00
Jeff Morriss
4020fb9c39 Move wtap_pcap_encap_to_wtap_encap()'s definition to libpcap.h so packet-ppi.c can get access to it even when we don't HAVE_LIBPCAP (besides, it doesn't seem to be specific to capturing...)
svn path=/trunk/; revision=22591
2007-08-22 19:38:49 +00:00
Guy Harris
2c041a8fa4 Cast away shortening conversions that are presumed not to lose any data.
Use G_GINT64_CONSTANT() to make a 64-bit integral constant; not all
compilers we use support LL as a suffix for that (MSVC++ 6, for one).

svn path=/trunk/; revision=22580
2007-08-22 02:45:42 +00:00
Richard van der Hoff
e6002deb3e From Shaun Jackman <sjackman@gmail.com> / bug 1753:
* asn1/mpeg/packet-mpeg-pes-template.c: Improved decoding of PES
        extension header and Pack header. Decode SCR, PTS, and DTS.
        * asn1/mpeg/mpeg-pes.asn (Pack): Remove.
        * epan/dissectors/packet-mpeg-pes.c: Regenerate.
        * wiretap/mpeg.c (mpeg_read): Decode the SCR using integer
        arithmetic instead of double float arithmetic to prevent rounding
        error.
        * wiretap/wtap-int.h (mpeg_t) <t0>: Use time_t instead of double.


svn path=/trunk/; revision=22577
2007-08-21 22:00:06 +00:00
Guy Harris
c193066114 At least some LAPB Windows Sniffer captures have 4 bytes of extra stuff
at the ends of packets.

svn path=/trunk/; revision=22540
2007-08-17 20:04:31 +00:00
Sake Blok
47ec0bead9 (http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1717)
This patch adds support for the Juniper NetScreen snoop output format. 
It takes a text-dump op the captured packets and parses the headers 
and hex-data. Since the snoop files on a Junpiper NetScreen can be saved 
to a tftp-server, this patch makes it quite easy to use the snoop 
function of the Juniper NetScreen firewalls.

/* XXX TODO:
 *
 * o  Create a wiki-page with instruction on how to make tracefiles
 *    on Juniper NetScreen devices. Also put a few examples up
 *    on the wiki (Done: wiki-page added 2007-08-03)
 *
 * o  Use the interface names to properly detect the encapsulation
 *    type (ie adsl packets are now not properly dissected)
 *    (Done: adsl packets are now correctly seen as PPP, 2007-08-03)
 *
 * o  Pass the interface names and the traffic direction to either
 *    the frame-structure, a pseudo-header or use PPI. This needs
 *    to be discussed on the dev-list first
 *    (Posted a message to wireshark-dev abou this 2007-08-03)
 *
 */


svn path=/trunk/; revision=22533
2007-08-17 08:03:32 +00:00
Guy Harris
adea9d1ffc Parenthesize macro arguments.
svn path=/trunk/; revision=22480
2007-08-09 22:50:16 +00:00
Jaap Keuter
f0b944adc9 Fix for bug 1659:
Changed eth_dir_get_name(dirent) macro

svn path=/trunk/; revision=22478
2007-08-09 20:40:32 +00:00
Jaap Keuter
171efad2b8 Fix for bug 1704:
libm required if C library is not libc (like uclibc)

svn path=/trunk/; revision=22475
2007-08-09 06:52:13 +00:00
Luis Ontanon
96f81d7eba From: Shaun Jackman
This patch adds MPEG PES (packetized elementary stream) to the list of
magic types in wiretap/mpeg.c.


svn path=/trunk/; revision=22460
2007-08-06 22:34:26 +00:00
Guy Harris
5238bd07f1 One quote mark sufficeth.
svn path=/trunk/; revision=22451
2007-08-04 03:47:20 +00:00
Guy Harris
b1e9777a81 1989 was quite a while ago. We use function prototypes extensively;
don't worry about YY_PROTO, which isn't defined with the newer shinier
versions of Flex.

svn path=/trunk/; revision=22450
2007-08-04 03:27:18 +00:00
Guy Harris
0f6b7b836e runlex.sh is in tools, not the top-level directory.
svn path=/trunk/; revision=22449
2007-08-04 03:14:00 +00:00
Guy Harris
c2d8a39d95 Sigh, crufty old shells. The Solaris test(1) manual says that
1) "-e" isn't supported by good old /bin/sh, so we use "-r"
	   instead;

	2) "The algorithm for determining the precedence of the
	   operators and the return value that will be generated is
	   based on the number of arguments presented to test", so we
	   explicitly parenthesize.

svn path=/trunk/; revision=22448
2007-08-04 03:11:06 +00:00
Guy Harris
517d6d57e4 Oops, forgot to check in the script for running Flex/Lex.
svn path=/trunk/; revision=22447
2007-08-04 02:36:21 +00:00
Guy Harris
5be4499ad1 Add a script as a front-end for Flex, to work around various problems,
such as the fact that Flex strips all but the last component of the "-o"
argument, and that it doesn't generate a header file to declare routines
the generated lexical analyzer defines.  Use that script when building
lexical analyzers, and, for each lexical analyzer, include the generated
header file in the generated analyzer.

svn path=/trunk/; revision=22446
2007-08-04 02:13:52 +00:00
Guy Harris
46be54cee3 Add a Makefile.nmake.inc file, to hold rules etc. used by multiple
Makefile.nmake files; currently, it has the (F)lex-to-C rule and a
.SUFFIXES pseudo-rule to add .l to the list of suffixes.  Have
Makefile.nmake files with .l.c rules include Makefile.nmake.inc to get
that rule.

The names Makefile.am.inc and Makefile.nmake.inc aren't necessarily the
right names for the files in question.

Use $(PACKAGE) in the Mate plugin's Makefile, rather than "mate".

svn path=/trunk/; revision=22437
2007-08-01 22:20:38 +00:00
Guy Harris
159e795100 Add a Makefile.am.inc file, to hold rules etc. used by multiple
Makefile.am files; currently, it has the (F)lex-to-C rule.  Have
Makefile.am files with .l.c rules include Makefile.am.inc to get that
rule.

svn path=/trunk/; revision=22436
2007-08-01 20:35:05 +00:00
Guy Harris
61dd46fa9c Use a common .l.c rule for running Flex on .l files, just as is done on
UN*X.

svn path=/trunk/; revision=22434
2007-08-01 00:22:25 +00:00
Martin Mathieson
0a5437dc33 Add "igmp" -> "ip" mapping.
svn path=/trunk/; revision=22430
2007-07-31 13:53:45 +00:00
Guy Harris
968d363f11 Add comments to various %option items to explain what they're doing.
Move the %options to the beginning if they weren't already there, and
put them in the same order in all files.

Add "prefix=" options to .l files that don't already have them, so we
don't have to pass a "-P" option.

Add "never-interactive" and "noyywrap" options to our lexical analyzers,
to remove extra isatty() checks and to eliminate the need for yywrap()
from the Flex library.

Get rid of %option nostdinit - that's the default.

Add .l.c: rules to Makefile.am files, replacing the rules for specific
.l files.  Have those rules all check that $(LEX) is set.

Update the address for the FSF.

svn path=/trunk/; revision=22424
2007-07-30 20:22:37 +00:00
Guy Harris
f104bfa2ad I think the intent, at least, is to allow people to build Wireshark from
a source release tarball without having Flex (think of a source release
tarball being as much a platform-independent distribution format for
people *not* interested in development, and who are on platforms for
which there aren't binary packages, as a way of getting the source to do
development).  Don't check Flex's capabilities in the configure script
(handling reentrant scanners would have to be done differently).

svn path=/trunk/; revision=22414
2007-07-27 18:52:05 +00:00
Guy Harris
96ef450636 Step 1 in adding support for reentrant Flex scanners if Flex supports
them - check whether Flex supports them.

svn path=/trunk/; revision=22410
2007-07-27 02:51:42 +00:00
Martin Mathieson
2cf2fed06a More space needed for wimax frames.
svn path=/trunk/; revision=22395
2007-07-24 15:15:02 +00:00
Guy Harris
90ab61d9f7 Fix another cast of the argument to a ctype.h macro.
svn path=/trunk/; revision=22305
2007-07-14 00:29:03 +00:00
Guy Harris
3ccd39aec7 Fix more ctype.h calls - casting to "int" suppresses the warning, but
doesn't fix the problem, as the sign extension is still done; you have
to cast to "guchar".

svn path=/trunk/; revision=22304
2007-07-13 23:20:02 +00:00
Guy Harris
7e95109118 "isdigit()" doesn't need to be cast to "int".
Its argument, however, needs to be cast to "guchar", so that if the
high-order bit is set, it doesn't get sign-extended.

svn path=/trunk/; revision=22303
2007-07-13 23:18:04 +00:00
Martin Mathieson
c4ebb075e7 Worked out properly the silly way aal header is encoded!
svn path=/trunk/; revision=22300
2007-07-13 15:51:34 +00:00
Jaap Keuter
6d6affd859 From Jim Paris:
The encap_table_base in wcap.c is missing an entry.
This causes e.g. "dumpcap -i usb3 -L" to output:
  Data link types (use option -y to set):
    USB_LINUX
   (MPEG)

svn path=/trunk/; revision=22292
2007-07-12 19:55:12 +00:00
Guy Harris
3242580dfa Check %l[doux] first, when looking for the format to use with 64-bit
integral data types, so we handle LP64 platforms if "gint64" is just a
"long int".

svn path=/trunk/; revision=22281
2007-07-09 20:27:38 +00:00
Jaap Keuter
668689a69d Now it really can read MP3 files, without SIGABRT.
svn path=/trunk/; revision=22261
2007-07-06 22:27:03 +00:00
Martin Mathieson
1d477c802c - Map gre -> IP
- Change a value string value to help an easily-frightened colleague

svn path=/trunk/; revision=22224
2007-06-29 16:16:57 +00:00
Martin Mathieson
1b8fccbc9d Don't create & leak a hash table during unsuccessful open()
svn path=/trunk/; revision=22150
2007-06-21 17:30:13 +00:00
Gerald Combs
d1a745f27b Add support for PPI (the Per-Packet Information header), described at
http://www.cacetech.com/documents/PPI_Header_format_1.0.pdf .

svn path=/trunk/; revision=22094
2007-06-13 22:36:58 +00:00
Luis Ontanon
e3fc848842 turns out that wtap_pkthdr was not exportable!
nm on my mac says it is there...


svn path=/trunk/; revision=22093
2007-06-13 19:43:26 +00:00
Luis Ontanon
df05be6cf4 Export all that's exportable from libwiretap.dll
svn path=/trunk/; revision=22092
2007-06-13 19:06:19 +00:00
Luis Ontanon
d24ceffe73 Fix coverity bug 244, [WS Bug 1649]
svn path=/trunk/; revision=22091
2007-06-13 19:05:03 +00:00
Bill Meier
68cdbd4e65 Note invalidity of realtick for
captypes ETH_CAPTYPE_OTHERPOD2 and
ETH_CAPTYPE_GIGPOD2 in comments for
the associated TpS tables.

svn path=/trunk/; revision=22074
2007-06-11 15:50:03 +00:00
Guy Harris
230c951306 From Stephen Donnelly of Endace:
The code for reading ERF files has not been significantly
	updated since 2004.  This patch brings it up to date with a
	number of changes.

	1) Increase number of decodable ERF types from 7 to 12. This
	   covers newer DAG card models and firmware updates.

	2) Fix timestamp conversion. Was calculating only microsecond
	   precision, now displaying with nanosecond resolution.  Hardware
	   precision is 7.5 to 30 ns depending on model.

	3) Allow the user to specify HDLC encapsulation as 'chdlc',
	   'ppp_serial', 'frelay' or 'mtp2'.  This is needed because the
	   ERF HDLC capture formats do not include information on what
	   protocol is used at the next level.  This is currently done via
	   an environment variable 'ERF_HDLC_ENCAP' and is analagous to the
	   existing 'ERF_ATM_ENCAP' variable.

	   If the user does not specify an HDLC encapsulation it tries to
	   guess, and falls back to MTP2 for backwards compatibility with
	   Florent's existing behaviour.

	   I know environment variables are ugly, suggestions are welcome.

	4) When reading HDLC captures as MTP2, use
	   WTAP_ENCAP_MTP2_WITH_PHDR rather than WTAP_ENCAP_MTP2.  This
	   allows us to put the 'Multi-Channel ERF' record 'channel
	   number' field into the MTP2 pseudo header > 'link_number'
	   field.  This is then displayed in Frame information, and can
	   be filtered on.  (Would be nice if it could be made a display
	   column?)

	Because the ERF record does not specify whether Annex A is used
	or not, we pass MTP2_ANNEX_A_USED_UNKNOWN and allow the existing
	user preference to decide.

Move the MTP2_ANNEX_A_ definitions into Wiretap, make the annex_a_used
field a guint8, and change MTP2_ANNEX_A_USED_UNKNOWN to 2 so it fits in
a guint8.  (This means that if you can save an ERF MTP2 file as a
libpcap file, the pseudo-header will have MTP2_ANNEX_A_USED_UNKNOWN in
it.)

svn path=/trunk/; revision=22067
2007-06-08 17:06:13 +00:00
Luis Ontanon
475916db3c Actually implement wtap_register_file_type() and have it returning the ID of the new file type.
Add few functions to wiretap's exported API.



svn path=/trunk/; revision=22060
2007-06-06 20:56:38 +00:00
Guy Harris
35546bfcc8 Note the version numbers in NetMon 3.0 files.
svn path=/trunk/; revision=22050
2007-06-05 17:17:22 +00:00
Guy Harris
ef511c0bbc Note realtick's invalidity for ETH_CAPTYPE_OTHERPOD in the comment for
TpS_otherpod[].  Ask about its validity for ETH_CAPTYPE_OTHERPOD2 and
ETH_CAPTYPE_GIGPOD2.

svn path=/trunk/; revision=22016
2007-05-31 05:51:15 +00:00
Guy Harris
aa3ac312b2 My comment is redundant with Bill's more-detailed comment; remove it.
svn path=/trunk/; revision=22015
2007-05-31 05:46:45 +00:00
Bill Meier
e88e33d5e2 Update Comments
svn path=/trunk/; revision=22005
2007-05-30 15:32:31 +00:00
Guy Harris
70a9743831 Update a comment.
svn path=/trunk/; revision=21998
2007-05-30 00:36:32 +00:00
Guy Harris
cba6441fa4 Give more detail on a captype of 6 for an Ethernet capture.
svn path=/trunk/; revision=21997
2007-05-29 23:35:45 +00:00
Guy Harris
acde0f9f8a It's pretty clear that hdr.captype's interpretation depends on the
network type; there's no "presumably" about it.

Suggest that "realtick" might have the right time stamp in other cases
(if not, a comment should explicitly indicate that, so that in all cases
where we either know that realtick is wrong or have a lot of evidence to
show that it's right, we note that fact).

svn path=/trunk/; revision=21996
2007-05-29 23:31:03 +00:00
Guy Harris
f93cf6dd86 Update the big time unit comment to reflect Bill Meier's recent changes.
Fix some other comments.

Add a suggestion for why the realtick values might correlate with
packets having an FCS.

svn path=/trunk/; revision=21993
2007-05-29 22:52:42 +00:00
Martin Mathieson
2d6388599a Work with isdn_l2.
svn path=/trunk/; revision=21986
2007-05-29 14:38:40 +00:00
Bill Meier
0bf864bc32 (fix comment)
svn path=/trunk/; revision=21983
2007-05-29 14:27:42 +00:00
Bill Meier
3b12c867a2 Another sniffer timestamp display fix; addresses bug 866 and other reports.
(Also: change variable name to correctly reflect usage).

svn path=/trunk/; revision=21982
2007-05-29 14:20:54 +00:00
Guy Harris
267a2cbf02 Print a gint64 the right way.
svn path=/trunk/; revision=21976
2007-05-29 06:16:24 +00:00
Sebastien Tandel
76729e5d0f From David Howells :
Fix compilation failures when building wireshark-0.99.6-SVN-21916 on an
x86_64-unknown-linux-gnu target with gcc version 4.1.2 20070403 (Red Hat
4.1.2-8).

The failures fall into two categories:
  (1) Casts between pointers and 32-bit integers without an intermediary cast
via 'long' or 'unsigned long'.  This results in a compiler warning complaining
about casts between a pointer and an integer of a different size.
  (2) Passing values to "%lld" or similar printf-style format options that the
compiler thinks are a different size.  Such values need to be cast to 'long
long' or 'unsigned long long'.

svn path=/trunk/; revision=21975
2007-05-29 02:43:18 +00:00
Guy Harris
00c0d3de9f Throw in some casts to suppress warnings.
svn path=/trunk/; revision=21971
2007-05-28 08:31:18 +00:00
Guy Harris
e49fe5baec Change the Wiretap code so that it doesn't dereference
possibly-unaligned pointers, and turn on -Wcast-align so at least some
future code that does that will fail to compile.

svn path=/trunk/; revision=21968
2007-05-28 06:47:50 +00:00
Luis Ontanon
9e7615967b remove the never used wiretap/wtap-plugins.c
svn path=/trunk/; revision=21936
2007-05-25 17:23:46 +00:00
Guy Harris
4703ca6fc4 Get rid of CR's, and add a newline at the end.
Set svn:keywords and svn:eol-style appropriately.

svn path=/trunk/; revision=21923
2007-05-24 17:02:06 +00:00
Guy Harris
b0f2653497 Back out the previous change.
svn path=/trunk/; revision=21918
2007-05-24 12:00:55 +00:00
Guy Harris
cbd762e968 Temporarily turn on a bunch of warnings and turn off -Werror, to see
what the complete set of warnings we should either try to fix or, for
cases where it can't be fixed, turn off or or avoid -Werror for.  I'll
revert this change as soon as a complete set of buildbot builds start
with it.

svn path=/trunk/; revision=21917
2007-05-24 11:43:53 +00:00
Jaap Keuter
3272e98c39 Fix for bug 1601: handle zero length packets.
svn path=/trunk/; revision=21904
2007-05-23 06:03:48 +00:00
Jörg Mayer
b7755fb4e4 Fix some (incorrect but unforseeable)
"might be used uninitialized" warnings.

svn path=/trunk/; revision=21862
2007-05-21 16:16:18 +00:00
Ronnie Sahlberg
532f102662 make the workaround use static so it wont dissapear when the frame ends
svn path=/trunk/; revision=21851
2007-05-21 02:13:21 +00:00
Ronnie Sahlberg
12f013d5fa workaroung a warning for const that prevents gtk1 builds
svn path=/trunk/; revision=21850
2007-05-21 02:12:19 +00:00
Jörg Mayer
e3e1d07557 Fix a typo to make compiling with extra-gcc flags disable compiling with
errors.

svn path=/trunk/; revision=21840
2007-05-20 14:40:45 +00:00
Sebastien Tandel
2f921aa4c7 typo fix
svn path=/trunk/; revision=21836
2007-05-19 18:42:58 +00:00
Sebastien Tandel
c60b0a4f3a temporarily put cast-align in extra-gcc-warnings while compilation on Solaris
slave generates 'cast increases required alignment of target type' warnings. 


svn path=/trunk/; revision=21835
2007-05-19 18:38:45 +00:00
Sebastien Tandel
55a4b5ad93 temporarily disable cast-align warnings
svn path=/trunk/; revision=21821
2007-05-18 00:04:58 +00:00
Sebastien Tandel
e545636a4f include generator sources in EXTRA_DIST
svn path=/trunk/; revision=21820
2007-05-18 00:00:10 +00:00
Sebastien Tandel
8e9a3ba58d Since code generated by lex may trigger gcc warnings, we are now generating two
libraries.  A single library is generated with the lex code without the barrier
"stop on warning". An other library is generated from the remaining source
files with the "stop on warning" barrier.


svn path=/trunk/; revision=21817
2007-05-17 18:02:22 +00:00
Martin Mathieson
47a9c22ad4 mipv6 -> ip
svn path=/trunk/; revision=21741
2007-05-10 15:29:38 +00:00
Ulf Lamping
b2afad68fb fix manifest error: for dll's mt.exe must be given ;2
svn path=/trunk/; revision=21735
2007-05-09 06:33:22 +00:00
Jörg Mayer
5b41e5bec5 propset...
svn path=/trunk/; revision=21725
2007-05-08 17:12:59 +00:00
Ronnie Sahlberg
a7faef785f new attempt to resolve recent breakage
svn path=/trunk/; revision=21710
2007-05-07 07:33:26 +00:00
Ronnie Sahlberg
119634f650 GTK1 does not have GDir and as such needs to include dirent.h
Since wiretap.h is not autogenerated, just make wtap-plugins.h include
the top level config.h to pull in the defines for HAVE_DIRENT which was 
checked at top level


svn path=/trunk/; revision=21707
2007-05-07 06:17:58 +00:00
Ulf Lamping
0abc3ba979 instead of copying the MSVC 2005 manifest files around, embed them into the .exe / .dll files - this way is easier to handle while packaging and alike, and probably will solve some problems. We might want to do this for the plugins as well later.
svn path=/trunk/; revision=21696
2007-05-06 09:17:19 +00:00
Ulf Lamping
3c2089e582 fix win32 build by using wtap_get_num_file_types() instead of direct variable access
svn path=/trunk/; revision=21689
2007-05-05 10:47:35 +00:00
Luis Ontanon
131cecd1e8 Add a plugin interface to wiretap.
So far I've done only regression testing (the new functionality and what's in wtap-plugins.c has not yet being tested).

it is a first step in the way to have lua opening files.



svn path=/trunk/; revision=21686
2007-05-04 21:10:55 +00:00
Luis Ontanon
bb7e52fcd8 will this finally get rid of the warnigs?
svn path=/trunk/; revision=21666
2007-05-03 18:32:52 +00:00
Luis Ontanon
13b1ebe574 fix warnings
svn path=/trunk/; revision=21653
2007-05-02 21:58:52 +00:00
Luis Ontanon
d4fd968d50 add support for the text export format of textronix k1[25]
svn path=/trunk/; revision=21651
2007-05-02 20:09:42 +00:00
Guy Harris
235596a3c8 From Jeff Foster: add support for Cisco HDLC captures.
svn path=/trunk/; revision=21598
2007-04-26 20:06:06 +00:00
Guy Harris
e7931530dd Grr. Flex. Can't make warnings errors yet - we'd have to keep that
from being done on Flex-generated files, or fix the problems that pop up
on some platforms.

svn path=/trunk/; revision=21520
2007-04-23 03:09:23 +00:00
Guy Harris
f5b1131374 Make warnings errors when possible.
svn path=/trunk/; revision=21519
2007-04-23 02:48:40 +00:00
Guy Harris
8093569ebe Add a couple more warnings to the standard set.
svn path=/trunk/; revision=21516
2007-04-23 00:28:50 +00:00
Guy Harris
3b884cb0df Propagate Joerg's fix to make --enable-extra-gcc-checks turn off
--enable-warnings-as-errors (if any tests enabled by
--enable-extra-gcc-checks are safe to treat as errors, they're safe to
turn on by default).

svn path=/trunk/; revision=21515
2007-04-22 23:52:38 +00:00
Guy Harris
aff8dc680d Turn on almost all warnings for Wiretap - if any of them cause problems
on some platforms due to unfixable problems (e.g., crappy vendor
headers), we can move them back to the "extra" list.

Put those warnings in the order in which they appear in the GCC man page
on my machine.

If we turn on -pedantic, try turning on -Wno-long-long as well, so that
it's not *so* pedantic that it rejects the 64-bit integral data types
that we explicitly require.

svn path=/trunk/; revision=21514
2007-04-22 23:47:56 +00:00
Sebastien Tandel
706627f882 adding AC_(WIRESHARK|WIRETAP)_GCC_CFLAGS_OPTION macro to test whether gcc
supports the options passed as arguments. If the options are supported, they
are added to CFLAGS.


svn path=/trunk/; revision=21493
2007-04-22 09:27:21 +00:00
Guy Harris
23faf81799 Use AC_HELP_STRING for the help strings for --with and --enable flags.
Add -Wpointer-arith to the GCC -W flags by default.

Make "extra-gcc-checks" and "warnings-as-errors" --enable flags rather
than --with flags - autoconf's model is that --enable is for turning
features on or off, --with is for enabling or disabling the use of
external packages (libpcap, Net-SNMP, GNU ADNS, etc.).

When testing whether the compiler is GCC, use the same style all the
time - check whether "x$GCC" equals "xyes".  (The "x" might be overkill
- if you don't quote the arguments, it avoids a missing argument to
"test"/"[", but if you do, it might not be needed.)

svn path=/trunk/; revision=21492
2007-04-22 07:22:37 +00:00
Guy Harris
464e5030ca Fix a comment to reflect reality - -Wcast-qual is added only with
--with-extra-gcc-checks.

Unconditionally add -Wpointer-arith to GCC flags, and, if
--with-extra-gcc-checks is specified, add -Wstrict-prototypes.

svn path=/trunk/; revision=21491
2007-04-21 23:04:36 +00:00
Guy Harris
3b120c2491 Match "%4x" with an unsigned value in sscanf.
Check for a case where, conceivably, the on-the-wire packet length (from
the IP header) could be shorter than the captured data length (due to
Ethernet padding), and handle it by making sure the on-the-wire length
is always >= the captured data length.

svn path=/trunk/; revision=21490
2007-04-21 22:59:52 +00:00
Guy Harris
48f03c7800 Get rid of a warning with at least some compilers.
svn path=/trunk/; revision=21489
2007-04-21 22:58:03 +00:00
Guy Harris
5713f53652 Explicitly mark new_k12_file_data() as taking no arguments - in C89, at
least, "int foo()" defines or declares an old-style function, not one
with no arguments.

svn path=/trunk/; revision=21488
2007-04-21 22:57:22 +00:00
Jeff Morriss
046cf4db31 Fix --with(out)-warnings-as-errors test so warnings-as-errors can be disabled (with gcc)
svn path=/trunk/; revision=21453
2007-04-17 10:01:39 +00:00
Sebastien Tandel
aa17869bf7 remove "treat warnings as errors" barrier for every repo containing code
generated by $(LEX) until a solution is found to compile them separately.


svn path=/trunk/; revision=21432
2007-04-14 14:07:46 +00:00
Jörg Mayer
8f3934e243 Beginnings of a Cisco ERSPAN dissector - the only thing missing is the code
to actually call this (aka to handle the ambiguities of DLT values).

svn path=/trunk/; revision=21427
2007-04-14 01:07:36 +00:00
Jörg Mayer
d5b5c41fa9 Same as for top level configure.in
svn path=/trunk/; revision=21426
2007-04-14 00:41:08 +00:00
Sebastien Tandel
d9e06450f4 change the script to automatically stop on warning if compiling with gcc.
svn path=/trunk/; revision=21422
2007-04-13 23:10:13 +00:00
Jaap Keuter
c150904c6a Fix for bug 1526. Compare to uppercased strings.
svn path=/trunk/; revision=21361
2007-04-10 05:38:57 +00:00
Guy Harris
c45434ce68 Fix a comment.
svn path=/trunk/; revision=21356
2007-04-08 20:42:08 +00:00
Guy Harris
69fec60a52 Fix up the configure message about extra GCC flags to indicate what
flags are being added.

Quote the message about flags added for the Apple linker, so it shows up
correctly.

svn path=/trunk/; revision=21355
2007-04-08 20:35:56 +00:00
Luis Ontanon
36e6827984 There are odd packet records in k15 generated files where the interface record does not match any given one.
I noticed that these records have the first byte changed so When a lookup fails mask the byte and lookup again.


svn path=/trunk/; revision=21303
2007-04-02 22:17:15 +00:00
Stephen Fisher
0e34913ca8 From James Menzies:
This corrects two long standing issues with the Visual
Networks file type in PPP and ML-PPP environments.


svn path=/trunk/; revision=21293
2007-03-31 22:38:10 +00:00
Stephen Fisher
8fd3ee0560 Remove almost all of the casts I committed recently and in place of
them, add -Wno-pointer-sign to CFLAGS when gcc will accept it.


svn path=/trunk/; revision=21253
2007-03-28 21:55:11 +00:00
Jeff Morriss
8c858b3787 Change the test for -Wdeclaration-after-statement slightly to make it work for me. Also redirect its stderr to /dev/null to avoid worrying users
svn path=/trunk/; revision=21208
2007-03-26 08:31:23 +00:00
Ronnie Sahlberg
988a5e16a3 make the test for -Wdeclaration-after-statement gcc 2.96 friendly.
and once again the mighty wireshark compiles on rh71



svn path=/trunk/; revision=21206
2007-03-26 06:58:22 +00:00
Jeff Morriss
a0086f5098 Also try to set -Wdeclaration-after-statement in wiretap
svn path=/trunk/; revision=21200
2007-03-26 02:05:54 +00:00
Guy Harris
07d6794bea All private data for a capture in a Wiretap module must be per-file, not
static to the module.

Add the older(?) ID tag for MPEG audio.

Just use the ID at the beginning to identify MPEG audio files; don't
check the file any further.

If the read of the magic number doesn't work, get the error, and, if
there is no error (i.e., it's a short read), just return 0 (meaning "no
error, but this isn't that type of file).

Similarly, if the magic number doesn't match, just return 0, so other
types of file are tried.

svn path=/trunk/; revision=21192
2007-03-25 22:07:40 +00:00
Luis Ontanon
4e7a4e0b06 make the mpeg_open() more conservative checking whether there's ssome magic bytes at the beginning of the file.
I added just one type of mpeg magic ("ID3") there's probably more, please add.

svn path=/trunk/; revision=21185
2007-03-25 19:00:59 +00:00
Stephen Fisher
2896811274 Fix about 150 warnings new to gcc 4.0 in the error on warning directories.
Comment out -Werror in plugins/asn1/ until warnings can be fixed.


svn path=/trunk/; revision=21158
2007-03-23 22:49:23 +00:00
Stephen Fisher
62f88a4a04 From Sebastien Tandel:
(Temporarily disable the warnings as errors default on Unix to get
to get the buildbots and people with gcc40 going again until those
additional warnings gcc40 generates can be fixed-I'm working on it
ASAP)

   Patch for configure.in which disables by default the treatment of
warnings as errors.
It can be enabled with './configure --with-warnings-as-errors'.
The macro will test first if GCC is present. If it's the case,
HAVE_WARNINGS_AS_ERRORS is defined. All the USING_GCC have been replaced
by HAVE_WARNINGS_AS_ERRORS.
With this switch, people won't suffer from unexpected warnings when
downloading svn sources during the transition time ;)


svn path=/trunk/; revision=21153
2007-03-23 17:49:59 +00:00
Stephen Fisher
bede68648b Fix some warnings on the Solaris buildbot
svn path=/trunk/; revision=21147
2007-03-23 05:50:31 +00:00
Ulf Lamping
636924e7c8 fix a new warning
svn path=/trunk/; revision=21128
2007-03-22 23:14:37 +00:00
Stephen Fisher
cdf47e536b Add -Werror when using GCC only to the Makefile.am of the base
directory and most of the plugins to match the same command 
put in the Makefile.nmake files for Windows compliations.  Fix
a few warnings when compiling under gcc 3.4.4 on FreeBSD.  Create
new automake file variable called USING_GCC in configure.in and
wiretap/configure.in to acomplish the above -Werror addition. 


svn path=/trunk/; revision=21127
2007-03-22 23:03:39 +00:00
Graham Bloice
f75e9eda65 Added mpeg exports
svn path=/trunk/; revision=21116
2007-03-22 12:55:01 +00:00
Ronnie Sahlberg
eac30afbec From Graham Bloice
Remove compiler warnings


svn path=/trunk/; revision=21115
2007-03-22 11:59:39 +00:00
Ronnie Sahlberg
80525da7db Add some missing includes and hope that msvc will find the definition for off_t
svn path=/trunk/; revision=21113
2007-03-22 11:33:18 +00:00
Ronnie Sahlberg
430eef27fe From Shaun Jackman
Wiretap support to read MPEG files


svn path=/trunk/; revision=21112
2007-03-22 10:44:33 +00:00
Ulf Lamping
f953c1b000 fix another warning
svn path=/trunk/; revision=21079
2007-03-21 02:47:53 +00:00
Ulf Lamping
77ec324774 set compiler option "treat warnings as errors" - to prevent new warnings for wiretap
remove all compiler warnings:
a) prevent wrong malloc/free definitions by lex/yacc generated files
b) add int/time_t casts - MSVC2005 is more "sensitive" about this than MSVC6

svn path=/trunk/; revision=21078
2007-03-21 01:32:50 +00:00
Bill Meier
04d29de81d Fix Windows Makefiles so clean removes all pdb files (PDB_FILE no longer defined)
svn path=/trunk/; revision=21052
2007-03-18 15:36:22 +00:00
Luis Ontanon
ebf1dd00ce rename a variable.
svn path=/trunk/; revision=21045
2007-03-17 17:55:19 +00:00
Luis Ontanon
5e2ebee66a K15 final:
add another interface record type with the very same arch than the "old" one.

now I can read all the K15 files I got.

svn path=/trunk/; revision=21044
2007-03-17 17:40:21 +00:00
Luis Ontanon
55d05abf5e K15 phase 1
be able to read files with records larger than 0x2000 bytes

this fixes http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=532

svn path=/trunk/; revision=21043
2007-03-17 14:56:04 +00:00
Luis Ontanon
9be42ac4dc Major cleanup of debug code and whitespace changes.
svn path=/trunk/; revision=21013
2007-03-10 02:04:57 +00:00
Gerald Combs
b7d30175c0 Fix a couple of off-by-one overflows reported in bug 1415. Update the
release notes accordingly.

svn path=/trunk/; revision=20990
2007-03-07 01:17:24 +00:00
Jeff Morriss
28767302a5 From Florent Drouin: support for MTP2 in ERF type 5 (Multi-Channel HDLC) files
svn path=/trunk/; revision=20838
2007-02-18 11:32:54 +00:00
Luis Ontanon
7432291121 From: Kriang Lerdsuwanakij
In the attached patch, the K12 wiretap now saves the content of record
after captured packet data. The K12 dissector then could extract them and provide
useful information to properly dissect FP frames (user plane of UTRAN Iub
interface).



svn path=/trunk/; revision=20749
2007-02-08 17:35:03 +00:00
Luis Ontanon
a84df38651 from:
Kriang Lerdsuwanakij <lerdsuwa@users.sourceforge.net> 	

I discovered that Wireshark K12xx detects the type of input (E1 timeslot or ATM)
based on the extra information. My previous patch to enable Wireshark to open
K12xx files with no extra information (extra_len equals 0 in SRCDEST record)
failed to give later dissectors the input type.

Attached is the patch to correct this for ATM PVC. It adds VPI/VCI/CID information
for display in the dissected tree (in k12_open function). k12_read and k12_seek_read
are also made more robust. These are reverse engineered based on hexeditor
and constants found in tektronix configuration file. Please apply the patch.


svn path=/trunk/; revision=20705
2007-02-04 02:13:12 +00:00
Ulf Lamping
cd5aae8116 instead of putting the MSC_VER_REQUIRED test into the root Makefile (which would require to change ALL makefiles - the buildbot revealed it), simply put it in the wiretap generation. As wiretap is mandatory and one of the first things to be build this doesn't even sound like a bad idea anyway ...
svn path=/trunk/; revision=20646
2007-01-31 05:26:41 +00:00
Guy Harris
9633ac8fee From Paolo Abeni: update to support the new DLT_USB_LINUX format header.
Modified to support the header as a pseudo_header rather than as part of
the packet data.

Fixed some calls that fetch data from the USB packet to fetch it in
little-endian byte order.

Got rid of redundant code to get conversation-specific data (the
get_usb_conv_info() call already does that).

For control packets, only parse the setup information if setup_flag is
0.

Don't interpret a control packet as a standard request unless the setup
type is "Standard".

svn path=/trunk/; revision=20632
2007-01-30 20:07:55 +00:00
Luis Ontanon
6a2d87516a from Kriang Lerdsuwanakij
I found out the reason Wireshark refuses to read some .rf file I have.
Those files have zero extra_len in SRCDEST header structure. See the
attached file for example. It was created by selecting some frames from
a larger .rf5 file (within Tektronix's own reader) and save as a
separate file.


svn path=/trunk/; revision=20579
2007-01-28 01:24:20 +00:00
Guy Harris
dd54b08eda Put in some information about RSSI.
svn path=/trunk/; revision=20498
2007-01-19 05:22:43 +00:00
Guy Harris
0fb0fa8794 Put
#ifdef __cplusplus
	extern "C" {
	#endif /* __cplusplus */

		...

	#ifdef __cplusplus
	}
	#endif /* __cplusplus */

wrappers into some header files, for the benefit of C++ plugins.  Also,
add multiple-include protections.

svn path=/trunk/; revision=20485
2007-01-18 18:43:30 +00:00
Guy Harris
0f44dcb15c From Clay Jones: Shomiti wireless packet support.
svn path=/trunk/; revision=20475
2007-01-18 12:19:17 +00:00
Martin Mathieson
997e5415f9 Add separate union entries to fvalue.value for signed and unsigned
32-bit numbers.  Separate signed and unsigned accessors have been
added and used where appropriate.

Definitely not for 0.99.5.

svn path=/trunk/; revision=20472
2007-01-18 11:02:26 +00:00
Luis Ontanon
e648b5c77b fix Bug 1301
do not let the ascend_open() read more than 256K without finding the first packet.


svn path=/trunk/; revision=20424
2007-01-14 06:13:07 +00:00
Guy Harris
bbdb2dd733 Automake variables ending with _LDFLAGS are special:
http://sources.redhat.com/ml/automake/2001-08/msg00046.html

so call it LDFLAGS_SHAREDLIB rather than SHAREDLIB_LDFLAGS.

svn path=/trunk/; revision=20410
2007-01-12 21:04:33 +00:00
Ulf Lamping
f3235a259f second try for file_util.c ... (at least OS X didn't liked it)
svn path=/trunk/; revision=20403
2007-01-12 05:47:12 +00:00
Ulf Lamping
2cbce84d41 Win32: MSVC > 6 doesn't work well with Unicode filenames!
fix this, by providing required functions in the new file file_util.c - it's mostly copied from GLib (g_open alike - that take UTF8 as filename format but don't use msvcrt.dll V6 for this as the glib files do) 

"link" to these functions in file_util.h: #define eth_open eth_stdio_open

revert changes (from SVN 20282) throughout the code related to these file functions which were introduced with the first tries of MSVC 2005 ...

Hopefully I've done everything right with the new file_util.c ...

svn path=/trunk/; revision=20402
2007-01-12 03:05:28 +00:00
Guy Harris
0e89a5617f We support nanosecond resolution in Wiretap; use that with AIX libpcap
files.

svn path=/trunk/; revision=20338
2007-01-08 02:55:41 +00:00
Guy Harris
4189374651 When Mr. Genius added the SHAREDLIB_LDFLAGS stuff, he forgot that
Wiretap has its own configuration file.  Do to its configuration file
what was done to the top-level configuration file.

svn path=/trunk/; revision=20326
2007-01-05 07:36:30 +00:00
Guy Harris
405b7189a4 On Darwin, build shared libraries with -Wl,-single_module to the LDFLAGS
used with shared libraries, to fix some error that shows up in some
cases; some Apple documentation recommends it for most shared libraries.

svn path=/trunk/; revision=20312
2007-01-04 20:47:43 +00:00
Martin Mathieson
b9f69234ad Check in trivial changes before generating a big diff...
svn path=/trunk/; revision=20304
2007-01-04 13:25:25 +00:00
Ulf Lamping
59cebb950f remove the PDB_FILE setting from config.nmake - there's no real need for this info
add some missing files to the clean targets

svn path=/trunk/; revision=20290
2007-01-03 05:41:11 +00:00
Ulf Lamping
894f6cd603 from Laurent Rabret:
I posted a patch about 1.5 years ago for the formerly Ethereal to successfully compiled with Visual > 6. I have always successfully used this patched Ethereal/Wireshark compiled with VS 2003 and have just checked when compiled with Visual C++ 2005 Express

svn path=/trunk/; revision=20282
2007-01-03 02:50:22 +00:00
Jaap Keuter
224a21ecfe From Mark C. Brown:
HP-UX 11.31 will add a new nettl trace subsystem, NS_LS_TELNET (ID=267).
NS_LS_TELNET is just raw telnet data.  There is no layer 2/3/4 headers, so
there's just the HP-UX nettl record header followed directly by the TCP payload
for a telnet connection.  Thus the need for a new wiretap encapsulation type...

svn path=/trunk/; revision=20253
2007-01-01 14:48:18 +00:00
Jaap Keuter
33310e87b6 From Mark C. Brown:
Fix some nettl encap types and size checks

svn path=/trunk/; revision=20252
2007-01-01 14:43:15 +00:00
Guy Harris
979195c122 Fix indentation.
svn path=/trunk/; revision=20213
2006-12-25 21:34:11 +00:00
Anders Broman
6c9ce8acf8 Froim Rene Pilz:
This patch consists also the last issues. Additionally it solves:
- For the SSCOP frames the AAL5 decoding was not performed due to an earlier patch. This caused that no SSCOP message was properly decoded.
- As the detection between a LANE frame and a SSCOP frame is rather hard a switch within the atm dissector is included which enforce SSCOP dissecting over a LANE frame. At the moment I do not see a better solution for that.

svn path=/trunk/; revision=20013
2006-11-29 06:44:07 +00:00
Guy Harris
8d8a1cb32a Map a DLT_ value of 188 to WTAP_ENCAP_IEEE802_16_MAC_CPS, and clarify
what a DLT_ value of 187 is.

svn path=/trunk/; revision=20004
2006-11-27 18:41:45 +00:00