Commit Graph

42 Commits

Author SHA1 Message Date
Martin Mathieson 48db2548a9 Deleting unneccessary #includes from dissectors.
Second batch (packet-eth.c -> packet-icmpv6.d).

Will look at cleaning up and committing script afterwards.

Change-Id: I14295758b81a59115d8c88899f166cc3d5d17594
Reviewed-on: https://code.wireshark.org/review/6013
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-23 12:22:54 +00:00
AndersBroman bba77c3fc0 tvb_length -> tvb_reported_length
Change-Id: I48b618008c8c8accd6f161bdc42e02906a4765b7
Reviewed-on: https://code.wireshark.org/review/5085
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-11-03 15:21:43 +00:00
Bill Meier 9b181b97c6 Add editor modelines; Adjust whitespace; Remove boilerplate comments
Change-Id: I1f5f83ed441f6009125cf2cbe5023af04986898a
Reviewed-on: https://code.wireshark.org/review/4392
Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-30 21:06:37 +00:00
Michael Mann 14824e6adf Revert "Fixup: tvb_* -> tvb_captured"
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html

This reverts commit 246fe2ca4c.

Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f
Reviewed-on: https://code.wireshark.org/review/2430
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19 18:25:59 +00:00
Dario Lombardo 246fe2ca4c Fixup: tvb_* -> tvb_captured
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f
Reviewed-on: https://code.wireshark.org/review/2377
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-18 14:14:58 +00:00
AndersBroman 9a977fc8d0 Add dissection of 3G Interface Type package and add some comments about
the usage of variables in the h248_package_t struct.

Change-Id: Ic5419ab5c20051e56963fe8ea1728d78f95538f0
Reviewed-on: https://code.wireshark.org/review/846
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-27 16:54:05 +00:00
Alexis La Goutte 296591399f Remove all $Id$ from top of file
(Using sed : sed -i '/^ \* \$Id\$/,+1 d')

Fix manually some typo (in export_object_dicom.c and crc16-plain.c)

Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8
Reviewed-on: https://code.wireshark.org/review/497
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04 14:27:33 +00:00
Guy Harris 0a99ee25d5 Don't make claims of constness that can't be guaranteed in terms the C
compiler can verify.

svn path=/trunk/; revision=54792
2014-01-14 17:45:03 +00:00
Jakub Zawadzki c45475ab45 Fix [-Wmissing-prototypes]
svn path=/trunk/; revision=54135
2013-12-15 23:44:12 +00:00
Anders Broman 6bde918078 From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48426
2013-03-19 20:00:52 +00:00
Bill Meier 1d4f9590a1 Rename 'hf_h248_package_3GUP' to 'proto_h248_package_3GUP'
in keeping with the usual convention for naming the
variable used to store the return value from
proto_register_protocol().
(Fixes checkhf false positive).


svn path=/trunk/; revision=47505
2013-02-05 21:55:31 +00:00
Martin Kaiser 387323569d fix
packet-h248_3gpp.c: In function ‘dissect_3gcsd_plmnbc’:
packet-h248_3gpp.c:168: error: cast to pointer from integer of different size
make[5]: *** [libdissectors_la-packet-h248_3gpp.lo] Error 1

I guess the last parameter of dissect_3gcsd_plmnbc() is a pointer to a
boolean variable. Call it implicit_param, not implicit, as there's
already a global variable 'implicit'.

Feel free to correct the fix if I got it wrong.

svn path=/trunk/; revision=46534
2012-12-14 02:27:05 +00:00
Anders Broman ca01731e86 Revert back to the original patch which actuallly worked.
svn path=/trunk/; revision=46533
2012-12-13 20:29:46 +00:00
Anders Broman 4f6998a6a5 From John Batty:- the h248_3GCSD_properties_vals array was missing entry 0 that defines the package name. - the h248_package_3GCSD structure was missing entries for the signal and event definitions (which were already been defined) For the plmnbc decoder, I found an existing decoder de_bearer_cap that could decode this field, so added a small function to call through to that The 3gtfo package definition was also missing the package name. https://bugs.wireshark.org/bugzilla/process_bug.cgi I fixed up the call to dissect_ber_octet_string() to use sub_tvb.
svn path=/trunk/; revision=46531
2012-12-13 20:17:17 +00:00
Jeff Morriss 2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Michael Mann 14f3f8c55a Add period separator for "base" proto filter name.
svn path=/trunk/; revision=44650
2012-08-24 02:02:22 +00:00
Jakub Zawadzki bf81b42e1e Update Free Software Foundation address.
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Anders Broman 189ea54f0b from Alex Lindberg:
Update to packet-h248.c and associated h248 dissecorts.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7332

svn path=/trunk/; revision=43107
2012-06-05 10:54:21 +00:00
Anders Broman 9e2c39d167 H248 package updates from Alex Lindberg in bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6915 applied by hand.
svn path=/trunk/; revision=41527
2012-03-13 13:41:28 +00:00
Bill Meier c4b63360dc Fix proto_tree_add_item( encoding args;
Do whitespace cleanup (for a few files).

svn path=/trunk/; revision=39640
2011-10-27 20:30:38 +00:00
Stephen Fisher faeaaaf8d0 Fix a few "equality comparison with extraneous parentheses" warnings
found by clang 3.0 (trunk 129935) compiler.


svn path=/trunk/; revision=36820
2011-04-22 17:31:57 +00:00
Jeff Morriss e92dd56b71 Register a bunch of ett_ variables.
Use gint (instead of int) for ett_ variables (for consistency only).

svn path=/trunk/; revision=35922
2011-02-11 21:27:46 +00:00
Bill Meier 03b57df5a0 Fix various typos and spelling errors.
svn path=/trunk/; revision=35126
2010-12-06 01:34:58 +00:00
Stig Bjørlykke e2d6320d75 Only include config.h in C files, to avoid multiple inclusion.
svn path=/trunk/; revision=30182
2009-09-28 17:58:47 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Bill Meier 79a1441582 FT_BOOLEAN fields w/o bitmasks really should use BASE_NONE (not BASE_DEC,...).
svn path=/trunk/; revision=28317
2009-05-08 20:35:57 +00:00
Luis Ontanon 42c3239a1a luis.ontanon@gmail.com => luis@ontanon.org
svn path=/trunk/; revision=25937
2008-08-05 21:03:46 +00:00
Anders Broman bf7150a834 Get rid of ber_last_created_item().
svn path=/trunk/; revision=24009
2008-01-04 12:53:29 +00:00
Anders Broman f08cd1e5e3 actx in the rest of dissect_ber..()l
svn path=/trunk/; revision=21773
2007-05-15 05:49:43 +00:00
Sebastien Tandel 68ad2f4b9b fix MacOSX gcc-3.3 warnings about unused tfs/value_string variables
most have been tagged unused (few have been deleted if dissector has not been
modified since a long time)

move packet-ssl-utils.c to DISSECTOR_SRC


svn path=/trunk/; revision=21431
2007-04-14 14:01:53 +00:00
Sebastien Tandel 8dc9e333ea fix some gcc warnings and put dissectors in CLEAN_DISSECTOR_SRC
svn path=/trunk/; revision=21410
2007-04-13 15:25:33 +00:00
Luis Ontanon b68f7da564 Add decoding of TFO Codec and Codec List
svn path=/trunk/; revision=21302
2007-04-02 21:47:54 +00:00
Luis Ontanon 0743cac9a4 remove warnings
svn path=/trunk/; revision=20921
2007-02-25 11:23:49 +00:00
Luis Ontanon 4211d0dba2 fix some bugs introduced in the latest releases and add value_strings for param, evt, sig and stat ids s well as "sub-parameters".
svn path=/trunk/; revision=20908
2007-02-23 20:57:22 +00:00
Luis Ontanon da3cc2efa8 + add some more packages from 3GPP TS 29.232
- fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1385


svn path=/trunk/; revision=20885
2007-02-21 00:00:49 +00:00
Anders Broman 43e6ba8b9f Fix bug 1328 (Still Malformed packet) update some of the other packages.
svn path=/trunk/; revision=20621
2007-01-30 06:16:39 +00:00
Bill Meier 444602bf97 Oops: wireshark.com --> wireshark.org
Also: 1 additional Ethereal --> Wireshark

svn path=/trunk/; revision=20272
2007-01-02 17:19:25 +00:00
Bill Meier 739eb43c3a More ethereal --> wireshark
svn path=/trunk/; revision=20270
2007-01-02 14:11:35 +00:00
Anders Broman c1bc224c9e Set properties.
svn path=/trunk/; revision=19515
2006-10-13 17:04:16 +00:00
Anders Broman d307493eb5 Fix a typo.
svn path=/trunk/; revision=19485
2006-10-10 21:56:10 +00:00
Anders Broman 1677b21838 Added the possibillity of Statistic pkg as well.
svn path=/trunk/; revision=19436
2006-10-04 22:43:38 +00:00
Luis Ontanon a4d7156808 H.248 packages...
few things to be fixed:
- // comments,
- not every hf_xxx used might be registered

some packages from the current h248 dissector are still missing.



svn path=/trunk/; revision=19407
2006-10-03 17:24:28 +00:00