Commit Graph

7118 Commits

Author SHA1 Message Date
Ronnie Sahlberg 3e15613ed6 add the new autogenerated lsa dissector
this changes some call signatures requiring changes to the netlogon 
dissector as well


svn path=/trunk/; revision=26320
2008-10-01 00:48:27 +00:00
Ronnie Sahlberg bf27687d94 add more policy handle types for the new LSA dissector
svn path=/trunk/; revision=26319
2008-10-01 00:47:05 +00:00
Ronnie Sahlberg baa1527783 mark LSA as a autogenerated (and thus warningprone) dissector
svn path=/trunk/; revision=26318
2008-10-01 00:46:05 +00:00
Ronnie Sahlberg 0b53fc415b update the conformance file to workaround a pidl bug/limitation for top
level arrays


svn path=/trunk/; revision=26317
2008-10-01 00:28:15 +00:00
Ronnie Sahlberg b12b8cec37 add initial idl file and conformance file for LSA
svn path=/trunk/; revision=26316
2008-10-01 00:14:17 +00:00
Stig Bjørlykke 63a2017571 Add a cast to avoid a warning.
svn path=/trunk/; revision=26315
2008-09-30 22:01:04 +00:00
Jaap Keuter 51a72a3478 Fix for bug 2917:
Modbus Application Protocol Specification V1.1b includes a function 43 (0x2b)
Encapsulated Interface Transport.  When Wireshark encounters this message it is
shown as a TCP message, not a Modbus message.

svn path=/trunk/; revision=26314
2008-09-30 21:23:19 +00:00
Anders Broman d3ffd5cafd From Wade Hennessey:
Add support the KDP (Kontiki Delivery Protocol).

svn path=/trunk/; revision=26313
2008-09-30 21:13:37 +00:00
Anders Broman 0548bc9116 From Ben Greear:
Add support for LANforge protocol.

svn path=/trunk/; revision=26312
2008-09-30 21:00:12 +00:00
Anders Broman 6771996389 Fix Bug 2860 Malformed Packet DCP ETSI error with UDP packet length 9 by
not accepting packages shorter than 10 bytes in the heuristic(min header length).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2860

svn path=/trunk/; revision=26311
2008-09-30 18:15:09 +00:00
Jeff Morriss 2207e21a91 get_iec104apdu_len(): make the offset variable a guin32 instead of a guint8 so
we can deal with TVB lengths greater than 255.  This fixes the infite loop
reported in:

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2914o

svn path=/trunk/; revision=26310
2008-09-30 16:03:18 +00:00
Bill Meier aa30dcd129 Minor proto_reg_handoff cleanup: use find_dissector when appropriate.
svn path=/trunk/; revision=26308
2008-09-30 14:49:44 +00:00
Bill Meier 09bef39f3d Minor cleanup related to proto_register, proto_reg_handoff
svn path=/trunk/; revision=26307
2008-09-30 14:46:48 +00:00
Sake Blok a550fb9d78 Make the index from the conversation-struct available as field
"tcp.stream", this will make it possible to sort packets by
tcp stream, filter tcp streams exactly, etc.

It is also the preparation for a fix for bug 1447


svn path=/trunk/; revision=26305
2008-09-30 12:24:27 +00:00
Jaap Keuter 8b1a8faf1b From Alex:
NFSV4 parsing of the GETATTR reply is broken. I'm not sure what is going on,
but I re-wrote the GETATTR parsing anyways and my version of the parsing does not 
exibit the same problems.

svn path=/trunk/; revision=26304
2008-09-30 07:06:32 +00:00
Gerald Combs d2821ce8c0 We always use start_offset, so don't wrap it in "#ifdef HAVE_KERBEROS".
svn path=/trunk/; revision=26301
2008-09-30 02:55:42 +00:00
Gerald Combs 6c8f59f916 Add a cast to try to fix compilation on Windows.
svn path=/trunk/; revision=26300
2008-09-30 02:55:13 +00:00
Ronnie Sahlberg 011e836f26 dissect lookupnames3
svn path=/trunk/; revision=26299
2008-09-29 22:10:40 +00:00
Jaap Keuter 8bea3dd9c1 From Derek Morr:
The DNS dissector conflates KEY (used for TSIG) and DNSKEY records. Also, the
DNSKEY dissector doesn't parse the REVOKED flag, defined in RFC 5011.

The attached patch splits KEY and DNSKEY parsing, and adds support for REVOKED.

svn path=/trunk/; revision=26298
2008-09-29 21:40:53 +00:00
Jaap Keuter 6a5135600c From Jelmer Vernooij:
The attached patch adds support for dissecting GSSAPI authentication
data to the SOCKS dissector.

svn path=/trunk/; revision=26297
2008-09-29 21:39:13 +00:00
Ronnie Sahlberg 617dac4e04 there exists clients (linux) that sends a SETCLIENTID specifying the
callback address/port with only 2 octets (high/low port)  i.e. witout 
specifying the ip address.


this caused wireshark to corrupt memory when trying to 0-terminate the 
original string after the fourth '.'   which happened to be beyond the 
end of the string.



svn path=/trunk/; revision=26296
2008-09-29 21:06:12 +00:00
Ronnie Sahlberg b4d74f2506 from metze
fallback to spnego_krb5_wrap for RFC4121 krb5 blobs


svn path=/trunk/; revision=26295
2008-09-29 18:52:17 +00:00
Ronnie Sahlberg 687b0422d3 from Metze
add dissection of RFC4121 krb5 blobs



svn path=/trunk/; revision=26294
2008-09-29 18:44:10 +00:00
Ronnie Sahlberg 7d3592fed2 from metze
add support for decryption of gssapi auth type 16


svn path=/trunk/; revision=26293
2008-09-29 18:38:45 +00:00
Anders Broman 34c2c82499 GSM MAP: inconsistent spacing in Info column
Bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2912

svn path=/trunk/; revision=26291
2008-09-29 16:57:09 +00:00
Anders Broman 39941336e4 Add Sequence Number for DTAP messages.
Fixes bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2490

svn path=/trunk/; revision=26290
2008-09-29 16:53:28 +00:00
Anders Broman 46ecae4dd1 From Joan Ramio:
New dissector IEC 60870-5-104.

svn path=/trunk/; revision=26289
2008-09-29 16:49:14 +00:00
Anders Broman 44a0e364e5 From Jelmer Vernooij:
Support for AYIYA protocol.

svn path=/trunk/; revision=26288
2008-09-29 16:28:34 +00:00
Anders Broman 637761d295 From Francesco Fusco:
Endace ERFII (extension header) support.

svn path=/trunk/; revision=26287
2008-09-29 16:20:24 +00:00
Anders Broman 3a26e89362 From Reinhard(rspmn):
Wrong display of USSD strings in the GSM 7-bit alphabet for non-ASCII data

svn path=/trunk/; revision=26286
2008-09-27 14:16:55 +00:00
Bill Meier 69336f7d96 Minor cleanup for proto_reg-handoff & etc
svn path=/trunk/; revision=26285
2008-09-27 14:02:23 +00:00
Bill Meier 97e7747d42 Small cleanup of proto_reg_handoff & etc
- 'once-only' not req'd in some cases
- use find_dissector as appropriate
- remove unneeded code

svn path=/trunk/; revision=26284
2008-09-27 13:38:59 +00:00
Bill Meier 1a7294c2a7 Handle pref change via pref callback instead of registering an init fcn
svn path=/trunk/; revision=26283
2008-09-27 01:08:19 +00:00
Bill Meier 09c5d0c15b Addt'l minor change relating to proto_reg_handoff
svn path=/trunk/; revision=26282
2008-09-26 22:34:41 +00:00
Bill Meier c3ea1560bd Minor cleanup related to proto_register and proto_reg_handoff
svn path=/trunk/; revision=26281
2008-09-26 22:07:45 +00:00
Bill Meier ffa7320de2 Minor cleanup related to proto_register & proto_reg_handoff
svn path=/trunk/; revision=26280
2008-09-26 20:06:40 +00:00
Bill Meier a14b7b5264 Addt'l minor cleanup
svn path=/trunk/; revision=26279
2008-09-26 17:12:15 +00:00
Bill Meier c60c77ba4a prefs callback not req'd
svn path=/trunk/; revision=26278
2008-09-26 17:06:44 +00:00
Bill Meier 3e347bb88c Minor cleanups related to proto_reg_handoff
svn path=/trunk/; revision=26277
2008-09-26 17:04:01 +00:00
Bill Meier 64f088530e Reformat somewhat for readability
svn path=/trunk/; revision=26276
2008-09-26 16:45:28 +00:00
Stig Bjørlykke d1c2234b89 Change emv -> evm, as noted in bug 2903.
svn path=/trunk/; revision=26275
2008-09-26 10:15:58 +00:00
Jaap Keuter e45be35abb From Sagar Pai:
This is a dissector for ZRTP, the Zfone projects secure media protocol, developed by Phil Zimmermann.
It is updated to the latest IETF draft draft-zimmermann-avt-zrtp-08.

svn path=/trunk/; revision=26274
2008-09-25 22:06:58 +00:00
Anders Broman d4a70f2961 Add the missing part of the fix for "Failure to dissect long SASL wrapped LDAP response".
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2687

svn path=/trunk/; revision=26272
2008-09-25 19:21:44 +00:00
Anders Broman e4e3a49dbe Update to the latest asn1 files and try to get rid of unused code warnings.
svn path=/trunk/; revision=26271
2008-09-25 19:20:14 +00:00
Anders Broman e34e97ac41 Update to the latest asn1 files and try to get rid of unused code warnings.
svn path=/trunk/; revision=26270
2008-09-25 19:19:39 +00:00
Tomas Kukosa 4981dbb788 do not call proto_tree_add_...() inside PROTO_ITEM_SET_HIDDEN() macro
it creates item three times

svn path=/trunk/; revision=26269
2008-09-25 18:32:14 +00:00
Anders Broman 7d8e236960 Add value_string to dissect_q931_cause_ie().
svn path=/trunk/; revision=26267
2008-09-25 05:21:33 +00:00
Guy Harris 48343abfdf Get rid of no-longer-used variables.
svn path=/trunk/; revision=26266
2008-09-25 02:57:58 +00:00
Bill Meier 432f7be1e0 Minor proto_reg_handoff cleanup
svn path=/trunk/; revision=26265
2008-09-25 02:21:04 +00:00
Anders Broman 33ad445703 Packet-isup.c &packet-q931.[ch]:
In case of cause pointing out ie "faults" use the correct "ie value_string".
in packet-isup.c use packet-e164.c for country code translation.

svn path=/trunk/; revision=26264
2008-09-24 21:59:50 +00:00
Ronnie Sahlberg 0536955ab3 track smb dialects between negprot request to the responses so we can
show the name of the selected dialect in the response and not just the 
index


svn path=/trunk/; revision=26263
2008-09-24 16:16:01 +00:00
Jeff Morriss ba3f1eaa5a Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2848 :
Decode SUA GT digits.  This removes the (undecoded, raw BCD) FT_BYTES field
sua.global_title_signals and adds an FT_STRING field sua.global_title_digits
(like in SCCP).

svn path=/trunk/; revision=26262
2008-09-24 13:41:47 +00:00
Tomas Kukosa 1e9ab739c3 put original tag name (not lowercase) into dissected xml structure too
dissect xml even if tree is null

svn path=/trunk/; revision=26261
2008-09-24 10:42:24 +00:00
Bill Meier 69c7082a64 Fix indentation to be reasonably consistent
svn path=/trunk/; revision=26258
2008-09-24 00:50:18 +00:00
Bill Meier 5ac2ba6354 Minor changes related to proto_reg_handoff & pref ranges
svn path=/trunk/; revision=26254
2008-09-23 15:03:39 +00:00
Bill Meier 65e1251846 Minor change: use guint for prefs port variables.
svn path=/trunk/; revision=26253
2008-09-23 01:10:45 +00:00
Bill Meier 1a7111b603 Minor revision related to proto_reg_handoff ...
svn path=/trunk/; revision=26252
2008-09-23 00:55:28 +00:00
Bill Meier c5ebd555b7 Trivial changes: comment and spacing
svn path=/trunk/; revision=26251
2008-09-23 00:45:05 +00:00
Bill Meier 5cba9cd3ae Fix minor bug: dissector_delete(...) should be "tcp" and not "udp".
svn path=/trunk/; revision=26250
2008-09-23 00:33:33 +00:00
Bill Meier 6aa5f8aa6a Minor cleanup related to proto_reg_handoff
svn path=/trunk/; revision=26246
2008-09-22 16:26:41 +00:00
Anders Broman 612463c139 Try to fix some "defined but not used" warnings.
svn path=/trunk/; revision=26243
2008-09-21 14:23:34 +00:00
Jaap Keuter 19e29e857e From Derek Morr:
The Kerberos dissector does not parse IPv6 addresses in AS-REQ messages.
Attached is a patch that adds IPv6 dissection support, and adds a new filter,
kerberos.addr_ipv6, which is analagous to the existing kerberos.addr_ip.

svn path=/trunk/; revision=26241
2008-09-21 13:55:32 +00:00
Guy Harris dbf7b99e97 The Official Home of the AVS header spec appears to bhe the
linux-wlan-ng source tree; just insert it verbatim into a big honking
comment, rather than trying to play Find The URL with it.

svn path=/trunk/; revision=26239
2008-09-20 01:57:18 +00:00
Bill Meier ca34becf82 Minor cleanup primarily related to proto_reg_handoff; spacing changes
svn path=/trunk/; revision=26237
2008-09-19 20:42:01 +00:00
Bill Meier a3e6eb8071 Minor cleanup mostly related to proto_reg_handoff
svn path=/trunk/; revision=26236
2008-09-19 17:39:44 +00:00
Gerald Combs 80e94e3ec3 Move wtap_pcap_encap_to_wtap_encap and wtap_wtap_encap_to_pcap_encap to
libwsutil.

svn path=/trunk/; revision=26233
2008-09-19 16:26:37 +00:00
Stig Bjørlykke bf24d9c3dc Dump the unsupported opcode for invoke result and invoke error,
as is done for invoke argument.

svn path=/trunk/; revision=26232
2008-09-19 15:28:43 +00:00
Jeff Morriss ee75b3eeae If we get an LSSU of length 2, interpret the first octet of the SF field the
same as it would be for a LSSU of length 1 (see Q.703/11.1.2).  Since the
second octet is undefined just display it was a hex FT_UINT8.

svn path=/trunk/; revision=26230
2008-09-19 12:19:17 +00:00
Jeff Morriss ad10542235 Correct the field lengths for the segmentation parameter (fixes the highlighting in the byte pane).
svn path=/trunk/; revision=26229
2008-09-19 12:17:32 +00:00
Gerald Combs aac8e0d91d Fix a spelling error pointed out by Noam Rathaus.
svn path=/trunk/; revision=26228
2008-09-18 17:19:15 +00:00
Jeff Morriss 1882e64736 If we're dissecting for a read filter in the GUI [tshark assigns
frame numbers before running the read filter], don't do the TSN
analysis.  (We can't anyway because we don't have a valid frame
number...)

Without this change if you load a capture file in the
GUI while using a read filter, every SCTP TSN is marked as a
retransmission of that in frame 0.

svn path=/trunk/; revision=26226
2008-09-17 21:59:15 +00:00
Jeff Morriss 0b1c118f92 A couple of trivial indentation fixes
svn path=/trunk/; revision=26225
2008-09-17 15:54:55 +00:00
Bill Meier 9d203cb9c6 Fix some imdentation
svn path=/trunk/; revision=26223
2008-09-17 03:27:40 +00:00
Bill Meier 618f722102 Minor cleanup related to proto_reg_handoff
svn path=/trunk/; revision=26222
2008-09-17 03:21:55 +00:00
Jaap Keuter cb477a2a4a From Vladimir Koutny:
The size of selected_registrar fiels in WPS IE should be 1b, not 2b 
(it is defined as BOOL in WPS specs).

svn path=/trunk/; revision=26214
2008-09-16 05:43:36 +00:00
Jaap Keuter b95f7e92ae Fix for bug 2875:
Fix a final eth_fopen -> ws_fopen
When configuring with --without-zlib these functions need to have some parameters tagged _U_

svn path=/trunk/; revision=26212
2008-09-15 21:50:50 +00:00
Jeff Morriss 740a53095c Put Data dissection (if no subdissector is found) on the toplevel tree instead of within the SUA tree.
svn path=/trunk/; revision=26211
2008-09-15 20:35:02 +00:00
Jeff Morriss f426f3363f If ANSI and national==0, decode the PC as ITU (not China). This fixes bug 2861.
svn path=/trunk/; revision=26210
2008-09-15 20:17:47 +00:00
Bill Meier 3ab617020d proto_reg_handoff: fix so port pref change works; gen'l cleanuop
svn path=/trunk/; revision=26208
2008-09-15 19:54:40 +00:00
Jaap Keuter 28c2ad711d From Michael Bernhard:
The dissector asserted displaying cookies in DTLS frames because it was registered as FT_NONE.

svn path=/trunk/; revision=26207
2008-09-15 19:49:43 +00:00
Bill Meier 771b90eba7 Fix compile error
svn path=/trunk/; revision=26206
2008-09-15 19:38:16 +00:00
Bill Meier 03187c631d Fix so pkt_ccc port pref works; proto_reg_handoff's: gen'l cleanup.
svn path=/trunk/; revision=26205
2008-09-15 19:33:38 +00:00
Bill Meier e90ee620d6 'static initialized' --> 'static gboolean initialized'
svn path=/trunk/; revision=26204
2008-09-15 19:03:03 +00:00
Bill Meier 8735dea057 proto_reg_handoff: rework/cleanup; fix so ports properly deleted/added.
svn path=/trunk/; revision=26203
2008-09-15 18:58:03 +00:00
Bill Meier 4f2845d9a0 proto_reg-handoff: Fix to properly delete/add port when pref changed; cleanup.
svn path=/trunk/; revision=26202
2008-09-15 18:48:28 +00:00
Bill Meier 795f0f8abb Fix several definitions
svn path=/trunk/; revision=26201
2008-09-15 18:39:34 +00:00
Bill Meier 4a94cd780c Add prefs callback so tcp_port pref works; Cleanup proto_reg_handoff.
svn path=/trunk/; revision=26200
2008-09-15 18:34:05 +00:00
Bill Meier 8f7331be64 Fix some indentation; 'static int' --> 'static guint'
svn path=/trunk/; revision=26198
2008-09-15 16:51:23 +00:00
Bill Meier 9a6db6e945 proto_reg-handoff: Use dissector_add_handle instead of registering to port 0;
Also: minor cleanup related to proto_reg_handoff

svn path=/trunk/; revision=26197
2008-09-15 16:36:06 +00:00
Bill Meier 1e7e3cee51 Minor cleanup related to proto_reg_handoff
svn path=/trunk/; revision=26196
2008-09-15 15:38:34 +00:00
Stig Bjørlykke 2aee2b22f6 Do not flag a low TTL if sending to a multicast address (224.0.0.0/4).
svn path=/trunk/; revision=26195
2008-09-15 12:50:35 +00:00
Bill Meier 82affdc4df Fix indentation to be consistent
svn path=/trunk/; revision=26194
2008-09-15 02:05:26 +00:00
Anders Broman aadfcc546c Allways show the Vendor OUI in the vedors specific IE.
svn path=/trunk/; revision=26193
2008-09-14 15:14:46 +00:00
Anders Broman d7c62b2db5 Use the unmodified DialoguePDUs ASN1 file.
svn path=/trunk/; revision=26192
2008-09-14 14:42:39 +00:00
Anders Broman 14f76023b3 Remove the rest of the ANSI TCAP stuff.
svn path=/trunk/; revision=26191
2008-09-14 14:33:01 +00:00
Jaap Keuter a83a87e9ca Fix for bug 2870:
Wrap dissect_q931_cause_ie() in a save version which clears the have_valid_q931_pi semaphore. This may remain set if a malformed q931 message causes an exception.

svn path=/trunk/; revision=26190
2008-09-14 13:09:14 +00:00
Anders Broman eb9dc794b2 Start to get rid of the "old" ANSI TCAP stuff.
svn path=/trunk/; revision=26189
2008-09-13 16:38:21 +00:00
Anders Broman 16512c7b8c Use original UnidialoguePDUs.
svn path=/trunk/; revision=26188
2008-09-13 15:32:59 +00:00
Bill Meier e344bc8f0f Small revisions related to proto_reg_handoff ....
svn path=/trunk/; revision=26185
2008-09-12 16:52:01 +00:00
Michael Tüxen 296be40635 Add support for
http://www.ietf.org/internet-drafts/draft-tuexen-tsvwg-sctp-sack-immediately-00.txt

svn path=/trunk/; revision=26184
2008-09-12 16:23:18 +00:00
Anders Broman 2382a8edaf Revert one of the changes.
svn path=/trunk/; revision=26183
2008-09-12 16:02:39 +00:00
Anders Broman 9bf8e1d741 Try to fix "defined but not used" warnings.
svn path=/trunk/; revision=26182
2008-09-12 09:11:28 +00:00
Anders Broman 021d8153b2 From Karl Heinz Wolf:
LoST Server Domain Name DHCPv4 Option (RFC 5223)

svn path=/trunk/; revision=26179
2008-09-11 20:44:19 +00:00
Anders Broman f08f558eea Work around a problem with custom columns.
svn path=/trunk/; revision=26178
2008-09-11 19:34:29 +00:00
Anders Broman 8e5509273f "Response flags" in GIOP Request is misinterpreted
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2800

svn path=/trunk/; revision=26177
2008-09-11 19:33:07 +00:00
Bill Meier 802f4452b4 Minor cleanup related to proto_reg_handoff ....
svn path=/trunk/; revision=26176
2008-09-11 14:07:02 +00:00
Guy Harris 7bdebbdb00 In the radio-information dissector, set the current protocol name before
calling the 802.11 dissector, so if we have a malformed frame or short
frame the right protocol name will be shown.

svn path=/trunk/; revision=26173
2008-09-10 21:48:15 +00:00
Bill Meier 961698e3e7 strncasecmp ==> g_ascii_strncasecmp
svn path=/trunk/; revision=26172
2008-09-10 12:57:48 +00:00
Jaap Keuter 890cbb15d1 Fix for bug 2859:
Skip data portion of unknown TLV.

Expand type interpretation and several other cleanups.

svn path=/trunk/; revision=26169
2008-09-09 21:17:17 +00:00
Bill Meier 7f2978acc8 From Pavol Rusnak: Add missing break statement....
svn path=/trunk/; revision=26166
2008-09-08 16:13:39 +00:00
Jaap Keuter b6b59d1f99 From Neil Piercy:
The IP Address IE did not decode correctly - the address fetch did not skip the
Address Type field.

svn path=/trunk/; revision=26164
2008-09-08 06:02:35 +00:00
Anders Broman 17df3adc80 Udate tlv_type_names with values from http://www.iana.org/assignments/ldp-namespaces.
svn path=/trunk/; revision=26162
2008-09-07 17:18:49 +00:00
Anders Broman 2c68dca215 From Neil Piercy:
Empty GPRS LLC S frames cause truncated data exception
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2855

svn path=/trunk/; revision=26160
2008-09-07 13:36:56 +00:00
Guy Harris 9e82ae1e49 Move the advancement of the packet offset outside the "if (tree)".
This fixes bug 2856.

svn path=/trunk/; revision=26159
2008-09-07 08:44:47 +00:00
Guy Harris e1d2a36b02 Clean up indetation.
If we're running in TShark, there's never a GUI; clean up comments.

Merge a couple of if statements together, as the "true" branch of the
second statement is executed only if the "true" branch of the first
statement is executed.

svn path=/trunk/; revision=26158
2008-09-07 03:13:10 +00:00
Guy Harris dd317fd99c Style and indentation cleanups.
Don't initialize a variable that's set (in the handoff registration
routine) before being used.

Now that we're GLib 2.0-only, use g_ascii_isalpha() rather than rolling
our own.

svn path=/trunk/; revision=26157
2008-09-07 01:50:44 +00:00
Guy Harris 22b5159053 Add support for TLS-over-SMTP.
svn path=/trunk/; revision=26156
2008-09-07 01:28:43 +00:00
Guy Harris 93e12f5b69 Have a line_is_smtp_command() routine to check whether a line is an SMTP
command, and use that in the parsing loop (that means we don't have to
treat 4-character commands and non-4-character commands separately).

svn path=/trunk/; revision=26155
2008-09-06 23:58:23 +00:00
Guy Harris 73e36ab9da Add some comments.
svn path=/trunk/; revision=26153
2008-09-06 22:33:22 +00:00
Anders Broman d1ea868c27 Bucket Leak Rate decoded incorrectly as bytes instead of bits
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2849

svn path=/trunk/; revision=26147
2008-09-06 11:45:08 +00:00
Anders Broman 7530143278 Add extended cap decoding.
svn path=/trunk/; revision=26145
2008-09-05 16:04:02 +00:00
Guy Harris b7d8597ec3 Move another comment next to the code to which it refers.
svn path=/trunk/; revision=26144
2008-09-05 09:51:13 +00:00
Guy Harris e707fb415f Move a comment to the right place.
svn path=/trunk/; revision=26143
2008-09-05 09:28:08 +00:00
Guy Harris 19d3eb7004 Clean up indentation.
svn path=/trunk/; revision=26142
2008-09-05 09:07:46 +00:00
Anders Broman ebc8f1f8bf From Niel Percy:
Much as I hate white space changes, I got fed up of the huge variation of styles within these files, and tried to get to a much smaller range of variation. Also a few comment tidies, and use of _U_ for unused args rather than "arg = arg" lines.

svn path=/trunk/; revision=26140
2008-09-05 05:49:39 +00:00
Guy Harris 6321274b52 Mark unused argument as such.
Style changes.

svn path=/trunk/; revision=26139
2008-09-04 21:21:27 +00:00
Anders Broman 0b53441f69 Modified patch from Siva Jupudi adding support for
WAVE Service information element Dissection - IEEE 802.11p Draft 4.0

svn path=/trunk/; revision=26138
2008-09-04 20:54:22 +00:00
Guy Harris 5a97fd382f That #include is necessary to get epan_strcasestr() declared;
unfortunately, that didn't show up in a build, as this file isn't yet
clean and isn't yet built with -Werror.

svn path=/trunk/; revision=26135
2008-09-03 23:51:26 +00:00
Guy Harris 9d1b5335ac g_ascii_strdown() and g_ascii_strup(), unlike g_strdown() and g_strup(),
do *not* modify the string handed to them - they g_mallocate a new
string and return it.

Create routines that *do* ASCII-only case mapping in place, and use them
instead.

Clean up indentation.

svn path=/trunk/; revision=26131
2008-09-03 19:14:52 +00:00
Anders Broman e708889484 Try to fix unused code warnings(hack).
svn path=/trunk/; revision=26129
2008-09-03 17:03:30 +00:00
Bill Meier 419e3a47f6 Cleanup related to prefs & proto_reg_handoff
svn path=/trunk/; revision=26128
2008-09-03 16:42:35 +00:00
Jaap Keuter 7116bc941b Made FCS calculation and checking code work on GCC 4.3.1.
Made FCS check actually mean something.

svn path=/trunk/; revision=26125
2008-09-03 05:56:30 +00:00
Bill Meier 8d9c5d9b2b Cleanup related to prefs & proto_reg_handoff
svn path=/trunk/; revision=26124
2008-09-02 21:40:46 +00:00
Anders Broman 80b87dfaf3 Try to fix unused code warnings.
svn path=/trunk/; revision=26122
2008-09-02 19:42:30 +00:00
Bill Meier 40bd43db83 Minor cleanup (mostly related to proto_reg_handoff...)
svn path=/trunk/; revision=26121
2008-09-02 19:08:29 +00:00
Anders Broman 6c7b56081c Handle extension header.
svn path=/trunk/; revision=26119
2008-09-02 18:27:33 +00:00
Bill Meier afd857957a Fix a few Emacs "file variables" to have "safe" values.
That is: indent-tabs-mode: tabs --> indent-tabs-mode: t
Also: fix a typo: set-tabs-mode --> indent-tabs-mode

svn path=/trunk/; revision=26113
2008-09-02 11:17:03 +00:00
Guy Harris dd190f38e5 OK, let's see if the x509sat dissector is clean.
svn path=/trunk/; revision=26112
2008-09-02 06:44:41 +00:00
Anders Broman 8970b4524d Try to fix unused code warnings.
svn path=/trunk/; revision=26111
2008-09-02 06:04:25 +00:00
Anders Broman 9d0a401a12 Try to fix unused code warnings.
svn path=/trunk/; revision=26110
2008-09-02 05:43:28 +00:00
Anders Broman a517a46fa7 Try to fix unused code warnings.
svn path=/trunk/; revision=26109
2008-09-01 21:10:28 +00:00
Anders Broman 1a109ff02c Update to use unchanged asn1 files and X.501:08/2005.
Hopefullly without breaking to many things.

svn path=/trunk/; revision=26108
2008-09-01 20:29:01 +00:00
Anders Broman 3d07d2bee8 Try to fix "defined but not used" warnings.
svn path=/trunk/; revision=26107
2008-08-31 21:37:16 +00:00
Anders Broman c7b010d246 Remove test code for depreciated OID.
svn path=/trunk/; revision=26106
2008-08-31 21:11:32 +00:00
Anders Broman 47d612ccc9 Update to X.509:08/2005.
svn path=/trunk/; revision=26105
2008-08-31 21:00:06 +00:00
Anders Broman 48dbffeda4 OID 1.3.6.1.5.5.7.8.5 (id-on-xmppAddr) not recognized by BER dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2835

svn path=/trunk/; revision=26104
2008-08-31 12:55:45 +00:00
Guy Harris 56ae1ea2f7 Give "initialized" the right data type.
svn path=/trunk/; revision=26101
2008-08-27 22:46:03 +00:00
Bill Meier 32dc6c98e4 If port pref changed, delete registration for previous port
svn path=/trunk/; revision=26099
2008-08-27 19:47:21 +00:00
Guy Harris 317201b985 Give macros and libraries names that imply that clean dissectors are the
normal case, and dissectors with warnings are the exception; the
ultimate goal is to have only clean dissectors.

Move a bunch of now-cleaned-up dissectors into the "clean" category.

Fix a comment.

svn path=/trunk/; revision=26096
2008-08-26 03:45:42 +00:00
Guy Harris f0acec0696 Fix some macro name errors.
svn path=/trunk/; revision=26092
2008-08-26 01:32:15 +00:00
Bill Meier b52d95d591 #include <emem.h> not req'd
svn path=/trunk/; revision=26091
2008-08-26 01:28:50 +00:00
Guy Harris d7a51fc7de Get rid of an unused variable in the P7 dissector.
Create a set of warning-clean ASN.1 dissectors and build them with
-Werror, to try to prevent errors creeping back in.  Put the P7
dissector there.

svn path=/trunk/; revision=26090
2008-08-26 01:04:39 +00:00
Bill Meier 77b81b391b #include <prefs.h> not req'd
svn path=/trunk/; revision=26089
2008-08-25 22:06:20 +00:00
Anders Broman 74efeaae80 Add Answer or Request to the Command name in the info column depending on
if the R bit is set or not.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2828

svn path=/trunk/; revision=26088
2008-08-25 21:15:55 +00:00
Bill Meier aac2a36133 #include <prefs.h> not req'd; Fix indentation to be conistent
svn path=/trunk/; revision=26086
2008-08-25 20:41:05 +00:00
Anders Broman 798fe6acca From Andrei Slavoiu:
TS 29.060 v7.8.0 and later specify new flags in the Common Flags IE:
bit 5 - No QoS Negotiation
bit 6 - NRSN
bit 7 - Upgrade QoS Supported

The current Wireshark implementation has bits 5 and 6 reversed. Attached patch
fixes this issue.

svn path=/trunk/; revision=26084
2008-08-25 20:05:26 +00:00
Bill Meier 5f26848657 prefs_register_protocol not req'd since no prefs; simplify reg_handoff & do minor cleanup
svn path=/trunk/; revision=26081
2008-08-25 19:53:32 +00:00
Bill Meier 9c250392d8 prefs_register_protocol not req'd since no prefs; simplify reg_handoff & do minor cleanup
svn path=/trunk/; revision=26080
2008-08-25 19:25:40 +00:00
Bill Meier c249da955c Remove unnecessary registration of a prefs callback
svn path=/trunk/; revision=26079
2008-08-25 18:42:30 +00:00
Bill Meier acbbc43f2e Remove unnecessary registration of a prefs callback & do minor cleanup
svn path=/trunk/; revision=26078
2008-08-25 18:37:18 +00:00
Bill Meier 1b85a4b1e9 prefs.h not req'd; cleanup reg_handoff;
svn path=/trunk/; revision=26077
2008-08-25 17:36:24 +00:00
Bill Meier 129145495e remove unnecessary registration of a prefs callback; minor cleanup
svn path=/trunk/; revision=26076
2008-08-25 17:26:26 +00:00
Bill Meier 2ac68fb78a remove unnecessary prefs registration since no prefs; minor cleanup
svn path=/trunk/; revision=26075
2008-08-25 17:14:20 +00:00
Bill Meier e6334320c5 Remove unnecessary prefs callback; simplify reg_handoff; minor cleanup
svn path=/trunk/; revision=26074
2008-08-25 16:59:38 +00:00
Bill Meier be5a1aa111 Move a buffer from the stack & do some minor cleanup
svn path=/trunk/; revision=26073
2008-08-25 16:42:09 +00:00
Guy Harris a1fb6f2e8c If HAVE_KERBEROS isn't defined, enc_authorization_data_etype isn't
defined; make it a local variable in that case.

svn path=/trunk/; revision=26072
2008-08-25 16:13:48 +00:00
Ronnie Sahlberg 640e4d4025 implement pac info type #12 UPN_DNS_INFO
svn path=/trunk/; revision=26069
2008-08-25 03:46:51 +00:00
Ronnie Sahlberg 8d98fcd177 start adding support to decrypt and dissect the enc-authorization-data
of TGS_REQ


svn path=/trunk/; revision=26068
2008-08-25 02:55:04 +00:00
Ronnie Sahlberg ed83f835e6 add a preference and code for tracking how many un-acked bytes are in
flight on a tcp connection.

this is quite useful toghether with io-grapgs to track how much of the 
tcp window that an application actually uses



svn path=/trunk/; revision=26067
2008-08-25 02:15:36 +00:00
Anders Broman ae07b1708a From Stefan Monhof:
Fix a bug in the previous patch.

svn path=/trunk/; revision=26065
2008-08-24 19:25:33 +00:00
Anders Broman 2226bccd44 From Neil Piercy:
1 new split file (GMM & SM in one file) and diff patches for the others. The RR, RP and BSSMAP patches are really a tidy-up: now they are split it becomes clear what was redundant code.

svn path=/trunk/; revision=26064
2008-08-24 17:42:30 +00:00
Anders Broman 924894e617 From: Stefan Monhof:
changes:
- fixed: display of kademlia hash (bug #2348)
- added: information on the meaning of the values of kad version, parameter of
message types KADEMLIA_REQ and KADEMLIA2_REQ, metatag sourcetype and metatag
encryption
- added: peer id, target id, recipients id, file id, keyword hash as variants
of kademlia hash (searchable as string now)
- added: xor between target id and recipients id
- fixed: ip adresses in taglist now displayed in dotted-decimal (instead of
int)
- fixed: some values in taglist were displayed in octal, it's hex now
- fixed: message type KADEMLIA2_BOOTSTRAP_REQ was wrongly marked as malformed
- added: differences in dissecting peer list 1.0 and peer list 2.0
- fixed: dissection of KADEMLIA2_SEARCH_KEY_REQ and KADEMLIA2_SEARCH_RES
- added: source-publishing and keyword-publishing in KADEMLIA_PUBLISH_REQ
- fixed: decompressed data are not displayed in a subtree anymore

svn path=/trunk/; revision=26063
2008-08-24 15:15:36 +00:00
Guy Harris 6f9b405534 One set of tests for whether a packet looks like a STUN2 packet
suffices; have the heuristic dissector call the message dissector and
return FALSE if the message dissector returns 0 (meaning it's not a
STUN2 packet) and TRUE otherwise.

New-style dissectors don't return a Boolean, they return 0 if the packet
isn't a packet for that protocol and the number of bytes dissected
otherwise.  (Yes, that's a problem if the length of the tvbuff handed to
the dissector is 0; that's why new-style dissectors aren't yet the
default.)

svn path=/trunk/; revision=26060
2008-08-22 22:17:37 +00:00
Stig Bjørlykke 7cf79249e0 Only use one IP address for seq/ack analysis.
Use correct length for dest entry and ack info entry.
Print correct id list for acks.

svn path=/trunk/; revision=26059
2008-08-22 15:15:56 +00:00
Bill Meier d13bc6c7f4 Fix a (probably benign) case where it appears that && should be &
svn path=/trunk/; revision=26058
2008-08-22 14:28:03 +00:00
Bill Meier 50fc84d329 Fix a case of && which should be &; add some parentheses for clarity
svn path=/trunk/; revision=26057
2008-08-22 14:02:05 +00:00
Jeff Morriss 2acffab343 Add an expert info noting an a_rwnd of 0.
svn path=/trunk/; revision=26055
2008-08-21 20:29:27 +00:00
Bill Meier 1391addb5a Modified version of a fix from Christopher Maynard as reported in bug 2822.
svn path=/trunk/; revision=26054
2008-08-21 18:51:17 +00:00
Bill Meier 383b5e9723 Fix from christopher maynard as reported in bug 2822
svn path=/trunk/; revision=26053
2008-08-21 18:48:26 +00:00
Guy Harris 3acd12510b The first argument to vendor IE dissectors is a proto_item *, not a
proto_tree * (yes, they're the same data type, but they're thought of
differently - it's a long story).

Just call the IE type in a Marvell vendor IE the "type".  For IEs with
no known type, show the IE data as raw data, as is done with
Aironet/Cisco vendor IEs.

Get rid of an unused variable, and mark as unused an unused parameter.

svn path=/trunk/; revision=26050
2008-08-20 23:57:50 +00:00
Anders Broman ec064849c5 From David Woodhouse:
The IEEE80211 part of "Add support for OLPC 802.11s-like mesh protocol".
With some changes to make it a bit more generic.

svn path=/trunk/; revision=26049
2008-08-20 19:50:26 +00:00
Jaap Keuter 45705aadc3 From Scott Bailey:
It takes a calculator to decode the timestamps.  But no more! 
Timestamps using the attached patch are displayed as follows:
   Timestamp = MM:SS mmm absolute (UTM)
or
   Timestamp = MM:SS mmm relative
where M is minutes, S is seconds, and m is milliseconds.
This is in accord with 'IEEE Std 1278.1-1995' section 5.2.31.

svn path=/trunk/; revision=26047
2008-08-20 06:32:08 +00:00
Jaap Keuter 90af2cb097 Lint reports addressed.
Whitespace cleanup.

svn path=/trunk/; revision=26046
2008-08-20 05:56:31 +00:00
Jaap Keuter fd86b5d61a From Eric Travis:
The included tweak allows for the filtering of packets on the presence of
TCP Option 20: tcp.options.scps;

svn path=/trunk/; revision=26045
2008-08-20 05:42:35 +00:00
Jaap Keuter d24ee65df8 From Steve Friedman:
s/Acknowledgment/Acknowledgement/

svn path=/trunk/; revision=26044
2008-08-20 05:40:25 +00:00
Guy Harris 267572b693 Fix up the construction of a subset tvbuff.
svn path=/trunk/; revision=26043
2008-08-20 02:58:41 +00:00
Anders Broman bba165265c Fix bug:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2285
7.3.2.22 Measurement Report element min length is 3
Added dissection of 
7.3.2.18 TPC Report element

svn path=/trunk/; revision=26042
2008-08-19 21:26:35 +00:00
Anders Broman 8417cf0fab Add a comment.
svn path=/trunk/; revision=26041
2008-08-19 08:11:49 +00:00
Anders Broman bafcc127f8 From Neil Piercy:
RR has been split from DTAP, with common stuff going to the common files (plus a few minor knock-on consequences).
Fix the broken tap:
I had not realised that the register_tap call in the dissector registration actually _created_ the tap entry (not the register_tap_listener), and not just associated the tap_id returned with the tap registered by the listener. The use of separate statics by the split lead to 3 taps called "gsm_a", but only the first of which was ever found in the tap_queue_packet. Added (yet another) global for now to cope.

Also attached is a patch to tap.c which simply returns the same tap_id if the register_tap is called twice with the same name - I can't see any downside to this, can you? Anyway it seemed to work with deliberately keeping multiple calls.

svn path=/trunk/; revision=26039
2008-08-19 08:05:04 +00:00
Guy Harris d9416525b6 Add to a comment.
svn path=/trunk/; revision=26036
2008-08-19 03:42:40 +00:00
Stig Bjørlykke 6b1c605ca4 Added handling of missing sequence number range in ack.
Add all message ids in ack to the info column.
Changed data types for sequence number and total number of pdus.
Untabify file.

svn path=/trunk/; revision=26031
2008-08-15 07:59:11 +00:00
Bill Meier 38eb4d6ce3 Use const with value_string array definitions
svn path=/trunk/; revision=26028
2008-08-14 23:51:52 +00:00
Gerald Combs 4cb727b342 It looks like /Zd was removed in VC++ 2005.
svn path=/trunk/; revision=26025
2008-08-14 22:23:27 +00:00
Stig Bjørlykke 5a526ecbaa Added a missing {0,NULL} as noted by Christopher.
svn path=/trunk/; revision=26024
2008-08-14 21:06:28 +00:00
Gerald Combs bb8e507f31 From cjkelly1: Add "/MD" to the PortAudio compilation flags. Fixes
bug 2791.

Don't use "-o" in the PortAudio compilation flags. If we're running Visual
C++ 2008, don't use "/Zd" when compiling packet-rrc.c. Fixes bug 2795.

svn path=/trunk/; revision=26023
2008-08-14 20:56:34 +00:00
Anders Broman 8239127661 From Siva Jupudi:
Support WAVE Short Message Protocol IEEE P1609.3(WSMP).
Slightly modified to display the message as Data as from the supplied trace it looks not to be text.
The packet-ieee80211.c patch is not included as the trace in question shows malformed packets.

svn path=/trunk/; revision=26022
2008-08-14 20:41:55 +00:00
Anders Broman f7e0b6490a Add Ethertype for WAVE Short Message dissection (WSMP).
svn path=/trunk/; revision=26018
2008-08-14 17:03:30 +00:00
Bill Meier 08281de94b Fix some spelling/typos
svn path=/trunk/; revision=26017
2008-08-14 16:55:42 +00:00
Stig Bjørlykke 7cba595943 From Edward J. Paradise (bug 2775):
Patch to fix windows compile errors.

svn path=/trunk/; revision=26015
2008-08-14 16:31:07 +00:00
Bill Meier c93ba4d596 Fix a few typos & spelling errors
svn path=/trunk/; revision=26014
2008-08-14 16:28:56 +00:00