42e0144f08
Remove unused function and variable.
...
svn path=/trunk/; revision=54590
2014-01-04 11:40:43 +00:00
2334acec2c
Omit assignment for not used types.
...
svn path=/trunk/; revision=54589
2014-01-04 11:34:46 +00:00
4763f36a75
Omit assignment for not used types.
...
svn path=/trunk/; revision=54588
2014-01-04 11:26:30 +00:00
2b32fed0ef
Omit assignment for not used types.
...
svn path=/trunk/; revision=54587
2014-01-04 11:24:33 +00:00
72970675bd
Add the rest of the NOKIA extensions.
...
svn path=/trunk/; revision=54586
2014-01-04 10:06:04 +00:00
4f62f2cfa3
Add a few more of the NOKIA extensions.
...
svn path=/trunk/; revision=54580
2014-01-03 13:29:48 +00:00
b22d9ab940
Disabling building of the gnm dissector, I don't tink it was ever used.
...
svn path=/trunk/; revision=54561
2014-01-02 18:01:33 +00:00
3cb2c58eaf
Fix [-Wmissing-prototypes]
...
svn path=/trunk/; revision=54552
2014-01-02 11:27:10 +00:00
c228237fac
Change incorrect property 'keywords' to 'svn:keywords'
...
svn path=/trunk/; revision=54540
2014-01-01 18:08:30 +00:00
6ebc058f47
Add proto_tree_add_ts_23_038_7bits_item() / tvb_get_ts_23_038_7bits_string() functions and update dissectors to use it.
...
Remove gsm_sms_char_7bit_unpack() / gsm_sms_chars_to_utf8() functions.
Update documentation a bit.
svn path=/trunk/; revision=54534
2014-01-01 14:33:19 +00:00
aa796df61c
Add SVN properties
...
svn path=/trunk/; revision=54511
2013-12-31 14:50:52 +00:00
43e892e985
From Dirk
...
dissector for Novell's PKIS certificate extensions
from me
clean up the $Id$ tags
remove packet-pkis(-template).h
remove ASN.1 definitions that cause compiler warnings
(OID, SecurityLabelType2)
move the dissector to the clean ASN.1 dissectors
support CMake build
change the name to novell_pkis
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9597
svn path=/trunk/; revision=54508
2013-12-31 14:20:08 +00:00
1c9b36ad46
gcamel_StatSRT is set by the CLI CAMEL tap, so it can't be static.
...
svn path=/trunk/; revision=54502
2013-12-30 22:31:04 +00:00
58346b6327
Move tcap and camel "persistent data" functionality to the dissectors themselves instead of being part of epan directory.
...
svn path=/trunk/; revision=54499
2013-12-30 22:07:38 +00:00
edb6cf0b16
Get rid of no-longer-used variables.
...
svn path=/trunk/; revision=54433
2013-12-24 01:30:00 +00:00
0d7a48a8bf
Add a ENC_3GPP_TS_23_038 encoding, for the standard SMS alphabet in a
...
bit-packed string, and use it in some places.
svn path=/trunk/; revision=54428
2013-12-24 00:20:09 +00:00
5084f58ce2
We support ENC_UCS_2, so use that in proto_tree_add_item() and
...
tvb_get_string_enc() rather than using iconv to convert it to UTF-8.
svn path=/trunk/; revision=54350
2013-12-22 02:12:32 +00:00
deb2b236f2
Add missing includes
...
svn path=/trunk/; revision=54332
2013-12-21 17:23:17 +00:00
33ef0c2600
isascii(x) && isprint(x) -> g_ascii_isprint(x)
...
svn path=/trunk/; revision=54328
2013-12-21 15:12:11 +00:00
064082e68a
Change G_GINT64_CONSTANT(xxxxU) to G_GUINT64_CONSTANT(xxxx)
...
svn path=/trunk/; revision=54314
2013-12-20 22:39:32 +00:00
90c8f5dde0
Copy Evan r54250 changes to asn/
...
Rename more to_str functions to have ep_ in the name if they return ephemeral buffers.
svn path=/trunk/; revision=54313
2013-12-20 22:32:11 +00:00
6be37815a1
Add bytestring_to_str() which takes a wmem scope and is otherwise identical to
...
bytestring_to_ep_str (now deprecated). Use the new one in a few obvious places.
Also just print directly to the buffer when loading ethernet addresses for
resolution. The straight-to-buffer bytes_to_hexstr seems useful, maybe it
shouldn't be in a private header...
svn path=/trunk/; revision=54270
2013-12-19 20:53:44 +00:00
771dc849f5
Update file forgotten in r54250
...
svn path=/trunk/; revision=54264
2013-12-19 18:58:31 +00:00
2ae8edccea
Rename more to_str functions to have ep_ in the name if they return ephemeral
...
buffers. Remove two unused functions.
svn path=/trunk/; revision=54250
2013-12-19 16:28:39 +00:00
a6415ece0a
Rename a couple of to_str functions to have ep_ in the name. This makes it
...
obvious that the returned string is ephemeral, and opens up the original names
in the API for versions that take a wmem pool (and thus can work in any scope).
svn path=/trunk/; revision=54249
2013-12-19 15:49:09 +00:00
317b828986
Use proto_tree_add_item() or tvb_get_string_enc() instead of
...
tvb_get_unicode_string(). If there's an indication that the encoding is
UCS-2, use that, otherwise use UTF-16. (For example, "BMP" stands for
"Basic Multilingual Plane", which is the part of Unicode that can be
encoded in 16 bits, hence UCS-2.)
In the description of the "Use Heuristics for UDP" preference for the
XML dissector, note that it's not just trying to recognize XML in UCS-2,
it's trying to recognize XML in *big-endian* UCS-2.
svn path=/trunk/; revision=54245
2013-12-19 09:19:33 +00:00
8f665d9b36
Add a sixteenth element to all BCD digit sets to avoid garbage values when
...
decoding corrupt bytes. Some of these digit sets could probably be
deduplicated...
svn path=/trunk/; revision=54224
2013-12-18 15:54:32 +00:00
e6d09c1634
Make local functions static. Include *.h when needed.
...
svn path=/trunk/; revision=54201
2013-12-17 22:07:32 +00:00
4d92f6079b
Remove not needed ';'
...
svn path=/trunk/; revision=54088
2013-12-14 11:12:20 +00:00
4b609d4c92
Reject the packet if data is NULL. For now, leave the DISSECTOR_ASSERT's since both get_rose_ctx() and get_asn1_ctx() also check signatures.
...
svn path=/trunk/; revision=53965
2013-12-12 19:04:38 +00:00
a97a3152b0
Reject the packet if data is NULL. Remove _U_ where data is actually used. For now, leave the DISSECTOR_ASSERT's since both get_rose_ctx() and get_asn1_ctx() also check signatures.
...
(Arguably it's the responsibility of the dissector passing this information to set the signature correctly so if there's an invalid signature, the bug is with the calling dissector and not with the one receiving the invalid signature.)
svn path=/trunk/; revision=53964
2013-12-12 18:10:08 +00:00
16f85131bd
Fix (-W)unused-const-variable error found by Clang
...
svn path=/trunk/; revision=53935
2013-12-11 13:14:00 +00:00
25ce6c262e
- Forward declaration of register functions.
...
svn path=/trunk/; revision=53908
2013-12-10 17:41:57 +00:00
ff42551d71
comment out unused functions
...
fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9538
reported by Yaniv Kaul
svn path=/trunk/; revision=53902
2013-12-10 10:52:29 +00:00
acf2fed688
- Forward declaration of register functions.
...
svn path=/trunk/; revision=53901
2013-12-10 06:01:16 +00:00
babc735c3a
Reject the packet if data is NULL. For now, leave the DISSECTOR_ASSERT(rose_ctx_tmp) since get_rose_ctx() also checks the signature, which might be invalid even if data is not NULL.
...
svn path=/trunk/; revision=53896
2013-12-09 22:38:42 +00:00
79fa0d0a3f
Reject the packet if data is NULL without doing anything else.
...
Note: We *might* want to do _something_ but that _something_ should be well-defined and consistent across all dissectors. Previously, some dissectors called proto_tree_add_text() to add some error message text to the tree, while others called DISSECTOR_ASSERT().
svn path=/trunk/; revision=53895
2013-12-09 22:23:44 +00:00
b693f74b89
- Forward declaration of register functions.
...
svn path=/trunk/; revision=53877
2013-12-09 06:50:09 +00:00
0d46cdae53
- Forward declaration of register functions.
...
svn path=/trunk/; revision=53876
2013-12-09 06:20:42 +00:00
6e2465b94e
- Forward declaration of register functions.
...
svn path=/trunk/; revision=53873
2013-12-08 22:11:18 +00:00
4124b7aa17
- Forward declaration of register functions.
...
svn path=/trunk/; revision=53872
2013-12-08 22:02:12 +00:00
93398e794e
Use STR_UNICODE display instead of proto_tree_add_unicode_string() in the remaining dissectors
...
svn path=/trunk/; revision=53867
2013-12-08 20:03:15 +00:00
5db045212e
- Forward declaration of register functions.
...
svn path=/trunk/; revision=53862
2013-12-08 16:50:07 +00:00
8983ae005a
- Forward declaration of register functions.
...
svn path=/trunk/; revision=53861
2013-12-08 16:40:49 +00:00
c9884f573a
- Forward declaration of register functions.
...
svn path=/trunk/; revision=53860
2013-12-08 15:52:29 +00:00
b630ccec17
- Forward declaration of register functions.
...
svn path=/trunk/; revision=53859
2013-12-08 15:40:10 +00:00
eb252d2d34
- Make local functions static.
...
- Forward declaration of register functions.
svn path=/trunk/; revision=53821
2013-12-07 11:37:58 +00:00
470a022c6d
Fix for dissecting cdt without having a tree.
...
svn path=/trunk/; revision=53777
2013-12-04 09:39:19 +00:00
65db82872c
When including <epan/prefs.h> don't force inclusion of <epan/uat.h>
...
svn path=/trunk/; revision=53769
2013-12-03 22:16:49 +00:00
231e52a9ea
Reject the packet if data is NULL without doing anything else.
...
svn path=/trunk/; revision=53737
2013-12-02 21:52:46 +00:00
9b38829b34
Reject the packet if data is NULL without doing anything else.
...
svn path=/trunk/; revision=53708
2013-12-02 02:31:04 +00:00
42a64c3557
If data is NULL, the bug, if any, is not with *this* dissector, but with whichever one failed to pass the data properly.
...
svn path=/trunk/; revision=53706
2013-12-02 02:07:42 +00:00
40c6d9abcb
Copy over rev 53700 to cmake
...
svn path=/trunk/; revision=53702
2013-12-01 21:56:40 +00:00
9baa93519c
Update to V11.7.1 (2013-09)
...
svn path=/trunk/; revision=53700
2013-12-01 20:34:21 +00:00
82e2675f45
Avoid including <wiretap/wtap.h> in dissectors.
...
svn path=/trunk/; revision=53655
2013-11-29 20:53:00 +00:00
5ac6474c94
Rename some of pint.h macros to match common style (bits number on the end).
...
pntohs -> pntoh16
pntohl -> pntoh32
pletohs -> pletoh16
pletohl -> pletoh32
phtons -> phton16
phtonl -> phton32
svn path=/trunk/; revision=53652
2013-11-29 18:59:06 +00:00
861e0334f4
From Vineeth:
...
Support for Nokias GSM MAP Private Extensions
svn path=/trunk/; revision=53600
2013-11-26 20:29:17 +00:00
402fed459f
Fix a shadowed declaration error when compiling with gcc 4.3.2
...
svn path=/trunk/; revision=53562
2013-11-25 11:23:11 +00:00
17e16ae136
Prettify LTE Positioning Protocol dissection
...
svn path=/trunk/; revision=53561
2013-11-25 11:16:24 +00:00
db7405bb13
Dissect UE Rx - Tx time difference field
...
svn path=/trunk/; revision=53557
2013-11-24 23:09:48 +00:00
1db1b8e2bb
Convert ASN1 dissectors from ep_address_to_str to address_to_str. Clean up a bit
...
of ansi_tcap code while in the neighbourhood.
svn path=/trunk/; revision=53530
2013-11-23 22:37:33 +00:00
9b7fb8a811
Create the ability to have packet scoped "proto" data. Bug 9470 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9470 )
...
I'm not sold on the name or module the proto_data functions live in, but I believe the function arguments are solid and gives us the most flexibility for the future. And search/replace of a function name is easy enough to do.
The big driving force for getting this in sooner rather than later is the saved memory on ethernet packets (and IP packets soon), that used to have file_scope() proto data when all it needed was packet_scope() data (technically packet_info->pool scoped), strictly for Decode As.
All dissectors that use p_add_proto_data() only for Decode As functionality have been converted to using packet_scope(). All other dissectors were converted to using file_scope() which was the original scope for "proto" data.
svn path=/trunk/; revision=53520
2013-11-23 02:20:13 +00:00
14ee1a5a86
Fix unused-const-variable error when build with clang 3.4
...
svn path=/trunk/; revision=53510
2013-11-22 14:52:04 +00:00
0d20064172
Fix unused-const-variable error when build with clang 3.4
...
svn path=/trunk/; revision=53509
2013-11-22 14:51:52 +00:00
ea45be32c5
Add a way to retrieve a PER variable bit string length
...
svn path=/trunk/; revision=53382
2013-11-17 13:31:32 +00:00
7221215cdc
Add "rtp handle protection" inside srtp_add_address/rtp_add_address/bluetooth_add_address so dissectors calling it don't need to find "rtp" just for the handle check.
...
svn path=/trunk/; revision=53288
2013-11-12 22:04:03 +00:00
a661864f48
Add "T.38 handle protection" inside t38_add_address() so dissectors calling it don't need to find "t38" just for the handle check.
...
svn path=/trunk/; revision=53283
2013-11-12 21:10:20 +00:00
4945174ae6
Pass "wild_card" directly to dissector instead of using private_data. "h248term" dissector is not in Wireshark source, so third-party will need to update accordingly.
...
svn path=/trunk/; revision=53241
2013-11-10 21:33:45 +00:00
ce62a3c5cc
Use ASN.1 private data instead of pinfo->private_data to exchange kerberos callback functions.
...
svn path=/trunk/; revision=53240
2013-11-10 19:58:03 +00:00
d5d8c3c359
context is not being passed to dissector, not through pinfo->private_data so check data parameter, not pinfo->private_data.
...
svn path=/trunk/; revision=53236
2013-11-10 17:17:18 +00:00
ae59b09443
Add missing includes in order to remove exceptions.h from proto.h (next commit).
...
svn path=/trunk/; revision=53230
2013-11-10 15:59:37 +00:00
8081cf1d90
Add data parameter to tcp_dissect_pdus() as well as convert it to using "new" style dissectors.
...
Now that "bytes consumed" can be determined, should tcp_dissect_pdus() take advantage of that?
Should tcp_dissect_pdus return length (bytes consumed)? There are many dissectors that just call tcp_dissect_pdus() then return tvb_length(tvb). Seems like that could all be rolled into one.
svn path=/trunk/; revision=53198
2013-11-09 17:46:28 +00:00
c9b2ee3768
include <wsutil/pint.h> only when needed.
...
svn path=/trunk/; revision=53196
2013-11-09 15:44:29 +00:00
1899903f69
Include <epan/to_str.h> only when needed.
...
svn path=/trunk/; revision=53189
2013-11-09 13:41:10 +00:00
d62f92b7f1
Make LDAP dissector use ASN.1 private_data instead of pinfo->private_data.
...
Cleanup a forgotten pinfo->private_data use in the H245 dissector.
svn path=/trunk/; revision=53160
2013-11-08 02:02:43 +00:00
fa3332e8ed
Remove extraction of cmake parameters from autotools files.
...
While it was an interesting exercise it just doesn't
work good enough to stay, i.e. it doesn't automatically
pick up changes but requires rerunning cmake instead.
svn path=/trunk/; revision=53149
2013-11-07 21:40:31 +00:00
696194999e
From Vasil Velichkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9382 :
...
Fix dissection of GSM MAPv3 ReportSM_DeliveryStatusRes
svn path=/trunk/; revision=53148
2013-11-07 21:08:15 +00:00
5f2c75e940
Add missing cast.
...
svn path=/trunk/; revision=53096
2013-11-05 22:58:50 +00:00
b6b78d69db
In an effort to reduce the use of pinfo->private_data (and some true global variables), I converted the ASN.1 dissectors that use pinfo->private_data to exchange a SESSION_DATA_STRUCTURE to instead only exchange it in the context of ASN.1. This meant converting dissectors to the "new" style to pass the SESSION_DATA_STRUCTURE as well as providing a pointer to it in asn1_ctx_t.private_data. Yes, it's still "private data", but it's not used by all dissectors like pinfo->private data is.
...
svn path=/trunk/; revision=53090
2013-11-05 18:47:26 +00:00
149de99d68
Have rose_ctx_t passed into subdissectors instead of using pinfo->private_data.
...
svn path=/trunk/; revision=53061
2013-11-03 12:57:58 +00:00
60e3e52a53
Have asn1_ctx_t passed into the "h245.gef.name" and "h245.gef.content" subdissectors instead of using pinfo->private_data.
...
svn path=/trunk/; revision=53055
2013-11-03 02:45:22 +00:00
02a8391535
Require dissector_try_string to pass a data parameter to its subdissectors. There weren't that many calls, so might as well modify the function than create a need for dissector_try_string_new.
...
svn path=/trunk/; revision=53049
2013-11-02 15:52:25 +00:00
c0fcebb07a
Add a data parameter to call_ber_oid_callback to be able to pass data to subdissectors found with dissector_try_string_new.
...
The intention is to aid in the removal of pinfo->private_data use as well as static global variables in a dissector. For now, all calls to call_ber_oid_callback have the data parameter set to NULL.
svn path=/trunk/; revision=52994
2013-10-31 00:57:03 +00:00
bd683d5ee1
Pass T.38 data to subdissectors directly instead of using pinfo->private_data.
...
svn path=/trunk/; revision=52964
2013-10-29 21:12:50 +00:00
0ad98563a2
From didier gautheron: remove redundant or use faster col_xxx functions
...
- when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster.
- same for replace col_append_fstr and col_append_str
- remove col_clear() when it's redundant:
+ before a col_set/col_add if the dissector can't throw an exception.
- replace col_append() after a col_clear() with faster col_add... or col_set
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344
svn path=/trunk/; revision=52948
2013-10-29 14:09:20 +00:00
66d64c686e
Pass security command details (integrity and ciphering algorithms) to PDCP (which doesn't yet do much with them)
...
svn path=/trunk/; revision=52946
2013-10-29 13:49:14 +00:00
c89b9a2cdc
initialize tree variables
...
svn path=/trunk/; revision=52920
2013-10-28 16:59:57 +00:00
3b91b9586f
Pass tcap_private into the dissectors that need it rather than use private_data. Not sure if value_ptr is the "proper" place to pass tcap_private "internally" within the TCAP dissector, but it gets away from (potential) private_data (ab)use.
...
svn path=/trunk/; revision=52916
2013-10-28 13:36:49 +00:00
09bd9ad788
Have ANSI TCAP dissector pass data through subdissector parameter instead of using struct _packet_info.
...
svn path=/trunk/; revision=52885
2013-10-27 02:00:18 +00:00
0690c4f490
More SVN properties cleanup.
...
svn path=/trunk/; revision=52884
2013-10-27 01:11:15 +00:00
3342e3bc89
Convert some emem to wmem. It took some manual flow analysis, but they are only
...
used during actual packet dissection.
svn path=/trunk/; revision=52870
2013-10-26 16:04:21 +00:00
6dd42b581a
Fix some [-Wunused-const-variable] warnings (using '#if 0')
...
svn path=/trunk/; revision=52862
2013-10-26 02:09:14 +00:00
95f484a91e
Add a very small hack to make the UAT update callback error string freeable, and
...
convert all existing UAT update callbacks to use glib memory instead of
ephemeral memory for that string.
UAT code paths are entirely distinct from packet dissection, so using ephemeral
memory was the wrong choice, because there was no guarantees about when it would
be freed.
The move away from emem still needs to be propogated deeper into the UAT code
itself at some point.
Net effect: remove another bunch of emem calls from dissectors, where replacing
with wmem would have caused assertions.
svn path=/trunk/; revision=52854
2013-10-25 22:14:25 +00:00
b552143a5c
Put PDU dissection in protocol tree
...
svn path=/trunk/; revision=52724
2013-10-20 21:05:37 +00:00
7f3d07b9fd
From e.yimjia via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9289 :
...
Add dissection of OMA-ILP
svn path=/trunk/; revision=52721
2013-10-20 18:43:00 +00:00
d269d19f99
Fix a typo
...
svn path=/trunk/; revision=52719
2013-10-20 18:06:23 +00:00
744f47107e
H.225.0: fix handling of compound parameters in Generic Extensible Framework (H.460.22 did not work well)
...
svn path=/trunk/; revision=52659
2013-10-17 11:24:43 +00:00
938206442c
Upgrade RRLP dissector to V11.0.0
...
svn path=/trunk/; revision=52640
2013-10-16 03:06:46 +00:00
f6e09faa2d
From Ed Beroset: add modelines and fix irregular indenting;
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9273
This patch adds modelines and cleans up the irregular indentation of
this dissector's code. The only other change was in
asn1/c1222/packet-c1222-template.c to consolidate an #ifdef that had a
redundant #endif (line 812) and subsequent reopening #ifdef (line
824). The only thing between them was comments, so the span of the
original #ifdef (line 644) was simply extended by eliminating those
two lines.
The purpose for this patch is to make the file easier to edit and
understand in advance of more substantive patches later. This patch
is intended to be easy to review by having only non-substantive
changes.
svn path=/trunk/; revision=52636
2013-10-16 00:57:28 +00:00
9c4ee86784
Add CMake properties to targets so that they are logically organised when using a Visual Studio solution.
...
Add CMake properties to group the source files in epan into logical blocks when using a Visual Studio solution.
svn path=/trunk/; revision=52580
2013-10-13 09:21:55 +00:00
545455db1c
Fix compilation when we don't HAVE_LIBGCRYPT
...
svn path=/trunk/; revision=52527
2013-10-11 00:42:02 +00:00
f29544f9df
Add a call to tvb_ensure_bytes_exist before we allocate memory based on our
...
offset+size, prevents attempts to allocate outrageous memory, fixing
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9260
svn path=/trunk/; revision=52503
2013-10-10 17:44:55 +00:00
a50dee3286
From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9246
...
Fix memory leaks and bad memory accesses in c1222 dissector.
From me: use realloc in a handoff function since it may get called multiple
times, and we only need the latest.
svn path=/trunk/; revision=52497
2013-10-10 16:18:49 +00:00
8a9e9de7bf
mpeg pes private data is 16 bytes long, see iso 13818-1
...
svn path=/trunk/; revision=52447
2013-10-08 11:23:22 +00:00
94f0e1fe21
Fully support relative AP-titles in C12.22. Bug 9196 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9196 )
...
From Ed Beroset
svn path=/trunk/; revision=52394
2013-10-06 02:42:14 +00:00
76e8ff1d8d
Replace the 3 dissector tables (with a single entry in each) by a direct call to the GSM SMS dissector
...
svn path=/trunk/; revision=52336
2013-10-02 18:04:06 +00:00
408ba7bade
From beroset@mindspring.com:
...
c1222 dissector has wrong tag value for BER-encoding of calling_AE_qualifier
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9193
svn path=/trunk/; revision=52225
2013-09-26 21:15:44 +00:00
019e64f58d
Upgrade RRC dissector to v11.7.0
...
svn path=/trunk/; revision=52202
2013-09-24 17:56:17 +00:00
d74564d6cf
Ensure to release an existing DRX configuration when receiving a RRC Connection Setup message
...
svn path=/trunk/; revision=52193
2013-09-23 21:21:58 +00:00
15ba18d1df
Upgrade LPPa dissector to v11.3.0
...
svn path=/trunk/; revision=52192
2013-09-23 20:20:36 +00:00
102c452bcb
More emem -> wmem conversion:
...
- tvb_get_g_stringz()/tvb_get_ephemeral_stringz()/tvb_get_seasonal_stringz() -> tvb_get_stringz()
- tvb_get_g_stringz_enc()/tvb_get_ephemeral_stringz_enc() -> tvb_get_stringz_enc()
- tvb_get_ephemeral_unicode_stringz() -> tvb_get_unicode_stringz()
- tvb_bcd_dig_to_ep_str() -> tvb_bcd_dig_to_wmem_packet_str()
- update docs accordingly
svn path=/trunk/; revision=52180
2013-09-22 20:04:35 +00:00
a0c53ffaa1
emem -> wmem conversion:
...
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits()
- tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup()
- tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode()
- tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string()
- tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string()
- tvb_get_ephemeral_string_enc() -> tvb_get_string_enc()
- update docs accordingly
svn path=/trunk/; revision=52172
2013-09-22 15:50:55 +00:00
6df83e8078
Add _g_ to the names of functions that allocate glib memory. This is a bit more
...
explicit, and frees up the "generic" names (like tvb_memdup) for new signatures
that take the appropriate wmem pool.
Majority of the conversion done with sed.
svn path=/trunk/; revision=52164
2013-09-21 17:04:41 +00:00
95c5f81c83
DCH-ID can be 255
...
svn path=/trunk/; revision=52154
2013-09-20 14:19:31 +00:00
ab7d8cc87d
Fix a couple of EXPORT_DEPENDS
...
svn path=/trunk/; revision=52135
2013-09-18 03:58:07 +00:00
6883f691c7
Add the dependeny handling for windows builds as well
...
svn path=/trunk/; revision=52134
2013-09-18 03:31:03 +00:00
ae8824d555
Missed 1 character replacement as part of r52132.
...
svn path=/trunk/; revision=52133
2013-09-18 02:58:14 +00:00
b9ee9fa694
Remove all non-ASCII characters from all .asn files. I didn't see the harm in replacing them all as opposed to only those not copied verbatim from other sources.
...
svn path=/trunk/; revision=52132
2013-09-18 02:48:29 +00:00
af15a51a6b
Fix remaining dependencides for -exp.cnf files.
...
svn path=/trunk/; revision=52129
2013-09-17 20:45:00 +00:00
de20bbf0ac
More dependeny updates for asn1 -exp.cnf files.
...
Only three remaining: p7, p22, x509ce - thanks to Chris Maynard for the list.
svn path=/trunk/; revision=52127
2013-09-17 19:43:37 +00:00
72f8ca4895
One of the wmem patches only updated the generated packet-snmp.c
...
but not the source. Fix that.
svn path=/trunk/; revision=52123
2013-09-17 18:54:18 +00:00
fb834104e5
When building packet-dap.c on an empty build tree, packet-dap.c would
...
be incorrect on the first pass and only be correct when remade.
The reason was that disp-exp.cnf was created incorrectly on first pass.
disp-exp.cnf required dop-exp.cnf to build correctly, so add a mechanism
to add dependencies for export files.
Note: Only the cmake change has been tested, the autofoo stuff requires
testing.
svn path=/trunk/; revision=52120
2013-09-17 18:02:25 +00:00
a2e86de160
Fix dependency problems (continuation of r52110 and r52112).
...
svn path=/trunk/; revision=52118
2013-09-17 14:45:52 +00:00
af96c7bb45
Fix a difference to Makefile.common
...
svn path=/trunk/; revision=52117
2013-09-17 05:53:02 +00:00
686dd9b061
Copy over rev 52110 to cmake
...
svn path=/trunk/; revision=52112
2013-09-16 21:45:46 +00:00
e14b587293
Fix dependency problem reported by Joerg Mayer on wireshark-dev.
...
Ref: http://www.wireshark.org/lists/wireshark-dev/201309/msg00151.html
svn path=/trunk/; revision=52110
2013-09-16 21:35:27 +00:00
886332e74f
Whitespace changes
...
svn path=/trunk/; revision=52109
2013-09-16 21:35:19 +00:00
7d6899b96b
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9155 :
...
Ensure that codec_str string is always initialized
svn path=/trunk/; revision=52107
2013-09-16 21:26:03 +00:00
c5ffff76d8
Fix checkapi warnings (missing id)
...
Replace Makefile.{am,nmake,common} that did not conform by
their asn1/c133/ version.
svn path=/trunk/; revision=52062
2013-09-15 15:00:03 +00:00
65ff43fada
Finish asn1 emem -> wmem conversion.
...
Left are snmp and those functions that don't have wmem equivalents.
svn path=/trunk/; revision=52060
2013-09-15 14:37:46 +00:00
c65459c729
emem -> wmem (don't forget about .cnf)
...
svn path=/trunk/; revision=52058
2013-09-15 14:33:38 +00:00
888650324b
emem -> wmem
...
svn path=/trunk/; revision=52054
2013-09-15 13:24:14 +00:00
868b345eea
Convert a few more dissectors to wmem API
...
svn path=/trunk/; revision=52053
2013-09-15 10:29:49 +00:00
fd50ee16e8
dissect OCSP nonce extension
...
some minor reformatting of the ASN.1 imports
svn path=/trunk/; revision=51987
2013-09-12 21:29:50 +00:00
efe18f199c
Convert a few dissectors from emem to wmem API
...
svn path=/trunk/; revision=51983
2013-09-12 20:37:30 +00:00
0c11b6f8da
Give various files RCS IDs.
...
svn path=/trunk/; revision=51963
2013-09-12 03:41:22 +00:00
0c41507bad
Change some internal dissector table UI names so it's clear which protocol they pertain to and it's easier to find in the list.
...
svn path=/trunk/; revision=51904
2013-09-09 21:55:57 +00:00
9e3f9b449f
expert_add_info_format_text -> expert_add_info_format
...
svn path=/trunk/; revision=51852
2013-09-09 00:44:09 +00:00
00dd0adc0d
expert_add_info_format_text -> expert_add_info_format
...
svn path=/trunk/; revision=51851
2013-09-09 00:28:48 +00:00
f54441c125
Add a chunk forgotten in r51846
...
svn path=/trunk/; revision=51847
2013-09-08 21:22:11 +00:00
a6ae13dee9
Slightly different fix for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9117 :
...
Check that tvb returned by dissect_per_bit_string is not null before trying to use it
svn path=/trunk/; revision=51846
2013-09-08 21:10:36 +00:00
57c28aeffd
Fix the FSF address in the license header for the new ASN.1 dissectors.
...
svn path=/trunk/; revision=51830
2013-09-07 22:12:24 +00:00
52c9e57474
Deduplicate some type and field names.
...
svn path=/trunk/; revision=51800
2013-09-06 17:39:03 +00:00
96d29a5d50
Get rid of a duplicated filter name.
...
svn path=/trunk/; revision=51792
2013-09-05 20:55:59 +00:00
8552f0df64
The length field is retrieved from the packet in bytes, not bits, so stop
...
adjusting it by 8 everywhere.
Seems to fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9087 though
someone more familiar with the protocol will have to verify it's actually
correct now.
svn path=/trunk/; revision=51784
2013-09-05 13:15:04 +00:00
3b6f55c579
Convert atn-* dissectors to wmem. No emem in new code please!
...
svn path=/trunk/; revision=51780
2013-09-05 12:13:00 +00:00
39bff3218a
Missed 50% of the updates in last commit
...
svn path=/trunk/; revision=51773
2013-09-05 07:33:05 +00:00
d4f2865595
CMakeLists was no longer in sync with Makefile.common
...
svn path=/trunk/; revision=51772
2013-09-05 07:28:47 +00:00
022706764b
Add missing CMakeLists.txt files
...
svn path=/trunk/; revision=51771
2013-09-05 06:05:15 +00:00
02a61b07e4
Fix cmake syntax - so now it "only" warns about missing
...
CMakeLists.txt in the subdirectories.
svn path=/trunk/; revision=51770
2013-09-05 05:48:22 +00:00
80cd0dca1d
From Mathias Guettler:
...
New dissector for Air/Ground Datalink ICAO doc 9705 Ed2: ULCS, CM, CPDLC.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8903
svn path=/trunk/; revision=51766
2013-09-05 05:26:04 +00:00
7dbc052d78
More dissectors to wmem. There are no more dissectors using se_tree now, just a
...
few other places.
svn path=/trunk/; revision=51622
2013-09-01 01:00:11 +00:00
a09ee6af03
The first step towards tracking and showing DRX info in MAC:
...
- send release from RRC
- show current DRX config from each frame, including a link back to the
RRC config frame
- show simple DRX state for each frame (currently only offset into long
cycle and whether within long cycle 'on' period)
TODO:
- simulate timers in response to new UL/DL transmissions or DL CRC
errors
- maintain whether in long or short cycle
- show state of all timers
svn path=/trunk/; revision=51585
2013-08-30 04:08:57 +00:00
7e3922cf43
Use dissector_delete_uint_range/dissector_add_uint_range
...
svn path=/trunk/; revision=51540
2013-08-27 19:21:20 +00:00
b5900e53d9
Make sure our ldap_call_response_t struct is always completely initialized,
...
fixing a "Conditional jump or move depends on uninitialised value" error found
by valgrind fuzzing.
svn path=/trunk/; revision=51516
2013-08-25 17:31:15 +00:00
0675ed7494
Clang, clang, clang went the warning....
...
Fix a memset (drb_mapping is a pointer, so its size is the size of a
pointer; we want the size of what it points to).
svn path=/trunk/; revision=51500
2013-08-23 23:51:52 +00:00
ae4f556630
Simplify logic a bit now that we do not use anymore GUINT_TO_POINTER macro
...
svn path=/trunk/; revision=51490
2013-08-23 12:51:07 +00:00
483ee317f7
From Martin Mathieson:
...
Follow-up of r51429 that
- uses accessors to lazily allocate a private_data struct and returns the different parts based upon their use
- includes the v1130 DRX Config
svn path=/trunk/; revision=51489
2013-08-23 10:42:11 +00:00
75f4fa5b4b
Remove tree check when dissecting PCCH message so as to avoid filtering expert info on first pass
...
svn path=/trunk/; revision=51477
2013-08-22 19:55:25 +00:00
b3dc1eed1c
Fix Coverity CID's 1063706-1063710: Out-of-bounds read (OVERRUN_STATIC)
...
svn path=/trunk/; revision=51450
2013-08-21 14:08:42 +00:00
641032ea44
Gather together dedicated DRX configuration, and make sure that it
...
is internally consistent.
TODO: include r11 sequence that can overwrite some of these values.
TODO: actx->private_data gets reused for several purposes, need to
separate these uses out and avoid possible conflicts...
svn path=/trunk/; revision=51429
2013-08-19 17:06:42 +00:00
b46f9bebe2
Change some dissectors to use pinfo memory pool instead of malloc if it can trigger an exception between between buffer allocation and tvb_set_free_cb call
...
svn path=/trunk/; revision=51427
2013-08-19 14:55:41 +00:00
02cae558f9
Do not use ephemeral memory when adding a new data source
...
svn path=/trunk/; revision=51424
2013-08-19 11:11:11 +00:00
64f079430b
Fix $Id$.
...
svn path=/trunk/; revision=51373
2013-08-15 03:55:09 +00:00
3b5aaefce3
- Extract variables from Makefile.common.
...
- Apply this to asn1/c1222/
svn path=/trunk/; revision=51324
2013-08-12 22:17:06 +00:00
24e7b8aefd
Fix copy paste error and reinitialize actx->private_data to NULL once used
...
svn path=/trunk/; revision=51311
2013-08-12 09:26:24 +00:00
467ece42b3
Fix (-W)documentation error found by Clang
...
../../asn1/c1222/packet-c1222-template.c:348:15: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param pinfo
~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:349:14: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param tree
~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:350:16: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param length
~~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:351:16: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param offset
~~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:758:11: error: parameter 'keybuf' not
found in the function declaration [-Werror,-Wdocumentation]
* \param keybuf is updated with a copy of the key data if successful lookup.
^~~~~~
../../asn1/c1222/packet-c1222-template.c:758:11: note: did you mean 'keybuff'?
* \param keybuf is updated with a copy of the key data if successful lookup.
^~~~~~
keybuff
../../asn1/c1222/packet-c1222-template.c:879:13: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param tvb
~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:880:16: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param offset
~~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:881:13: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param len
~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:882:15: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param pinfo
~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:883:14: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param tree
~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1023:13: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param tvb
~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1024:15: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param pinfo
~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1025:14: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param tree
~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1047:15: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param pinfo
~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1048:13: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param tvb
~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1049:16: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param offset
~~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1068:13: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param tvb
~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1069:15: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param pinfo
~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1070:14: error: empty paragraph passed
to '\param' command [-Werror,-Wdocumentation]
* \param tree
~~~~~~~~~~^
svn path=/trunk/; revision=51272
2013-08-10 21:30:38 +00:00
237182ba42
Use proper macros to cast between uint and pointer
...
svn path=/trunk/; revision=51246
2013-08-10 17:09:12 +00:00
11304a30ee
Try again...
...
svn path=/trunk/; revision=51245
2013-08-10 16:53:05 +00:00
8cddb7a24e
Try using guint.
...
svn path=/trunk/; revision=51244
2013-08-10 16:34:19 +00:00
0fb73abcc9
Add a malformed check to show if GroupA has more RAPIDs than A & B
...
combined.
svn path=/trunk/; revision=51243
2013-08-10 16:17:33 +00:00
cf6288e21f
Added default ignore targets for new asn1 dissectors.
...
Removed cnf data from atn-cpdlc.asn to make it generate.
svn path=/trunk/; revision=51215
2013-08-08 11:15:45 +00:00
77f4bef154
From Mathias Guettler:
...
New dissector for Air/Ground Datalink ICAO doc 9705 Ed2: ULCS, CM, CPDLC.
Add the files to the distribution.
svn path=/trunk/; revision=51212
2013-08-08 05:34:22 +00:00
a4d1560fd1
From Mathias Guettler:
...
New dissector for Air/Ground Datalink ICAO doc 9705 Ed2: ULCS, CM, CPDLC.
Just adding the files to SVN for now.
svn path=/trunk/; revision=51210
2013-08-08 05:09:13 +00:00
08d223eb71
When dissecting IMSI handle the zero length tvb case, fixes "Malformed Packet: CAMEL (empty IMSI tag)"
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9015
svn path=/trunk/; revision=51208
2013-08-08 04:36:54 +00:00
2f072ac53c
add a range check for dch_id
...
this should fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9005
svn path=/trunk/; revision=51195
2013-08-07 20:18:11 +00:00
9cfac1227d
Replace hfinfo pointer to same_name_prev, with same_name_prev_id.
...
svn path=/trunk/; revision=51175
2013-08-06 20:53:47 +00:00
518ac53e2c
Make some global variables static
...
svn path=/trunk/; revision=51163
2013-08-05 20:15:06 +00:00
af134c29ca
Convert proto_item_set_expert_flags into filterable items.
...
svn path=/trunk/; revision=51140
2013-08-04 19:59:01 +00:00
3eafc74e2b
Convert proto_item_set_expert_flags to "filterable" items in alcap dissector. Unfortunately it had a few tentacles, so they needed to be brought along for the ride.
...
svn path=/trunk/; revision=51136
2013-08-04 13:46:25 +00:00
f7843da692
md5.h is in wsutil now.
...
svn path=/trunk/; revision=51102
2013-08-01 23:53:35 +00:00
2df54da6e2
Move a bunch of the crypt modules and pint.h into wsutil.
...
This means wsutil now links against libcrypt.
Protect a bunch of the crypt header files from multiple inclusion.
svn path=/trunk/; revision=51100
2013-08-01 23:34:47 +00:00
82569132d9
Add the forgotten makefile updates.
...
svn path=/trunk/; revision=51017
2013-07-29 18:19:59 +00:00
266e577aee
Update to handle version 9.
...
svn path=/trunk/; revision=50981
2013-07-28 19:25:14 +00:00
8441fff193
Use the pinfo pool for adding data sources in the h245 dissector. The packet
...
pool is freed before the packet is displayed or otherwise processed, so adding
data sources from it leads to use-after-free errors.
Not sure why this wasn't showing up in the fuzz-bot valgrind step, there
are lots of h245 captures in the menagerie...
svn path=/trunk/; revision=50897
2013-07-25 23:58:49 +00:00
802e7bed77
Try to differentiate a non filled private_data (pointer set to NULL) from an enum with value = 0
...
svn path=/trunk/; revision=50837
2013-07-23 14:34:46 +00:00
c702e92121
Replace relative timestamp with reference frame number. Saves 16B per frame.
...
svn path=/trunk/; revision=50772
2013-07-21 23:07:33 +00:00
a18172147f
Remove fragment_data, add fragment_head, fragment_item - for now alias it to the same structure.
...
This is begin of work to split fragment head and fragments items.
svn path=/trunk/; revision=50708
2013-07-17 21:12:24 +00:00
f5f20fa8e3
Fix warning: ISO C does not allow extra ';' outside of a function.
...
svn path=/trunk/; revision=50638
2013-07-15 20:42:57 +00:00
54bb2e7a5c
Move report_err.{h,c} from epan into wsutil: there's nothing epan-specific there and moving it avoids having to recompile the file for use in editcap and capinfos (which don't link against libwireshark).
...
svn path=/trunk/; revision=50598
2013-07-15 02:48:26 +00:00
0e40234217
Make pointers to raw packet data pointers to guint8, not pointers to
...
char; they're chunks of raw octets, not characters.
svn path=/trunk/; revision=50586
2013-07-14 17:39:36 +00:00
543ba2746b
fix: ../../asn1/t38/packet-t38-template.c:346: warning: request for implicit conversion from 'gpointer' to 'char *' not permitted in C++
...
svn path=/trunk/; revision=50582
2013-07-14 15:51:15 +00:00
c766e78cfa
Rewrite reassemble API to use TVBs instead of raw data.
...
(it seems to be working for TCP ^^)
svn path=/trunk/; revision=50580
2013-07-14 14:42:05 +00:00
8c9ab802ce
Upgrade LTE RRC dissector to v11.4.0
...
svn path=/trunk/; revision=50473
2013-07-09 20:39:09 +00:00
b2475c1c29
Squelch some warnings that show up with, for example, the GCC 4.2.1 that
...
comes with Xcode 3.2.6 (it's not a real problem, but that requires more
flow analysis than that version of the compiler does, apparently).
svn path=/trunk/; revision=50419
2013-07-06 19:34:21 +00:00
74e1b830a9
Use epan-scoped memory for h248 packages. Fixes another ~24KB of leaks.
...
svn path=/trunk/; revision=50414
2013-07-06 18:14:04 +00:00
225698ef0b
Fix display filter errors caught by checkfiltername.pl
...
svn path=/trunk/; revision=50399
2013-07-06 02:53:45 +00:00
eec311ef39
Fix duplicate diplay filter names found by checkfiltername.pl
...
svn path=/trunk/; revision=50396
2013-07-06 01:20:38 +00:00
7878e93cad
expert_add_info_format_text + proto_tree_add_text = proto_tree_add_expert_format, where applicable.
...
svn path=/trunk/; revision=50377
2013-07-03 23:43:26 +00:00
b00abd1c43
Check actx->private_data validity before using it
...
svn path=/trunk/; revision=50339
2013-07-03 12:01:12 +00:00
b91b990a77
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8880 :
...
Check actx->private_data validity before using it
svn path=/trunk/; revision=50338
2013-07-03 08:53:47 +00:00
98492c5619
expert_add_info + proto_tree_add_text = proto_tree_add_expert, where applicable
...
svn path=/trunk/; revision=50337
2013-07-03 02:59:31 +00:00
17772df943
Fix Coverity CID 1040373 (Dereference before null check). Minor whitespace changes come along for the ride on this one.
...
svn path=/trunk/; revision=50297
2013-07-01 15:09:56 +00:00
997c6c7d8e
Fix Coverity CID 712348 (Unused pointer value).
...
svn path=/trunk/; revision=50288
2013-07-01 06:15:37 +00:00
95daae2290
Squelch some warnings.
...
svn path=/trunk/; revision=50286
2013-07-01 06:13:21 +00:00
bfcaf93bff
Fix Coverity CID 1040372 (Printf arg count mismatch) by eliminating the double %'s.
...
svn path=/trunk/; revision=50283
2013-07-01 05:47:13 +00:00
c1ddd6046d
replace object_identifier_id with actx->external.direct_reference
...
svn path=/trunk/; revision=50209
2013-06-28 12:52:13 +00:00
9009944d51
Remove all global variables in P1 dissector. Bug 8515 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8515 )
...
Added a "subtree context" structure to asn1_ctx_t. This should allow other ASN.1 dissector global variables to be replaced when only used for transferring data between fields in a subtree.
svn path=/trunk/; revision=50208
2013-06-28 12:43:29 +00:00
a441793cba
Move a couple of time-related modules into wsutil.
...
A bunch of files didn't really need to include these header files so remove
the include line rather than changing it.
svn path=/trunk/; revision=50154
2013-06-25 22:02:20 +00:00
d23f769c0d
Add an option to dissect RRC-Container IE
...
svn path=/trunk/; revision=50130
2013-06-24 21:31:25 +00:00
87eb22f464
More proper fix (per advice of bug 8515 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8515 )) of global variables complained about in bug 7060 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7060 ). Not sure if algorithm_id of x509af dissector could also be a actx->external.direct_reference, so left it alone.
...
svn path=/trunk/; revision=50113
2013-06-22 15:08:18 +00:00
de10bc6b5e
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8799 :
...
Display certificate as UINT64 and add support for a 64bits unsigned value in BER dissector
svn path=/trunk/; revision=50096
2013-06-20 23:37:16 +00:00
64e15853fc
Fix for bug 8826.
...
The global variable 'address_item' was not always being set to NULL
before the dissection of a new frame. Do more to set it in the general
case, and in the particular case of an MTSBindResult_PDU, which was
triggering an error in the supplied capture.
There may be other entry points where this still safely isn't being
set.
svn path=/trunk/; revision=50083
2013-06-20 18:54:58 +00:00
7c8530539c
Ldap still needs to include wmem.h since it uses wmem during normal dissection,
...
just not for UAT purposes.
svn path=/trunk/; revision=50074
2013-06-20 14:01:54 +00:00
d63bd5330f
Back out some of the wmem conversions (r50063 and r50057).
...
These dissectors allocate ephemeral or seasonal memory in UAT callbacks, which
really makes no sense because UAT callbacks can occur when there is no packet or
file in scope, making this effectively a leak if the user is fiddling with their
UAT and never opens a capture.
Emem let you get away with this, wmem forces an assertion. Back out the changes
so that the UATs are usable until the code can be properly fixed to not use
out-of-scope allocators.
svn path=/trunk/; revision=50073
2013-06-20 06:26:03 +00:00
0d3718b467
Add some missing wmem includes that apparently only show up on Windows.
...
svn path=/trunk/; revision=50071
2013-06-19 23:53:25 +00:00
8b0f1addd9
Apparently one of our major global headers must include emem.h, because I just
...
found a bunch more asn1 dissectors using emem without ever directly including
the header. Convert those to wmem as well, which involves add a number of
#include directives since dissectors do *not* automatically pull in the wmem
headers.
svn path=/trunk/; revision=50066
2013-06-19 23:08:58 +00:00
b1e12ec925
Convert the rest of the ASN1 dissectors from emem to wmem.
...
svn path=/trunk/; revision=50063
2013-06-19 22:47:36 +00:00
9fa4a8e6b6
Convert a batch of asn1 dissectors from emem to wmem.
...
svn path=/trunk/; revision=50057
2013-06-19 20:43:03 +00:00
b77119aca7
Remove traling whitespace.
...
svn path=/trunk/; revision=50048
2013-06-19 18:33:49 +00:00
2eec913a4d
Fet rid of a global variable
...
svn path=/trunk/; revision=50034
2013-06-19 07:16:14 +00:00
830ebed406
Get rid of global variables
...
svn path=/trunk/; revision=50032
2013-06-19 06:44:39 +00:00
d9b5210c61
Fix CID 712341: Dereference null return value (NULL_RETURNS)
...
Well, not really. Just catch that case and error out.
svn path=/trunk/; revision=50029
2013-06-19 03:23:31 +00:00
2cf27a92a6
Set PDCP SN length for DRBs for separate RRC element.
...
svn path=/trunk/; revision=50021
2013-06-18 22:38:54 +00:00
868f74d628
Also signal value of PDCP SN (only used if enabled by RLC preferences).
...
svn path=/trunk/; revision=50019
2013-06-18 21:44:48 +00:00
ece132a5ce
Configure MAC LCID -> RLC channel settings from RRC.
...
svn path=/trunk/; revision=50016
2013-06-18 21:02:00 +00:00
458dcb7ea2
Add ability to export decrypted SSL/DTLS PDUs
...
svn path=/trunk/; revision=50001
2013-06-18 01:13:07 +00:00
f42e5bc9c0
Remove check_col() and the occasional tree.
...
This leaves just the Pidl dissectors remaining for removal of check_col() in the dissectors directory. A small handful of check_col() calls remain outside of the dissectors.
svn path=/trunk/; revision=49941
2013-06-14 19:46:54 +00:00
9c26c32645
Add parentheses around assignment used as truth value.
...
svn path=/trunk/; revision=49929
2013-06-14 13:20:41 +00:00
2dbf6c59a2
Remove check_col() from ASN.1 dissectors
...
svn path=/trunk/; revision=49927
2013-06-14 12:44:50 +00:00
82e220f2bd
Pretify dissection of date and Time.
...
svn path=/trunk/; revision=49905
2013-06-12 15:08:08 +00:00
822c02b5d0
Fix wrong offset in H.235 tokens causing malformed packet exception
...
svn path=/trunk/; revision=49899
2013-06-12 09:03:21 +00:00
03a322661f
Fix a crash when oid_info->value_typem is NULL
...
svn path=/trunk/; revision=49894
2013-06-12 04:21:40 +00:00
93be0fb393
Batch of filterable expert infos with some minor cleanup I noticed while doing the filter conversions.
...
svn path=/trunk/; revision=49893
2013-06-12 03:33:44 +00:00
bbb5aacd42
Show DisplayString as a string.
...
svn path=/trunk/; revision=49887
2013-06-11 16:35:06 +00:00
c891784de7
Quick fix for bug 8768. For now assume that only three logical channels
...
are valid. If we run into more add expert item and cap the channel
count.
svn path=/trunk/; revision=49787
2013-06-05 16:38:20 +00:00
1bb2081fd2
From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8746 :
...
Add procedure numbers to C12.22 dissection
svn path=/trunk/; revision=49775
2013-06-04 20:21:17 +00:00
3bfeaff546
Add subdissection of:
...
- SNMPv2-MIB sysDescr
- SNMPv2-MIB::sysName
svn path=/trunk/; revision=49774
2013-06-04 20:05:16 +00:00
29d51623c2
From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8762 :
...
Remove dead code (condition can never happen).
svn path=/trunk/; revision=49743
2013-06-04 01:38:53 +00:00
5e408534c8
cc1: warnings being treated as errors
...
../../asn1/nbap/packet-nbap-template.c: In function 'add_hsdsch_bind':
../../asn1/nbap/packet-nbap-template.c:349: warning: unused parameter 'tree'
svn path=/trunk/; revision=49708
2013-06-03 04:25:31 +00:00
7fe5422c4b
Convert ASN.1 dissectors to use filterable expert info.
...
NOTE: Kerberos ASN.1 template was updated, but not generated to source.
svn path=/trunk/; revision=49707
2013-06-03 03:42:36 +00:00
d7638de9b7
Also notify CMAS alerts
...
svn path=/trunk/; revision=49685
2013-06-01 23:27:16 +00:00
c553280339
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8745 :
...
Upgrade AP-title ASN.1 description
svn path=/trunk/; revision=49684
2013-06-01 23:10:37 +00:00
d41ce46c92
Make Earthquake and Tsunami Warning Sytem indications stand out a
...
bit more.
svn path=/trunk/; revision=49683
2013-06-01 22:26:47 +00:00
c310bd7dcc
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8744 :
...
Display C12.22 Invocation Id as unsigned integer
svn path=/trunk/; revision=49682
2013-06-01 20:51:14 +00:00
813dcf79a1
Don't intentionally use -1 as an hfindex: while only naughty before, with the
...
changes from r49644 you'll get complaints about the hf being unregistered...
Note that this code also intentionally passes -1 as an ett_index. It doesn't
currently complain so I'm leaving it alone for now...
svn path=/trunk/; revision=49648
2013-05-31 02:27:40 +00:00
3a80080fe9
Add some info to make it easier to see when SI config changes:
...
- show systemInfoModification in info column (and expert info), also
show number of UEs paged
- add expert item when systemInfoValueTag changes
- for MIB, add SFN to info column
svn path=/trunk/; revision=49603
2013-05-28 22:11:56 +00:00
ec1ebf5dd8
From LI Hai via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8708 :
...
Add MAC-DATA support to TETRA dissector and other minor improvements
svn path=/trunk/; revision=49567
2013-05-24 20:55:42 +00:00
a68080a1c6
Don't access nbap_dch_chnl_info if the index is > maxNrOfDCHs
...
svn path=/trunk/; revision=49418
2013-05-19 15:21:33 +00:00
4745ae8689
Revert r49406: it's not ready for prime time yet
...
svn path=/trunk/; revision=49410
2013-05-18 17:48:50 +00:00
Anders Broman