Commit Graph

59 Commits

Author SHA1 Message Date
Ulf Lamping 597ee656db try to fix some solaris buildbot warnings
svn path=/trunk/; revision=27449
2009-02-14 01:18:11 +00:00
Bill Meier 8afa208ffb Windows build: #include winsock2.h only when needed.
#include winsock2.h pulls in about 90 distinct .h files
and about 140 total .h files. 
Currently winsock2.h is (mostly unnecessarily) included
for each dissector via packet.h/wtap.h.
This patch removes #include winsock2.h from wtap.h and 
then includes winsock2.h (or windows.h) in the 
few specific places required. 
With this patch, my Windows Wireshark build takes 
about 30% less time.


svn path=/trunk/; revision=26535
2008-10-24 00:42:09 +00:00
Bill Meier 119d449880 Fix a bit more spacing
svn path=/trunk/; revision=26506
2008-10-20 21:38:53 +00:00
Bill Meier 6da6ad6451 Oops ! Revert (Remove) development stuff ....
svn path=/trunk/; revision=26505
2008-10-20 21:14:21 +00:00
Bill Meier 145e8f7b74 Adjust indentation to be more consistent ....
svn path=/trunk/; revision=26504
2008-10-20 20:51:04 +00:00
Bill Meier a14b7b5264 Addt'l minor cleanup
svn path=/trunk/; revision=26279
2008-09-26 17:12:15 +00:00
Bill Meier c60c77ba4a prefs callback not req'd
svn path=/trunk/; revision=26278
2008-09-26 17:06:44 +00:00
Bill Meier f8e3822738 Fix some warnings reported by gcc -Wshadow ...
Fix some spacing in packet-dcom.c

svn path=/trunk/; revision=25618
2008-06-27 16:15:30 +00:00
Stig Bjørlykke 677eb18d20 Rewrote some prohibited APIs in epan/dissectors/ (sprintf, strcpy, strcat).
If we get some truncated strings we probably overwrote some buffers...

svn path=/trunk/; revision=24249
2008-02-02 17:25:40 +00:00
Stephen Fisher c38ff43591 Fix compilation on OS X with GLib 1.2 by including ctype.h since our
isprint.h override only kicks in for GLib 2+.


svn path=/trunk/; revision=22125
2007-06-18 01:42:17 +00:00
Guy Harris 5a43799a17 Use G_GINT64_MODIFIER, rather than the PRI[douxX]64 macros, for GLib
routines and routines using those routines.  GLib might use different
modifiers for 64-bit quantities than the platform's C library does.

svn path=/trunk/; revision=21990
2007-05-29 18:52:42 +00:00
Guy Harris 1bc049906a Add some GCC warnings to the standard set, and add some others to the
--enable-extra-gcc-checks set.

If we turn on -pedantic, try turning on -Wno-long-long as well, so that
it's not *so* pedantic that it rejects the 64-bit integral data types
that we explicitly require.

Constify a bunch of stuff, and make some other changes, to get rid of
warnings.

Clean up some indentation.

svn path=/trunk/; revision=21526
2007-04-23 10:59:26 +00:00
Stephen Fisher 8fd3ee0560 Remove almost all of the casts I committed recently and in place of
them, add -Wno-pointer-sign to CFLAGS when gcc will accept it.


svn path=/trunk/; revision=21253
2007-03-28 21:55:11 +00:00
Stephen Fisher ab8f589336 Fix about 100 simple to fix warnings from gcc 4.0 in epan/dissectors
svn path=/trunk/; revision=21233
2007-03-27 22:50:11 +00:00
Ulf Lamping 0f8dbb8dc2 correct multidimensional SAFEARRAYs
svn path=/trunk/; revision=21123
2007-03-22 22:41:16 +00:00
Guy Harris a0fecf54bd Correctly return the item value through the pointer.
svn path=/trunk/; revision=21030
2007-03-14 18:25:19 +00:00
Ulf Lamping 7887d478cc add a new function dissect_dcom_HRESULT_item() for some more flexibility, use it in the CBA-ACCO dissector - as the value_strings from dcom can't be used in hf_register_info from a plugin
svn path=/trunk/; revision=20926
2007-02-25 15:48:43 +00:00
Bill Meier 103bf29730 Continuing the tradition: squelch some compiler warnings ....
svn path=/trunk/; revision=20866
2007-02-19 22:29:23 +00:00
Ulf Lamping 0f7e40945e dissector changes:
- new: ICBALogicalDevice2::PBAddressInfo
- enhanced: GROUPERRORDEF

simplify ett registration
add a callback for SAFEARRAY data dissection

svn path=/trunk/; revision=20723
2007-02-06 01:33:39 +00:00
Jaap Keuter 5f955a0fcc From Albert Chin:
Patch attached to convert usage of ntohl() -> g_ntohl(). On HP-UX,
ntohl() isn't available unless you -D_XOPEN_SOURCE_EXTENDED but there
are other uses of g_ntohl().

svn path=/trunk/; revision=19844
2006-11-07 07:39:16 +00:00
Jörg Mayer b9c69db9d3 Remove some // comments.
Fix a warning about nested comments.

svn path=/trunk/; revision=19828
2006-11-06 19:56:11 +00:00
Jaap Keuter 7ded21f336 Squelch compiler warnings
svn path=/trunk/; revision=19597
2006-10-18 19:42:10 +00:00
Ulf Lamping 4a03300106 distinguish between things "ToBeDone" and "NoSpecificationAvailable" as some DCOM things are just unknown and cannot be implemented therefore
svn path=/trunk/; revision=19174
2006-09-07 20:30:48 +00:00
Ulf Lamping 4ad1f977d2 add a new this/that flag value
svn path=/trunk/; revision=19066
2006-08-28 21:14:36 +00:00
Guy Harris 7cb6f60b18 Fix some format strings and format string arguments.
svn path=/trunk/; revision=18957
2006-08-19 03:01:15 +00:00
Ulf Lamping 7d04019388 some further work on the GUID/UUID resolvings
most of the relevant code moved to guid_utils
lot of corresponding code cleanup in packet-dcerpc.c
still using GHashTable
still not using a manuf like file

svn path=/trunk/; revision=18939
2006-08-17 19:09:41 +00:00
Ulf Lamping de0594b9a5 various UUID/GUID based changes.
I think I've changed all corresponding appearances from FT_STRING to FT_GUID, so assert the FT_ type as it should only be a FT_GUID now.

Add a generic implementation in guid_utils.h to have a way to store data about GUID to name resolving (something like value_string for e.g. int). It might be better to have a single registry for all GUID's of all dissectors and implement the GUID name resolving into the proto_tree_add... functions.

svn path=/trunk/; revision=18935
2006-08-16 23:13:26 +00:00
Ulf Lamping b2751079ac various minor DCOM dissection enhancements:
- add a generic guid register to dissect UUID's (move this to a seperate file?)
- this enables us to set some known names for special UUID's
- use standard DCOM fields for IID and alike in remunk.c
- cleanup dcom_protseq_vals handling
- some FT_STRING to FT_GUID changes

svn path=/trunk/; revision=18904
2006-08-14 23:39:48 +00:00
Ulf Lamping d0aed5f920 add an experimental DCOM object "database" based on the exchanged interface pointers
add a lot more PROFINET CBA dissection output based on these DCOM context information
still need some improvements, e.g. dissection uses a simple (slow) linear list search
changes are fuzz-tested

svn path=/trunk/; revision=18882
2006-08-11 19:15:12 +00:00
Ulf Lamping 692a3adfbb remove two old comments
svn path=/trunk/; revision=18632
2006-07-01 12:13:54 +00:00
Ulf Lamping 690bfd0bff add dissection of custom marshalled OBJREF's (as far as known)
svn path=/trunk/; revision=18596
2006-06-28 18:51:24 +00:00
Ulf Lamping 39e7f020e6 fix the hresult "filter" fields
svn path=/trunk/; revision=18469
2006-06-15 11:42:47 +00:00
Ulf Lamping aa748fc102 dcom_tvb_get_nwstringz0(): convert output to hexdump if the string contains nonprintable characters
svn path=/trunk/; revision=18453
2006-06-13 18:18:53 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Ulf Lamping cf17ccd7ac fix VARIANT BOOL meaning
svn path=/trunk/; revision=18095
2006-05-05 19:29:50 +00:00
Ulf Lamping 384c960017 bring HRESULT values in the right order
svn path=/trunk/; revision=17840
2006-04-07 22:05:34 +00:00
Ulf Lamping 6ea4c2745e add missing IDispatch methods and related dissections
svn path=/trunk/; revision=17658
2006-03-17 21:41:56 +00:00
Ronnie Sahlberg ebc0197755 remove two redundant strcpy so they dont show up as noice for grep strcpy *.c
svn path=/trunk/; revision=16231
2005-10-15 23:26:32 +00:00
Guy Harris f6ef22c553 Have show_exception() take a "const char *" as its exception message,
and not free the string to which it points.  Pass to
REPORT_DISSECTOR_BUG() strings allocated with ep_strdup_printf(), so
that they're freed automatically.

svn path=/trunk/; revision=16039
2005-09-28 16:16:37 +00:00
Ulf Lamping 57d099a0c2 some things fixed, leftover from code cleanup (thanks to the buggy MSVC dependencies)
svn path=/trunk/; revision=15755
2005-09-11 17:15:00 +00:00
Ulf Lamping 642467ad5c I'm adding the "Expert Info" prototype now, as it seems to be in a state where others might have a look and probably already find it useful :-). Anyway, we can easily disable it at one or two places in the code if it get's in our way of a new release.
Please see: http://wiki.ethereal.com/Development/ExpertInfo for a complete overview of the intended feature and it's current state of implementation.

While I'm working on this, I've also added some more status result codes to the DCE/RPC and DCOM dissectors.

svn path=/trunk/; revision=15754
2005-09-11 16:55:34 +00:00
Ulf Lamping 0dc9fb3d4a various code cleanup:
-use g_snprintf instead of sprintf and snprintf
-use g_strdup_printf where appropriate
-remove #include "snprintf.h" (as only g_snprintf should be used)
-replace some more alloc/realloc/calloc/free with their glib pendants

svn path=/trunk/; revision=15264
2005-08-08 18:50:39 +00:00
Jörg Mayer 5602f5bb83 Make some funtions static. More char -> const char warning fixes
svn path=/trunk/; revision=15146
2005-07-30 01:01:02 +00:00
Jörg Mayer 7949c7f31c char -> const char warning fixes
svn path=/trunk/; revision=15079
2005-07-26 08:01:16 +00:00
Guy Harris 554f620001 Constify to remove a bunch of warnings. Add some casts to squelch
(presumably-)harmless-but-otherwise-unremovable const-to-nonconst
warnings.

In the TACACS dissector, clean up the variables used in option parsing
to avoid some const-to-nonconst warnings.

Clean up some white space.

svn path=/trunk/; revision=15043
2005-07-24 19:01:28 +00:00
Ulf Lamping 46ff66522f prevent "Dissector Bug": prevent a string processing of length 0
svn path=/trunk/; revision=14516
2005-06-01 19:19:40 +00:00
Ulf Lamping e821e8a1f2 fix handling, if ArraySize of a BSTR is 0,
replace a g_assert by DISSECTOR_ASSERT

svn path=/trunk/; revision=14503
2005-05-31 08:02:24 +00:00
Ulf Lamping 772af896b9 add a tvb_ensure_bytes_exist() to prevent a dissector bug
svn path=/trunk/; revision=14502
2005-05-30 22:40:55 +00:00
Ulf Lamping 5fd2ecb1d5 add values for STDOBJREF flags
svn path=/trunk/; revision=14428
2005-05-24 20:00:14 +00:00
Gerald Combs 01270e7e44 Don't call proto_item_set_len() with a negative length. Found during
fuzz testing.

svn path=/trunk/; revision=14242
2005-04-30 16:08:29 +00:00