0c598a950d
Fix Dead Store (Dead nested assignment) Warning found by Clang
...
svn path=/trunk/; revision=36756
2011-04-21 13:33:04 +00:00
ab38454697
Fix Dead Store (Dead nested assignment) Warning found by Clang
...
svn path=/trunk/; revision=36754
2011-04-21 13:32:11 +00:00
4b87a3d770
CID 1161: Not really used variable
...
svn path=/trunk/; revision=36725
2011-04-19 21:20:15 +00:00
8efd127f31
CID 1162: Not really used variable
...
svn path=/trunk/; revision=36724
2011-04-19 21:15:58 +00:00
67900c23be
Fix Unused varaiable warnings.
...
CID 1163 - 1166
svn path=/trunk/; revision=36675
2011-04-17 09:34:38 +00:00
e07cb22a47
Rework whitespace.
...
svn path=/trunk/; revision=36583
2011-04-12 14:33:30 +00:00
c424bd7c83
Don't assign to a proto_item * if the value won't be used: Coverity 1158 & 1159.
...
svn path=/trunk/; revision=36581
2011-04-12 13:27:08 +00:00
e3f4dc17a9
localtime() can return a NULL ptr.
...
svn path=/trunk/; revision=36580
2011-04-12 13:21:32 +00:00
3e44421764
Either remove or use unused values found by Coverity. Fixes CIDs
...
1169-1172.
svn path=/trunk/; revision=36500
2011-04-06 18:59:36 +00:00
735b61500c
Don't dereference a NULL pointer. Fixes CID 426.
...
svn path=/trunk/; revision=36424
2011-03-31 18:00:26 +00:00
645cfe9ef2
Add a missing break.
...
CID 487
svn path=/trunk/; revision=36403
2011-03-29 21:20:36 +00:00
ce248d9ea9
Add a missing break.
...
CID 488
svn path=/trunk/; revision=36402
2011-03-29 21:11:26 +00:00
2b81b097e5
Add a missing break.
...
CID 490
svn path=/trunk/; revision=36401
2011-03-29 21:08:34 +00:00
bc0fbb792a
Added FALLTHRU comment to avoid a "missing break" warning.
...
CID 489
svn path=/trunk/; revision=36400
2011-03-29 21:05:29 +00:00
7356320a2a
Don't assign proto_item pointers that are not used.
...
Coverity 1174
svn path=/trunk/; revision=36395
2011-03-29 14:23:13 +00:00
10928bc0cc
Don't use prohibited strncpy(). Use g_strlcpy() instead. Ensures that "orig"
...
will be NULL-terminated, even if len >= SCS_HUGE_SIZE.
svn path=/trunk/; revision=36383
2011-03-28 17:04:58 +00:00
7c41d527fd
Removed uneeded 'continue'.
...
Fixes Coverity 815 ("UNREACHABLE").
svn path=/trunk/; revision=36367
2011-03-27 14:34:19 +00:00
78c5c20d08
Don't assign to a proto_item* if the value won't be used: Coverity 1155-1156;
...
Also:
- Fix a few cases of SET_HIDDEN on the wrong item. (The SET_HIDDEN was being
done on an already hidden item).
- Minor indentation cleanup;
svn path=/trunk/; revision=36315
2011-03-24 21:19:39 +00:00
b9331456e9
Don't assign to a proto_item* if the value won't be used: Coverity 1151-1154;
...
svn path=/trunk/; revision=36312
2011-03-24 17:37:07 +00:00
24b8d23fb4
Don't assign to a proto_item* if the value isn't to be used: Coverity 1173;
...
Also:
- Fix 2 cases of an item attached to the wrong subtree;
- "localize" & rename some variable definitions;
- Minor indentation cleanup.
svn path=/trunk/; revision=36310
2011-03-24 16:03:12 +00:00
cb56e84556
Removed unused parameter to parseServiceNodeId.
...
Coverity 596.
svn path=/trunk/; revision=36283
2011-03-23 08:03:02 +00:00
888880eb25
Rewrote check for szStr in dissect_ICBAPhysicalDevice_get_LogicalDevice_rqst.
...
Coverity 535.
svn path=/trunk/; revision=36282
2011-03-23 07:34:00 +00:00
875abf1deb
dont assign to a proto_item* unless we are going to use the value
...
coverity 1157
svn path=/trunk/; revision=36276
2011-03-23 05:18:26 +00:00
1f108b02a0
Allocate correct size of range.
...
Coverity 718.
svn path=/trunk/; revision=36262
2011-03-22 18:58:32 +00:00
3621346c20
Fix a typo
...
svn path=/trunk/; revision=36249
2011-03-22 13:49:07 +00:00
7191538bcc
Coverity 1167
...
Dont assign tlv_item unless we need to dereference it.
Also push the variable deeper into the scope where it is used isntead of function wide scope.
svn path=/trunk/; revision=36243
2011-03-22 09:55:33 +00:00
3037db8904
Coverity 1168
...
Create the items for 33_ARS under the subtree we create for this type and not under the parent node in the tree.
svn path=/trunk/; revision=36242
2011-03-22 09:47:34 +00:00
ea9e664fc9
Coverity 420
...
Remove dead code and add a g_assert_not_reached() at a spot we can definitely never reach.
change a if(x)g_free(x) to a g_free(x)
since g_free(NULL) is just a nop.
svn path=/trunk/; revision=36238
2011-03-22 09:05:26 +00:00
a774994572
Added some casts to fix coverity 325.
...
svn path=/trunk/; revision=36228
2011-03-21 18:33:18 +00:00
7dfd6b1e09
From Roland Knall <rknall [AT] gmail.com>: allow heuristic subdissectors
...
for SERCOS III packets.
svn path=/trunk/; revision=36214
2011-03-20 00:47:18 +00:00
a62a37fbbe
From Roland Knall via bug #5726 : Adding a dissector registration, so the
...
dissector may be called by other dissectors.
svn path=/trunk/; revision=36055
2011-02-24 21:47:37 +00:00
c514eaabf9
Try to fix some Clan scan-build warnings.
...
svn path=/trunk/; revision=36003
2011-02-18 19:57:18 +00:00
f749439b71
Remove some of the many dead assignments found by clang
...
svn path=/trunk/; revision=35982
2011-02-17 18:45:45 +00:00
e3ae028064
Rename some hf_... vars so name starts with hf_docsis_cmstatus
...
svn path=/trunk/; revision=35873
2011-02-08 01:15:44 +00:00
7eb1530061
#if 0 code related to unused "docsis" dissector table;
...
Use consistent indentation & other whitespace cleanup.
svn path=/trunk/; revision=35869
2011-02-08 00:24:10 +00:00
3312fc1bfe
From Hendrik Robbel:
...
Dissector for DOCSIS 3.0 CM-STATUS Report Messages.
svn path=/trunk/; revision=35866
2011-02-07 22:19:38 +00:00
3eecbb3248
Just use g_strdup_printf(), rather than doing it ourselves.
...
svn path=/trunk/; revision=35780
2011-02-03 08:31:04 +00:00
d3efa3ed9f
A bit of Windows makefiles rework and cleanup:
...
- Define macros for certain CFLAGS in config.nmake iso of having defs in each makefile;
a. -DHAVE_CONFIG_H and -D_U_="" are now part of a macro named STANDARD_CFLAGS;
b. -WX has been replaced by WARNINGS_ARE_ERRORS (defined as -WX in config.nmake)
(This allows disabling "Warnings as Errors" by just changing config.nmake)
c. CVARSDLL definitions (not usage) have been removed from the various makefiles.
XXX: It appears the usage of CVARSDLL can also be removed (not yet done) since:
-DWIN32 and -DNULL=0 do not appear to be needed (any more);
-D_MT and _D_DLL are not needed since /MP causes these definitions.
d. Define a macro WARNINGS_CFLAGS with additional specific compiler (level4) warnings to be enabled.
E.G., 4295: array is too small to include a terminating null character
- config.nmake: reformat some long lines for readability;
- plugins\Makefile.nmake: clean-deps does nothing: remove it (and usage in top-level makefile);
- dissectors/Makefile.nmake: test to enable packet-rrc.obj target needs to include MSVC2010 ...
svn path=/trunk/; revision=35747
2011-02-02 01:19:53 +00:00
6e079af172
Whitespace cleanup (remove trailing blanks from lines).
...
svn path=/trunk/; revision=35711
2011-01-30 22:57:00 +00:00
17281958a2
Add a comment about some "unreachable code" indicating possible incorrect code someplace.
...
Fix some spelling..
svn path=/trunk/; revision=35710
2011-01-30 22:42:06 +00:00
f53744b59d
There's no need to pass the result of tvb_get_ptr() as the 'value' in
...
proto_tree_add_*(): just use proto_tree_add_item().
Replace some tvb_get_ptr()s with tvb_get_ephemeral_string().
svn path=/trunk/; revision=35603
2011-01-21 03:00:31 +00:00
969b5a240e
Don't stop calling subdissectors when there's no tree.
...
svn path=/trunk/; revision=35591
2011-01-19 22:55:53 +00:00
c5c0a0d943
Use Wireshark standard marking for unused parameters.
...
svn path=/trunk/; revision=35590
2011-01-19 22:53:46 +00:00
7089b9c780
Do Windows compile with /WX flag: treat warnings as errors.
...
svn path=/trunk/; revision=35565
2011-01-16 23:47:05 +00:00
742915eca5
Fix some cut-and-pasteos and other typoes.
...
svn path=/trunk/; revision=35328
2011-01-02 19:39:24 +00:00
a8bc4a0d13
Rename the routines that handle dissector tables with unsigned integer
...
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys. (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)
svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
84aebe5af7
There is no exceptions.h file here, remove it from DISSECTOR_INCLUDES.
...
svn path=/trunk/; revision=35201
2010-12-16 14:39:33 +00:00
a6b55e6530
From Guido Reismueller:
...
packet-mdd.c
- TLV 15 fixed
packet-tlv.c
- Added Support for DOCSIS 3.0 TLVs (38-66)
Added Support for the following DOCSIS 3.0 MAC Management Messages
- DBC-REQ (packet-dbcreq.c)
- DBC-RSP (packet-dbcrsp.c)
- DBC-ACK (packet-dbcack.c)
- CM-CTRL-REQ (packet-cmctrlreq.c)
- CM-CTRL-RSP (packet-cmctrlrsp.c)
- DPV-REQ (packet-dpvreq.c)
- DPV-RSP (packet-dpvrsp.c)
svn path=/trunk/; revision=35193
2010-12-16 07:01:22 +00:00
d9af8b16ba
Added opcua_extensionobjecttable.c from revision 34906.
...
svn path=/trunk/; revision=35177
2010-12-11 21:40:01 +00:00
64a099a652
From Gerhard Gappmeier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5429 :
...
Until now the info column only shows the OPC UA transport protocol type (Hello,
Ack, Secure Conversion message).
After connections establishment has finished this column shows only Secure
Conversion message, because every service is sent over the secure channel.
This patch adds the useful support of displaying the service type in the info
column. This makes it easier to find specific service calls in huge capture
files.
svn path=/trunk/; revision=35119
2010-12-04 02:54:59 +00:00
4f6ea6ef47
From Gerhard Gappmeier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5427 :
...
This patch adds support for dissecting all Extension Objects types defined by
the OPC Foundation.
svn path=/trunk/; revision=35118
2010-12-04 02:54:25 +00:00
a06eef00b8
From Gerhard Gappmeier:
...
Fix mapping of datatype strings in opcua plugin
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5428
svn path=/trunk/; revision=35105
2010-12-02 20:44:18 +00:00
dd43cbec82
From Robert Groenenberg:
...
Assert when using ASN.1 dissector with loading a 'type table'
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5447
svn path=/trunk/; revision=35055
2010-11-28 21:03:43 +00:00
b1914ff4df
Fix for bug 5435:
...
Add support for dissecting SLL type 0x17 frames.
svn path=/trunk/; revision=35029
2010-11-25 19:59:19 +00:00
a25be762f5
Fix properties.
...
svn path=/trunk/; revision=34997
2010-11-21 19:33:46 +00:00
9aeb1dac17
From David Katz via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5166 :
...
Add a configuration parameter of the NWG version for WiMAX ASN CP dissector.
The format and meaning of TLVs, as well as function types and messages changed
between the different NWG versions.
Added support for the version number of TLVs in the dictionary xml, its parser,
and of course in the packet itself.
Added support for the version number of function-types and message-types by
extending the value_string structure to contain also a "since" version number.
Successfully tested with a live capture and capture file, containing WiMAX ASN
packets (full Network entry).
Also fuzzed 500 passes successfully.
The XML doesn't contain all existing NWG versions, only selected ones. This is
a little tedious work to go over all TLVs of each version, so I'll add some
newer versions later on. can add a short how-to of adding a new version, for
others to use, if needed.
svn path=/trunk/; revision=34919
2010-11-17 03:16:30 +00:00
3c7ac06886
From Gerhard Gappmeier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5410 :
...
This patch adds support for displaying OPC UA ExtensionObjects.
An ExtensionObject is a mechanism to transport user defined structures as
serialized blobs. Some types of ExtensionObjects are already defined by the OPC
Foundation's OPC UA Specifications.
These types can be implemented by this dissector, because they are well-known.
Real user-defined or vendor-defined types are unlikely to be implemented by a
passive dissector, because this would require browsing of the UA server's
address space to retrieve the type information.
Currently only the following types are supported:
* DataChangeNotification
* EventNotification
Others OPC defined types will follow.
From me: fix warnings: "format not a string literal and no format arguments"
svn path=/trunk/; revision=34906
2010-11-16 17:00:50 +00:00
b7b98d4315
From Gerhard Gappmeier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5409 :
...
This patch fixes displaying OPCUA Strings and ByteStrings.
From me: fix warnings: "format not a string literal and no format arguments"
svn path=/trunk/; revision=34905
2010-11-16 16:45:22 +00:00
987e35df39
From Gerhard Gappmeier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5406 :
...
I attached a patch which fixes some problems in the array handling of OPC UA
data when the array length is zero or -1 which is a Null-Array.
svn path=/trunk/; revision=34880
2010-11-15 18:52:41 +00:00
1f2f2e918e
Simply use %c for printing char.
...
svn path=/trunk/; revision=34789
2010-11-05 09:59:40 +00:00
75c2052a01
Fixed a printf modifier to remove a warning from clang.
...
svn path=/trunk/; revision=34784
2010-11-05 08:04:24 +00:00
4b1be2be63
Remove some unused hf entries.
...
svn path=/trunk/; revision=34549
2010-10-17 20:57:11 +00:00
333ef8b5b7
Removed unused hf_pn_dcp and hf_pn_ptcp.
...
svn path=/trunk/; revision=34544
2010-10-17 16:49:10 +00:00
763e03b407
Removed unused hf_ecat_mailbox.
...
svn path=/trunk/; revision=34543
2010-10-17 16:43:07 +00:00
7502bd4a8f
From ToddS via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5300 :
...
In the profinet plugin, the decoding of the MRP LinkUp and MRP LinkDown
messages is missing the MRP_SA field which garbles the decode of the rest of
the packet.
This fix adds the decoding of the MRP_SA field to the MRP LinkUp and MRP
LinkDown dissectors.
svn path=/trunk/; revision=34524
2010-10-15 17:17:04 +00:00
2d9d0900c5
From ToddS via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5299 :
...
In profinet plugin, there is a dissection based on whether the read data
returned is expected to contain a single or multiple blocks. Currently, the
I&M0FilterData case assumes only a single block is returned. Profinet specifies
two optional additional blocks.
This change moves I&M0FilterData to expect multiple blocks to correct decode
the optional information.
svn path=/trunk/; revision=34523
2010-10-15 17:10:29 +00:00
5984fb4888
From Yu Zhang:
...
MRP packet is not correctly parsed in PROFINET multiple write record request.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5267
svn path=/trunk/; revision=34358
2010-10-04 06:16:45 +00:00
ac3ac6c476
Plugins are not shared libraries, so:
...
1) don't set thei SOVERSION - run-time-loaded modules don't have
an SOVERSION;
2) build them with link mode MODULE, not SHARED, on all
platforms.
(Fixing 1) also fixes the problem with building them as MODULE on OS X.)
svn path=/trunk/; revision=34243
2010-09-24 20:41:34 +00:00
5025165845
Track offset even when tree==NULL.
...
svn path=/trunk/; revision=34239
2010-09-24 18:46:28 +00:00
9ce0915786
Replace blurbs that match the name (case insensitive) with NULL.
...
svn path=/trunk/; revision=34231
2010-09-24 02:55:52 +00:00
0ff5638f37
Replace blurbs that match the name (case insensitive) with NULL.
...
svn path=/trunk/; revision=34227
2010-09-23 21:46:31 +00:00
de68ad3066
H. Sivank <hsivank@gmail.com>
...
I try to configure Wireshark with cmake on macosx 10.6.
It fails with : set_target_properties called with incorrect number of arguments.
Attached a patch to fix this issue.
svn path=/trunk/; revision=34201
2010-09-23 07:02:33 +00:00
9a1c175692
interlink type is decimal
...
some keyword substitution added
svn path=/trunk/; revision=34178
2010-09-22 07:18:49 +00:00
381664535b
As suggested by Kovarththanan Rajaratnam in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3548 :
...
Clean up hf fields some more: mostly removing leading and trailing spaces from names and blurbs.
svn path=/trunk/; revision=34165
2010-09-21 03:14:49 +00:00
7219ee2a49
Use val_to_str_ext() & friends to access sminmpec_values[];
...
Also: packet-nhrp.c: #include sminmpec.h not req'd;
svn path=/trunk/; revision=34143
2010-09-17 04:51:21 +00:00
d2b84da490
prefs_register_string_preference() overwrites the given value pointer with a copy of the string. Since the string this dissector passes in is mallocated, keep a pointer to it and then free it after the pointer has been overwritten.
...
svn path=/trunk/; revision=33872
2010-08-21 03:44:36 +00:00
e600394937
(Trivial) Use consistent indentation; Whitespace cleanup.
...
svn path=/trunk/; revision=33788
2010-08-12 16:27:16 +00:00
32ea9657c8
Add new expansion.h file left out of the previous commit.
...
svn path=/trunk/; revision=33787
2010-08-12 15:58:01 +00:00
ead0425688
From Don Newton: Added dissection of Expansion Module (KEM,GEM) messages to Unistim plugin.
...
From me: Add expansion.h to list of .h files in Makefile.common;
#include <stdio.h> not required.
svn path=/trunk/; revision=33786
2010-08-12 15:47:31 +00:00
ccf61ec3b2
From Don Newton:
...
Fails to decrement msg_len on 3 different message types which causes the
dissector to attempt to decode an addition or misplaced unistim cmd.
svn path=/trunk/; revision=33643
2010-07-27 06:46:00 +00:00
75ffa6bb71
The only reason to escape "%" in a string is if you are, incorrectly,
...
passing a string directly to a routine that expects a format string.
The correct way to handle that is to pass "%s" as the string.
As long as you're escaping non-printable characters, just let
tvb_format_string() handle that.
For null-terminated strings, get the length of the string with
tvb_strsize(), and then just put the string into the protocol tree as a
regular item.
svn path=/trunk/; revision=33482
2010-07-09 21:27:08 +00:00
bc9f8d0cd7
Add Visual C++ project files to the distribution.
...
svn path=/trunk/; revision=33386
2010-06-30 23:20:03 +00:00
423669df7d
Back out r33088 for now.
...
svn path=/trunk/; revision=33102
2010-06-05 00:29:31 +00:00
d123b9e737
Add a checkapis target.
...
svn path=/trunk/; revision=33092
2010-06-04 19:49:12 +00:00
f6b2458924
From Matt Poduska via bug 1957 (with minor changes):
...
New dissector (plugin) to support decode of the EPCglobal Low-Level Reader
protocol (see llrp.org for more information). This dissector has passed fuzz
testing.
svn path=/trunk/; revision=33088
2010-06-04 18:45:02 +00:00
1b444c55fd
Refer to the endianness arguments as "encoding" rather than
...
"representation" - we already use "representation" to refer to the text
representation of fields.
Change some routines with an endianness argument to make it a
representation argument instead;
svn path=/trunk/; revision=32929
2010-05-24 06:06:17 +00:00
aa6dc5e692
Fixed warning "Field width should have type 'int'".
...
svn path=/trunk/; revision=32909
2010-05-20 14:53:29 +00:00
eb6efdc4a4
Synchronize Makefiles even more.
...
svn path=/trunk/; revision=32808
2010-05-14 16:48:17 +00:00
54082c6ed0
Add Cmake stuff to the source distribution so more people can try it out.
...
svn path=/trunk/; revision=32807
2010-05-14 16:27:03 +00:00
998677339e
Create a new REP_NA value for fields where there are no representations
...
from which to choose; use that for protocol fields in some protocols
(modify the CORBA generator to use it, and manually update the generated
CORBA dissectors accordingly).
svn path=/trunk/; revision=32777
2010-05-13 00:20:40 +00:00
d85cc79af1
Add some information about how/why this dissector is (partially) machine-generated and what that means to Wireshark maintainers.
...
svn path=/trunk/; revision=32577
2010-04-27 13:50:43 +00:00
85885007ef
Make the OpcUa plugin's fields filterable (by giving them abbreviations).
...
(Thank you, sed, for doing the 90% of the work for me.)
Note that two of these files says "do not modify" implying that they are
machine generated but AFAIK we don't have the means to rebuild them.
svn path=/trunk/; revision=32561
2010-04-26 00:15:30 +00:00
17b57d46d3
Simplify Makefile.nmake so that adding a new plugin to Makefile.nmake
...
requires only adding the plugin (directory) name to a list of plugins.
svn path=/trunk/; revision=32516
2010-04-19 14:38:20 +00:00
b09f79f414
Be sure we initialize the p_id in hf's. This fixes
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3010 .
Also finish the implementation of ShowTimes for GOGs so that the variable gets
initialized (preventing another uninitialized variable warning from Valgrind).
svn path=/trunk/; revision=32465
2010-04-14 18:39:00 +00:00
ef2548d093
Fix up MATE's hf display values so MATE will actually run.
...
svn path=/trunk/; revision=32464
2010-04-14 14:20:16 +00:00
e611923124
Get rid of check_col().
...
svn path=/trunk/; revision=32428
2010-04-08 15:51:44 +00:00
a10b76a99b
Get rid of check_col().
...
svn path=/trunk/; revision=32426
2010-04-08 15:21:07 +00:00
5ccee6196a
Remove some uneeded #includes
...
svn path=/trunk/; revision=32419
2010-04-07 18:24:18 +00:00
846eed1d9e
Get rid of check_col
...
svn path=/trunk/; revision=32401
2010-04-06 16:13:09 +00:00
a2241bf7b8
Don't use %s as the format string in val_to_str().
...
svn path=/trunk/; revision=32400
2010-04-06 15:45:11 +00:00
8f21d5c167
Don't use %s as the format string in val_to_str(). This fixes the fuzz failure in bug 4646.
...
svn path=/trunk/; revision=32398
2010-04-06 13:40:06 +00:00
252178ed7e
The third argument to val_to_str() is a format string that gets passed
...
the value that couldn't be mapped to a string - it's an integer and
needs to be printed with an integer format. Fixes bug 4644.
svn path=/trunk/; revision=32396
2010-04-06 02:49:18 +00:00
7cfa27b04b
Get rid of a bunch of check_col().
...
svn path=/trunk/; revision=32388
2010-04-05 20:04:52 +00:00
9c05bc3bc5
Make the test compile.
...
svn path=/trunk/; revision=32359
2010-04-02 06:03:44 +00:00
dc5e066cae
From sangaran:
...
8-bit Bit Flag decoder method needed in wimaxasncp plugin dissecto.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4608
svn path=/trunk/; revision=32356
2010-04-01 20:49:07 +00:00
beb8d29ad6
From Richard Kümmel: Added the bitmasks for port 10 and port 11.
...
From me: As per Richard: Fix definitions of the bitfield for hf_esl_crcerror and
hf_esl_alignerror.
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3677#c10
svn path=/trunk/; revision=32324
2010-03-29 16:52:47 +00:00
96779de920
cmake changes:
...
- Add checking for linker flags
- Install plugins with the name including the Wireshark version.
This will make it easier to find matching plugin versions if
files get just copied over.
svn path=/trunk/; revision=32231
2010-03-18 10:27:17 +00:00
2dc49da00d
Some if (tree) cleanup
...
svn path=/trunk/; revision=32207
2010-03-16 07:53:48 +00:00
4d2163dd3b
Avoid some dead assignments
...
svn path=/trunk/; revision=32206
2010-03-16 07:49:13 +00:00
737d0b5549
Whitespace cleanup
...
svn path=/trunk/; revision=32205
2010-03-16 07:45:12 +00:00
4296471220
Indicate width of parent bitfield
...
svn path=/trunk/; revision=32204
2010-03-16 07:43:17 +00:00
850aba71ac
Inline truth/false table
...
svn path=/trunk/; revision=32203
2010-03-16 07:36:00 +00:00
c4d29dfd99
This adds a new dissector plugin: INTERLINK. This protocol is used in
...
(real and simulated) BMW cars for all kinds of gadget communication.
My plugin only dissects the high level infrastructure and not any particular
messages. It uses a heuristic dissector to detect INTERLINK packets.
svn path=/trunk/; revision=32202
2010-03-16 06:58:25 +00:00
5535f4a598
Fix some compiler warnings, clean up indentation a bit.
...
svn path=/trunk/; revision=32201
2010-03-16 03:31:44 +00:00
67072286bf
- Remove the lib prefix for plugin names.
...
- Remove a (resolved) comment.
- Add a commented out line how to add version infos to the
plugin's file name.
svn path=/trunk/; revision=31995
2010-02-24 22:32:10 +00:00
25dcd066b6
From Hannes Diethelm via bug 4525:
...
Corrected values for IdentInfo (which was obviously wrong)
svn path=/trunk/; revision=31978
2010-02-24 08:22:33 +00:00
c033a08313
Fix some gcc -Wshadow warnings.
...
svn path=/trunk/; revision=31724
2010-01-28 23:53:27 +00:00
bb79476b22
Fix gcc -Wshadow warning;
...
Move proto_register... and proto_reg_handoff... to the end of the file.
svn path=/trunk/; revision=31723
2010-01-28 23:11:54 +00:00
1341fcd87e
Fix some gcc -Wshadow warnings.
...
svn path=/trunk/; revision=31722
2010-01-28 21:49:30 +00:00
2ea1e1962f
Fix gcc -Wshadow warning.
...
svn path=/trunk/; revision=31721
2010-01-28 19:58:48 +00:00
440c3f9261
From Didier Gautheron:
...
check_col.diff
Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394
svn path=/trunk/; revision=31519
2010-01-13 20:32:01 +00:00
c4dd31cd87
From Didier Gautheron:
...
col_clear.diff
Remove calls to col_clear :
- called twice.
- before functions which also clear the column
- by replacing col_clear + col_append_xxx with col_add_xxx
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394
svn path=/trunk/; revision=31517
2010-01-13 20:25:10 +00:00
de767f7dea
Do some cleanup:
...
- Separate .h file not req'd since not used elsewhere;
- Use bitmasks instead of using non-portable bitfields;
- Note possible incorrect display of crcError and alignError flags;
- Clean up spacing.
svn path=/trunk/; revision=31412
2010-01-02 22:00:30 +00:00
8e236e55de
For fields of type FT_ABSOLUTE_TIME, have the "display" value be one of
...
ABSOLUTE_TIME_LOCAL or ABSOLUTE_TIME_UTC, indicating whether to display
the date/time in local time or UTC. (int)ABSOLUTE_TIME_LOCAL ==
(int)BASE_NONE, so there's no source or binary compatiblity issue,
although we might want to eliminate BASE_NONE at some point and have the
BASE_ values used with integral types start at 0, so that you can't
specify BASE_NONE for an integral field.
svn path=/trunk/; revision=31319
2009-12-19 03:17:44 +00:00
9587938020
From Martin Lutz: Patch tvb_memeql return check;
...
... tvb_memeql returns 0 for truth.
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3986#c7
svn path=/trunk/; revision=31294
2009-12-17 16:22:50 +00:00
0bd900a72b
Fix header field names containing dots.
...
Move excessive long texts to header field blurb.
svn path=/trunk/; revision=31207
2009-12-08 22:05:55 +00:00
c840cdd5a0
Remove the address operator from value_string arrays fed to VALS()
...
svn path=/trunk/; revision=30995
2009-11-17 18:35:27 +00:00
d2cc318f4f
Beginnings of enabling static builds. Still to do:
...
* Add -static
* Registration may need different handling
* Add plugins
* Build error in wslua
svn path=/trunk/; revision=30987
2009-11-17 11:58:36 +00:00
9ee31d1d0e
cmake will now honor -Werror if configured (default: on)
...
svn path=/trunk/; revision=30852
2009-11-07 10:07:00 +00:00
06e6441c9e
add "reserved for profiles" comments
...
svn path=/trunk/; revision=30811
2009-11-04 00:07:54 +00:00
03c3b66945
From Benjamin Meyer:
...
UserData in Profinet ProcessAlarm declared as UserStructIdentifier
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4195
svn path=/trunk/; revision=30808
2009-11-03 20:11:19 +00:00
ecbe3c28f3
From Matthias FRANK:
...
PROFIDrive parameter requests not decoded.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4193
svn path=/trunk/; revision=30804
2009-11-03 12:30:59 +00:00
d0a15b4473
From Matthias FRANK:
...
PROFISafe F-Parameter record not decoded in PROFINET dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4192
From me remove check_col();
svn path=/trunk/; revision=30801
2009-11-02 18:09:46 +00:00
9e4549de12
The stats_tree plugin deserves a version number other than "0.0".
...
svn path=/trunk/; revision=30706
2009-10-26 09:29:46 +00:00
762af05327
Don't call PROTO_ITEM_SET_GENERATED(proto_tree_add[...]): that will end up adding the item to the tree multiple times.
...
svn path=/trunk/; revision=30635
2009-10-20 14:03:00 +00:00
a52bf035b7
Removed redundant redeclaration of delete_avpl().
...
svn path=/trunk/; revision=30618
2009-10-19 14:42:10 +00:00
8248955d7d
Renamed tvb_new -> new_tvb to avoid name collision.
...
svn path=/trunk/; revision=30617
2009-10-19 14:36:26 +00:00
ce502fc59b
Added cast to (void *) for pointers used in printf format %p.
...
svn path=/trunk/; revision=30614
2009-10-19 13:24:54 +00:00
d7ca2a6444
Initialize variables which may be used uninitialized.
...
svn path=/trunk/; revision=30535
2009-10-12 14:13:01 +00:00
09393ee57d
Replace GMemChunk usage with se_alloc();
...
Fixes memory leak for GLib > 2.8.
svn path=/trunk/; revision=30526
2009-10-12 01:13:20 +00:00
8b8399b711
Use register_dissector_files in the plugins dissectors
...
svn path=/trunk/; revision=30435
2009-10-09 16:39:34 +00:00
6d93ca7c96
Use register_dissector_files in asn1 plugin
...
svn path=/trunk/; revision=30434
2009-10-09 16:33:16 +00:00
4d2e653901
From Didier Gautheron:
...
Dissectors using call_dissector() function inside a 'if (tree) {}' block.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4107
svn path=/trunk/; revision=30415
2009-10-09 07:24:33 +00:00
c8605cc746
Don't include config.h in header files.
...
svn path=/trunk/; revision=30382
2009-10-07 06:28:36 +00:00
cf85342eec
Build plugins with cmake on OSX.
...
svn path=/trunk/; revision=30373
2009-10-06 18:58:09 +00:00
b95ab896f7
From Benjamin Meyer:
...
Profinet PDIRFrameData field FrameDetails not decoded
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4091
svn path=/trunk/; revision=30321
2009-10-04 19:34:48 +00:00
7bff8c664b
From Benjamin Meyer:
...
PROFINET DCP ResetFactorySettings not decoded.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4090
svn path=/trunk/; revision=30320
2009-10-04 19:31:02 +00:00
0721ade9ed
Remove check_col()
...
svn path=/trunk/; revision=30317
2009-10-04 18:40:44 +00:00
80f0d3116a
Use G_N_ELEMENTS instead of hard coding size of array
...
svn path=/trunk/; revision=30315
2009-10-04 18:29:51 +00:00
09932ce535
Constify wimax_mac_calc_crc8()
...
svn path=/trunk/; revision=30314
2009-10-04 18:26:01 +00:00
0c860d2cd5
Constify wimax_mac_calc_crc16()
...
svn path=/trunk/; revision=30313
2009-10-04 18:22:36 +00:00
70d977764c
Constify wimax_mac_calc_crc32()
...
svn path=/trunk/; revision=30309
2009-10-04 17:21:45 +00:00
c33111a841
Remove forward references
...
svn path=/trunk/; revision=30308
2009-10-04 17:12:42 +00:00
86ca4a24b6
Move prototype to wimax_utils.h
...
svn path=/trunk/; revision=30307
2009-10-04 17:03:57 +00:00
0bc65a23d0
Include wimax_utils.h
...
svn path=/trunk/; revision=30306
2009-10-04 16:57:04 +00:00
0b17f67061
Until we either supply "yapp" or put "yapp" into the list of tools you
...
need to install, don't include in Wireshark anything that requires "yapp".
svn path=/trunk/; revision=30154
2009-09-25 20:05:16 +00:00
cbc3d3f772
Try to add tpg, but it seems it doesn't build with autofoo either.
...
svn path=/trunk/; revision=30151
2009-09-25 18:09:42 +00:00
72ea6d56d2
Forgot to commit the unistim cmakefile
...
svn path=/trunk/; revision=30145
2009-09-25 15:29:15 +00:00
6a2f689235
Fix build of make and asn1 plugins.
...
svn path=/trunk/; revision=30144
2009-09-25 15:17:45 +00:00
00810ff199
* Prefer col_append_str instead of col_append_fstr for constant strings
...
* Remove check_col guards
svn path=/trunk/; revision=30127
2009-09-24 20:21:23 +00:00
65c53fedb6
Don't guard col_append_str with check_col
...
svn path=/trunk/; revision=30125
2009-09-24 20:00:21 +00:00
cf8138e195
Remove check_col() guard
...
svn path=/trunk/; revision=30124
2009-09-24 19:50:43 +00:00
9ac672ca81
Update *.vcproj to visual studio 8
...
svn path=/trunk/; revision=30111
2009-09-24 05:11:47 +00:00
124faf721c
Use col_set_str instead of col_add_fstr/col_add_str when adding constant strings to COL_INFO
...
svn path=/trunk/; revision=30089
2009-09-23 14:52:01 +00:00
633bb05380
Use col_set_str instead of col_add_fstri/col_add_str when adding constant strings to COL_PROTOCOL
...
svn path=/trunk/; revision=30088
2009-09-23 14:43:23 +00:00
99624329fa
Don't col_clear() followed by col_set_str(). A col_set_str() will clear (replace) any existing string (the fence still needs to be respected though)
...
svn path=/trunk/; revision=30086
2009-09-23 14:30:36 +00:00
ebfcf3c387
Build more plugins with cmake.
...
svn path=/trunk/; revision=30084
2009-09-23 04:41:14 +00:00
c28bafe341
Use col_set_str instead of col_add_fstr when adding constant strings to COL_INFO
...
svn path=/trunk/; revision=30082
2009-09-22 21:18:11 +00:00
95182116aa
CMake:
...
- Add opcua to the list of plugins to build
- Link the gtk stuff statically into wireshark
- Beginnings of "make install"
- Change a few things about install paths
svn path=/trunk/; revision=30029
2009-09-21 00:19:07 +00:00
9441e9b344
Use tvb_get_ephemeral_stringz() instead of tvb_get_stringz()
...
svn path=/trunk/; revision=30002
2009-09-20 08:40:01 +00:00
5a2247f5a3
Build a few more plugins
...
svn path=/trunk/; revision=29942
2009-09-16 06:30:03 +00:00
ed8483ae98
Save some memory: Don't statically allocate ett[] arrays used "dynamically".
...
svn path=/trunk/; revision=29934
2009-09-15 18:20:56 +00:00
24fb135ffe
Build the asn1 plugin. The only problem(?) is, that it is
...
name libasn1.so instead of asn1.so
svn path=/trunk/; revision=29919
2009-09-15 12:22:13 +00:00
4661aad9a4
Run checkapi on the dissector header files
...
svn path=/trunk/; revision=29883
2009-09-13 19:48:22 +00:00
2547ce21bf
We no longer support the old plugin API so remove it completely from the build system
...
svn path=/trunk/; revision=29821
2009-09-09 14:01:57 +00:00
ffd3a72374
Check our array lengths and refuse to process them if they're too large.
...
Fixes bug 3986. Use tvb_memeql and proto_tree_add_item instead of
digging around in tvb->real_data.
svn path=/trunk/; revision=29813
2009-09-09 00:18:15 +00:00
8c48c6835f
Rename address_to_str() to ep_address_to_str() because:
...
1) This indicates that the string has ephemeral lifetime
2) More consistent with its existing seasonal counterpart, se_address_to_str().
svn path=/trunk/; revision=29747
2009-09-06 14:25:47 +00:00
94f28dd8f9
(FWIW) One step towards including stdio.h & stdlib.h only when req'd.
...
svn path=/trunk/; revision=29568
2009-08-26 19:27:49 +00:00
ee9ef9f5cb
Remove unneeded #includes.
...
svn path=/trunk/; revision=29496
2009-08-21 18:56:15 +00:00
bf580bfa14
Remove unneeded #includes.
...
svn path=/trunk/; revision=29495
2009-08-21 18:54:28 +00:00
6f87844d0a
(Minor) Remove unneeded #includes.
...
svn path=/trunk/; revision=29492
2009-08-21 14:36:27 +00:00
27f7d88c84
Also fake empty field_info's by gracefully handling NULL field_info pointer elsewhere.
...
svn path=/trunk/; revision=29490
2009-08-21 11:03:30 +00:00
929a92a454
From Geoffrey Kimball:
...
DOCSIS 3.0 includes a new Bonded Initial Ranging Request (B-INIT-RNG-REQ) MAC
Management type (34). A simple dissector is needed to decode this message.
svn path=/trunk/; revision=29487
2009-08-20 19:41:53 +00:00
8b515e9340
Switch a bunch of dissectors over to using tvb_new_subset_remaining()
...
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
197d30a3b8
Use HFILL instead of hard coding the values
...
svn path=/trunk/; revision=29431
2009-08-15 11:21:36 +00:00
2dfa5ccebe
From Artem Tamazov via. 3899:
...
Remove superfluous /MP
svn path=/trunk/; revision=29410
2009-08-14 10:17:13 +00:00
083729e02c
Add PTREE_FINFO and use PITEM_FINFO when possible.
...
svn path=/trunk/; revision=29355
2009-08-09 17:57:31 +00:00
d3174f0d03
(Trivial): Remove uneeded #includes; make a few fcns static;
...
svn path=/trunk/; revision=29353
2009-08-09 16:48:28 +00:00
0a60e46adf
'if(proto_... == -1)' not req'd; Don't register ett[] more than once;
...
svn path=/trunk/; revision=29351
2009-08-09 15:07:35 +00:00
ac463d2697
Don't guard col_clear with col_check
...
svn path=/trunk/; revision=29346
2009-08-09 08:14:59 +00:00
6110a96f68
Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check
...
svn path=/trunk/; revision=29345
2009-08-09 07:59:51 +00:00
0a5b014cec
Don't guard col_clear with col_check
...
svn path=/trunk/; revision=29344
2009-08-09 07:36:13 +00:00
4b6090e576
Don't guard col_set_str (COL_INFO) with col_check
...
svn path=/trunk/; revision=29342
2009-08-09 07:01:26 +00:00
24ca3c44c9
Don't guard col_set_str (COL_PROTOCOL) with col_check
...
svn path=/trunk/; revision=29341
2009-08-09 06:47:24 +00:00
e971354a54
Don't guard col_set_str (COL_PROTOCOL) with col_check
...
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
53a24d94f9
Check TLV lengths before we try to add them to the tree. Fixes bug 3824.
...
svn path=/trunk/; revision=29338
2009-08-08 22:20:08 +00:00
3d1e81ff3d
Fix typo.
...
svn path=/trunk/; revision=29300
2009-08-05 00:13:38 +00:00
6847b0b94d
Put the initializers for the elements of value_string arrays into curly
...
brackets, so the API checks for non-terminated value_string arrays will
not falsely think the arrays are non-terminated.
svn path=/trunk/; revision=29299
2009-08-04 23:14:40 +00:00
8589c2f11b
Minor changes:
...
- Move proto_register...() to the end of the file as per convention;
- Move ett[] to be local to proto_register...();
- "if (...==-1)" not req'd in proto_register...();
- #include <moduleinfo.h> not req'd;
- Remove unneeded forward declarations.
svn path=/trunk/; revision=29296
2009-08-04 19:01:34 +00:00
9bc8469d96
Remove a couple of unused variables.
...
svn path=/trunk/; revision=29286
2009-08-03 23:50:55 +00:00
Alexis La Goutte