Stig Bjørlykke
47be3577a7
Introduce "Ignore Packet" in the packet list.
...
This will remove the package from the dissection functions without
removing it from the capture file.
svn path=/trunk/; revision=31287
2009-12-17 01:18:14 +00:00
Jaap Keuter
81b585cf8e
From Valerio Messina:
...
As now, when Wireshark save capture files, it show "Loading" in status bar and
in the dialog box, warning many users of lost them packets. Saving work as expected.
Is simply a GUI use interaction problem.
svn path=/trunk/; revision=31269
2009-12-14 22:05:29 +00:00
Anders Broman
cafad87fd9
From Stig:
...
Invalidate cfile.current_row instead(revert 30910).
svn path=/trunk/; revision=30925
2009-11-10 20:16:14 +00:00
Gerald Combs
5e34f21076
Add the ability to push temporary (and highlighted) messages onto the
...
statusbar. This lets us notify the user about something significant
without having to pop up an annoying window. Replace a few dialogs with
statusbar messages.
svn path=/trunk/; revision=30810
2009-11-04 00:02:52 +00:00
Stig Bjørlykke
1fc92dee03
Fixed 'Delta timestamp to previous captured frame' calculation in
...
old packet list. This bug was introduced in r30052.
svn path=/trunk/; revision=30758
2009-10-29 13:27:05 +00:00
Stig Bjørlykke
2f199b9d96
Made some functions static.
...
svn path=/trunk/; revision=30616
2009-10-19 14:21:11 +00:00
Stig Bjørlykke
e162470d6b
Prime interesting fields when selecting a package, so Lua's ProtoField
...
can extract the field value correctly.
This fixes bug 4058.
svn path=/trunk/; revision=30252
2009-10-02 19:55:43 +00:00
Anders Broman
ffcaf32074
Select the first packet when doing a live capture. In the old packet list this is automatically done as the clist emits a selct-row signal.
...
Seting focus in new_packet_list_moveto_end() seems also to be needed to make it work properly I'm not 100% sure if it should be done differently.
svn path=/trunk/; revision=30074
2009-09-22 18:51:33 +00:00
Kovarththanan Rajaratnam
07cb929d6b
dfilter_free() can handle a NULL pointer so don't guard against that before calling it
...
svn path=/trunk/; revision=30072
2009-09-22 16:49:26 +00:00
Kovarththanan Rajaratnam
9398b679e8
Introduce cap_file_add_fdata() and start using it
...
svn path=/trunk/; revision=30071
2009-09-22 16:39:48 +00:00
Kovarththanan Rajaratnam
627a7c1f47
Switch Wireshark GUI (file.c) over to using frame_data.c
...
svn path=/trunk/; revision=30067
2009-09-22 14:41:30 +00:00
Kovarththanan Rajaratnam
054ef7aa0f
Make sure that the old packet list works with the changes introduced in r30047
...
svn path=/trunk/; revision=30060
2009-09-22 05:23:45 +00:00
Kovarththanan Rajaratnam
1989aa700d
Bring frame_data_init() and add_packet_to_packet_list() more in sync by adding 'ref_time' handling to frame_data_init(). For tshark/rawshark this is unused because they only do a single pass through the capture file
...
svn path=/trunk/; revision=30055
2009-09-21 20:17:59 +00:00
Kovarththanan Rajaratnam
aa4af67e1b
Only set cumulative bytes after passing the display filter test
...
svn path=/trunk/; revision=30053
2009-09-21 19:48:53 +00:00
Kovarththanan Rajaratnam
c3647b4e3b
Move 'Delta timestamp to previous captured frame' calculation inside add_packet_to_packet_list(). This is done in order to streamline add_packet_to_packet_list() with frame_data_init(). Hopefully we can switch to frame_data_init() soon
...
svn path=/trunk/; revision=30052
2009-09-21 19:30:06 +00:00
Kovarththanan Rajaratnam
7ca137e294
Rename capture_file.plist to capture_file.plist_start to make it consistent with capture_file.plist_end
...
svn path=/trunk/; revision=30047
2009-09-21 18:09:19 +00:00
Kovarththanan Rajaratnam
109875c775
Remove second (redundant) assignment to fdata->cum_bytes
...
svn path=/trunk/; revision=30046
2009-09-21 17:38:10 +00:00
Kovarththanan Rajaratnam
9831d4c4e1
Reverse order of NEW_PACKET_LIST guard, i.e. #ifdef NEW_PACKET_LIST instead of #ifndef NEW_PACKET_LIST
...
svn path=/trunk/; revision=30045
2009-09-21 17:32:35 +00:00
Stephen Fisher
d923139789
Fix typo in comment
...
svn path=/trunk/; revision=30043
2009-09-21 17:09:15 +00:00
Kovarththanan Rajaratnam
3c9afabfe0
(cosmetic change) - reset cumulative bytes together with 'first_ts' and 'prev_dis_ts'
...
svn path=/trunk/; revision=30042
2009-09-21 15:50:15 +00:00
Kovarththanan Rajaratnam
8527133db0
cf->dfilter is only set if it's valid so assert if that's not the case
...
svn path=/trunk/; revision=30041
2009-09-21 15:38:40 +00:00
Kovarththanan Rajaratnam
112a677484
Reset cumulative bytes when we open the file
...
svn path=/trunk/; revision=30040
2009-09-21 15:29:32 +00:00
Kovarththanan Rajaratnam
8dc906da00
Set fdata->num up front and roll back if necessary
...
svn path=/trunk/; revision=30039
2009-09-21 15:23:33 +00:00
Kovarththanan Rajaratnam
03a9cfe84c
Shuffle NEW_PACKET_LIST guard
...
svn path=/trunk/; revision=30038
2009-09-21 14:13:46 +00:00
Kovarththanan Rajaratnam
d86635a3d8
Introduce a NEW_PACKET_LIST specialized version of add_packet_to_packet_list(). The old one contained too many #ifdef NEW_PACKET_LIST which reduced readability
...
svn path=/trunk/; revision=30036
2009-09-21 12:14:11 +00:00
Anders Broman
546014cdaf
cf_change_time_formats() is not needed with new packet list.
...
svn path=/trunk/; revision=30034
2009-09-21 11:58:36 +00:00
Kovarththanan Rajaratnam
3b7a12dda0
Add NEW_PACKET_LIST guard wrt fdata->col_text
...
svn path=/trunk/; revision=30030
2009-09-21 04:29:25 +00:00
Kovarththanan Rajaratnam
2e282e7567
Introduce frame_data_cleanup() and start using it
...
svn path=/trunk/; revision=30023
2009-09-20 18:18:29 +00:00
Kovarththanan Rajaratnam
ad7f82f9ce
From Jakub Zawadzki:
...
Fix copy/paste error wrt. fdata->col_text_len
svn path=/trunk/; revision=29921
2009-09-15 14:01:40 +00:00
Anders Broman
b0c3abfa79
Fix:
...
cleanup_dissection() calls se_free_all(); And after that fdata->col_text (which is allocated using se_alloc0()) no longer points to valid memory.
svn path=/trunk/; revision=29920
2009-09-15 13:18:13 +00:00
Stephen Fisher
5dfeb86fb7
Fix warning that variable may be unused and then declare volatile so it
...
survives the TRY/CATCH code.
svn path=/trunk/; revision=29863
2009-09-11 15:38:33 +00:00
Anders Broman
6edeb87ad7
Only move to last row if it's vissible.
...
svn path=/trunk/; revision=29861
2009-09-11 14:58:49 +00:00
Anders Broman
0772dd06b4
New_packet_list
...
Select the correct frame in packet details when filtering.
svn path=/trunk/; revision=29857
2009-09-11 11:58:00 +00:00
Anders Broman
a65f72e8f0
Allocate col_text and col_text_len when the fdata struct is allocated.
...
(complete the checkin).
svn path=/trunk/; revision=29818
2009-09-09 08:51:33 +00:00
Kovarththanan Rajaratnam
de23d92163
Add an option to col_fill_in() to allow us to disable column expression processing. This is rarely needed. It's only needed when the user right clicks on the packet list view to generate a display filter.
...
svn path=/trunk/; revision=29806
2009-09-08 19:00:54 +00:00
Kovarththanan Rajaratnam
c6f96e4ec9
Make sure that reset the elapsed time to load a file before we reload/rescan the file
...
svn path=/trunk/; revision=29783
2009-09-07 21:07:51 +00:00
Kovarththanan Rajaratnam
8d909ba79e
Rename new_packet_list_set_time_width() -> new_packet_list_resize_column() because it contains no time format specific code. Further this change also ensures that new_packet_list_resize_columns() uses the newly introduced new_packet_list_resize_column()
...
svn path=/trunk/; revision=29782
2009-09-07 20:45:32 +00:00
Kovarththanan Rajaratnam
a65d590002
Store the packet encapsulation type as gint8. Saves 3 bytes per packet
...
svn path=/trunk/; revision=29767
2009-09-07 13:54:46 +00:00
Stig Bjørlykke
e55129063b
Fixed arguments to new_packet_list_set_time_width().
...
svn path=/trunk/; revision=29761
2009-09-07 12:01:19 +00:00
Anders Broman
5cc8d3e71d
col_fmt not needed.
...
svn path=/trunk/; revision=29760
2009-09-07 11:50:08 +00:00
Kovarththanan Rajaratnam
cd8831c72d
Track length of columns strings. We'll need this in order to resize columns quickly
...
svn path=/trunk/; revision=29759
2009-09-07 11:33:38 +00:00
Anders Broman
7473e1e04c
Automatically adjust the time column width when time format changes.
...
svn path=/trunk/; revision=29758
2009-09-07 10:03:55 +00:00
Kovarththanan Rajaratnam
0e5cef61be
Split a bunch of init routines into init() and cleanup(). This allows us to free memory properly on shutdown.
...
This is an initial step. There's still some work to do.
svn path=/trunk/; revision=29754
2009-09-06 18:25:23 +00:00
Kovarththanan Rajaratnam
95ddec4d07
Get rid off GtkTreeModelFilter because the time to sort becomes unbearable when combined with GtkTreeSortable. This means that we now track which frames are visible in the our own packet list store. To do so, we now distinguish between physical and visible rows. All frames are added as physical rows. Only those that passes the display filter are marked as visible.
...
svn path=/trunk/; revision=29705
2009-09-05 10:36:29 +00:00
Kovarththanan Rajaratnam
6be0e11906
Remove superfluous assignment
...
svn path=/trunk/; revision=29686
2009-09-03 14:41:09 +00:00
Kovarththanan Rajaratnam
bd69669e1d
Make sure that we stop auto scroll if we start scrolling manually.
...
Caveat: we jump to first frame when auto scroll is stopped
svn path=/trunk/; revision=29685
2009-09-03 14:32:11 +00:00
Kovarththanan Rajaratnam
47b766a998
Only try and select the last row if not already selected. This fix doesn't seem to work. Any suggestions?
...
svn path=/trunk/; revision=29677
2009-09-02 19:31:56 +00:00
Kovarththanan Rajaratnam
bc36849a9e
Add seperate new_packet_list_moveto_end() which scrolls to the end _without_ selecting the last packet.
...
svn path=/trunk/; revision=29670
2009-09-02 17:29:52 +00:00
Kovarththanan Rajaratnam
6149d4be35
Make sure that we select the last row if autoscroll is enabled. The scrolling is still very jumpy. It seems that we always select the first packet before moving to the end.
...
svn path=/trunk/; revision=29668
2009-09-02 17:15:20 +00:00
Martin Mathieson
e256fed975
Add volatile to avoid clobbered by longjmp warning.
...
svn path=/trunk/; revision=29651
2009-09-01 11:15:24 +00:00