2c269c2864
Fix a set of obscure bugs found by checkhf.
...
svn path=/trunk/; revision=47666
2013-02-15 01:31:27 +00:00
9ad02809f2
Put in a comment explaining what the signal strength value probably
...
means here.
svn path=/trunk/; revision=47665
2013-02-15 00:43:04 +00:00
39a742107e
Put in a comment explaining what the signal strength value means here.
...
svn path=/trunk/; revision=47664
2013-02-15 00:34:05 +00:00
58a2320b89
Show the signal strength as a percentage in the RSSI column, as that's
...
what it is.
svn path=/trunk/; revision=47663
2013-02-14 22:38:50 +00:00
b8179ab57b
Show the signal strength as dBm, as that's what it is in the PPI header.
...
svn path=/trunk/; revision=47662
2013-02-14 22:38:12 +00:00
bf4e129f5f
Get rid of unused string to squelch warning.
...
svn path=/trunk/; revision=47661
2013-02-14 22:27:04 +00:00
f244067727
From Chris Bontje via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8333 :
...
Corrections to Recent DNP3 Control Code Changes in Bug ID 7865
svn path=/trunk/; revision=47660
2013-02-14 21:57:30 +00:00
19eb91cb27
Fix potential buffer overflow in RTPS and RTPS2 dissectors by allocating enough memory to fit the "indentation space".
...
Bug 8332 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8332 )
svn path=/trunk/; revision=47658
2013-02-14 19:42:58 +00:00
cb679f279b
If the requested wmem allocator is NULL, take that to mean manually-managed
...
memory. This permits using manually-scoped versions of certain wmem structures.
svn path=/trunk/; revision=47657
2013-02-14 16:23:22 +00:00
5071e8b627
Add an option for bypassing the wmem slab similar to the one for
...
bypassing the emem slab, to aid in debugging with valgrind.
svn path=/trunk/; revision=47656
2013-02-14 16:07:25 +00:00
c3c6ebe6c0
From Michael Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8304 : Fix potential inconsistency with interfaces introduced with r47651.
...
svn path=/trunk/; revision=47655
2013-02-14 15:29:25 +00:00
203e7e0301
Factorize FGI dissection
...
svn path=/trunk/; revision=47654
2013-02-14 10:09:46 +00:00
1019582c47
Move version field outside of the switch, since it exists for all subtypes.
...
This fixes the TSPEC case, which didn't include it before.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8330
svn path=/trunk/; revision=47653
2013-02-14 03:35:35 +00:00
ad92b749e8
Fix crash with SDP setup mechanism, bug 8323 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8323 )
...
The issue was that hash tables were being accessed after they were freed from a "rejected answer".
The code was also too generous in considering many SIP status codes as "rejected answers", so now less SIP status codes are treated as "rejected answers" and are ignored by the transport API.
svn path=/trunk/; revision=47652
2013-02-14 03:30:32 +00:00
7410bf54a1
Fix Coverity CID 981007: Dereference before null check. Bug introduced with r47632.
...
svn path=/trunk/; revision=47651
2013-02-13 16:39:31 +00:00
5e2c5c7cbd
Fix Coverity CID's 981004-981006: Out-of-bounds read. Bugs introduced with r47632. (Backport does not apply.)
...
svn path=/trunk/; revision=47650
2013-02-13 16:01:42 +00:00
d2dcf56c94
From Sascha Herrmann:
...
Patch registering ieee802154 dissector to Linux SLL frames.
svn path=/trunk/; revision=47649
2013-02-13 07:16:14 +00:00
222a190373
Fix Coverity 980630, negative array index read.
...
svn path=/trunk/; revision=47648
2013-02-13 01:49:06 +00:00
3a37624a7b
Cleanup:
...
- Fix various message handler message dissection bugs;
- Change all loops with a potentially large loop count
to be done only when 'tree' is non-null;
- Simplify code somewhat;
- Do some whitespace and formatting style changes.
svn path=/trunk/; revision=47647
2013-02-13 00:46:15 +00:00
d4dbbe0965
From Chaitanya via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8320
...
Fix typo in case value that led to misdissection of TSPEC IEs.
svn path=/trunk/; revision=47646
2013-02-13 00:01:38 +00:00
1c0ef12021
Fix typos in display filters caught by checkfiltername.pl
...
svn path=/trunk/; revision=47645
2013-02-12 21:26:47 +00:00
486c6d5445
Fix the grammar.h/grammar.c/grammar.lemon dependency so that
...
grammar.h is not always out of date. Use the same pattern as in the
Makefile.nmake files
svn path=/trunk/; revision=47643
2013-02-12 17:25:28 +00:00
a99e6fe842
From Jim Young via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8318
...
Support for processing UTF-16 surrogate pairs in JSON packets.
svn path=/trunk/; revision=47642
2013-02-12 16:20:24 +00:00
090d5e7eda
From metatech via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8322
...
MQSeries V7 protocol support.
svn path=/trunk/; revision=47641
2013-02-12 16:13:25 +00:00
fe266892a7
Even when adding a value with proto_tree_add_uint() the mask is applied to the value which may not be the optimal behavioure.
...
Remove the mask to get the correct value displayed.
svn path=/trunk/; revision=47640
2013-02-12 16:12:03 +00:00
c45252a75f
SDP in 183 session progress is also SDP_EXCHANGE_ANSWER_ACCEPT.
...
Without this patch I get a crash on Linux and lots of
STATUS_ACCESS_VIOLATION and a single STATUS_INTEGER_DIVIDE_BY_ZERO on windows.
svn path=/trunk/; revision=47639
2013-02-12 14:58:02 +00:00
ed5045605a
SDP in 180 ringing is also SDP_EXCHANGE_ANSWER_ACCEPT.
...
Without this patch I get a crash on Linux and lots of
STATUS_ACCESS_VIOLATION and a single STATUS_INTEGER_DIVIDE_BY_ZERO on windows.
svn path=/trunk/; revision=47638
2013-02-12 14:27:06 +00:00
a3ef2a7293
Fix bit_offset.
...
svn path=/trunk/; revision=47637
2013-02-11 17:39:52 +00:00
755ccf4162
{..., NULL} is required as the last XXX_string array entry: value_string q763_generic_notification_indicator_vals[]
...
svn path=/trunk/; revision=47635
2013-02-11 15:56:02 +00:00
76557a21f9
From: Michal Labedzki:
...
[PATCH 5/6] Bluetooth: BNEP: Remove unneeded code and do some style
changes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8304
svn path=/trunk/; revision=47634
2013-02-11 15:23:51 +00:00
4056b11883
From: Michal Labedzki:
...
Subject: [PATCH 3/6] Bluetooth: Add modeline to hci_usb
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8304
svn path=/trunk/; revision=47633
2013-02-11 15:18:26 +00:00
4dc754f454
From: Michal Labedzki:
...
Bluetooth: Improve support of MAP, PBAP, BPP and BIP in OBEX
Add support for recognize profiles using OBEX (by "Target"), then add
all Application Parameters specific for MAP, PBAP, BPP, BIP.
Also fix one FIXME, so now dissecting by OBEX does not cause malformed
frames while jumping over dissected packets.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8304
svn path=/trunk/; revision=47632
2013-02-11 15:04:53 +00:00
07d2692cad
Fixes/Updates:
...
- Call conversation_set_dissector();
- Fix encoding args related to use of FT_ABSOLUTE_TIME;
- Remove unneeded #include;
- Cleanup some whitespace.
svn path=/trunk/; revision=47631
2013-02-11 14:59:03 +00:00
8f96a14263
Dissection of Q.763 ISUP Generic Notification.
...
based on bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8311
svn path=/trunk/; revision=47630
2013-02-11 14:50:50 +00:00
8fd4797a08
Add an if (tree) check to prevent a very-long-but-not-infinite loop,
...
since without a tree the proto_tree_add_item calls won't throw an exception
when we run past the end of our TVB which means we could end up doing MAX_INT64
iterations.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8312
svn path=/trunk/; revision=47629
2013-02-11 13:23:05 +00:00
2f156d0edc
From Cal Turney via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8309
...
Restore an else clause that appears to have been accidentally removed in r44542
which was causing TCP reassembly for SMB2 messages to fail.
svn path=/trunk/; revision=47620
2013-02-10 22:28:15 +00:00
ebacca89a7
Add %option noinput to a bunch of Flex files, as we aren't using the
...
input() routine and thus don't need to have it generated - and as it
produces warnings of a routine defined but not used, we don't want to
have it generated.
Squelch a casting-const-away warning.
svn path=/trunk/; revision=47613
2013-02-10 19:13:07 +00:00
3f70cb4406
Add an "Unregistered hf!" hint to DISSECTOR_ASSERT((guint)hfindex < gpa_hfinfo.len).
...
svn path=/trunk/; revision=47611
2013-02-10 18:38:46 +00:00
ffa42bbdd8
Add svn properties and modelines.
...
svn path=/trunk/; revision=47608
2013-02-10 16:52:52 +00:00
27cf61e0a9
Add Bitcoin dissector
...
From Christian Svensson, bug 6000 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6000 )
Cleaned up from the original patch
svn path=/trunk/; revision=47606
2013-02-10 16:23:11 +00:00
6da5bbbe9e
[Automatic manuf, services and enterprise-numbers update for 2013-02-10]
...
svn path=/trunk/; revision=47602
2013-02-10 15:03:25 +00:00
4da35cc956
Add support for IGNORE message type to SSH2 dissector + some minor cleanup
...
I was hoping this would fix bug 5064 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5064 ), but all it did was fix the malformed part of the dissector.
svn path=/trunk/; revision=47601
2013-02-10 02:27:08 +00:00
c225aafb8c
Pull in a comment from the MATE plugin Makefile.nmake.
...
Pull in a change from that Makefile.nmake to keep us from trying to hand
a header file to the compiler as if it were a C source file.
svn path=/trunk/; revision=47600
2013-02-09 23:41:43 +00:00
a13d58a509
Put NODIST_ at the beginning of macro names, as was done for the plugins
...
directory.
svn path=/trunk/; revision=47599
2013-02-09 23:35:30 +00:00
47d20bf9be
From Lori Tribble via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8306
...
Fix decoding the Loop Object Setpoint-Reference property in BACapp packets.
svn path=/trunk/; revision=47577
2013-02-09 01:32:19 +00:00
efa7e8f2b6
Fix bug 8056: Maximum value of Duration should be 32767.
...
Duration/ID field dissected according to Table 8-3 of 8.2.4.2 of the IEEE std. 802.11-2012: http://www.techstreet.com/cgi-bin/pdf/free/1071374/802.11-2012.pdf
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8056
#BACKPORT(1.8, 1.6)
svn path=/trunk/; revision=47575
2013-02-08 19:25:59 +00:00
d21f62b73b
Add a directory name preference type (PREF_DIRNAME) and registration
...
routine (prefs_register_directory_preference). Add PREF_FILENAME and
PREF_DIRNAME support to the Qt module preferences. Change a couple of
preferences to directory names.
Clean up some names and default settings.
svn path=/trunk/; revision=47573
2013-02-08 18:07:34 +00:00
c752593698
Handle SIP "resends" within SDP. This is to handle "duplicate" OFFERs so they don't end up being handled by setup_sdp_transport() because the current frame couldn't match a request (due to duplication).
...
setup_sdp_transport_resend() should be unnecessary once all higher layers use setup_sdp_transport() and the "registration" code within dissect_sdp() is removed.
svn path=/trunk/; revision=47572
2013-02-08 17:52:12 +00:00
8c8533e0dd
Use the new realloc API when growing a string-buffer.
...
svn path=/trunk/; revision=47571
2013-02-08 17:09:18 +00:00
d6af95490a
Fix error: no newline at end of file
...
svn path=/trunk/; revision=47570
2013-02-08 16:45:15 +00:00
24065ce625
Change string to filename preference so file can be browsed for
...
svn path=/trunk/; revision=47566
2013-02-08 14:43:11 +00:00
fc48d80b32
Use glib's isdigit function.
...
svn path=/trunk/; revision=47565
2013-02-08 14:03:33 +00:00
faf307e2fc
Support SDP context over SIP.
...
Added setup_sdp_transport() to allow higher layer protocols to call SDP with context to correctly setup an OFFER/ANSWER within SDP (which doesn't have its own transport layer). I attempted to keep backwards compatibility until all higher layer protocols set up OFFER/ANSWER context. If OFFER/ANSWER (request/response) can't be found (which would be the case for higher layer protocols without context), Wireshark should resort to the old behavior of applying SDP information as it sees packets.
This patch includes integration with SIP as it appears to have the most bug reports. Other higher layer protocols will be done later. Most are mentioned in bug 2368.
Fixes bug 2368 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2368 ) and all its duplicates
Fixes bug 2992 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2992 ) and all its duplicates
svn path=/trunk/; revision=47564
2013-02-08 13:47:07 +00:00
e92f2f398d
Constify the name member of a struct _proto_xmlpi_attr, to squelch
...
warnings.
svn path=/trunk/; revision=47561
2013-02-08 09:09:29 +00:00
922a57753b
Constify the second argument to uat_load(), to squelch some warnings.
...
svn path=/trunk/; revision=47560
2013-02-08 09:06:08 +00:00
1df459c415
Constify the return value of append_to_buffer(), to squelch some
...
warnings.
svn path=/trunk/; revision=47559
2013-02-08 09:00:03 +00:00
2cbfc5db98
Constify the return value of replace_entity(), to squelch some warnings.
...
svn path=/trunk/; revision=47558
2013-02-08 08:56:55 +00:00
fad8b88242
Capitalize the short name.
...
svn path=/trunk/; revision=47555
2013-02-08 03:17:13 +00:00
e1bfc1c61c
Fix issue where using realloc() to shrink a chunk could result in
...
multiple adjacent free chunks. When splitting a used chunk, the resulting
extra unused chunk may need to be merged to its right.
svn path=/trunk/; revision=47552
2013-02-08 02:40:05 +00:00
ebc2067e30
Add explicit casts to pacify MSVC buildbot.
...
svn path=/trunk/; revision=47551
2013-02-08 02:15:03 +00:00
9fcb518818
Make use of the new garbage-collection routines when closing a file.
...
svn path=/trunk/; revision=47550
2013-02-08 01:58:04 +00:00
b636b88646
Expose the new wmem API functions, and use a consistent order of
...
alloc/free/realloc across all of wmem.
svn path=/trunk/; revision=47548
2013-02-08 01:47:48 +00:00
eea6cb6315
Rewrite the block allocator to support the new wmem API (realloc, free, gc).
...
Some interesting algorithmic stuff going on in here for those who are
interested.
This completes the allocator rewrites for the API additions, so those can be
exposed now.
svn path=/trunk/; revision=47547
2013-02-08 01:38:03 +00:00
24d67b60ab
Add a ModulePreferencesScrollArea widget which builds a scrollable frame
...
for a preferences module. Use it to fill in the remaining preferences.
Don't show the printing preferences since they're not used here.
Change the titles and tooltips for some of the name resolution
preferences.
Disable the capture preferences if we can't capture. This is different
from the GTK+ version which hides it completely.
Thus concludes the preferences dialog (for the time being).
svn path=/trunk/; revision=47545
2013-02-08 01:16:46 +00:00
900d29a95e
Use proto_registrar_get_id_byname() instead of proto_registrar_get_byname();
...
The code is slightly cleaner and the use of proto_registrar_get_id_byname()
enables an additional checkhf test to reduce false positives.
Also: comment out 2 unused hf_... vars in packet-smb-sidsnooping.c
(found by checkhf)
svn path=/trunk/; revision=47541
2013-02-07 22:07:49 +00:00
cfff564398
Add 'proto_registrar_get_id_byname()' accessor.
...
svn path=/trunk/; revision=47540
2013-02-07 22:04:02 +00:00
8bb6b5fe05
Add proto_tree_set_visible. Also, sort.
...
(Ref: http://www.wireshark.org/lists/wireshark-dev/201302/msg00048.html )
Q. Should the addition of proto_tree_set_visible be backported to 1.8?
svn path=/trunk/; revision=47535
2013-02-07 19:12:10 +00:00
138b732b80
C++-ize filter_expressions.h.
...
svn path=/trunk/; revision=47525
2013-02-06 19:12:14 +00:00
fe8b2c63e3
Fix missing hf field array entries:
...
- In two cases, add missing entries to hf[];
- Other cases: 'if 0' the packages referring to
the missing entries.
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4842
ERROR: NO ARRAY: packet-h248_annex_e.c:
Fixed:
hf_h248_pkg_ct
hf_h248_pkg_nt
Packages 'if 0'd out:
hf_h248_pkg_dd
hf_h248_pkg_root
svn path=/trunk/; revision=47524
2013-02-06 19:04:24 +00:00
1c0deb0fc8
Add Filter Expressions^WButton^WShortcut^WBookmark preferences.
...
Add comments noting that
- We might want to do something different when the bookmark button is
pressed.
- The display filters (dfilters file) and gui.filter_expressions
preferences should be merged.
- Many buttons on Qt4 + OS X + unifiedTitleAndToolBarOnMac makes the
main window really wide.
Add a qstring_strdup convenience routine. Add "disabled" display filter
edit icons. Fix up whitespace and descriptions in a couple of places.
svn path=/trunk/; revision=47522
2013-02-06 18:22:54 +00:00
ae527cbf10
Update a comment.
...
svn path=/trunk/; revision=47521
2013-02-06 15:01:40 +00:00
e32e0114e6
From Stefan Allers via
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8282
Extended Negotiation support for the DICOM dissector.
svn path=/trunk/; revision=47520
2013-02-06 13:33:31 +00:00
6bcbacf99a
From Tyson Key:
...
Support for dissection of MiFare command payloads in PN532 InDataExchange packets.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8291
svn path=/trunk/; revision=47518
2013-02-06 13:23:54 +00:00
1d4f9590a1
Rename 'hf_h248_package_3GUP' to 'proto_h248_package_3GUP'
...
in keeping with the usual convention for naming the
variable used to store the return value from
proto_register_protocol().
(Fixes checkhf false positive).
svn path=/trunk/; revision=47505
2013-02-05 21:55:31 +00:00
febbfac792
Comment out code which will never be executed in its current state.
...
svn path=/trunk/; revision=47503
2013-02-05 21:30:37 +00:00
37146b8bfd
remove some unnecessary if(tree) checks
...
svn path=/trunk/; revision=47501
2013-02-05 20:47:04 +00:00
8e56438611
Remove an unneeded set of parens in a macro definition;
...
Fixes checkhf false positive (when scanning the
preprocessed dissector source file).
svn path=/trunk/; revision=47500
2013-02-05 20:43:56 +00:00
974afe6319
a DVB-CI session number is not globally unique, it's only unique per
...
transport connection, so it's not a good choice for a circuit id
use (session number|transport connection id) as circuit id
svn path=/trunk/; revision=47499
2013-02-05 20:38:15 +00:00
fe29434e82
Export dissect_japan_isup_additonal_user_cat()
...
svn path=/trunk/; revision=47497
2013-02-05 15:12:54 +00:00
e5556e29ce
Export TBCD-STRING.
...
svn path=/trunk/; revision=47496
2013-02-05 15:12:13 +00:00
affae2fe22
Add missing hf[] entries found by checkhf.
...
ERROR: NO ARRAY: packet-fmp_notify.c, hf_fmp_extentList_len
ERROR: NO ARRAY: packet-fmp_notify.c, hf_fmp_extent_state
ERROR: NO ARRAY: packet-fmp_notify.c, hf_fmp_numBlks
ERROR: NO ARRAY: packet-fmp_notify.c, hf_fmp_startOffset
ERROR: NO ARRAY: packet-fmp_notify.c, hf_fmp_volID
svn path=/trunk/; revision=47494
2013-02-05 15:04:22 +00:00
a5b230b1d8
Add missing hf[] entries found by checkhf.
...
ERROR: NO ARRAY: packet-9p.c, hf_9P_dm_exec_group
ERROR: NO ARRAY: packet-9p.c, hf_9P_dm_read_group
ERROR: NO ARRAY: packet-9p.c, hf_9P_dm_write_group
svn path=/trunk/; revision=47493
2013-02-05 14:51:59 +00:00
e9376dcf4c
Include generated C files that we're *not* distributing.
...
svn path=/trunk/; revision=47489
2013-02-05 09:06:39 +00:00
d4f5a36ae7
dtd_parse.obj depends on dtd_grammar.h, but you can't build
...
dtd_parse.obj by handing dtd_parse.c *and* dtd_grammar.h to the C
compiler - dtd_grammar.h gets included by dtd_parse.c.
svn path=/trunk/; revision=47488
2013-02-05 08:57:58 +00:00
ace7556d5f
dtd_parse.c includes dtd_grammar.h; make sure we build dtd_grammar.h
...
before trying to compile dtd_parse.c
svn path=/trunk/; revision=47487
2013-02-05 08:42:27 +00:00
b793e9069b
Fix for previous changes.
...
svn path=/trunk/; revision=47486
2013-02-05 07:50:57 +00:00
9eba2ea90a
Don't distribute the results of running Lemon, as we distribute Lemon
...
ourselves.
Clean up various bits of "distribute" vs. "don't distribute" stuff in
the process - use similar names, and make the "distribute vs. don't
distribute" distinction the same as the "don't clean with "make
distclean" vs. clean with "make distclean"" distinction.
svn path=/trunk/; revision=47485
2013-02-05 06:09:17 +00:00
e93a96f7dd
Misc:
...
- Add col_clear(..., COL_INFO);
- Use val_to_str() (not val_to_str_consr()) with "format" arg;
- Indentation/whitespace;
- Add svn:keywords & svn:eol-style properties.
svn path=/trunk/; revision=47482
2013-02-05 02:25:24 +00:00
72db5eed02
Unwrap lines inadvertenly wrapped in r47472
...
svn path=/trunk/; revision=47473
2013-02-04 18:27:05 +00:00
5130da6935
More silent build support.
...
svn path=/trunk/; revision=47472
2013-02-04 17:49:54 +00:00
17679a8733
From me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8296 Add RPKI-RTR Dissector (RFC6810)
...
Support all PDU Type (IPv4/6 Prefix, Serial Notify/Query...)
Not supported the packet with a lot of PDU (fragmentation)
svn path=/trunk/; revision=47470
2013-02-04 17:24:27 +00:00
c0ca6220ef
Prettify more build output.
...
svn path=/trunk/; revision=47469
2013-02-04 17:22:32 +00:00
f21a7c9824
'#if 0' out an unused hf[] entry;
...
Do some minor cleanup.
svn path=/trunk/; revision=47464
2013-02-04 14:58:04 +00:00
97c0fe56cd
Comment out two more case of an unused hf[] entry.
...
svn path=/trunk/; revision=47463
2013-02-04 14:43:37 +00:00
45e801913e
Add a FALLTHROUGH comment to fix Coverity CID 745673: Missing break in switch.
...
(No need to backport.)
svn path=/trunk/; revision=47462
2013-02-04 02:50:26 +00:00
97af002693
Fix Coverity CID 746734: Dead default in switch. (No need to backport)
...
svn path=/trunk/; revision=47461
2013-02-04 02:44:04 +00:00
6549fbbad7
#if 0 unused hf[] entries & etc.
...
Note: All (or almost all) unused hf[] entries
in non-generated Wireshark dissectors
have been #if 0'd (or commented) out.
(This applies only to 'static hf_...' vars).
A number of (non-generated) dissector
files with *missing* hf[] entries
still need to be fixed.
svn path=/trunk/; revision=47459
2013-02-03 22:29:48 +00:00
b85efceddc
fix dead increment
...
http://www.wireshark.org/download/automated/analysis/scan-build-2013-02-02-1/report-JzzXua.html#EndPath
svn path=/trunk/; revision=47456
2013-02-03 20:09:46 +00:00
822d9de7cd
[Automatic manuf, services and enterprise-numbers update for 2013-02-03]
...
svn path=/trunk/; revision=47450
2013-02-03 15:03:20 +00:00
c895033e4a
Comment out unused hf[] entry.
...
svn path=/trunk/; revision=47449
2013-02-02 18:25:38 +00:00
8dbe825b77
Restore hf[] entry commented out by mistake in SVN #47389 .
...
svn path=/trunk/; revision=47448
2013-02-02 17:40:52 +00:00
8ef31f222e
Hack: disguise '/*' in text strings to prevent checkAPIs & etc seeing 'start of comment' within a text string.
...
svn path=/trunk/; revision=47446
2013-02-02 14:20:15 +00:00
3ff81e9332
Fix error: declaration of 'j' shadows a previous local
...
svn path=/trunk/; revision=47445
2013-02-02 13:31:46 +00:00
eac8585dc9
Increase the maximum number of OPTIONAL / DEFAULT components per SEQUENCE to 128 and make it configurable through a define
...
svn path=/trunk/; revision=47444
2013-02-02 13:13:19 +00:00
f78791d7d2
Revert changes committed by error in r47433
...
svn path=/trunk/; revision=47442
2013-02-02 09:02:11 +00:00
7187abf120
Add $(AM_V_GEN) in a few more places.
...
svn path=/trunk/; revision=47434
2013-02-01 22:57:41 +00:00
f26b250595
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8290 :
...
Allow up to 64 OPTIONAL / DEFAULT components per SEQUENCE
svn path=/trunk/; revision=47433
2013-02-01 22:44:14 +00:00
8984a38512
Enable more build silence.
...
svn path=/trunk/; revision=47432
2013-02-01 22:13:43 +00:00
c97b7912fa
Go far enough down a rabbit hole and you will encounter libtool. See
...
if changing .o to .lo works.
svn path=/trunk/; revision=47430
2013-02-01 20:16:31 +00:00
34df2dbe54
Change some "<x>.c : <y>.h" rules to "<x>.o : <y>.h" in order to fix
...
distcheck. Add some rules recommended by the Automake manual in order
to avoid duplicate actions.
svn path=/trunk/; revision=47429
2013-02-01 18:20:17 +00:00
cfa53be211
From Gaurav Patwardhan, RFC 6720 - Generalized TTL Security Mechanism (GTSM) for the Label Distribution Protocol (LDP)
...
Bug 7856 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7856 )
svn path=/trunk/; revision=47428
2013-02-01 18:13:50 +00:00
f70b7bb15b
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=47427
2013-02-01 16:37:04 +00:00
8524df12c3
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=47426
2013-02-01 16:36:55 +00:00
1951eff160
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=47425
2013-02-01 16:36:46 +00:00
c6ff7f75ea
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=47424
2013-02-01 16:36:37 +00:00
a3e901f508
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=47423
2013-02-01 16:36:29 +00:00
d5557b458e
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=47422
2013-02-01 16:36:15 +00:00
a71824a38b
Replace THROW(ReportedBoundsError) with expert infos
...
Follow up to rev 47408
svn path=/trunk/; revision=47421
2013-02-01 16:32:15 +00:00
eee4f31ab6
Evan Huus pointed out a duplicate block of code, so delete it. Also, move the other block before the "next_tvb=..." statement. Other changes:
...
-> Delete some unused header fields found with checkhf.pl
-> Fix a couple of typos.
-> Minor whitespace changes.
-> Add a TODO about replacing strstr with either g_strrstr or g_str_has_suffix
svn path=/trunk/; revision=47420
2013-02-01 16:23:16 +00:00
158574f1d6
follow/clean up to rev 47389. The causes of some of the unused hf_ was typos and refactoring. hf_cip_reserved16 was a "placeholder", so it can remain commented out.
...
svn path=/trunk/; revision=47419
2013-02-01 16:16:05 +00:00
981c598367
From Hendrik Uhlmann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8289 :
...
Negative integer values are displayed positive in hmi: -1 = 65535
(Change the variable to signed and add some casts to avoid this problem.)
svn path=/trunk/; revision=47418
2013-02-01 14:36:13 +00:00
2d776c5c29
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=47417
2013-02-01 09:22:57 +00:00
7ef4c2f29c
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=47416
2013-02-01 09:22:49 +00:00
03e97ee7d3
* Fix indent (Tab => 2 Spaces) and add Modelines info
...
svn path=/trunk/; revision=47414
2013-02-01 09:22:31 +00:00
db66187a16
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
Add also a missing break;
svn path=/trunk/; revision=47413
2013-02-01 09:22:22 +00:00
794daaa882
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=47412
2013-02-01 09:22:07 +00:00
da2a2f39bd
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=47411
2013-02-01 09:21:57 +00:00
5bff584648
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=47410
2013-02-01 09:21:48 +00:00
be111f2192
Fix the fuzz failure reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8284 :
...
Throw an exception if we don't find the guint8 we're looking for. (This could
also be done as expert infos; throwing an exception is a bit brute force but
anyway the -1 return case has to be dealth with.)
Maybe there should be a version of tvb_find_guint8() which throws an
exception...
svn path=/trunk/; revision=47408
2013-02-01 03:55:49 +00:00
21b1b0c5da
Add heuristic MTP3 standard detection to M3UA (not for the draft M3UA versions).
...
The SCCP heuristics actually don't work all that well here but checking the PCs
(in M3UA) seems to do a decent job at least of differentiating ANSI from ITU.
svn path=/trunk/; revision=47407
2013-02-01 02:42:01 +00:00
5754564be8
Fix format string error.
...
svn path=/trunk/; revision=47406
2013-02-01 02:19:17 +00:00
73d339a5a4
Add Port Control Protocol dissector and convert NAT-PMP dissector to "new" style.
...
The Port Control Protocol overtakes the NAT-PMP IANA UDP ports, but is backwards compatible enough to trigger off of the version number (NAT-PMP is version 0). NAT-PMP can still use Decode As.
Left the two dissectors with their own unique display filters despite a few overlapping fields. Didn't want it to turn into a BOOTP/DHCP situation.
svn path=/trunk/; revision=47405
2013-02-01 01:29:58 +00:00
7fb4d231c3
Eliminate a bunch of basically useless/duplicate hf's for affected PCs: they
...
all have the same name and abbreviation so there's not much point in having
multiple variables for them. (Arguably the ansi_apc and chinese_apc variables
should be merged too but we may as well preserve the user interface: they have
different abbreviations.)
(Prompted by Bill's discovery of a cut-n-paste problem which rendered a couple
of these hf's unused.)
svn path=/trunk/; revision=47402
2013-01-31 22:43:04 +00:00
baa9dd683f
Fix dissection of SI6 when carried in a SACCH Info Modify message
...
Issue reported by damker: http://www.wireshark.org/lists/wireshark-users/201301/msg00067.html
svn path=/trunk/; revision=47401
2013-01-31 22:34:12 +00:00
e169262c57
Remove some trailing whitespace from 3 field labels (aka names)
...
which was used to align the display of a few field values.
It certainly is desirable to align value fields;
However, the current convention is to not pad field labels
(which is enforced by checkAPIs).
As Evan Huus notes:
"If we want fields to align (which would be nice, I admit) it should be
done in some dissector-agnostic way."
Also: do a little whitespace cleanup.
svn path=/trunk/; revision=47400
2013-01-31 22:32:07 +00:00
414b0c09e6
col...() and expert...() fcns should not be under 'if (tree0'.
...
svn path=/trunk/; revision=47398
2013-01-31 22:12:13 +00:00
3d143dc3ff
gerald@ethereal.com -> gerald@wireshark.org
...
svn path=/trunk/; revision=47397
2013-01-31 21:02:23 +00:00
aa297f4ed3
replaced TABs+spaces mixture with spaces
...
added editor modelines
removed one more if(tree)
other minor reformatting
svn path=/trunk/; revision=47396
2013-01-31 20:58:48 +00:00
a50877b1e5
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
http://www.wireshark.org/download/automated/analysis/scan-build-2013-01-31-1/report-vSXKx6.html#EndPath
use NULL instead of 0 for pointers
remove some unnecessary if (tree) checks
svn path=/trunk/; revision=47395
2013-01-31 20:51:15 +00:00
98c1748e12
Add SIB type to info column
...
svn path=/trunk/; revision=47394
2013-01-31 20:08:38 +00:00
d1f6e2e3ec
Use a not-quite-black background for marked packets.
...
http://ianstormtaylor.com/design-tip-never-use-black/
svn path=/trunk/; revision=47392
2013-01-31 18:46:40 +00:00
959ae3d687
Use '#if 0 ... #endif' rather than /** ... **/ to comment out
...
unused hf[] entries (which I should have done in the first place).
svn path=/trunk/; revision=47391
2013-01-31 18:35:06 +00:00
d3a7f4b817
Use '#if 0 ... #endif' rather than /** ... **/ to comment out
...
unused hf[] entries (which I should have done in the first place).
svn path=/trunk/; revision=47390
2013-01-31 18:31:28 +00:00
c439b805e2
Comment out unused hf[] entries & etc.
...
(found by checkhf)
svn path=/trunk/; revision=47389
2013-01-31 17:55:31 +00:00
eb5fcc8d01
Fix Coverity CID 971261: Unused pointer value. Additionally, #if 0 two unused value_string's (should they be deleted altogether?), minor whitespace cleanup, delete a continuation character, try to use a consistent bracketing style throughout. [Is "Movment" a typo?]
...
svn path=/trunk/; revision=47387
2013-01-31 17:07:19 +00:00
4a8f124c43
Add an OID translation.
...
svn path=/trunk/; revision=47386
2013-01-31 16:59:39 +00:00
a4902853a5
Constify a variable to which C string pointers will be assigned.
...
svn path=/trunk/; revision=47385
2013-01-31 06:50:24 +00:00
094e30f9db
Fix RCS ID.
...
svn path=/trunk/; revision=47384
2013-01-31 06:49:34 +00:00
7999b06d76
Get rid of CR's, and set the appropriate properties.
...
svn path=/trunk/; revision=47383
2013-01-31 06:49:05 +00:00
9ee8360e4a
Add Parrot AR Drone dissector.
...
Bug 7493 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7493 )
svn path=/trunk/; revision=47382
2013-01-31 03:52:06 +00:00
9b23449384
Clean up white space.
...
svn path=/trunk/; revision=47379
2013-01-30 22:56:05 +00:00
e9479b543f
A "DAAP request" is just an HTTP request of a certain type, possibly on
...
port 3689. They don't have the media type application/x-dmap-tagged, so
they're not handed to us any more. (This means that the Info column now
shows the HTTP URI rather than just "DAAP Request", so that's arguably a
feature; if you want to see all the traffic in the session, use "Follow
TCP Stream" or look for port 3689.)
svn path=/trunk/; revision=47377
2013-01-30 21:56:54 +00:00
a4714f643a
Add a routine to allow dissectors to specify ports that carry HTTP
...
traffic *without* claiming all that traffic for themselves; they might
want, instead, to register for a particular media type.
Not all traffic to or from port 3689 is DAAP - not even traffic between
two Apple machines doing media stuff (e.g., some FairPlay traffic
isn't). Register for the media type application/x-dmap-tagged, and just
say port 3689 is HTTP. This means we can get rid of the FPLY hack, as
that traffic is application/octet-stream. Update some comments.
Leave it up to the DAAP dissector to tag traffic as DAAP in the protocol
column.
svn path=/trunk/; revision=47376
2013-01-30 21:49:33 +00:00
b1e6d2730e
Some FairPlay stuff in DAAP starts out with a 4-character FPLY tag, but
...
what follows the tag isn't a length, it's some unknown form of data.
svn path=/trunk/; revision=47370
2013-01-30 20:08:50 +00:00
f0d670afb3
Fix a couple of dependencies.
...
svn path=/trunk/; revision=47369
2013-01-30 19:58:12 +00:00
d6901da1d1
Wiretap: Add support for files contain GIF, PNG images
...
From Michal Labedzki, bug 8278 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8278 )
svn path=/trunk/; revision=47368
2013-01-30 19:26:05 +00:00
942ac68bdc
Add a cast to hopefully quiet the mac buildbot.
...
svn path=/trunk/; revision=47367
2013-01-30 01:14:13 +00:00
b8a74f33b6
Add SVN properties, modelines.
...
svn path=/trunk/; revision=47366
2013-01-30 01:09:31 +00:00
e5ba6f9b1e
Add Gearman dissector. Bug 4992 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4992 )
...
svn path=/trunk/; revision=47365
2013-01-30 00:59:27 +00:00
b48fb53c7e
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
http://www.wireshark.org/download/automated/analysis/scan-build-2013-01-28-1/report-AQojcV.html#EndPath
svn path=/trunk/; revision=47363
2013-01-29 23:35:30 +00:00
a32b153890
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
http://www.wireshark.org/download/automated/analysis/scan-build-2013-01-28-1/report-eehjto.html#EndPath
svn path=/trunk/; revision=47362
2013-01-29 22:33:37 +00:00
4a64d51119
simplify dissect_gds() a bit
...
svn path=/trunk/; revision=47360
2013-01-29 22:15:06 +00:00
b3f2e26a7a
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
http://www.wireshark.org/download/automated/analysis/scan-build-2013-01-28-1/report-tWikJH.html#EndPath
svn path=/trunk/; revision=47359
2013-01-29 22:04:32 +00:00
5d026123c4
Make eDonkey dissector a "new style" and only dissect if first byte matches a valid eDonkey protocol. This addresses the problem of Bug 3033 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3033 ), but I'm still not sure eDonkey should have explicitly registered TCP and UDP ports.
...
svn path=/trunk/; revision=47349
2013-01-29 18:16:23 +00:00
23168c9677
Get Server Info should not have any data unless "challenged", per eMule source code. Addresses bug 3509 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3509 ).
...
Also updated documentation links.
svn path=/trunk/; revision=47345
2013-01-29 15:43:33 +00:00
c268f2c153
Add missing '&hf_gtpv2_bss_con_xid' entry to hf[].
...
(Found by checkhf)
Fix apparent issues with two hf[] entries.
Also: Do minor whitespace cleanup.
##Baclport 1.8
svn path=/trunk/; revision=47344
2013-01-29 14:31:21 +00:00
39886c79cb
Add missing '&hf_fw1_trailer' hf[] entry;
...
Found by checkhf.
## Backport 1.8
svn path=/trunk/; revision=47343
2013-01-29 14:18:04 +00:00
ef242060b8
Add an XXX comment about some code which will never be executed;
...
Also: mention that there's a missing hf[] entry.
svn path=/trunk/; revision=47342
2013-01-29 13:59:17 +00:00
3520ab3889
Add missing 'hf_scsi_persresv_control_unreg' hf[] entry.
...
(Found by checkhf)
Do some minor whitespace cleanup.
svn path=/trunk/; revision=47341
2013-01-29 13:53:16 +00:00
f10906369a
Remove some unneeded parens in hf[] entries;
...
svn path=/trunk/; revision=47340
2013-01-29 13:33:04 +00:00
ec880b7db3
Use readlink instead of ls.
...
svn path=/trunk/; revision=47338
2013-01-29 01:06:24 +00:00
c6f9d4c131
make dumpabi target build with multiple digits in library version numbers
...
svn path=/trunk/; revision=47329
2013-01-28 21:45:44 +00:00
8ad4ccb850
Allow SNMP user table entry to be re-editted even if engineID/Username remains the same.
...
Bug 2426 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2426 )
svn path=/trunk/; revision=47328
2013-01-28 21:08:14 +00:00
29f02b2bb2
Update the MSRP link, it's an actual RFC now.
...
svn path=/trunk/; revision=47323
2013-01-28 13:27:28 +00:00
335b2bdc96
From Gyanesh:
...
Add SPBV MAC address sub-TLV support (802.1aq).
svn path=/trunk/; revision=47321
2013-01-28 06:46:21 +00:00
fd85b72d51
the fragment id must depend on the transport connection
...
fragments from different transport connections can be interleaved
svn path=/trunk/; revision=47320
2013-01-27 22:08:29 +00:00
f857265011
Fix some dead increment warnings found by Clang
...
svn path=/trunk/; revision=47319
2013-01-27 18:58:52 +00:00
2e05d7256c
Fix typo error
...
svn path=/trunk/; revision=47318
2013-01-27 18:57:08 +00:00
5eb312b04b
From Hadar Shoham via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8262
...
Bootp updates, fixes and additional options.
svn path=/trunk/; revision=47317
2013-01-27 16:07:02 +00:00
b76078d210
Bugfix crash caused by AirPDcap decryption. Bug 8177 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8177 )
...
svn path=/trunk/; revision=47314
2013-01-27 15:28:55 +00:00
10d1f1cd8b
[Automatic manuf, services and enterprise-numbers update for 2013-01-27]
...
svn path=/trunk/; revision=47313
2013-01-27 15:03:25 +00:00
c929e42eb4
Fix various instances of unused hf[] entries found
...
by checkhf.
svn path=/trunk/; revision=47312
2013-01-26 22:43:34 +00:00
38dbf79f14
Fix for CID 718640:
...
Make sure the AVPs length are right before we go into hash calculation.
svn path=/trunk/; revision=47311
2013-01-26 22:36:54 +00:00
329f6e8cc0
Initialize some hf_... vars to -1;
...
(Reduces the number of checkhf false positives)
svn path=/trunk/; revision=47310
2013-01-26 21:42:36 +00:00
50efee619e
Make airpcap's print_debug_line take const arguments so that it compiles
...
on newer GCC's when _DEBUG is #defined.
Found while investigating
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8177
svn path=/trunk/; revision=47309
2013-01-26 21:21:25 +00:00
6fe0b4cf12
Init several hf... vars to -1.
...
(found by checkhf)
svn path=/trunk/; revision=47308
2013-01-26 20:41:55 +00:00
1cb988eb4c
Add two missing hf[] entries (which should have been part of SVN #42819 ).
...
(Found by checkhf)
##Backport 1.8
svn path=/trunk/; revision=47304
2013-01-26 19:59:41 +00:00
0c2e7dbe06
Use "4 space" indentation.
...
svn path=/trunk/; revision=47303
2013-01-26 19:09:15 +00:00
0960e508e4
Comment out cases of unused hf array entries found by checkhf.
...
svn path=/trunk/; revision=47302
2013-01-26 18:54:53 +00:00
33df8647d5
Reformat hf array entries slightly (to help checkdf)
...
svn path=/trunk/; revision=47301
2013-01-26 16:31:24 +00:00
fbf1970b06
Always call sub-dissectors with the top-level tree.
...
svn path=/trunk/; revision=47299
2013-01-26 15:41:35 +00:00
a18bdb19df
From Tyson Key via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8246
...
Support for dissection of FeliCa payloads in PN532 InCommunicateThru packets.
svn path=/trunk/; revision=47297
2013-01-26 15:38:12 +00:00
8444e23988
USB-CCID header is always 10 bytes and may contain payloads, so setting
...
it to run to the end of the packet was confusing and/or wrong.
svn path=/trunk/; revision=47296
2013-01-26 15:34:48 +00:00
c3651f0409
dcp-etsi dissector: new formula for rx_min
...
Bug 8231 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8231 )
svn path=/trunk/; revision=47295
2013-01-26 15:07:25 +00:00
0f5ea5487f
Whitespace cleanup.
...
svn path=/trunk/; revision=47286
2013-01-25 22:04:59 +00:00
e55b8a1d38
From Florian Fainelli via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8259
...
Improve the dissection of the "Get Software Version" confirmation frame as well
as the "Read configuration Block" confirmation frame by properly dissecting the
fields previously marked as reserved in the Homeplug-AV dissector.
svn path=/trunk/; revision=47285
2013-01-25 21:54:18 +00:00
520230116f
Clean up:
...
- Remove hf & ett decls not used externally from .h
- For hf & ett vars not used externally:
remove from .c if not used internally otherwise
declare as static.
svn path=/trunk/; revision=47284
2013-01-25 21:48:38 +00:00
df466c5940
Remove duplicate include file
...
svn path=/trunk/; revision=47275
2013-01-25 18:37:00 +00:00
fd659d2b4a
Fix dissection of ETWS/CMAS messages
...
svn path=/trunk/; revision=47274
2013-01-25 18:33:07 +00:00
eaf731ccad
Remove non ASCII character
...
svn path=/trunk/; revision=47273
2013-01-25 16:50:05 +00:00
ce6025b059
Dissect Broadcast-Message-Content correctly.
...
svn path=/trunk/; revision=47272
2013-01-25 15:29:19 +00:00
738dae7c3d
From Florian Fainelli via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8258 :
...
HomePlugAV dissector: improve device ID decoding
svn path=/trunk/; revision=47271
2013-01-25 14:10:09 +00:00
750c5a8401
Fix dissection of path ["/" session-id] is optional.
...
svn path=/trunk/; revision=47270
2013-01-25 09:08:24 +00:00
4b3d76d426
Add new query types, options and message types for DHCPv6 Bulk Leasequery protocol. Also enforce message rules in RFC 5460 section 4 through expert_info
...
Part of bug 8172 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8172 )
svn path=/trunk/; revision=47267
2013-01-25 03:40:53 +00:00
471dde4a21
Use pinfo-scoped memory for mtp3 addresses.
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8247
svn path=/trunk/; revision=47266
2013-01-25 00:28:48 +00:00
d334115b4d
From Florian Fainelli via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8166
...
properly dissect the 0x6048 and 0x6038 frames with HomePlug AV 1.1
svn path=/trunk/; revision=47265
2013-01-25 00:18:10 +00:00
10dd94fa0b
Add support for HFI and infiniband interfaces in AIX iptrace files.
...
svn path=/trunk/; revision=47258
2013-01-24 18:08:25 +00:00
9037ec60ed
From Florian Fainelli via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8166
...
Fixes for decoding HPAV-1.1 Network Info Request/Confirmation
From me: minor whitespace cleanup.
svn path=/trunk/; revision=47257
2013-01-24 16:23:15 +00:00
5d3ff466da
Fix H.460.9 numbers of parameters
...
svn path=/trunk/; revision=47256
2013-01-24 11:54:18 +00:00
40efff2019
Fix warning: cast to pointer from integer of different size
...
While we are at it, restore the private data if no private extension dissector is not found (seems to be the right thing to do)
svn path=/trunk/; revision=47255
2013-01-24 10:36:51 +00:00
1bf78b2ba6
Add missing newline at end of file
...
svn path=/trunk/; revision=47254
2013-01-24 10:14:37 +00:00
d19cde439e
Fix H.460.x calling from H.225 - content decoding
...
svn path=/trunk/; revision=47253
2013-01-24 10:11:02 +00:00
e2d3294617
From Katrina Zhang sligtly modified.
...
- Add dissection of Selected PLMN ID.
- Put enterpice id in the tree
- Filter for UTRAN Transparent Field.
svn path=/trunk/; revision=47252
2013-01-24 09:59:06 +00:00
7140161402
From Katrina Zhang sligtly modified.
...
- Correct dissection of 8.50 Selected PLMN ID.
- Pass Instance to private extension dissectors.
svn path=/trunk/; revision=47251
2013-01-24 09:56:28 +00:00
5bd9f6aa9d
Add sGSNPLMNIDChange
...
svn path=/trunk/; revision=47250
2013-01-24 09:53:57 +00:00
335d6ca7e2
Prevent copying longer than expected NTLM SSP key
...
svn path=/trunk/; revision=47248
2013-01-24 09:34:54 +00:00
42de9da8e3
From Manuel Hofer: Dissector for the OpenVPN Protocol
...
As part of a semster project in our 3rd semester of
"secure information systems" at the university of
applied sciences upper austria, we built a wireshark
dissector for the OpenVPN protocol.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8240
From me:
Rework reassembly code and tree display of
message fragments and reassembled messages.
Fix various bugs and do some cleanup.
Also: Do minor whitespace changes in AUTHORS.
svn path=/trunk/; revision=47247
2013-01-24 04:26:46 +00:00
ce5adea80a
Try making dataCodingScheme a guint32 to quiet the MacOS buildbots.
...
svn path=/trunk/; revision=47244
2013-01-24 02:28:12 +00:00
83fffcf258
Delete duplicated word, "you".
...
svn path=/trunk/; revision=47241
2013-01-24 01:39:59 +00:00
2dff8d7605
Add font and color preferences. Unfortunately Qt doesn't have a color
...
picker widget so we're back to popping up dialogs. Move the contents of
monospace_font.{cpp,h} to wireshark_application.{cpp,h}.
Pango and Qt use completely different string representations for fonts.
Add a separate gui.qt.font_name preference so that they don't clobber
each other.
svn path=/trunk/; revision=47240
2013-01-24 01:10:12 +00:00
9cf7642d19
Allow dissection of several segmented warning messages in parallel
...
svn path=/trunk/; revision=47236
2013-01-23 21:55:07 +00:00
59e4794390
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8216 :
...
Add basic dissection of UTF8String type in ASN.1 PER dissector
svn path=/trunk/; revision=47233
2013-01-23 20:50:18 +00:00
d59e9cf574
mm_context_used_cipher is 3 bits.
...
svn path=/trunk/; revision=47230
2013-01-23 15:56:29 +00:00
c94d02cf85
svn path=/trunk/; revision=47229
2013-01-23 15:40:32 +00:00
260cafb04c
Fix for CID 280286:
...
Take negative value into account, avoid all casting in the process.
svn path=/trunk/; revision=47223
2013-01-23 06:11:18 +00:00
0cb2a257de
Convert the strict allocator to use a hash table similarly to the simple
...
allocator, allowing it to implement realloc and free.
svn path=/trunk/; revision=47222
2013-01-23 02:31:04 +00:00
681a3ad5a2
Handle NULL-pointers and 0-lengths in a much simpler allocator-agnostic way,
...
and document the fact that allocator authors don't have to care.
svn path=/trunk/; revision=47220
2013-01-23 01:11:36 +00:00
c25c5915c5
Add wrapper functions for realloc, free and gc, but don't expose them in the
...
header yet as not all allocators implement them.
svn path=/trunk/; revision=47219
2013-01-23 00:59:38 +00:00
ae61fe0158
Try to fix dissection of GSM protocol family broken by r47209.
...
Using val_to_str seemed to be a good idea, but most value_string arrays were not properly filled or were using hacks.
(I hope I got everything right...)
svn path=/trunk/; revision=47218
2013-01-22 23:25:44 +00:00
6e1c54c8fd
Fix for CID 761911-761984 and CID 761985-761994.
...
Try to convince Coverity that the passed in item pointer is appreciated,
but not used.
This time see if it pleases the Windows compiler too.
svn path=/trunk/; revision=47217
2013-01-22 22:07:44 +00:00
1c7c18b725
Fix a typo in a comment;
...
Do some minor whitespace & etc cleanup.
svn path=/trunk/; revision=47216
2013-01-22 20:55:54 +00:00
7ad70545cc
More fixes for handling of NULL-pointers and 0-lengths in calls to
...
malloc/realloc/free.
svn path=/trunk/; revision=47215
2013-01-22 18:46:35 +00:00
6ef1fc5002
GTK+:
...
Get rid of user-hostile behavior. In the layout preferences pane 2 & 3
radio buttons overrode the user's selection if a duplicate item was
selected. Now we assume that the user knows what he or she is doing and
steal duplicate selections from the other panes.
Qt:
Match the new GTK+ behavior in the layout preferences. Add padding
around the layout images. Add toolbar style preferences to the
Appearance pane (instead of the layout pane).
All:
Remove the selection mode and scrollbar placement prefs and mark them
obsolete as recently discussed on -dev.
Adjust the layout images yet again after more Awful Monitor Testing.
svn path=/trunk/; revision=47214
2013-01-22 18:27:18 +00:00
df41b2aefa
#include <epan/reassemble.h> not needed.
...
svn path=/trunk/; revision=47212
2013-01-22 15:55:59 +00:00
9a636739ba
Create/use extended value-string;
...
Add editor modelines;
Do minor whitespace, long lines, and etc cleanup.
svn path=/trunk/; revision=47211
2013-01-22 15:38:55 +00:00
6a6aaf7409
Fix for CID 717414-717435.
...
Never ever access a string in a value string by its array index.
Use the proper access functions (val_to_str[_ext] and friends).
Also: make clean compile, so move out of dirty dissectors.
svn path=/trunk/; revision=47209
2013-01-22 07:18:20 +00:00
332012288b
Revert 47201 it does not compile on Windows.
...
svn path=/trunk/; revision=47208
2013-01-22 07:05:39 +00:00
52b63d96a4
Update the FeliCa dissector to identify FeliCa Standard commands
...
From Tyson Key, bug 8243 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8243 )
svn path=/trunk/; revision=47205
2013-01-22 04:29:37 +00:00
604fd1f1c5
Try to eliminate VS Code Analysis warning: warning C6385: Invalid data: accessing 'hf_packetbb_addr_value', the readable size is '16' bytes, but '4004' bytes might be read
...
svn path=/trunk/; revision=47204
2013-01-22 02:48:55 +00:00
0e34036761
Fix bug found by VS Code Analysis: warning C6336: Arithmetic operator has precedence over question operator, use parentheses to clarify intent
...
svn path=/trunk/; revision=47202
2013-01-22 01:56:07 +00:00
86dd0abcd3
Fix for CID 761911-761984 and CID 761985-761994.
...
Try to convince Coverity that the passed in item pointer is appreciated,
but not used.
svn path=/trunk/; revision=47201
2013-01-21 22:38:11 +00:00
23b5828115
From Subramanian via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8109 Add support for Bidirectional Forwarding Detection (BFD) for MPLS Label Switched Paths (LSPs) [ RFC 5884]
...
svn path=/trunk/; revision=47193
2013-01-21 08:38:40 +00:00
b7548f11bd
Update to 3GPP TS 25.419 V11.0.0 (2012-09) no change in asn1.
...
svn path=/trunk/; revision=47192
2013-01-21 07:09:13 +00:00
5fe15dfd37
Fix CID 966637 and CID 966638
...
Check pointers before using them.
svn path=/trunk/; revision=47186
2013-01-20 21:14:12 +00:00
31b969a4b5
Replace tvb_get_ipv4 / ip_to_str ... by tvb_ip_to_str
...
svn path=/trunk/; revision=47181
2013-01-20 18:32:56 +00:00
26df7b88e5
Fix indent (Replace tabs by space) and add Modelines info
...
svn path=/trunk/; revision=47180
2013-01-20 18:32:47 +00:00
56bddf989b
Use proto_tree_add_item for stun_att_reserved and use FT_BYTES type.
...
svn path=/trunk/; revision=47179
2013-01-20 18:32:37 +00:00
48cef7c61a
Enhance FIX generator
...
* Remove whitespace and tab
* Add information how to generate packet-fix.h (in top of packet-fix.h)
Regenerate packet-fix.h
svn path=/trunk/; revision=47178
2013-01-20 18:32:23 +00:00
1a182e2a79
Dissect ETWS and CMAS notifications
...
svn path=/trunk/; revision=47177
2013-01-20 17:14:24 +00:00
4cd9fb3084
[Automatic manuf, services and enterprise-numbers update for 2013-01-20]
...
svn path=/trunk/; revision=47174
2013-01-20 15:03:39 +00:00
Bill Meier