Commit Graph

15 Commits

Author SHA1 Message Date
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier 67ee5049d4 Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors:
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
  the encoding parameter for proto_tree_add_item() calls which directly reference
  an item in hf[] which has a type of:
     FT_BOOLEAN
     FT_IPv4
     FT_EUI64
     FT_GUID
     FT_UINT_STRING

Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260)

svn path=/trunk/; revision=39328
2011-10-10 00:39:31 +00:00
Bill Meier 4e57694d4a Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors:
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
 the encoding parameter for proto_tree_add_item() calls which directly reference
 an item in hf[] which has a type of:
    FT_UINT8
    FT_UINT16
    FT_UINT24
    FT_UINT32
    FT_UINT64
    FT_INT8
    FT_INT16
    FT_INT24
    FT_INT32
    FT_INT64
    FT_FLOAT
    FT_DOUBLE


svn path=/trunk/; revision=39288
2011-10-06 03:35:44 +00:00
Bill Meier 94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00
Anders Broman a6f7c3a8bd Tweak the display of the header.
svn path=/trunk/; revision=34946
2010-11-18 16:01:39 +00:00
Anders Broman 5df12df600 Update offset outside of if statement.
svn path=/trunk/; revision=32250
2010-03-20 00:04:39 +00:00
Anders Broman 7ad6ee5056 Add dissection of "multiplexing with RTP header compression"
inspired by Sourabh Rathors bug
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4591

svn path=/trunk/; revision=32229
2010-03-17 20:45:50 +00:00
Jaap Keuter 75f1e13c12 Cleanup header fields.
svn path=/trunk/; revision=30394
2009-10-07 23:08:22 +00:00
Kovarththanan Rajaratnam bb0108cf25 Use NB_RTPMUX as protocol short name
svn path=/trunk/; revision=29610
2009-08-29 04:47:28 +00:00
Kovarththanan Rajaratnam e0c4b20c86 We need to handoff even when we don't have a tree
svn path=/trunk/; revision=29609
2009-08-29 04:43:52 +00:00
Kovarththanan Rajaratnam a87c4885b8 Indent comments
svn path=/trunk/; revision=29608
2009-08-29 04:39:59 +00:00
Guy Harris c960781f5e Note what the 3GPP spec is for this protocol.
Suggest a possible less-weak heuristic.

Note that we're not checking the T bit and handling RTP header
compression.

At least as I read TS 29.414, the length indicator isn't supposed to be
zero; however, a length indicator of 0 doesn't keep us from dissecting
further, so just don't bother dissecting the payload.  We should,
perhaps, add an expert info for this.

We should perhaps also catch exceptions thrown when dissecting the RTP
packet, so a malformed RTP packet will still let us continue dissecting
the rest of the Nb packet.

svn path=/trunk/; revision=29607
2009-08-29 02:32:33 +00:00
Bill Meier 79428f30cb Cleanup:
- proto_reg_handoff: 'if (!inited)' not req'd;
- Remove unneeded #includes;
- Use NULL instead of " for 'blurbs';
- Remove unneeded foward reference.

svn path=/trunk/; revision=29604
2009-08-29 01:46:42 +00:00
Guy Harris a340788eb2 Note that the "heuristic" is fatally weak, and must be strengthened or
eliminated.

Fix indentation.

Use tvb_reported_length(), so we throw an exception for packets cut
short by a snapshot length.

Don't bother showing or dissecting the payload if there isn't any.

Don't show an item with a zero-length payload as going to the end of the
packet.

svn path=/trunk/; revision=29603
2009-08-29 01:08:31 +00:00
Anders Broman 988a595e79 From Neil Piercy:
Add new protocol for 3GPP 29.414 (Nb interface RTP Mux).

- Don't use C++-style comments (comments beginning with "//")
- Don't declare variables in the middle of executable code; not all C
compilers support that. 
- Dont register preferences when none present.
- Removed CHECK_COL

svn path=/trunk/; revision=29602
2009-08-28 21:34:59 +00:00