Commit Graph

22 Commits

Author SHA1 Message Date
Stig Bjørlykke 27344a90fe Removed some unneeded assignments.
Found by clang.

svn path=/trunk/; revision=36698
2011-04-18 15:29:25 +00:00
Gerald Combs 7b254f46fb Fix some Visual C++ static analyzer complaints.
svn path=/trunk/; revision=35971
2011-02-17 01:11:05 +00:00
Guy Harris a595f69ce4 The lack of _WITH_PHDR in WTAP_ENCAP_BLUETOOTH_H4 means there's no
pseudo-header, and hence there's no direction indication. Don't set
pinfo->p2p_dir for it.  Use WTAP_ENCAP_BLUETOOTH_H4_WITH_PHDR, not
WTAP_ENCAP_BLUETOOTH_H4, for capture files where we have the direction.

Don't assume pinfo->p2p_dir is either P2P_DIR_SENT or P2P_DIR_RECV when
setting the info column in various Bluetooth dissectors; it might be
unknown.

In the HCI H4 dissector, put the direction into the info column
regardless of whether we have a type match or not; the dissectors for
HCI packet types appear to assume it's been set (as they put a blank at
the beginning of the stuff they append to the direction).

svn path=/trunk/; revision=35933
2011-02-12 19:59:41 +00:00
Stig Bjørlykke 84bc28bd6a Introduce "Fragment count" filter element for all protocols doing reassembly.
svn path=/trunk/; revision=35705
2011-01-30 21:01:07 +00:00
Jeff Morriss f36e2be287 Use tvb_memeql() and tvb_memcpy().
Use tvb_ip_to_str() and tvb_ip6_to_str().

There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the
return string is NULL terminated.

svn path=/trunk/; revision=35546
2011-01-16 03:35:29 +00:00
Kovarththanan Rajaratnam 46dd093b94 From Allan M. Madsen via. bug 5445:
Bluetooth profiles and protocols above RFCOMM and L2CAP can not be dissected correctly because the required information (server channel and dynamic PSM value mappings to services/profiles) about the type of data carried in the payload is not available. RFCOMM is currently hardcoded to handoff all payload data to the obex dissector though it may carry e.g. handsfree, dial-up networking or serial port profile related data.

The patch consists of modifcations to the following dissectors:

btsdp: Extraction of RFCOMM server channel and L2CAP dynamic PSM with service mapping is provided to RFCOMM and L2CAP through a tap interface. In addition, the packet list info is beautyfied and extended with more details for better
overview.

btl2cap: Adds a new dissector table with services and dynamic PSM mapping which is filled by a tap listner catching the info from btsdp. More info added to packet list.

btrfcomm: Adds a new dissector table with services and server channel mapping which is filled by a tap listner catching the info from btsdp. Dissectors for handsfree, dial-up netorking and serial port profiles (all based on RFCOMM) are also added.

btobex: Registers several obex based profiles (e.g. obex push, file transfer, basic printing etc.) in both RFCOMM and L2CAP. Some cleanup.


svn path=/trunk/; revision=35323
2011-01-02 08:13:40 +00:00
Jeff Morriss cca3ba3ce2 (Refining the regexp...) Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34230
2010-09-24 02:51:40 +00:00
Jeff Morriss 0ff5638f37 Replace blurbs that match the name (case insensitive) with NULL.
svn path=/trunk/; revision=34227
2010-09-23 21:46:31 +00:00
Bill Meier 10fb76ce44 Add svn 'keywords' and 'eol-style' properties
svn path=/trunk/; revision=32898
2010-05-19 12:44:57 +00:00
Kovarththanan Rajaratnam 52d4ae5b8d Add and use BTOBEX_CODE_VALS_MASK to avoid hardcoding values
svn path=/trunk/; revision=32897
2010-05-19 08:47:10 +00:00
Kovarththanan Rajaratnam 855bafe183 Use newly introduced BTOBEX_CODE_VALS_CONNECT define
svn path=/trunk/; revision=32895
2010-05-19 08:23:53 +00:00
Kovarththanan Rajaratnam 9537eb450e Introduce defines to avoid hardcoding values
svn path=/trunk/; revision=32894
2010-05-19 08:19:41 +00:00
Kovarththanan Rajaratnam 2bde45d2f5 Tighten scope of code variable
svn path=/trunk/; revision=32893
2010-05-19 08:13:26 +00:00
Kovarththanan Rajaratnam 1b7aa4bc16 Remove weird assignment to pinfo->private_data
svn path=/trunk/; revision=32890
2010-05-19 06:28:48 +00:00
Kovarththanan Rajaratnam 93bc47d26a Add FIXME
svn path=/trunk/; revision=32874
2010-05-18 11:44:32 +00:00
Kovarththanan Rajaratnam bb2340b232 Remove NULL pointer guard in defragment_init()
svn path=/trunk/; revision=32873
2010-05-18 10:49:09 +00:00
Kovarththanan Rajaratnam ea6d8edcce Remove a couple of superfluous NULL assignments
svn path=/trunk/; revision=32872
2010-05-18 10:45:39 +00:00
Kovarththanan Rajaratnam 52122ece9c Remove a couple of check_col()
svn path=/trunk/; revision=32871
2010-05-18 10:43:36 +00:00
Kovarththanan Rajaratnam 62a20b9b19 Mark defragment_init() as an init routine
svn path=/trunk/; revision=32866
2010-05-18 08:08:08 +00:00
Kovarththanan Rajaratnam 100e30939a Fix several GCC build issues
svn path=/trunk/; revision=32865
2010-05-18 07:49:55 +00:00
Kovarththanan Rajaratnam 6476632fda Include (local) packet-btl2cap.h properly
svn path=/trunk/; revision=32863
2010-05-18 07:35:31 +00:00
Kovarththanan Rajaratnam 9d568f7f9c From Allan M. Madsen:
Initial implementation of Bluetooth OBEX dissector. Work in progress.

svn path=/trunk/; revision=32862
2010-05-18 07:32:04 +00:00