Commit Graph

35480 Commits

Author SHA1 Message Date
Gerald Combs 835d5e4ec7 Switch to an installer package for OS X instead of a draggable app
bundle. There are still a few rough edges but it's an improvement over
what we currently have. Fixes bug 5756.

svn path=/trunk/; revision=37093
2011-05-12 18:02:00 +00:00
Gerald Combs f9fad8cd75 "tshark -D" writes to stderr now.
svn path=/trunk/; revision=37092
2011-05-12 17:49:15 +00:00
Chris Maynard 10ed235707 WANT_PACKET_EDITOR fixups for Windows.
svn path=/trunk/; revision=37091
2011-05-12 17:46:54 +00:00
Chris Maynard 29ec75d29e Add snai, mpf and efi to bf_tree, not tree. Fixes Coverity CID 1045.
svn path=/trunk/; revision=37090
2011-05-12 17:26:54 +00:00
Chris Maynard dbc48efbe8 Wrap assoc_tree within #if 0 ... #endif. Fixes Coverity CID 1049.
svn path=/trunk/; revision=37089
2011-05-12 17:25:43 +00:00
Chris Maynard a847fd391f Add token to query_tree instead of to tree. Fixes Coverity CID 1057.
svn path=/trunk/; revision=37088
2011-05-12 17:23:38 +00:00
Chris Maynard ea41f9a9d9 Delete eth_addr; it was assigned a value but never used. Fixes Coverity 1070.
svn path=/trunk/; revision=37087
2011-05-12 17:21:49 +00:00
Chris Maynard 1f1789fa41 Use nonce_2_item instead of incorrect nonce_1_item. Fixes Coverity CID 1071.
svn path=/trunk/; revision=37086
2011-05-12 17:19:10 +00:00
Chris Maynard a01a527166 Delete acm as it is assigned but never used. Fixes Coverity 1072.
svn path=/trunk/; revision=37085
2011-05-12 17:16:45 +00:00
Jakub Zawadzki b680407847 Conditional support for packet-editor [default=no].
svn path=/trunk/; revision=37084
2011-05-12 17:14:59 +00:00
Chris Maynard 21363344ec Add text to fac_subtree instead of fac_tree. Fixes Coverity CID 1129.
svn path=/trunk/; revision=37083
2011-05-12 17:14:36 +00:00
Michael Tüxen 2d6cd58f91 Add support for handling multiple interfaces as command line
parameters. An array of interface specific data is handled
in addition to the current way.
This change should not have any effect right now, it will
be used by dumpcap when supporting multiple interfaces
(and tshark/wireshark... in the future).


svn path=/trunk/; revision=37082
2011-05-12 16:54:16 +00:00
Jakub Zawadzki 12d8f46860 Fix double free.
compr is also freed outside loop. So free it only when returning.

Might be related with bug #5908, but I don't have access to that bug ;-)

svn path=/trunk/; revision=37081
2011-05-12 16:31:42 +00:00
Anders Broman d9c5fa2537 Remove check_col, use ENC_BIG_ENDIAN.
svn path=/trunk/; revision=37080
2011-05-12 15:48:51 +00:00
Anders Broman 4857270e0b Copy-paste error.
svn path=/trunk/; revision=37079
2011-05-12 15:40:32 +00:00
Anders Broman bce6b09c8a Convetr more menus to GUIManager.
svn path=/trunk/; revision=37078
2011-05-12 15:17:28 +00:00
Jeff Morriss 14e2a91fdf Include config.h (for WS_MSVC_NORETURN) and g_gnuc.h (for G_GNUC_NORETURN)
svn path=/trunk/; revision=37077
2011-05-12 13:50:44 +00:00
Michael Tüxen 93377f5236 Another whitespace cleanup.
svn path=/trunk/; revision=37076
2011-05-12 12:06:19 +00:00
Stig Bjørlykke 0fc261ab54 Corrected endif.
svn path=/trunk/; revision=37075
2011-05-12 11:17:22 +00:00
Stig Bjørlykke 624a041e6f Indicate Signed Receipt in info column.
svn path=/trunk/; revision=37074
2011-05-12 11:06:42 +00:00
Michael Tüxen 4b303018d1 Clean up some indentation. A purely whitespace change.
svn path=/trunk/; revision=37073
2011-05-12 10:58:14 +00:00
Anders Broman 50e30e3c70 Make the use of UIManager a configure option.
NOTE Only for Windows.

Additional moves to UIManager.

svn path=/trunk/; revision=37072
2011-05-12 10:56:26 +00:00
Stig Bjørlykke 516442af8f Prefix "fragments" with IPv6, as is done with IPv4.
svn path=/trunk/; revision=37071
2011-05-12 10:27:30 +00:00
Stig Bjørlykke 1becef31f0 Use IPv4 as protocol name, to align with IPv6.
svn path=/trunk/; revision=37070
2011-05-12 10:27:02 +00:00
Jeff Morriss 009156289f Fix the test.sh failures based on Guy's suggestion in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5445#c15 :
Add a new tap flag to indicate that a tap listener is just a "dissector helper",
that is, a tap which is used by a dissector to help it do its dissection but
does not, itself, require dissection.

Use this new flag in the dissectors which register taps.

Remove the (now-unused) have_tap_listeners() function.

svn path=/trunk/; revision=37069
2011-05-12 03:18:34 +00:00
Gerald Combs 995d748f05 Check our original record length. Fixes a crash bug found by Huzaifa
Sidhpurwala of the Red Hat Security Response Team.

svn path=/trunk/; revision=37068
2011-05-11 22:36:59 +00:00
Chris Maynard d264cd5658 When performing heuristics, use tvb_length() instead of tvb_reported_length().
svn path=/trunk/; revision=37067
2011-05-11 20:40:14 +00:00
Gerald Combs 32749c0fad Use a comparison instead of an assignment. Fixes Coverity CID 1194.
svn path=/trunk/; revision=37066
2011-05-11 20:39:11 +00:00
Gerald Combs 16938e6470 Remove some unused variable assignments. Fixes Coverity CID 1202.
svn path=/trunk/; revision=37065
2011-05-11 20:35:57 +00:00
Bill Meier f5d76afe25 Add Tyson Key;
Fix spacing for a few entries;
Add back missing blank line before "and by".

svn path=/trunk/; revision=37064
2011-05-11 13:58:35 +00:00
Bill Meier 6d6da5af53 #include <string.h> not req'd;
Move proto_reg_handoff...() to the end of the file as per the usual convention.

svn path=/trunk/; revision=37063
2011-05-11 13:36:17 +00:00
Bill Meier c7cb5bd325 Add packet-usb-at.c;
Also: put a few entries in alphabetical order.

svn path=/trunk/; revision=37062
2011-05-11 13:31:41 +00:00
Michael Tüxen eaead49183 Fix a wrong name in a debug print statement.
svn path=/trunk/; revision=37061
2011-05-11 12:51:01 +00:00
Martin Mathieson 9a4b6db704 Support multiple Scheduling Requests in one PDU.
svn path=/trunk/; revision=37060
2011-05-11 11:10:30 +00:00
Tomas Kukosa e3ef98c477 Export wtap_fstat()
svn path=/trunk/; revision=37059
2011-05-11 07:31:18 +00:00
Jeff Morriss 02835bc4c5 From Michael Chen via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5863 :
5. A guaranteed null pointer access violation is fixed in packet-ssl-utils.c
when DTLS succeeded in dissecting its payload.

svn path=/trunk/; revision=37058
2011-05-11 02:06:22 +00:00
Jeff Morriss 1c515d2af2 Use consistent casing in hf_ descriptions and expert infos.
svn path=/trunk/; revision=37057
2011-05-11 01:39:10 +00:00
Jeff Morriss eb0bbf105a From Peter Paluch via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5893 :
- Put back the hf_ variables removed from the last patch

- Change the verbose protocol name to the (now) official spelling "VLAN
Trunking Protocol" instead of "Virtual Trunk Protocol"

- Made the "Info" column more informative by placing the message type and
selected key information into it, instead of just the verbose protocol name

- Corrected an error in the handling of the Advert-Request message where the
Management Domain Name field was not parsed properly, resulting in wrong
parsing of the remainder of the entire Advert-Request message


svn path=/trunk/; revision=37056
2011-05-11 01:11:50 +00:00
Jeff Morriss 9d03ce44f4 Eliminate redundant blurbs
svn path=/trunk/; revision=37055
2011-05-11 01:06:37 +00:00
Guy Harris 0a4e212e4b file_read() can return -1; don't just blindly add it to a previous
file_read() return value.  Use wtap_file_read_expected_bytes() in a
number of places.

svn path=/trunk/; revision=37054
2011-05-10 21:53:10 +00:00
Guy Harris 2ca5312b64 file_read() can return -1; don't just blindly add it to a previous
file_read() return value.  Use wtap_file_read_expected_bytes() in a
number of places.

svn path=/trunk/; revision=37053
2011-05-10 20:17:31 +00:00
Chris Maynard 025f9ee4db From Olivier Crete via bug 5761: Compute the FCI size correctly for RTCP RTPFB.
svn path=/trunk/; revision=37052
2011-05-10 18:52:37 +00:00
Bill Meier 7050847bc9 Add missing line of code: Fixes Coverity 1042 (UNUSED);
Remove unneeded lines of code: Coverity 1043 (UNUSED).

svn path=/trunk/; revision=37051
2011-05-10 18:43:40 +00:00
Bill Meier adfbe89aaa Remove some unneeded lines of code: Coverity 1063;
Also: remonve someunneeded #includes.

svn path=/trunk/; revision=37050
2011-05-10 17:44:36 +00:00
Chris Maynard e5adfc8e18 Add support for USB CDC Ethernet. Resolves bug 4819.
svn path=/trunk/; revision=37049
2011-05-10 17:40:29 +00:00
Bill Meier 4edfe4961f Don't assign to unused variable: Coverity 1068 & 1069.
Remove some related no longer needed code and variables;
Also: Fix a typo and reword a comment.

svn path=/trunk/; revision=37048
2011-05-10 17:28:46 +00:00
Michael Tüxen 6898a1f0ad Remove unused variable to avoid a warning which breaks the build.
svn path=/trunk/; revision=37047
2011-05-10 17:25:45 +00:00
Chris Maynard 79940000f2 Add subversion Id and Wireshark copyright.
svn path=/trunk/; revision=37046
2011-05-10 17:06:20 +00:00
Chris Maynard df79077cdd Add USB/AT dissector, submitted by Tyson Key via bug 5868 with some
modifications by me as described/documented in the bug report.

svn path=/trunk/; revision=37045
2011-05-10 17:04:05 +00:00
Gerald Combs a79777beaf Make sure we set a variable.
svn path=/trunk/; revision=37044
2011-05-10 16:05:14 +00:00