Commit Graph

90552 Commits

Author SHA1 Message Date
Gerald Combs b7ae4f2eb7 Qt: Add null checks to the protocol tree
eab4734a0d removed actionAnalyzeDecodeAs and actionFileExportPacketBytes
from Logray.
2024-02-07 15:00:14 -08:00
Martin Mathieson b8999a383c Fix some more spelling errors 2024-02-07 21:51:34 +00:00
Joakim Karlsson 754a16258c LI5G: update column protocol and filter name
Lawful Interception (LI) is the main area and should be located first
in name, which will be more easy of use for new user when want to
filter messages
2024-02-07 10:14:38 +01:00
John Thacker 75a64a96b7 Qt: Only save the filtered rows to the Map
Be a little more careful in TrafficTab about whether we
want the Proxy Model or the Source Model, since the tap
filter doesn't exclude rows from the source model (since
the non-displayed rows are used to as part of the percentages
of the total.)

When we want to respect the display filtering or the sorting,
use the proxy model.

In the tap data model, only claim we have GeoIPData (which makes
the map available) if a row that isn't filtered out has data.

Fix #18530
2024-02-07 08:17:15 +00:00
Timo Warns 7fbff7a381 GNSS: add dissector for UBX-RXM-RAWX messages of u-blox GNSS receivers
Add dissector for UBX-RXM-RAWX messages of u-blox GNSS receivers.
2024-02-07 08:15:26 +00:00
Timo Warns 59d56d7520 Move unit string for cycles to unit_strings.h
Move unit string for cycles to unit_strings.h from packet-usb-i1d3.c to
allow for usage by other dissectors.
2024-02-07 08:15:26 +00:00
Timo Warns 5a761cf95c GNSS: use proto_tree_add_bitmask() for UBX bitmask fields
Use proto_tree_add_bitmask() for bitmask fields of UBX messages.
2024-02-07 08:15:26 +00:00
Timo Warns 54fa2250bd GNSS: replace usage of "^2" by UTF8_SUPERSCRIPT_TWO
Replace usage of "^2" by UTF8_SUPERSCRIPT_TWO in value_strings
2024-02-07 08:15:26 +00:00
Timo Warns 44bcfa9f0a GNSS: add dissector for UBX-NAV-SBAS messages
Add dissector for UBX-NAV-SBAS messages of u-blox GNSS receivers.
2024-02-07 08:15:26 +00:00
Timo Warns f1463bbd32 GNSS: Map GNSS ID in UBX-NAV-SAT SV info subtrees
Map the GNSS ID in the UBX-NAV-SAT SV info subtrees
2024-02-07 08:15:26 +00:00
Timo Warns d66973d947 GNSS: reduce ett_ubx_nav_sat_sv_info length
Reduce ett_ubx_nav_sat_sv_info length to 255 entries as a UBX-NAV-SAT
message may include 255 SV infos at most.
2024-02-07 08:15:26 +00:00
Timo Warns 48a5255a25 GNSS: make available SBAS UDREI mapping to other files
Make available SBAS UDREI mapping to other files to enable usage in
other dissectors (e.g. UBX).
2024-02-07 08:15:26 +00:00
Timo Warns c3305a4bd1 GNSS: add dissector for UBX-NAV-TIMEUTC messages
Add dissector for UBX-NAV-TIMEUTC messages of u-blox GNSS receivers.
2024-02-07 08:15:26 +00:00
Stefan Metzmacher 4b68415213 dcerpc-netlogon: fix const related compiler warnings
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2024-02-07 08:10:19 +00:00
Stefan Metzmacher b85a56ac73 dcerpc-netlogon: fix dissecting NetrLogonGetCapabilities
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2024-02-07 08:10:19 +00:00
Stefan Metzmacher 962979a802 dcerpc-netlogon: add basic dissection for NetrChainSetClientAttributes
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2024-02-07 08:10:19 +00:00
Stefan Metzmacher d65b6075af dcerpc-netlogon: add decryption support for netlogon.sendtosam.opaquebuffer
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2024-02-07 08:10:19 +00:00
Stefan Metzmacher e673fc411d dcerpc-netlogon: fix dissecting of NetrLogonSendToSam
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2024-02-07 08:10:19 +00:00
Stefan Metzmacher 4f1ed11da0 dcerpc-netlogon: fix netlogon_dissect_NETLOGON_SECURE_CHANNEL_TYPE for NDR64
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2024-02-07 08:10:19 +00:00
Stefan Metzmacher a8ad212436 dcerpc-netlogon: add the latest opcodes from [MS-NRPC]
Dissecting them in detail is a task for another day...

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2024-02-07 08:10:19 +00:00
Stefan Metzmacher 8a6a10b02d dcerpc-netlogon: make use of common dissect_ndr_nt_SE_GROUP_ATTRIBUTES()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2024-02-07 08:10:19 +00:00
Stefan Metzmacher 3a0891a257 dcerpc-nt: add dissect_ndr_nt_SE_GROUP_ATTRIBUTES
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2024-02-07 08:10:19 +00:00
Stefan Metzmacher dde539d342 windows-commoni: add new wellknown rids values
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2024-02-07 08:10:19 +00:00
Stefan Metzmacher dff5065873 windows-common: fix handling of Compounded Authentication/Claims Valid SIDs
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2024-02-07 08:10:19 +00:00
Stefan Metzmacher 4be3aad2a4 pkinit: pass kerberos_is_win2k_pkinit() over actx boundaries
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2024-02-07 08:09:36 +00:00
Stefan Metzmacher 647bb10117 Kerberos: add support for aes256-cts-hmac-sha1-96-sk
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2024-02-07 08:09:36 +00:00
Stefan Metzmacher 8b15994f2b Kerberos: add support for PAC_FULL_CHECKSUM
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2024-02-07 08:09:36 +00:00
Stefan Metzmacher 8efeee83d1 Kerberos: add AP_OPTIONS UNVERIFIED_TARGET_NAME flag
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2024-02-07 08:09:36 +00:00
Vadim Yanitskiy ecb4562e3b M3UA: also dissect tcp/2905, implement reassembly
RFC 4666 section 1.3.1 states that "TCP MAY be used as the underlying
common transport protocol" under certain scenarios.  There is even
IANA-allocated TCP port 2905 for that purpose (see section 1.4.8).
2024-02-07 08:05:41 +00:00
Gerald Combs c9bbcca3b8 Qt: Show "Events" in the status bar when appropriate 2024-02-07 03:25:38 +00:00
Gerald Combs eab4734a0d Logray: UI updates
Change some instances of "packet" to "event" in Logray's menu items.
Remove "Export Objects" and "Export PDUs" and associated code. Remove
the packet diagram menu items and associated code. Remove the "Decode
as" menu items and associated code.

Use "Selected" instead of the parenthetical plural "Packet(s)" for
marking and ignoring. Remove an attempt at plural translation which
apparently doesn't work if we don't have a "%n" in the translation
string.
2024-02-07 03:25:15 +00:00
Darius Davis 2de251261d conversation: Fix conversation_element_list_values.
Fix a misplaced brace in debug-only function conversation_element_list_values.
(The "#if 0" means that the compiler didn't catch it.)

Move the type_names array to file-level to avoid the two copies getting out of
sync again.

Add a DISSECTOR_ASSERT to ensure that input conversation_element_type values
are within range.
2024-02-07 10:48:43 +10:00
Gerald Combs b5d010d44e CMake+Logray: Add the About → Authors CSV resource 2024-02-06 21:11:26 +00:00
Gerald Combs 2a73e99cfb Falco bridge: Syscall conversation updates
Add a pinfo conversation filter which enables related packets based on
(container.id, proc.id) combinations. Register the "Process" conversation
filter first so that the "Go" menu behavior matches the related packet
display.

Handle cases where container.id is missing.

Add 64-bit integer type support to conversations.
2024-02-06 12:24:28 -08:00
John Thacker e972a755d2 dfilter: Handle null arguments to min, max
min and max need to handle null arguments where the GPtrArray
is null, generated when there have been other opcodes between
the field loading and the function. (They are ignored, not
treated as zero, so they don't change the minimum.)

Prevents crashes with filters where a field does not exist in the tree:

min(tcp.srcport * 10, tcp.dstport * 10) == 800
min(len(tcp.payload), len(udp.payload)) == 153
min(len(tcp.payload[2:]) + 2, len(udp.payload[2:]) + 2) == 153

where a register is loaded where it has not had its GPtrArray created:

./run/dftest 'min(len(tcp.payload), len(udp.payload))'
Filter:
 min(len(tcp.payload), len(udp.payload))

Instructions:
 0000 READ_TREE        tcp.payload      -> R1
 0001 IF_FALSE_GOTO    3
 0002 LENGTH           R1               -> R2
 0003 STACK_PUSH       R2
 0004 READ_TREE        udp.payload      -> R3
 0005 IF_FALSE_GOTO    7
 0006 LENGTH           R3               -> R4
 0007 STACK_PUSH       R4
 0008 CALL_FUNCTION    min(R2, R4)      -> R0
 0009 STACK_POP        [2]
 0010 IF_FALSE_GOTO    12
 0011 NOT_ALL_ZERO     R0
 0012 RETURN

Related to fcb6bb5763
(Prior to that commit, this worked because a NULL pointer is a
valid, empty GSList.)
2024-02-06 15:32:57 +00:00
Stefan Metzmacher 795dc54aae ldap: make use of STRING_CASE_INSENSITIVE for CLDAP
Commit 05e404e8cb was wrong...

This allows dissection of the 'NETLOGON' attribute in
the same way as the 'netlogon' attribute.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2024-02-06 14:14:50 +00:00
Stefan Metzmacher f6efcb3313 ldap: assume GSS-SPNEGO as default
This allows GSSAPI/SASL dissection if the ldap bind is not captured.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2024-02-06 14:14:50 +00:00
Jaap Keuter 9dde2bee6e DHCP: interpret option 108 properly
Add option 108 (IPv6-Only Preferred) value interpretation.

Really fixes #18943
2024-02-06 12:59:31 +00:00
Martin Mathieson 714e568f66 Fix some more spelling errors 2024-02-06 10:46:08 +00:00
Martin Mathieson 600de02805 PDCP-NR: Show Integrity data 2024-02-05 11:37:02 +00:00
Pascal Quantin dcaad51341 XnAP: fix a typo in a variable name 2024-02-05 12:08:15 +01:00
John Thacker 7b114620c7 opcua: Have a default signature length preference
If the OpenSecureChannel message is not captured, then whether
messages are signed, and what the signature length is is unknown.
This creates a preference that can be set to a default value to use,
instead of assuming that all messages on the channel are unsigned.

Fix #15206
2024-02-05 08:30:57 +00:00
Darius Davis 89ce06c459 Fix a grab-bag of typos.
One of these modifies a field name ("hart_ip.pt.rsp.transducer_serail_number"
in packet-hartip.c), a few are in text displayed for fields (in packet-nvme.c)
or for unknown fields (in packet-oer.c and packet-per.c), one is in a
preprocessor macro (in packet-cip.[ch]), and the rest are all in comments.

   arry -> array
   authos -> authors
   compatability -> compatibility
   contigous -> contiguous
   dispaly -> display
   erorr -> error
   filed (where it was obviously incorrect) -> field or filled
   hueristic -> heuristic
   regsiter -> register
   serail -> serial
2024-02-05 11:58:31 +10:00
Gerald Combs 2735ae7219 Qt: Add delta times to the follow dialog text formats
When showing the follow data as text (ASCII, UTF-8, EBCDIC, etc), add a
newline at each turn. Add the ability to show delta times between
packets and turns. Add a recent setting for delta times.

Make the initial dialog a bit wider.

Save and restore our scoll position when reading a stream.

Manually connect our signals and slots. Fix some clazy warnings.
2024-02-04 19:39:08 +00:00
Gerald Combs dae546e83a [Automatic update for 2024-02-04]
Update manuf, services enterprise numbers, translations, and other items.
2024-02-04 09:24:18 +00:00
John Thacker d74c040e9e file: Use the compiled dfcode in cf_filter_packets
While we do immediately free it and recompile in rescan_packets,
or if we open a capture file in cf_read, if we start a capture
we go from cf_open to cf_continue_tail, and we want to use this
filter since we don't compile during a capture for each group
of packets (for reasons explained in the previous commit.)

Fixup 08cf0e9553
2024-02-02 21:01:20 -05:00
Gerald Combs 126c95fe2b Falco bridge: Set our sinsp buffer format
Set our buffer format to PF_EOLS_COMPACT, which seems to offer the
closest thing to raw data.
2024-02-03 01:01:22 +00:00
Andreas Schultz 6a0277a9e4 diameter: add Travelping vendor dictionary 2024-02-02 21:23:00 +00:00
Martin Mathieson 78e9f6e003 F1AP: Set a UEId for PDCP-NR frames 2024-02-02 14:59:13 +00:00
Joakim Karlsson 97f33510e7 GTPv2: update IE F-Container to utilize expert field
This will allow dissector to continue with following IEs after
faulty F-Container
2024-02-02 13:34:02 +00:00