osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

No need for a per-instance private sctp_allassocs_info_t pointer. 

The result of sctp_stat_get_info() is only used in fillTable, so there's
no need to save it.

Make it a const pointer, to squelch warnings.

Change-Id: Icb6fd7e2f5c3c5c53f7d33509d100a0947e69369
Reviewed-on: https://code.wireshark.org/review/32460
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
This commit is contained in:
Guy Harris 2019-03-17 14:23:34 -07:00
parent 86c9d41510
commit f2e511e148
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ui/qt/sctp_all_assocs_dialog.cpp
View File

@ -43,6 +43,7 @@ SCTPAllAssocsDialog::~SCTPAllAssocsDialog()
void SCTPAllAssocsDialog::fillTable()
{
const sctp_allassocs_info_t *sctp_assocs;
GList *list;
const sctp_assoc_info_t* assinfo;
int numAssocs;
@ -53,7 +54,7 @@ void SCTPAllAssocsDialog::fillTable()
ui->assocList->setColumnWidth(3, 150);
ui->assocList->setColumnWidth(4, 150);
sctp_assocs = (sctp_allassocs_info_t*)sctp_stat_get_info();
sctp_assocs = sctp_stat_get_info();
if (sctp_assocs->is_registered == FALSE) {
register_tap_listener_sctp_stat();
/* (redissect all packets) */

1
ui/qt/sctp_all_assocs_dialog.h
View File

@ -48,7 +48,6 @@ private slots:
private:
Ui::SCTPAllAssocsDialog *ui;
capture_file *cap_file_;
sctp_allassocs_info_t *sctp_assocs;
guint16 selected_assoc_id;