The answer to the question "why pass err to open_routines[i]() if err is

overwritten here?" is probably "because I was cutting-and-pasting text
to insert the error-handling code, and didn't remove the "*err = errno"
from that particular case.  Remove it now.

svn path=/trunk/; revision=955
This commit is contained in:
Guy Harris 1999-10-31 19:30:53 +00:00
parent 24807c0afa
commit e5e89164b6
1 changed files with 1 additions and 4 deletions

View File

@ -1,6 +1,6 @@
/* file.c
*
* $Id: file.c,v 1.27 1999/10/31 17:46:06 gram Exp $
* $Id: file.c,v 1.28 1999/10/31 19:30:53 guy Exp $
*
* Wiretap Library
* Copyright (c) 1998 by Gilbert Ramirez <gram@verdict.uthscsa.edu>
@ -145,9 +145,6 @@ wtap* wtap_open_offline(const char *filename, int *err)
case -1:
/* I/O error - give up */
/* XXX - why pass err to open_routines[i]() if err is
* overwritten here? */
*err = errno;
file_close(wth->fh);
free(wth);
return NULL;