osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Qt: Fix a couple of resource leaks found by Coverity. 

Change-Id: Ic3156d8afc2fa237407f3893c34672b1306866fa
Reviewed-on: https://code.wireshark.org/review/7420
Reviewed-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: Evan Huus <eapache@gmail.com>
This commit is contained in:
Gerald Combs 2015-02-26 10:46:15 -08:00 committed by Evan Huus
parent 49b8f99449
commit df8b1a0154
3 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ui/qt/qt_ui_utils.cpp
View File

@ -52,9 +52,9 @@ gchar *qstring_strdup(QString q_string) {
}
QString gchar_free_to_qstring(gchar *glib_string) {
QString *qt_string = new QString(glib_string);
QString qt_string(glib_string);
g_free(glib_string);
return *qt_string;
return qt_string;
}
const QString address_to_qstring(const _address *address)

5
ui/qt/sequence_diagram.cpp
View File

@ -95,6 +95,11 @@ SequenceDiagram::SequenceDiagram(QCPAxis *keyAxis, QCPAxis *valueAxis, QCPAxis *
// valueAxis->setTickLabelRotation(30);
}
SequenceDiagram::~SequenceDiagram()
{
delete data_;
}
void SequenceDiagram::setData(_seq_analysis_info *sainfo)
{
data_->clear();

1
ui/qt/sequence_diagram.h
View File

@ -55,6 +55,7 @@ class SequenceDiagram : public QCPAbstractPlottable
Q_OBJECT
public:
explicit SequenceDiagram(QCPAxis *keyAxis, QCPAxis *valueAxis, QCPAxis *commentAxis);
virtual ~SequenceDiagram();
// getters: