osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

pref_models(Qt/model): Fix Dead Store (Found by Clang Analyzer) 

Although the value stored to 'pref' is used in the enclosing expression, the value is never actually read from 'pref'
This commit is contained in:
Alexis La Goutte 2021-07-27 12:51:08 +00:00 committed by Wireshark GitLab Utility
parent a3f9c6bc45
commit d886837df9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ui/qt/models/pref_models.cpp
View File

@ -36,7 +36,7 @@ static void prefInsertPrefPtr(void * pref_ptr, pref_t * pref)
gpointer val = (gpointer) pref;
/* Already existing entries will be ignored */
if ((pref = (pref_t *)g_hash_table_lookup(pref_ptr_to_pref_, key)) == NULL)
if ((void *)g_hash_table_lookup(pref_ptr_to_pref_, key) == NULL)
g_hash_table_insert(pref_ptr_to_pref_, key, val);
}