osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

RTP Player: Showing of setup frame for RTP stream fixed 

When RTP stream has no setup frame, but is decoded by Decode as or
with rtp_udp active, setup frame was shown as SETUP <number>, but
correct is RTP <number>.
This commit is contained in:
Jirka Novak 2021-03-27 00:39:30 +01:00 committed by Wireshark GitLab Utility
parent 828b43491c
commit cd5b568233
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ui/qt/rtp_player_dialog.cpp
View File

@ -576,7 +576,13 @@ void RtpPlayerDialog::addRtpStream(rtpstream_info_t *rtpstream)
ti->setText(dst_addr_col_, address_to_qstring(&rtpstream->id.dst_addr));
ti->setText(dst_port_col_, QString::number(rtpstream->id.dst_port));
ti->setText(ssrc_col_, int_to_qstring(rtpstream->id.ssrc, 8, 16));
if (rtpstream->setup_frame_number == 0xFFFFFFFF) {
// 0xFFFFFFFF mean no setup frame
// first_packet_num == setup_frame_number happens, when
// rtp_udp is active or Decode as was used
if ((rtpstream->setup_frame_number == 0xFFFFFFFF) ||
(rtpstream->rtp_stats.first_packet_num == rtpstream->setup_frame_number)
) {
int packet = rtpstream->rtp_stats.first_packet_num;
ti->setText(first_pkt_col_, QString("RTP %1").arg(packet));
ti->setData(first_pkt_col_, Qt::UserRole, QVariant(packet));