osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Re-balance DINDENT/DENDENT macros in conversation.c. 

The indent macros used for DEBUG_CONVERSATION have become unbalanced, making
the conversation debug output migrate rightwards for no good reason.  This
simple change corrects it by ensuring that DINDENT and DENDENT are neatly
paired up throughout conversation.c .

Testing Done: Built on macOS 10.12.6 with DEBUG_CONVERSATION enabled.  Tested
   tshark with a few captures, and observed that the debug output, while still
   being indented, generally stayed along the left margin of the screen instead
   of migrating steadily over to the right.

Change-Id: Ic91e4562296d34f74c4d832edbf75172562672b8
Reviewed-on: https://code.wireshark.org/review/30856
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This commit is contained in:
Darius Davis 2018-12-01 14:33:50 +10:00 committed by Anders Broman
parent ee92fcf4b4
commit c66fbf481f
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
epan/conversation.c
View File

@ -1477,6 +1477,8 @@ find_conversation_pinfo(packet_info *pinfo, const guint options)
}
}
DENDENT();
return conv;
}
@ -1503,8 +1505,6 @@ find_or_create_conversation(packet_info *pinfo)
DENDENT();
}
DENDENT();
return conv;
}
@ -1523,8 +1523,6 @@ find_or_create_conversation_by_id(packet_info *pinfo, const endpoint_type etype,
DENDENT();
}
DENDENT();
return conv;
}