osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

rpc: fix regression in gbfc5483174d 

value can be NULL, in which case memduping it will crash

Bug: 10667
Change-Id: I8950fae94d80a2f06f24a785532536ad73f1855d
Reviewed-on: https://code.wireshark.org/review/5152
Reviewed-by: Evan Huus <eapache@gmail.com>
This commit is contained in:
Evan Huus 2014-11-05 23:43:20 -05:00
parent d0c031ff19
commit c321dc3f2e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
epan/dissectors/packet-rpc.c
View File

@ -2334,7 +2334,7 @@ dissect_rpc_message(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
rpc_call->flavor = flavor;
rpc_call->gss_proc = gss_proc;
rpc_call->gss_svc = gss_svc;
rpc_call->proc_info = (rpc_proc_info_value*)wmem_memdup(wmem_file_scope(), value, sizeof(*value));
rpc_call->proc_info = value ? (rpc_proc_info_value*)wmem_memdup(wmem_file_scope(), value, sizeof(*value)) : NULL;
rpc_call->req_time = pinfo->fd->abs_ts;
/* store it */