osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Get rid of unnecessary casts. 

snprintf(), sensibly, takes a size_t argument specifying the size of the
buffer.  g_snprintf(), bogusly, takes a gulong argument specifying the
size of the buffer, so we had to do casts to avoid narrowing complaints,
but we're just using snprintf() now (as we require C11 or later), and
don't need the casts any more.
This commit is contained in:
Guy Harris 2023-06-18 15:06:48 -07:00
parent dafd334270
commit bfe3bacd53
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
capture/capture-pcap-util.c
View File

@ -895,14 +895,14 @@ set_pcap_datalink(pcap_t *pcap_h, int datalink, char *name,
if (pcap_set_datalink(pcap_h, datalink) == 0)
return true; /* no error */
set_datalink_err_str = pcap_geterr(pcap_h);
snprintf(errmsg, (unsigned long) errmsg_len, "Unable to set data link type on interface '%s' (%s).",
snprintf(errmsg, errmsg_len, "Unable to set data link type on interface '%s' (%s).",
name, set_datalink_err_str);
/*
* If the error isn't "XXX is not one of the DLTs supported by this device",
* tell the user to tell the Wireshark developers about it.
*/
if (strstr(set_datalink_err_str, "is not one of the DLTs supported by this device") == NULL)
snprintf(secondary_errmsg, (unsigned long) secondary_errmsg_len,
snprintf(secondary_errmsg, secondary_errmsg_len,
"%s", please_report_bug());
else
secondary_errmsg[0] = '\0';