osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

windows-common: fix Clang 

Value stored to 'len' is never read
This commit is contained in:
Alexis La Goutte 2020-11-19 19:01:53 +00:00 committed by Wireshark GitLab Utility
parent 785ef0f43d
commit b78abaf1be
4 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
epan/charsets.c
View File

@ -106,7 +106,6 @@ get_utf_8_string(wmem_allocator_t *scope, const guint8 *ptr, gint length)
wmem_strbuf_t *str;
guint8 ch;
const guint8 *prev;
gsize unichar_len;
str = wmem_strbuf_sized_new(scope, length+1, 0);
@ -115,8 +114,8 @@ get_utf_8_string(wmem_allocator_t *scope, const guint8 *ptr, gint length)
* Table 3-7 "Well-Formed UTF-8 Byte Sequences" and
* U+FFFD Substitution of Maximal Subparts. */
while (length > 0) {
gsize unichar_len;
ch = *ptr;
unichar_len = 1;
if (ch < 0x80) {
wmem_strbuf_append_c(str, ch);

2
epan/dissectors/packet-dhcpv6.c
View File

@ -2469,7 +2469,7 @@ dhcpv6_option(tvbuff_t *tvb, packet_info *pinfo, proto_tree *bp_tree,
guint8 flags;
proto_item *fi = NULL;
proto_tree *flags_tree = NULL;
char *flags_str, *suffix;
char *flags_str= NULL, *suffix;
gboolean is_client;
proto_item *exi;
proto_tree *ex_subtree;

1
epan/dissectors/packet-someip.c
View File

@ -2564,7 +2564,6 @@ dissect_someip_payload(tvbuff_t* tvb, packet_info* pinfo, proto_item *ti, guint1
if (offset_bits != 0) {
/* allign to byte */
offset += 1;
offset_bits = 0;
}
if (length > offset) {

1
epan/dissectors/packet-windows-common.c
View File

@ -2104,7 +2104,6 @@ dissect_nt_conditional_ace_token(tvbuff_t *tvb, int offset, guint16 size, proto_
break;
case COND_ACE_TOKEN_SID:
len = tvb_get_letohl(tvb, offset); /* in bytes */
offset += sizeof(len);
offset = dissect_nt_sid(tvb, offset, tree, "SID", NULL, -1);