osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

TLS: Don't assert on zero length handshake fragment 

The fragment functions will work with a zero length fragment,
which might happen if a record length is zero in a malformed
packet and a reassembly is in progress. It is not by itself
a fatal error (and could actually work, even though
non-compliant.) There is already a tls.record.length.invalid
expert info added by ssl_check_record_length for this case.

Related to #17890.
This commit is contained in:
John Thacker 2022-08-15 07:21:44 -04:00 committed by AndersBroman
parent 69daf2e339
commit b025c45cf3
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
epan/dissectors/packet-tls.c
View File

@ -2253,8 +2253,6 @@ save_tls_handshake_fragment(packet_info *pinfo, guint8 curr_layer_num_tls,
{
// Full handshake messages should not be saved.
DISSECTOR_ASSERT(!(frag_offset == 0 && is_last));
// Fragment data must be non-empty.
DISSECTOR_ASSERT(frag_len != 0);
// 0 is a special value indicating no reassembly in progress.
DISSECTOR_ASSERT(reassembly_id != 0);