osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

BPV7: Address check_static.py issues 

epan/dissectors/packet-bpv7.c (00000000000010d0 T bp_block_canonical_free) is not referred to so could be static?
epan/dissectors/packet-bpv7.c (0000000000000e50 T bp_creation_ts_new) is not referred to so could be static?

One function was not called at all - the other only in this dissector so could be static.
This commit is contained in:
Martin Mathieson 2021-10-12 10:27:21 +01:00 committed by Wireshark GitLab Utility
parent 01e858e0a3
commit abcadce44f
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
epan/dissectors/packet-bpv7.c
View File

@ -466,7 +466,7 @@ static void file_scope_delete(gpointer ptr) {
wmem_free(wmem_file_scope(), ptr);
}
bp_creation_ts_t * bp_creation_ts_new(wmem_allocator_t *alloc) {
static bp_creation_ts_t * bp_creation_ts_new(wmem_allocator_t *alloc) {
bp_creation_ts_t *obj = wmem_new0(alloc, bp_creation_ts_t);
return obj;
}
@ -547,12 +547,6 @@ bp_block_canonical_t * bp_block_canonical_new(wmem_allocator_t *alloc, guint64 b
return obj;
}
void bp_block_canonical_free(wmem_allocator_t *alloc, bp_block_canonical_t *obj) {
wmem_free(alloc, obj->sec.data_i);
wmem_free(alloc, obj->sec.data_c);
wmem_free(alloc, obj);
}
static guint64 * guint64_new(wmem_allocator_t *alloc, const guint64 val) {
guint64 *obj = wmem_new(alloc, guint64);
*obj = val;