osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Qt: Improve profile dialog messages 

Add correct numerus translation for exported profiles.
Use uniform capitalization in the profile type selection combo box.
Use horizontal ellipsis in "Search for profile …"

Change-Id: I2898685f01a119cac5543fcb9f1dd18ae8fc3e93
Reviewed-on: https://code.wireshark.org/review/34115
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
This commit is contained in:
Stig Bjørlykke 2019-07-29 09:33:54 +02:00 committed by Roland Knall
parent 806bef47a2
commit a5d2c5e44c
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ui/qt/profile_dialog.cpp
View File

@ -110,7 +110,7 @@ ProfileDialog::ProfileDialog(QWidget *parent) :
selectProfile(); selectProfile();
QStringList items; QStringList items;
items << tr("All Profiles") << tr("System profiles") << tr("User-defined profiles"); items << tr("All profiles") << tr("System profiles") << tr("User profiles");
pd_ui_->cmbProfileTypes->addItems(items); pd_ui_->cmbProfileTypes->addItems(items);
connect (pd_ui_->cmbProfileTypes, SIGNAL(currentTextChanged(const QString &)), connect (pd_ui_->cmbProfileTypes, SIGNAL(currentTextChanged(const QString &)),
@ -435,7 +435,7 @@ void ProfileDialog::exportProfiles(bool exportAll)
QString err; QString err;
if ( model_->exportProfiles(zipFile, items, &err) ) if ( model_->exportProfiles(zipFile, items, &err) )
QMessageBox::information(this, tr("Exporting profiles"), tr("%Ln profile(s) have been exported", "", items.count())); QMessageBox::information(this, tr("Exporting profiles"), tr("%Ln profile(s) exported", "", items.count()));
else else
QMessageBox::warning(this, tr("Exporting profiles"), QString("%1\n\n%2: %3").arg(tr("An error has occured while exporting profiles")).arg("Error").arg(err)); QMessageBox::warning(this, tr("Exporting profiles"), QString("%1\n\n%2: %3").arg(tr("An error has occured while exporting profiles")).arg("Error").arg(err));
} }

2
ui/qt/profile_dialog.ui
View File

@ -16,7 +16,7 @@
<item> <item>
<widget class="QLineEdit" name="lineProfileFilter"> <widget class="QLineEdit" name="lineProfileFilter">
<property name="placeholderText"> <property name="placeholderText">
<string>Search for profile ...</string> <string>Search for profile …</string>
</property> </property>
</widget> </widget>
</item> </item>

8
ui/qt/wireshark_en.ts
View File

@ -8554,10 +8554,10 @@ For example, use 1 hour to have a new file created every hour on the hour.</sour
<translation type="unfinished"></translation> <translation type="unfinished"></translation>
</message> </message>
<message numerus="yes"> <message numerus="yes">
<source>%Ln profile(s) have been exported</source> <source>%Ln profile(s) exported</source>
<translation type="unfinished"> <translation>
<numerusform></numerusform> <numerusform>%Ln profile exported</numerusform>
<numerusform></numerusform> <numerusform>%Ln profiles exported</numerusform>
</translation> </translation>
</message> </message>
<message> <message>