osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

tcp: default no-subdissector-on-error to TRUE 

Dissectors that need this set break badly when it isn't. Dissectors which don't
need this set will still generally be understandable without it, since e.g.
retransmissions will link to the original packet at the TCP layer, and
presumably the subdissector payload is exactly the same in that case.

Change-Id: I2871c2a90c601637bdfb8cffaa34a7407995c603
Ping-Bug: 10525
Ping-Bug: 10289
Reviewed-on: https://code.wireshark.org/review/4487
Reviewed-by: Evan Huus <eapache@gmail.com>
This commit is contained in:
Evan Huus 2014-10-05 21:25:19 -04:00
parent 47de5a1fa0
commit 9128e43745
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
epan/dissectors/packet-tcp.c
View File

@ -333,7 +333,7 @@ static expert_field ei_tcp_urgent_pointer_non_zero = EI_INIT;
* This preference can be set for such protocols to make sure that we don't
* invoke the subdissectors for retransmitted or out-of-order segments.
*/
static gboolean tcp_no_subdissector_on_error = FALSE;
static gboolean tcp_no_subdissector_on_error = TRUE;
/*
* FF: (draft-ietf-tcpm-experimental-options-03)