osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Fix a FIXME: remove an if(tree). 

The reason the notice in the INFO column disappeared when a display filter was
added is because the column operation was wrapped in an if(tree).

Change-Id: Ic8ff929d7ef601458b8650f8095f87282f9fde40
Reviewed-on: https://code.wireshark.org/review/14449
Reviewed-by: Michael Mann <mmann78@netscape.net>
This commit is contained in:
Jeff Morriss 2016-03-13 14:09:42 -04:00 committed by Michael Mann
parent 55fd97e73d
commit 89fc294892
1 changed files with 25 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
epan/dissectors/packet-radius.c
View File

@ -1942,14 +1942,13 @@ dissect_radius(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *data _
/* Indicate the frame to which this is a reply. */ /* Indicate the frame to which this is a reply. */
if (radius_call->req_num) if (radius_call->req_num)
{ {
nstime_t delta;
proto_item *item;
rad_info->request_available = TRUE; rad_info->request_available = TRUE;
rad_info->req_num = radius_call->req_num; rad_info->req_num = radius_call->req_num;
radius_call->responded = TRUE; radius_call->responded = TRUE;
if (tree)
{
nstime_t delta;
proto_item* item;
item = proto_tree_add_uint_format(radius_tree, item = proto_tree_add_uint_format(radius_tree,
hf_radius_req_frame, tvb, 0, 0, hf_radius_req_frame, tvb, 0, 0,
radius_call->req_num, radius_call->req_num,
@ -1975,12 +1974,10 @@ dissect_radius(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *data _
if (!valid) if (!valid)
{ {
/* FIXME: this information disappears when a display filter is enterred */
col_append_fstr(pinfo->cinfo,COL_INFO," [incorrect authenticator]"); col_append_fstr(pinfo->cinfo,COL_INFO," [incorrect authenticator]");
} }
} }
} }
}
if (radius_call->rsp_num == 0) if (radius_call->rsp_num == 0)
{ {